Re: Review Request 70761: RANGER-2397: HiveServer2 fails to start with Hive Plugin for Ranger

2019-05-30 Thread Mehul Parikh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70761/#review215600
---


Ship it!




Ship It!

- Mehul Parikh


On May 30, 2019, 4:38 a.m., Pradeep Agrawal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70761/
> ---
> 
> (Updated May 30, 2019, 4:38 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh 
> Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2397
> https://issues.apache.org/jira/browse/RANGER-2397
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> **Problem Statement:**
> HIVE-18777 added Authorization interface to support information_schema 
> integration with external authorization, but it causes the bug with Hive 
> Plugin for Ranger. Specifically, it causes the following error while starting 
> HiveServer2 with the Hive Plugin, and blocks HiveServer2 to start.
> 
> java.lang.AbstractMethodError: 
> org.apache.ranger.authorization.hive.authorizer.RangerHiveAuthorizer.getHivePolicyProvider()Lorg/apache/hadoop/hive/ql/security/authorization/plugin/HivePolicyProvider
> 
> **Solution:(provided by Junseung Hwang in the Jira)** :
> Hive already has an abstract class to prevent this kind of error, so the 
> patch just makes RangerHiveAuthorizerBase to extend AbstractHiveAuthorizer 
> instead of implementing HiveAuthorizer directly.
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizerBase.java
>  afc57b2e8 
> 
> 
> Diff: https://reviews.apache.org/r/70761/diff/1/
> 
> 
> Testing
> ---
> 
> Tested Ranger build with this patch.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>



Re: Review Request 70761: RANGER-2397: HiveServer2 fails to start with Hive Plugin for Ranger

2019-05-29 Thread Ramesh Mani

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70761/#review215599
---


Ship it!




Ship It!

- Ramesh Mani


On May 30, 2019, 4:38 a.m., Pradeep Agrawal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70761/
> ---
> 
> (Updated May 30, 2019, 4:38 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh 
> Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2397
> https://issues.apache.org/jira/browse/RANGER-2397
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> **Problem Statement:**
> HIVE-18777 added Authorization interface to support information_schema 
> integration with external authorization, but it causes the bug with Hive 
> Plugin for Ranger. Specifically, it causes the following error while starting 
> HiveServer2 with the Hive Plugin, and blocks HiveServer2 to start.
> 
> java.lang.AbstractMethodError: 
> org.apache.ranger.authorization.hive.authorizer.RangerHiveAuthorizer.getHivePolicyProvider()Lorg/apache/hadoop/hive/ql/security/authorization/plugin/HivePolicyProvider
> 
> **Solution:(provided by Junseung Hwang in the Jira)** :
> Hive already has an abstract class to prevent this kind of error, so the 
> patch just makes RangerHiveAuthorizerBase to extend AbstractHiveAuthorizer 
> instead of implementing HiveAuthorizer directly.
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizerBase.java
>  afc57b2e8 
> 
> 
> Diff: https://reviews.apache.org/r/70761/diff/1/
> 
> 
> Testing
> ---
> 
> Tested Ranger build with this patch.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>



Review Request 70761: RANGER-2397: HiveServer2 fails to start with Hive Plugin for Ranger

2019-05-29 Thread Pradeep Agrawal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70761/
---

Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh Mani, 
Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2397
https://issues.apache.org/jira/browse/RANGER-2397


Repository: ranger


Description
---

**Problem Statement:**
HIVE-18777 added Authorization interface to support information_schema 
integration with external authorization, but it causes the bug with Hive Plugin 
for Ranger. Specifically, it causes the following error while starting 
HiveServer2 with the Hive Plugin, and blocks HiveServer2 to start.

java.lang.AbstractMethodError: 
org.apache.ranger.authorization.hive.authorizer.RangerHiveAuthorizer.getHivePolicyProvider()Lorg/apache/hadoop/hive/ql/security/authorization/plugin/HivePolicyProvider

**Solution:(provided by Junseung Hwang in the Jira)** :
Hive already has an abstract class to prevent this kind of error, so the patch 
just makes RangerHiveAuthorizerBase to extend AbstractHiveAuthorizer instead of 
implementing HiveAuthorizer directly.


Diffs
-

  
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizerBase.java
 afc57b2e8 


Diff: https://reviews.apache.org/r/70761/diff/1/


Testing
---

Tested Ranger build with this patch.


Thanks,

Pradeep Agrawal