Re: Review Request 70882: RANGER-2475 : Replacing bootstrap accordion with jquery SlideToggle.

2019-06-19 Thread Mehul Parikh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70882/#review215987
---


Ship it!




Ship It!

- Mehul Parikh


On June 19, 2019, 8:54 a.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70882/
> ---
> 
> (Updated June 19, 2019, 8:54 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2475
> https://issues.apache.org/jira/browse/RANGER-2475
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Removed the logic of using bootstrap accordion and added new logic using 
> jquery slideToggle. Updated the html and css for the same.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js 
> 9bce74b 
>   
> security-admin/src/main/webapp/scripts/views/security_zone/ZoneAdministration.js
>  1dfa36c 
>   security-admin/src/main/webapp/styles/xa.css e8238ca 
>   
> security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html 
> b14519c 
>   
> security-admin/src/main/webapp/templates/security_zone/ZoneAdministration_tmpl.html
>  125bf86 
> 
> 
> Diff: https://reviews.apache.org/r/70882/diff/1/
> 
> 
> Testing
> ---
> 
> Verified CRUD operation for Security Zone Module.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>



Re: Review Request 70882: RANGER-2475 : Replacing bootstrap accordion with jquery SlideToggle.

2019-06-19 Thread Velmurugan Periasamy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70882/#review215967
---


Ship it!




Ship It!

- Velmurugan Periasamy


On June 19, 2019, 8:54 a.m., Nitin Galave wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70882/
> ---
> 
> (Updated June 19, 2019, 8:54 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2475
> https://issues.apache.org/jira/browse/RANGER-2475
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Removed the logic of using bootstrap accordion and added new logic using 
> jquery slideToggle. Updated the html and css for the same.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js 
> 9bce74b 
>   
> security-admin/src/main/webapp/scripts/views/security_zone/ZoneAdministration.js
>  1dfa36c 
>   security-admin/src/main/webapp/styles/xa.css e8238ca 
>   
> security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html 
> b14519c 
>   
> security-admin/src/main/webapp/templates/security_zone/ZoneAdministration_tmpl.html
>  125bf86 
> 
> 
> Diff: https://reviews.apache.org/r/70882/diff/1/
> 
> 
> Testing
> ---
> 
> Verified CRUD operation for Security Zone Module.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>



Re: Review Request 70882: RANGER-2475 : Replacing bootstrap accordion with jquery SlideToggle.

2019-06-19 Thread Nitin Galave

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70882/
---

(Updated June 19, 2019, 8:54 a.m.)


Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and 
Velmurugan Periasamy.


Bugs: RANGER-2475
https://issues.apache.org/jira/browse/RANGER-2475


Repository: ranger


Description
---

Removed the logic of using bootstrap accordion and added new logic using jquery 
slideToggle. Updated the html and css for the same.


Diffs
-

  security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js 
9bce74b 
  
security-admin/src/main/webapp/scripts/views/security_zone/ZoneAdministration.js
 1dfa36c 
  security-admin/src/main/webapp/styles/xa.css e8238ca 
  security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html 
b14519c 
  
security-admin/src/main/webapp/templates/security_zone/ZoneAdministration_tmpl.html
 125bf86 


Diff: https://reviews.apache.org/r/70882/diff/1/


Testing (updated)
---

Verified CRUD operation for Security Zone Module.


Thanks,

Nitin Galave



Review Request 70882: RANGER-2475 : Replacing bootstrap accordion with jquery SlideToggle.

2019-06-19 Thread Nitin Galave

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70882/
---

Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and 
Velmurugan Periasamy.


Bugs: RANGER-2475
https://issues.apache.org/jira/browse/RANGER-2475


Repository: ranger


Description
---

Removed the logic of using bootstrap accordion and added new logic using jquery 
slideToggle. Updated the html and css for the same.


Diffs
-

  security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js 
9bce74b 
  
security-admin/src/main/webapp/scripts/views/security_zone/ZoneAdministration.js
 1dfa36c 
  security-admin/src/main/webapp/styles/xa.css e8238ca 
  security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html 
b14519c 
  
security-admin/src/main/webapp/templates/security_zone/ZoneAdministration_tmpl.html
 125bf86 


Diff: https://reviews.apache.org/r/70882/diff/1/


Testing
---


Thanks,

Nitin Galave