Re: Review Request 71418: RANGER-2533: update ‘xasecure.audit.is.enabled’ default value to ‘true’ in AuditProviderFactory.java and remove unnecessary unit test changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71418/#review217645 --- Ship it! Ship It! - pengjianhua On 八月 31, 2019, 2:38 a.m., Xing Peng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71418/ > --- > > (Updated 八月 31, 2019, 2:38 a.m.) > > > Review request for ranger, Colm O hEigeartaigh, Madhan Neethiraj, > pengjianhua, Pradeep Agrawal, Ramesh Mani, Velmurugan Periasamy, and Qiang > Zhang. > > > Bugs: RANGER-2533 > https://issues.apache.org/jira/browse/RANGER-2533 > > > Repository: ranger > > > Description > --- > > to avoid breaking deployments where xasecure.audit.is.enabled is not set in > configuration file, please update default value to 'true' in > AuditProviderFactory.java, which will make the unit test changes in this > patch unnecessary > > > Diffs > - > > > agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java > 405fb1d23 > security-admin/src/test/java/org/apache/ranger/audit/TestAuditQueue.java > 99b7c49c5 > > > Diff: https://reviews.apache.org/r/71418/diff/1/ > > > Testing > --- > > Test Result: > > Tested. > > > Thanks, > > Xing Peng > >
Re: Review Request 71418: RANGER-2533: update ‘xasecure.audit.is.enabled’ default value to ‘true’ in AuditProviderFactory.java and remove unnecessary unit test changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71418/#review217523 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 31, 2019, 2:38 a.m., Xing Peng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71418/ > --- > > (Updated Aug. 31, 2019, 2:38 a.m.) > > > Review request for ranger, Colm O hEigeartaigh, Madhan Neethiraj, > pengjianhua, Pradeep Agrawal, Ramesh Mani, Velmurugan Periasamy, and Qiang > Zhang. > > > Bugs: RANGER-2533 > https://issues.apache.org/jira/browse/RANGER-2533 > > > Repository: ranger > > > Description > --- > > to avoid breaking deployments where xasecure.audit.is.enabled is not set in > configuration file, please update default value to 'true' in > AuditProviderFactory.java, which will make the unit test changes in this > patch unnecessary > > > Diffs > - > > > agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java > 405fb1d23 > security-admin/src/test/java/org/apache/ranger/audit/TestAuditQueue.java > 99b7c49c5 > > > Diff: https://reviews.apache.org/r/71418/diff/1/ > > > Testing > --- > > Test Result: > > Tested. > > > Thanks, > > Xing Peng > >
Review Request 71418: RANGER-2533: update ‘xasecure.audit.is.enabled’ default value to ‘true’ in AuditProviderFactory.java and remove unnecessary unit test changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71418/ --- Review request for ranger, Colm O hEigeartaigh, Madhan Neethiraj, pengjianhua, Pradeep Agrawal, Ramesh Mani, Velmurugan Periasamy, and Qiang Zhang. Bugs: RANGER-2533 https://issues.apache.org/jira/browse/RANGER-2533 Repository: ranger Description --- to avoid breaking deployments where xasecure.audit.is.enabled is not set in configuration file, please update default value to 'true' in AuditProviderFactory.java, which will make the unit test changes in this patch unnecessary Diffs - agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java 405fb1d23 security-admin/src/test/java/org/apache/ranger/audit/TestAuditQueue.java 99b7c49c5 Diff: https://reviews.apache.org/r/71418/diff/1/ Testing --- Test Result: Tested. Thanks, Xing Peng
