Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

2019-10-10 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71565/#review218185
---


Ship it!




Ship It!

- Madhan Neethiraj


On Oct. 10, 2019, 10:22 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71565/
> ---
> 
> (Updated Oct. 10, 2019, 10:22 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, and 
> Selvamohan Neethiraj.
> 
> 
> Bugs: RANGER-2589
> https://issues.apache.org/jira/browse/RANGER-2589
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Important JVM attributes can be returned via Ranger REST API : 
> 
> heap memory usage
> GC time
> # of open threads
> # of open file descriptors
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerMetrics.java 
> PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java 
> PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/util/RangerMetricsUtil.java 
> PRE-CREATION 
>   security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
> 672d4a6 
> 
> 
> Diff: https://reviews.apache.org/r/71565/diff/7/
> 
> 
> Testing
> ---
> 
> Getting the desired json
> {
>"data":{
>   "jvm":{
>  "JVM Machine Actual Name":"OpenJDK 64-Bit Server VM",
>  "version":"25.222-b10",
>  "JVM Machine Representation Name":"27693@fipl5",
>  "Up time of JVM":9036,
>  "JVM Vendor Name":"Private Build",
>  "os.spec":"Linux, amd64, 4.15.0-65-generic",
>  "os.vcpus":"4",
>  "memory":{
> "heapInit":"1073741824",
> "heapMax":"1024983040",
> "heapCommitted":"1024983040",
> "heapUsed":"245119288",
> "nonHeapInit":"2555904",
> "nonHeapMax":"662700032",
> "nonHeapCommitted":"101842944",
> "nonHeapUsed":"100077808",
> "memory_pool_usages":{
>"PS Eden Space":{
>   "init":268435456,
>   "used":206599792,
>   "committed":260046848,
>   "max":261619712
>},
>"PS Survivor Space":{
>   "init":44564480,
>   "used":30648600,
>   "committed":48758784,
>   "max":48758784
>},
>"PS Old Gen":{
>   "init":716177408,
>   "used":7870896,
>   "committed":716177408,
>   "max":716177408
>}
> }
>  }
>   }
>}
> }
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

2019-10-10 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71565/#review218184
---


Ship it!




Ship It!

- Velmurugan Periasamy


On Oct. 10, 2019, 10:22 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71565/
> ---
> 
> (Updated Oct. 10, 2019, 10:22 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, and 
> Selvamohan Neethiraj.
> 
> 
> Bugs: RANGER-2589
> https://issues.apache.org/jira/browse/RANGER-2589
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Important JVM attributes can be returned via Ranger REST API : 
> 
> heap memory usage
> GC time
> # of open threads
> # of open file descriptors
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerMetrics.java 
> PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java 
> PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/util/RangerMetricsUtil.java 
> PRE-CREATION 
>   security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
> 672d4a6 
> 
> 
> Diff: https://reviews.apache.org/r/71565/diff/7/
> 
> 
> Testing
> ---
> 
> Getting the desired json
> {
>"data":{
>   "jvm":{
>  "JVM Machine Actual Name":"OpenJDK 64-Bit Server VM",
>  "version":"25.222-b10",
>  "JVM Machine Representation Name":"27693@fipl5",
>  "Up time of JVM":9036,
>  "JVM Vendor Name":"Private Build",
>  "os.spec":"Linux, amd64, 4.15.0-65-generic",
>  "os.vcpus":"4",
>  "memory":{
> "heapInit":"1073741824",
> "heapMax":"1024983040",
> "heapCommitted":"1024983040",
> "heapUsed":"245119288",
> "nonHeapInit":"2555904",
> "nonHeapMax":"662700032",
> "nonHeapCommitted":"101842944",
> "nonHeapUsed":"100077808",
> "memory_pool_usages":{
>"PS Eden Space":{
>   "init":268435456,
>   "used":206599792,
>   "committed":260046848,
>   "max":261619712
>},
>"PS Survivor Space":{
>   "init":44564480,
>   "used":30648600,
>   "committed":48758784,
>   "max":48758784
>},
>"PS Old Gen":{
>   "init":716177408,
>   "used":7870896,
>   "committed":716177408,
>   "max":716177408
>}
> }
>  }
>   }
>}
> }
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

2019-10-10 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71565/
---

(Updated Oct. 10, 2019, 10:22 a.m.)


Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, and Selvamohan 
Neethiraj.


Bugs: RANGER-2589
https://issues.apache.org/jira/browse/RANGER-2589


Repository: ranger


Description
---

Important JVM attributes can be returned via Ranger REST API : 

heap memory usage
GC time
# of open threads
# of open file descriptors


Diffs (updated)
-

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerMetrics.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/util/RangerMetricsUtil.java 
PRE-CREATION 
  security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
672d4a6 


Diff: https://reviews.apache.org/r/71565/diff/7/

Changes: https://reviews.apache.org/r/71565/diff/6-7/


Testing (updated)
---

Getting the desired json
{
   "data":{
  "jvm":{
 "JVM Machine Actual Name":"OpenJDK 64-Bit Server VM",
 "version":"25.222-b10",
 "JVM Machine Representation Name":"27693@fipl5",
 "Up time of JVM":9036,
 "JVM Vendor Name":"Private Build",
 "os.spec":"Linux, amd64, 4.15.0-65-generic",
 "os.vcpus":"4",
 "memory":{
"heapInit":"1073741824",
"heapMax":"1024983040",
"heapCommitted":"1024983040",
"heapUsed":"245119288",
"nonHeapInit":"2555904",
"nonHeapMax":"662700032",
"nonHeapCommitted":"101842944",
"nonHeapUsed":"100077808",
"memory_pool_usages":{
   "PS Eden Space":{
  "init":268435456,
  "used":206599792,
  "committed":260046848,
  "max":261619712
   },
   "PS Survivor Space":{
  "init":44564480,
  "used":30648600,
  "committed":48758784,
  "max":48758784
   },
   "PS Old Gen":{
  "init":716177408,
  "used":7870896,
  "committed":716177408,
  "max":716177408
   }
}
 }
  }
   }
}


Thanks,

Fatima Khan

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

2019-10-07 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71565/
---

(Updated Oct. 7, 2019, 5:47 p.m.)


Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, and Selvamohan 
Neethiraj.


Bugs: RANGER-2589
https://issues.apache.org/jira/browse/RANGER-2589


Repository: ranger


Description
---

Important JVM attributes can be returned via Ranger REST API : 

heap memory usage
GC time
# of open threads
# of open file descriptors


Diffs
-

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerMetrics.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/util/RangerMetricsUtil.java 
PRE-CREATION 
  security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
672d4a6 


Diff: https://reviews.apache.org/r/71565/diff/6/


Testing (updated)
---

Getting the desired json
{
  "data": {
"jvm": {
  "os.spec": "Linux, amd64, 4.15.0-65-generic",
  "os.vcpus": "4",
  "memory": {
"heapInit": "1073741824",
"heapMax": "1024983040",
"heapCommitted": "1024983040",
"heapUsed": "284762328",
"nonHeapInit": "2555904",
"nonHeapMax": "662700032",
"nonHeapCommitted": "102694912",
"nonHeapUsed": "98983000",
"memory_pool_usages": {
  "PS Eden Space": {
"init": 268435456,
"used": 246715792,
"committed": 260046848,
"max": 261619712
  },
  "PS Survivor Space": {
"init": 44564480,
"used": 30075104,
"committed": 48758784,
"max": 48758784
  },
  "PS Old Gen": {
"init": 716177408,
"used": 7971432,
"committed": 716177408,
"max": 716177408
  }
}
  }
},
"vm": {
  "JVM Machine Actual Name": "OpenJDK 64-Bit Server VM",
  "version": "25.222-b10",
  "JVM Machine Representation Name": "15526@fipl5",
  "Up time of JVM": 10414,
  "JVM Vendor Name": "Private Build"
}
  }
}


Thanks,

Fatima Khan

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

2019-10-07 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71565/
---

(Updated Oct. 7, 2019, 12:03 p.m.)


Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, and Selvamohan 
Neethiraj.


Bugs: RANGER-2589
https://issues.apache.org/jira/browse/RANGER-2589


Repository: ranger


Description
---

Important JVM attributes can be returned via Ranger REST API : 

heap memory usage
GC time
# of open threads
# of open file descriptors


Diffs (updated)
-

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerMetrics.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/util/RangerMetricsUtil.java 
PRE-CREATION 
  security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
672d4a6 


Diff: https://reviews.apache.org/r/71565/diff/6/

Changes: https://reviews.apache.org/r/71565/diff/5-6/


Testing
---

Getting the desired json


Thanks,

Fatima Khan

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

2019-10-07 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71565/
---

(Updated Oct. 7, 2019, 11:55 a.m.)


Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, and Selvamohan 
Neethiraj.


Bugs: RANGER-2589
https://issues.apache.org/jira/browse/RANGER-2589


Repository: ranger


Description
---

Important JVM attributes can be returned via Ranger REST API : 

heap memory usage
GC time
# of open threads
# of open file descriptors


Diffs (updated)
-

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerMetrics.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/util/RangerMetricsUtil.java 
PRE-CREATION 
  security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
672d4a6 


Diff: https://reviews.apache.org/r/71565/diff/5/

Changes: https://reviews.apache.org/r/71565/diff/4-5/


Testing
---

Getting the desired json


Thanks,

Fatima Khan

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

2019-10-04 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71565/#review218071
---




agents-common/src/main/java/org/apache/ranger/plugin/model/RangerJVMMetricDef.java
Lines 38 (patched)


RangerJVMMetricDef => RangerMetrics



security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java
Lines 49 (patched)


RangerJVMMetricUtil is defined as a "@Component". Can this be 'autowired' 
in MetricsREST, insteaded of instantiated here for every call?



security-admin/src/main/java/org/apache/ranger/util/RangerJVMMetricUtil.java
Lines 45 (patched)


RangerJVMMetricUtil => RangerMetricsUtil



security-admin/src/main/java/org/apache/ranger/util/RangerJVMMetricUtil.java
Lines 59 (patched)


Consider having 'values' and 'memory' as local variables in getValues() 
method, as they need to be populated for each call.



security-admin/src/main/java/org/apache/ranger/util/RangerJVMMetricUtil.java
Lines 78 (patched)


I suggest to replace these key-names (like "JVM Machine Actual Name", 
"version", ..) with corresponding 'public static final' constants in 
MetricsREST.



security-admin/src/main/java/org/apache/ranger/util/RangerJVMMetricUtil.java
Lines 168 (patched)


StringUtils has a join method; can that not be used, instead of adding a 
new method?



security-admin/src/main/java/org/apache/ranger/util/RangerJVMMetricUtil.java
Lines 180 (patched)


getValues() seems to be the only public method. To make it easier to read, 
consider moving all public methods before protected/private methods.


- Madhan Neethiraj


On Oct. 4, 2019, 1:28 p.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71565/
> ---
> 
> (Updated Oct. 4, 2019, 1:28 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
> Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, and 
> Selvamohan Neethiraj.
> 
> 
> Bugs: RANGER-2589
> https://issues.apache.org/jira/browse/RANGER-2589
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Important JVM attributes can be returned via Ranger REST API : 
> 
> heap memory usage
> GC time
> # of open threads
> # of open file descriptors
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerJVMMetricDef.java
>  PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java 
> PRE-CREATION 
>   
> security-admin/src/main/java/org/apache/ranger/util/RangerJVMMetricUtil.java 
> PRE-CREATION 
>   security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
> 672d4a6 
> 
> 
> Diff: https://reviews.apache.org/r/71565/diff/4/
> 
> 
> Testing
> ---
> 
> Getting the desired json
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

2019-10-04 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71565/
---

(Updated Oct. 4, 2019, 1:28 p.m.)


Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, and Selvamohan 
Neethiraj.


Changes
---

Added license in RangerJVMMetricDef.java


Bugs: RANGER-2589
https://issues.apache.org/jira/browse/RANGER-2589


Repository: ranger


Description
---

Important JVM attributes can be returned via Ranger REST API : 

heap memory usage
GC time
# of open threads
# of open file descriptors


Diffs (updated)
-

  
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerJVMMetricDef.java
 PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/util/RangerJVMMetricUtil.java 
PRE-CREATION 
  security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
672d4a6 


Diff: https://reviews.apache.org/r/71565/diff/4/

Changes: https://reviews.apache.org/r/71565/diff/3-4/


Testing
---

Getting the desired json


Thanks,

Fatima Khan

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

2019-10-04 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71565/
---

(Updated Oct. 4, 2019, 1:05 p.m.)


Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, and Selvamohan 
Neethiraj.


Bugs: RANGER-2589
https://issues.apache.org/jira/browse/RANGER-2589


Repository: ranger


Description
---

Important JVM attributes can be returned via Ranger REST API : 

heap memory usage
GC time
# of open threads
# of open file descriptors


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerJVMMetricDef.java
 PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/util/RangerJVMMetricUtil.java 
PRE-CREATION 
  security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
672d4a6 


Diff: https://reviews.apache.org/r/71565/diff/3/


Testing
---

Getting the desired json


Thanks,

Fatima Khan

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

2019-10-04 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71565/
---

(Updated Oct. 4, 2019, 1:04 p.m.)


Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan 
Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, and Selvamohan 
Neethiraj.


Bugs: RANGER-2589
https://issues.apache.org/jira/browse/RANGER-2589


Repository: ranger


Description
---

Important JVM attributes can be returned via Ranger REST API : 

heap memory usage
GC time
# of open threads
# of open file descriptors


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerJVMMetricDef.java
 PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/rest/MetricsREST.java 
PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/util/RangerJVMMetricUtil.java 
PRE-CREATION 
  security-admin/src/main/resources/conf.dist/security-applicationContext.xml 
672d4a6 


Diff: https://reviews.apache.org/r/71565/diff/3/


Testing
---

Getting the desired json


Thanks,

Fatima Khan