Re: Review Request 73539: RANGER-3348: Add user & group delete functionality in Apache Ranger Python APIs - follow-up

2021-08-24 Thread Mehul Parikh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73539/#review223380
---


Ship it!




Ship It!

- Mehul Parikh


On Aug. 23, 2021, 2:57 p.m., Kishor Gollapalliwar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73539/
> ---
> 
> (Updated Aug. 23, 2021, 2:57 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3348
> https://issues.apache.org/jira/browse/RANGER-3348
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Remove hard-coded 'true' for 'forceDelete' request param in delete user & 
> group APIs
> 
> 
> Diffs
> -
> 
>   intg/src/main/python/apache_ranger/client/ranger_client.py dc69b045d 
> 
> 
> Diff: https://reviews.apache.org/r/73539/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean compile package install
> Python client - create service
> Python client - create policy
> Python client - delete policy
> Python client - delete service
> Python client - delete group
> Python client - delete user
> Python client - delete role
> 
> 
> Thanks,
> 
> Kishor Gollapalliwar
> 
>



Re: Review Request 73539: RANGER-3348: Add user & group delete functionality in Apache Ranger Python APIs - follow-up

2021-08-23 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73539/#review223373
---


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 23, 2021, 2:57 p.m., Kishor Gollapalliwar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73539/
> ---
> 
> (Updated Aug. 23, 2021, 2:57 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3348
> https://issues.apache.org/jira/browse/RANGER-3348
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Remove hard-coded 'true' for 'forceDelete' request param in delete user & 
> group APIs
> 
> 
> Diffs
> -
> 
>   intg/src/main/python/apache_ranger/client/ranger_client.py dc69b045d 
> 
> 
> Diff: https://reviews.apache.org/r/73539/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean compile package install
> Python client - create service
> Python client - create policy
> Python client - delete policy
> Python client - delete service
> Python client - delete group
> Python client - delete user
> Python client - delete role
> 
> 
> Thanks,
> 
> Kishor Gollapalliwar
> 
>



Review Request 73539: RANGER-3348: Add user & group delete functionality in Apache Ranger Python APIs - follow-up

2021-08-23 Thread Kishor Gollapalliwar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73539/
---

Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, and 
Velmurugan Periasamy.


Bugs: RANGER-3348
https://issues.apache.org/jira/browse/RANGER-3348


Repository: ranger


Description
---

Remove hard-coded 'true' for 'forceDelete' request param in delete user & group 
APIs


Diffs
-

  intg/src/main/python/apache_ranger/client/ranger_client.py dc69b045d 


Diff: https://reviews.apache.org/r/73539/diff/1/


Testing
---

mvn clean compile package install
Python client - create service
Python client - create policy
Python client - delete policy
Python client - delete service
Python client - delete group
Python client - delete user
Python client - delete role


Thanks,

Kishor Gollapalliwar