Re: Review Request 73911: RANGER-3666 : Ranger UI improvement - Add warning popup if auto-complete for resource lookup is failing in Edit policy page.

2022-03-23 Thread Mehul Parikh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73911/#review224202
---


Ship it!




Ship It!

- Mehul Parikh


On March 23, 2022, 1:07 p.m., Dhaval Rajpara wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73911/
> ---
> 
> (Updated March 23, 2022, 1:07 p.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, 
> Kishor Gollapalliwar, Mateen Mansoori, Mehul Parikh, Nitin Galave, Pradeep 
> Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3666
> https://issues.apache.org/jira/browse/RANGER-3666
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Currently if the resource lookup fails (due to some misconfiguration), there 
> is no indication to the user. If a warning popup is added in Edit policy page 
> if auto-complete for resource lookup is failing, that would help
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> be779f55f 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
> d4452a8d2 
>   
> security-admin/src/main/webapp/scripts/views/security_zone/ZoneResourceForm.js
>  7242d7bc2 
>   
> security-admin/src/main/webapp/scripts/views/service/ServiceAuditFilterResources.js
>  115486efd 
>   security-admin/src/main/webapp/styles/xa.css ff99fb195 
> 
> 
> Diff: https://reviews.apache.org/r/73911/diff/1/
> 
> 
> Testing
> ---
> 
> Tested that while the resource lookup fails (due to some misconfiguration), 
> we added notification that indicate proper error message.
> 
> 
> Thanks,
> 
> Dhaval Rajpara
> 
>



Review Request 73911: RANGER-3666 : Ranger UI improvement - Add warning popup if auto-complete for resource lookup is failing in Edit policy page.

2022-03-23 Thread Dhaval Rajpara

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73911/
---

Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, 
Kishor Gollapalliwar, Mateen Mansoori, Mehul Parikh, Nitin Galave, Pradeep 
Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-3666
https://issues.apache.org/jira/browse/RANGER-3666


Repository: ranger


Description
---

Currently if the resource lookup fails (due to some misconfiguration), there is 
no indication to the user. If a warning popup is added in Edit policy page if 
auto-complete for resource lookup is failing, that would help


Diffs
-

  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
be779f55f 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 
d4452a8d2 
  
security-admin/src/main/webapp/scripts/views/security_zone/ZoneResourceForm.js 
7242d7bc2 
  
security-admin/src/main/webapp/scripts/views/service/ServiceAuditFilterResources.js
 115486efd 
  security-admin/src/main/webapp/styles/xa.css ff99fb195 


Diff: https://reviews.apache.org/r/73911/diff/1/


Testing
---

Tested that while the resource lookup fails (due to some misconfiguration), we 
added notification that indicate proper error message.


Thanks,

Dhaval Rajpara