Re: Review Request 74194: RANGER-3962: Add preload directive to HSTS header
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74194/ --- (Updated Nov. 21, 2022, 6:48 a.m.) Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy. Bugs: RANGER-3962 https://issues.apache.org/jira/browse/RANGER-3962 Repository: ranger Description --- "Preload" directive is absent in HSTS header. As security its recommended to have within HSTS header. Diffs (updated) - kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMDCFilter.java 1174f0bd6 security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 9f83daf9a security-admin/src/main/webapp/login.jsp df234efd9 Diff: https://reviews.apache.org/r/74194/diff/2/ Changes: https://reviews.apache.org/r/74194/diff/1-2/ Testing --- 1. Ranger maven build successful -> mvn clean compile verify test install 2. Ranger Setup & install successful 3. Performed sanity testing. Thanks, Mahesh Bandal
Re: Review Request 74194: RANGER-3962: Add preload directive to HSTS header
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74194/#review224892 --- Ship it! Ship It! - Dhaval Shah On Nov. 8, 2022, 11:37 a.m., Mahesh Bandal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74194/ > --- > > (Updated Nov. 8, 2022, 11:37 a.m.) > > > Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor > Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep > Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3962 > https://issues.apache.org/jira/browse/RANGER-3962 > > > Repository: ranger > > > Description > --- > > "Preload" directive is absent in HSTS header. As security its recommended to > have within HSTS header. > > > Diffs > - > > kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMDCFilter.java > 1174f0bd6 > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java > 9f83daf9a > security-admin/src/main/webapp/login.jsp df234efd9 > > > Diff: https://reviews.apache.org/r/74194/diff/1/ > > > Testing > --- > > 1. Ranger maven build successful -> mvn clean compile verify test install > 2. Ranger Setup & install successful > 3. Performed sanity testing. > > > Thanks, > > Mahesh Bandal > >
Re: Review Request 74194: RANGER-3962: Add preload directive to HSTS header
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74194/#review224884 --- Ship it! Ship It! - Mehul Parikh On Nov. 8, 2022, 11:37 a.m., Mahesh Bandal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74194/ > --- > > (Updated Nov. 8, 2022, 11:37 a.m.) > > > Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor > Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep > Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3962 > https://issues.apache.org/jira/browse/RANGER-3962 > > > Repository: ranger > > > Description > --- > > "Preload" directive is absent in HSTS header. As security its recommended to > have within HSTS header. > > > Diffs > - > > kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMDCFilter.java > 1174f0bd6 > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java > 9f83daf9a > security-admin/src/main/webapp/login.jsp df234efd9 > > > Diff: https://reviews.apache.org/r/74194/diff/1/ > > > Testing > --- > > 1. Ranger maven build successful -> mvn clean compile verify test install > 2. Ranger Setup & install successful > 3. Performed sanity testing. > > > Thanks, > > Mahesh Bandal > >
Review Request 74194: RANGER-3962: Add preload directive to HSTS header
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74194/ --- Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy. Bugs: RANGER-3962 https://issues.apache.org/jira/browse/RANGER-3962 Repository: ranger Description --- "Preload" directive is absent in HSTS header. As security its recommended to have within HSTS header. Diffs - kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMDCFilter.java 1174f0bd6 security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java 9f83daf9a security-admin/src/main/webapp/login.jsp df234efd9 Diff: https://reviews.apache.org/r/74194/diff/1/ Testing --- 1. Ranger maven build successful -> mvn clean compile verify test install 2. Ranger Setup & install successful 3. Performed sanity testing. Thanks, Mahesh Bandal
