Re: Review Request 74287: RANGER-3910 : API Documentation is broken for knox sso.

2023-01-30 Thread Nitin Galave

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74287/#review225139
---


Ship it!




Ship It!

- Nitin Galave


On Jan. 31, 2023, 7:23 a.m., Dhaval Rajpara wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74287/
> ---
> 
> (Updated Jan. 31, 2023, 7:23 a.m.)
> 
> 
> Review request for ranger, bhavik patel, Dhaval Shah, Dineshkumar Yadav, 
> Harshal Chavan, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Nitin 
> Galave, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3910
> https://issues.apache.org/jira/browse/RANGER-3910
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Steps to reproduce :
> 
> 1. Open rander admin & login with knox user
> 2. Click on user's dropdown and navigate to API documentations.
> 
> 
> Diffs
> -
> 
>   docs/src/site/resources/index.html  
>   security-admin/src/main/webapp/scripts/views/common/ProfileBar.js d4ca108b9 
>   security-admin/src/main/webapp/templates/common/ProfileBar_tmpl.html 
> 049f472d0 
> 
> 
> Diff: https://reviews.apache.org/r/74287/diff/1/
> 
> 
> Testing
> ---
> 
> Tested that after patch knox sso for API Documentation link work as expected.
> 
> 
> Thanks,
> 
> Dhaval Rajpara
> 
>



Re: Review Request 74287: RANGER-3910 : API Documentation is broken for knox sso.

2023-01-30 Thread Dineshkumar Yadav

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74287/#review225138
---


Ship it!




Ship It!

- Dineshkumar Yadav


On Jan. 31, 2023, 7:23 a.m., Dhaval Rajpara wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74287/
> ---
> 
> (Updated Jan. 31, 2023, 7:23 a.m.)
> 
> 
> Review request for ranger, bhavik patel, Dhaval Shah, Dineshkumar Yadav, 
> Harshal Chavan, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Nitin 
> Galave, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3910
> https://issues.apache.org/jira/browse/RANGER-3910
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Steps to reproduce :
> 
> 1. Open rander admin & login with knox user
> 2. Click on user's dropdown and navigate to API documentations.
> 
> 
> Diffs
> -
> 
>   docs/src/site/resources/index.html  
>   security-admin/src/main/webapp/scripts/views/common/ProfileBar.js d4ca108b9 
>   security-admin/src/main/webapp/templates/common/ProfileBar_tmpl.html 
> 049f472d0 
> 
> 
> Diff: https://reviews.apache.org/r/74287/diff/1/
> 
> 
> Testing
> ---
> 
> Tested that after patch knox sso for API Documentation link work as expected.
> 
> 
> Thanks,
> 
> Dhaval Rajpara
> 
>



Review Request 74287: RANGER-3910 : API Documentation is broken for knox sso.

2023-01-30 Thread Dhaval Rajpara

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74287/
---

Review request for ranger, bhavik patel, Dhaval Shah, Dineshkumar Yadav, 
Harshal Chavan, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Nitin 
Galave, Pradeep Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-3910
https://issues.apache.org/jira/browse/RANGER-3910


Repository: ranger


Description
---

Steps to reproduce :

1. Open rander admin & login with knox user
2. Click on user's dropdown and navigate to API documentations.


Diffs
-

  docs/src/site/resources/index.html  
  security-admin/src/main/webapp/scripts/views/common/ProfileBar.js d4ca108b9 
  security-admin/src/main/webapp/templates/common/ProfileBar_tmpl.html 
049f472d0 


Diff: https://reviews.apache.org/r/74287/diff/1/


Testing
---

Tested that after patch knox sso for API Documentation link work as expected.


Thanks,

Dhaval Rajpara