Re: Review Request 74573: RANGER-4290: Adding uiHint attribute in policy condition

2023-08-29 Thread Mehul Parikh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74573/#review225706
---


Ship it!




Ship It!

- Mehul Parikh


On Aug. 29, 2023, 10:57 a.m., sanket shelar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74573/
> ---
> 
> (Updated Aug. 29, 2023, 10:57 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Sailaja 
> Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4290
> https://issues.apache.org/jira/browse/RANGER-4290
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-4157  introduced addition of Policy conditions to all service-defs. 
> However, this update does not include uiHint attribute in policy condition. 
> This needs to be fixed so that uiHint attribute will be available in all 
> service-defs.
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java
>  91d5f26bc 
> 
> 
> Diff: https://reviews.apache.org/r/74573/diff/1/
> 
> 
> Testing
> ---
> 
> Tested for service-defs and UiHint attribute is present in policy condition.
> 
> 
> Thanks,
> 
> sanket shelar
> 
>



Re: Review Request 74573: RANGER-4290: Adding uiHint attribute in policy condition

2023-08-29 Thread Ramesh Mani

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74573/#review225704
---


Ship it!




Ship It!

- Ramesh Mani


On Aug. 29, 2023, 10:57 a.m., sanket shelar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74573/
> ---
> 
> (Updated Aug. 29, 2023, 10:57 a.m.)
> 
> 
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Sailaja 
> Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4290
> https://issues.apache.org/jira/browse/RANGER-4290
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-4157  introduced addition of Policy conditions to all service-defs. 
> However, this update does not include uiHint attribute in policy condition. 
> This needs to be fixed so that uiHint attribute will be available in all 
> service-defs.
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java
>  91d5f26bc 
> 
> 
> Diff: https://reviews.apache.org/r/74573/diff/1/
> 
> 
> Testing
> ---
> 
> Tested for service-defs and UiHint attribute is present in policy condition.
> 
> 
> Thanks,
> 
> sanket shelar
> 
>



Review Request 74573: RANGER-4290: Adding uiHint attribute in policy condition

2023-08-29 Thread sanket shelar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74573/
---

Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay 
Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Sailaja Polavarapu, 
and Velmurugan Periasamy.


Bugs: RANGER-4290
https://issues.apache.org/jira/browse/RANGER-4290


Repository: ranger


Description
---

RANGER-4157  introduced addition of Policy conditions to all service-defs. 
However, this update does not include uiHint attribute in policy condition. 
This needs to be fixed so that uiHint attribute will be available in all 
service-defs.


Diffs
-

  
security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java
 91d5f26bc 


Diff: https://reviews.apache.org/r/74573/diff/1/


Testing
---

Tested for service-defs and UiHint attribute is present in policy condition.


Thanks,

sanket shelar