Re: Review Request 74699: RANGER-4497: updated service-defs to assign category to access-type-defs

2023-11-09 Thread Madhan Neethiraj 


> On Oct. 28, 2023, 6:58 a.m., Subhrat Chaudhary wrote:
> > agents-common/src/main/resources/service-defs/ranger-servicedef-hive.json
> > Lines 182 (patched)
> > 
> >
> > should the category be UPDATE or MANAGE here? Same for Alter in 
> > ranger-servicedef-kudu.json and ranger-servicedef-presto.json.

ALTER is a metadata operation, hence categoriezed as CREATE.


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74699/#review225900
---


On Oct. 26, 2023, 8:49 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74699/
> ---
> 
> (Updated Oct. 26, 2023, 8:49 a.m.)
> 
> 
> Review request for ranger, Anand Nadar, Ankita Sinha, Abhay Kulkarni, Mehul 
> Parikh, Monika Kachhadiya, Mugdha Varadkar, Prashant Satam, Ramesh Mani, 
> Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4497
> https://issues.apache.org/jira/browse/RANGER-4497
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> - updated all service-defs to assign category to access-types
> 
> 
> Diffs
> -
> 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-abfs.json 
> 879df6b9f 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json 
> 960f10123 
>   
> agents-common/src/main/resources/service-defs/ranger-servicedef-elasticsearch.json
>  da621c748 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-hbase.json 
> f94e73a5e 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-hdfs.json 
> bc021a0dd 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-hive.json 
> ab8ca5c92 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json 
> a131ed08b 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kms.json 
> abd28f034 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-knox.json 
> ee44687b4 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kudu.json 
> 51fd9f8a2 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json 
> 70566dfd6 
>   
> agents-common/src/main/resources/service-defs/ranger-servicedef-nestedstructure.json
>  dc6b1d32d 
>   
> agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json
>  3db268bb8 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-nifi.json 
> 30680083f 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-ozone.json 
> 13915130c 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json 
> b16b02a7b 
>   
> agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json
>  bdebf406d 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json 
> 50545f744 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-sqoop.json 
> 544276e9a 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-storm.json 
> 4db4a7431 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-trino.json 
> 88a57e1f0 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-wasb.json 
> fd30c51d8 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-yarn.json 
> b102641ee 
> 
> 
> Diff: https://reviews.apache.org/r/74699/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that assigned categories are persisted in the database
> - verified that implied-grants of markerAccessTypes are populated with 
> access-types having respective category
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 74699: RANGER-4497: updated service-defs to assign category to access-type-defs

2023-10-28 Thread Subhrat Chaudhary via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74699/#review225900
---




agents-common/src/main/resources/service-defs/ranger-servicedef-hive.json
Lines 182 (patched)


should the category be UPDATE or MANAGE here? Same for Alter in 
ranger-servicedef-kudu.json and ranger-servicedef-presto.json.



agents-common/src/main/resources/service-defs/ranger-servicedef-kudu.json
Lines 126 (patched)


Should the category be CREATE here?



agents-common/src/main/resources/service-defs/ranger-servicedef-nestedstructure.json
Line 51 (original), 51 (patched)


We do not have category WRITE, should this be UPDATE here?



agents-common/src/main/resources/service-defs/ranger-servicedef-storm.json
Lines 55 (patched)


Should category be READ here, since this access type will not allow to 
anything?


- Subhrat Chaudhary


On Oct. 26, 2023, 2:19 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74699/
> ---
> 
> (Updated Oct. 26, 2023, 2:19 p.m.)
> 
> 
> Review request for ranger, Anand Nadar, Ankita Sinha, Abhay Kulkarni, Mehul 
> Parikh, Monika Kachhadiya, Mugdha Varadkar, Prashant Satam, Ramesh Mani, 
> Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4497
> https://issues.apache.org/jira/browse/RANGER-4497
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> - updated all service-defs to assign category to access-types
> 
> 
> Diffs
> -
> 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-abfs.json 
> 879df6b9f 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json 
> 960f10123 
>   
> agents-common/src/main/resources/service-defs/ranger-servicedef-elasticsearch.json
>  da621c748 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-hbase.json 
> f94e73a5e 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-hdfs.json 
> bc021a0dd 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-hive.json 
> ab8ca5c92 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json 
> a131ed08b 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kms.json 
> abd28f034 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-knox.json 
> ee44687b4 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kudu.json 
> 51fd9f8a2 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json 
> 70566dfd6 
>   
> agents-common/src/main/resources/service-defs/ranger-servicedef-nestedstructure.json
>  dc6b1d32d 
>   
> agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json
>  3db268bb8 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-nifi.json 
> 30680083f 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-ozone.json 
> 13915130c 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json 
> b16b02a7b 
>   
> agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json
>  bdebf406d 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json 
> 50545f744 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-sqoop.json 
> 544276e9a 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-storm.json 
> 4db4a7431 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-trino.json 
> 88a57e1f0 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-wasb.json 
> fd30c51d8 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-yarn.json 
> b102641ee 
> 
> 
> Diff: https://reviews.apache.org/r/74699/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that assigned categories are persisted in the database
> - verified that implied-grants of markerAccessTypes are populated with 
> access-types having respective category
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Review Request 74699: RANGER-4497: updated service-defs to assign category to access-type-defs

2023-10-26 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74699/
---

Review request for ranger, Anand Nadar, Ankita Sinha, Abhay Kulkarni, Mehul 
Parikh, Monika Kachhadiya, Mugdha Varadkar, Prashant Satam, Ramesh Mani, 
Subhrat Chaudhary, and Velmurugan Periasamy.


Bugs: RANGER-4497
https://issues.apache.org/jira/browse/RANGER-4497


Repository: ranger


Description
---

- updated all service-defs to assign category to access-types


Diffs
-

  agents-common/src/main/resources/service-defs/ranger-servicedef-abfs.json 
879df6b9f 
  agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json 
960f10123 
  
agents-common/src/main/resources/service-defs/ranger-servicedef-elasticsearch.json
 da621c748 
  agents-common/src/main/resources/service-defs/ranger-servicedef-hbase.json 
f94e73a5e 
  agents-common/src/main/resources/service-defs/ranger-servicedef-hdfs.json 
bc021a0dd 
  agents-common/src/main/resources/service-defs/ranger-servicedef-hive.json 
ab8ca5c92 
  agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json 
a131ed08b 
  agents-common/src/main/resources/service-defs/ranger-servicedef-kms.json 
abd28f034 
  agents-common/src/main/resources/service-defs/ranger-servicedef-knox.json 
ee44687b4 
  agents-common/src/main/resources/service-defs/ranger-servicedef-kudu.json 
51fd9f8a2 
  agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json 
70566dfd6 
  
agents-common/src/main/resources/service-defs/ranger-servicedef-nestedstructure.json
 dc6b1d32d 
  
agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json
 3db268bb8 
  agents-common/src/main/resources/service-defs/ranger-servicedef-nifi.json 
30680083f 
  agents-common/src/main/resources/service-defs/ranger-servicedef-ozone.json 
13915130c 
  agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json 
b16b02a7b 
  
agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json
 bdebf406d 
  agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json 
50545f744 
  agents-common/src/main/resources/service-defs/ranger-servicedef-sqoop.json 
544276e9a 
  agents-common/src/main/resources/service-defs/ranger-servicedef-storm.json 
4db4a7431 
  agents-common/src/main/resources/service-defs/ranger-servicedef-trino.json 
88a57e1f0 
  agents-common/src/main/resources/service-defs/ranger-servicedef-wasb.json 
fd30c51d8 
  agents-common/src/main/resources/service-defs/ranger-servicedef-yarn.json 
b102641ee 


Diff: https://reviews.apache.org/r/74699/diff/1/


Testing
---

- verified that assigned categories are persisted in the database
- verified that implied-grants of markerAccessTypes are populated with 
access-types having respective category


Thanks,

Madhan Neethiraj