Re: Review Request 74730: RANGER-4283: [WIP] UI for GDS: shared resource design fix, CSS. bug fixes

2023-11-09 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74730/#review225953
---


Ship it!




Ship It!

- Madhan Neethiraj


On Nov. 9, 2023, 1:03 p.m., Anand Nadar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74730/
> ---
> 
> (Updated Nov. 9, 2023, 1:03 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Brijesh Bhalala, Dhaval Rajpara, 
> Madhan Neethiraj, Mugdha Varadkar, Prashant Satam, and Subhrat Chaudhary.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/RANGER-4283
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4283
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> UI for GDS: shared resource design fix, CSS. bug fixes
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/react-webapp/src/images/view-request.svg 
> PRE-CREATION 
>   security-admin/src/main/webapp/react-webapp/src/styles/style.css e00450bf0 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/AccessGrantForm.jsx
>  4a6b7c402 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetDetailLayout.jsx
>  43d023caa 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatashareInDatasetListComp.jsx
>  5616fca6f 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/MyDatasetListing.jsx
>  e0b9a19f9 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/PrinciplePermissionComp.jsx
>  c39201941 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/AddDatashareView.jsx
>  483b89ea0 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/AddSharedResourceComp.jsx
>  eb489535c 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/DatashareDetailLayout.jsx
>  4c777286d 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/MyDatashareListing.jsx
>  eb877a04b 
>   
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx
>  e2ef63188 
> 
> 
> Diff: https://reviews.apache.org/r/74730/diff/1/
> 
> 
> Testing
> ---
> 
> Validated create/update/delete for shared resource with new design
> Validated Save & Close, Save & Add another functionality for shared resource 
> creation.
> Validated edit of dataset and datashare names.
> CSS for access grant page.
> 
> 
> Thanks,
> 
> Anand Nadar
> 
>



Review Request 74730: RANGER-4283: [WIP] UI for GDS: shared resource design fix, CSS. bug fixes

2023-11-09 Thread Anand Nadar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74730/
---

Review request for ranger, Ankita Sinha, Brijesh Bhalala, Dhaval Rajpara, 
Madhan Neethiraj, Mugdha Varadkar, Prashant Satam, and Subhrat Chaudhary.


Bugs: https://issues.apache.org/jira/browse/RANGER-4283

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4283


Repository: ranger


Description
---

UI for GDS: shared resource design fix, CSS. bug fixes


Diffs
-

  security-admin/src/main/webapp/react-webapp/src/images/view-request.svg 
PRE-CREATION 
  security-admin/src/main/webapp/react-webapp/src/styles/style.css e00450bf0 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/AccessGrantForm.jsx
 4a6b7c402 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetDetailLayout.jsx
 43d023caa 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatashareInDatasetListComp.jsx
 5616fca6f 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/MyDatasetListing.jsx
 e0b9a19f9 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/PrinciplePermissionComp.jsx
 c39201941 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/AddDatashareView.jsx
 483b89ea0 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/AddSharedResourceComp.jsx
 eb489535c 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/DatashareDetailLayout.jsx
 4c777286d 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/MyDatashareListing.jsx
 eb877a04b 
  
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx
 e2ef63188 


Diff: https://reviews.apache.org/r/74730/diff/1/


Testing
---

Validated create/update/delete for shared resource with new design
Validated Save & Close, Save & Add another functionality for shared resource 
creation.
Validated edit of dataset and datashare names.
CSS for access grant page.


Thanks,

Anand Nadar