Re: Review Request 74777: RANGER-4585:Support multiple columns policy creation in ranger for Grant / Revoke request

2023-12-20 Thread Abhay Kulkarni

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74777/#review226073
---


Ship it!




Ship It!

- Abhay Kulkarni


On Dec. 7, 2023, 9:59 p.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74777/
> ---
> 
> (Updated Dec. 7, 2023, 9:59 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, 
> Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-4585
> https://issues.apache.org/jira/browse/RANGER-4585
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-4585:Support multiple columns policy creation in ranger for Grant / 
> Revoke request
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
> cffd177be 
>   security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 
> d049f9949 
> 
> 
> Diff: https://reviews.apache.org/r/74777/diff/1/
> 
> 
> Testing
> ---
> 
> - Testing done on select with mulitple and single columns in a VM via impala 
> and hive shell.
> -   grant select (col1, col2, col3, col4, col5, col6, col7, col8)  on table 
> demo.data9 to role testrole1
> -   revoke select(col1,col2) on table demo.data10 from role testrole1;
> -   grant select (col1)  on table demo.data10 to role testrole2;
> -   revoke select(col1)  on table demo.data10 from role testrole2;
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>



Review Request 74777: RANGER-4585:Support multiple columns policy creation in ranger for Grant / Revoke request

2023-12-07 Thread Ramesh Mani

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74777/
---

Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, 
Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan 
Periasamy.


Bugs: RANGER-4585
https://issues.apache.org/jira/browse/RANGER-4585


Repository: ranger


Description
---

RANGER-4585:Support multiple columns policy creation in ranger for Grant / 
Revoke request


Diffs
-

  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
cffd177be 
  security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 
d049f9949 


Diff: https://reviews.apache.org/r/74777/diff/1/


Testing
---

- Testing done on select with mulitple and single columns in a VM via impala 
and hive shell.
-   grant select (col1, col2, col3, col4, col5, col6, col7, col8)  on table 
demo.data9 to role testrole1
-   revoke select(col1,col2) on table demo.data10 from role testrole1;
-   grant select (col1)  on table demo.data10 to role testrole2;
-   revoke select(col1)  on table demo.data10 from role testrole2;


Thanks,

Ramesh Mani