Thanks for putting this release together Mukul. +1 (binding)
1. Verified hashes 2. Verified signatures 3. Release source matches git tag. Minor issue, not a blocker: pom.xml.versionsBackup files are present in release source. 4. LICENSE/NOTICE files look sane. 5. Built from source. 6. Ran filestore example I ran into a command-line parsing bug while trying the filestore example. I was able to work around it and it need not block the release. Couple of comments: 1. Your public key is not present in https://dist.apache.org/repos/dist/dev/incubator/ratis/KEYS 2. It would be good to sign the git tag. > On Jul 29, 2019, at 2:59 AM, Mukul Kumar Singh <mksingh.apa...@gmail.com> > wrote: > > Hi Apache Ratis PPMC, > > I am calling a vote for Apache Ratis incubating Release 0.4.0 rc1. > This vote is after fixing issues RATIS-642 & RATIS-621 in the rc0 vote. > > This is with respect to the discuss mailthread > <https://lists.apache.org/thread.html/781fb6db8fe3327683f96b880496cf4b297f8666a2fab85c413c6f4b@%3Cdev.ratis.apache.org%3E>. > > The git tag to be voted upon: > https://gitbox.apache.org/repos/asf?p=incubator-ratis.git;a=shortlog;h=refs/tags/0.4.0-rc1 > > The git commit hash: > https://gitbox.apache.org/repos/asf?p=incubator-ratis.git;a=commit;h=5dc4e717c8540b275cc2af33ab100c2a6ec21fc2 > > <https://gitbox.apache.org/repos/asf?p=incubator-ratis.git;a=commit;h=d4f5c9ded9ea4dc1a8acbec9a5e24f5e2f3bc6b6> > > The source and binary tarballs can be found at: > http://people.apache.org/~msingh/0.4.0-rc1/ > <http://people.apache.org/~msingh/0.4.0-rc0/> > > The fingerprint of key to sign release artifacts: > 45B0 13F6 29C6 89CC 6EE3 77B0 8D43 C3D9 A8F1 02BD > > Release artifacts are signed with one of the keys available at: > https://dist.apache.org/repos/dist/dev/incubator/ratis/KEYS > <https://dist.apache.org/repos/dist/dev/incubator/ratis/KEYS> > > This vote will remain open for at least 72 hours. > Please vote on releasing this RC. Thank you in advance. > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > Starting with my +1. > > Regards, > Mukul Kumar Singh >
