[GitHub] [rocketmq] liony opened a new issue #1482: fix communicationMode
liony opened a new issue #1482: fix communicationMode URL: https://github.com/apache/rocketmq/issues/1482 cause sync as try once , and async can try once more, but this line code is not that meaning, and from the invoke context alse can explain there has some logic wrong.   so change the code: int timesTotal = communicationMode == CommunicationMode.**SYNC** ? 1 + this.defaultMQProducer.getRetryTimesWhenSendFailed() : 1; fix as: int timesTotal = communicationMode == CommunicationMode.**ASYNC** ? 1 + this.defaultMQProducer.getRetryTimesWhenSendFailed() : 1; here is the fixed file: [DefaultMQProducerImpl.java](https://github.com/apache/rocketmq/files/3650452/DefaultMQProducerImpl.txt) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-operator] liuruiyiyang opened a new pull request #8: [New Feature] Add TopicTransfer CRD for Topic Transfer Feature with Atomicity
liuruiyiyang opened a new pull request #8: [New Feature] Add TopicTransfer CRD for Topic Transfer Feature with Atomicity URL: https://github.com/apache/rocketmq-operator/pull/8 Change List: 1. Add a new feature of topic transfer operation with corresponding CRD and controller. 2. Add some implementations of operation undo-process for topic transfer operation atomicity. 3. Add some docs about the new feature ```Topic Transfer``` 4. Fix a bug that happens when scaling up broker cluster if config path does not exist. 5. Replace some magic numbers with constants. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-operator] liuruiyiyang commented on issue #7: Dockerfile issue
liuruiyiyang commented on issue #7: Dockerfile issue URL: https://github.com/apache/rocketmq-operator/issues/7#issuecomment-534835486 Thanks for your questions. Currently the ```rocketmq-operator``` and other related images has not been pushed to the ```docker.io/library``` repo, but we will push the images to the official docker repo in the future. You may consider ```docker.io/library``` as a placeholder for now, which you can replace it with your own repo for development and testing purpose. We will mention this in the documents for developers later. For the rocketmq code, the operator will collaborate with the ```RocketMQ Admin Tool``` to do the cluster management jobs so we simply install rocketmq code in the operator image. We haven't separated the ```mqadmin``` related part yet, welcome to do some optimizations on that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] coveralls edited a comment on issue #1422: [RIP-16]Support request/response pattern
coveralls edited a comment on issue #1422: [RIP-16]Support request/response pattern URL: https://github.com/apache/rocketmq/pull/1422#issuecomment-531618889 [](https://coveralls.io/builds/25911850) Coverage increased (+0.003%) to 49.512% when pulling **777285011e81d145b067a6e73816a6a5c533057f on qqeasonchen:rocketmq-dev-rpc** into **61f4f99b884d6b1d716414b14ed2e494d201bebe on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-operator] huanwei opened a new issue #7: Dockerfile issue
huanwei opened a new issue #7: Dockerfile issue
URL: https://github.com/apache/rocketmq-operator/issues/7
**BUG REPORT**
1. Please describe the issue you observed:
- What did you do (The steps to reproduce)?
./create-operator.sh
- What did you expect to see?
operator image built with success
- What did you see instead?
operator image built with error, as following:
```
INFO[] Building OCI image
docker.io/library/rocketmq-operator:v0.0.1-snapshot
Sending build context to Docker daemon 70.62MB
Step 1/15 : FROM openjdk:8-alpine
---> a3562aa0b991
Step 2/15 : RUN apk add --no-cache bash gettext nmap-ncat openssl
busybox-extras
---> Using cache
---> f589b44cfa81
Step 3/15 : ENV OPERATOR=/usr/local/bin/rocketmq-operator USER_UID=1001
USER_NAME=rocketmq-operator
---> Using cache
---> cc4ea4c26514
Step 4/15 : COPY build/_output/bin/rocketmq-operator ${OPERATOR}
---> Using cache
---> 4a1a344fd240
Step 5/15 : COPY build/bin /usr/local/bin
---> Using cache
---> 7579aed2506c
Step 6/15 : RUN /usr/local/bin/user_setup
---> Using cache
---> 3d3e29904d3d
Step 7/15 : ENV ROCKETMQ_VERSION 4.5.0
---> Using cache
---> bb839b99a39c
Step 8/15 : ENV ROCKETMQ_HOME /home/rocketmq/rocketmq-${ROCKETMQ_VERSION}
---> Using cache
---> 43ff35f63e5f
Step 9/15 : WORKDIR ${ROCKETMQ_HOME}
---> Using cache
---> 9ef1be398427
Step 10/15 : COPY build/rocketmq.zip ${ROCKETMQ_HOME}/rocketmq.zip
COPY failed: stat
/var/lib/docker/tmp/docker-builder520479874/build/rocketmq.zip: no such file or
directory
Error: failed to output build image
docker.io/library/rocketmq-operator:v0.0.1-snapshot: (failed to exec
[]string{"docker", "build", "-f", "build/Dockerfile", "-t",
"docker.io/library/rocketmq-operator:v0.0.1-snapshot", "."}: exit status 1)
```
2. Please tell us about your environment:
linux
3. Other information (e.g. detailed explanation, logs, related issues,
suggestions how to fix, etc):
Why did we install rocketmq code in operator? I suggest removing the unused
parts.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-spring] MartinDai opened a new pull request #150: [ISSUE #81]fix RocketMQTemplate.syncSend collection type method signature
MartinDai opened a new pull request #150: [ISSUE #81]fix RocketMQTemplate.syncSend collection type method signature URL: https://github.com/apache/rocketmq-spring/pull/150 ## What is the purpose of the change fix RocketMQTemplate.syncSend collection type method signature ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-externals] xujianhai666 opened a new pull request #425: [ISSUE #376] Runtime support dynamic add connector
xujianhai666 opened a new pull request #425: [ISSUE #376] Runtime support dynamic add connector URL: https://github.com/apache/rocketmq-externals/pull/425 ## What is the purpose of the change support dynamic add connector ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-spring] MartinDai commented on issue #143: RocketMQLocalTransactionListener auto config not support placeholder value
MartinDai commented on issue #143: RocketMQLocalTransactionListener auto config not support placeholder value URL: https://github.com/apache/rocketmq-spring/issues/143#issuecomment-534566624 @RongtongJin I found this BUG was fixed by chunhai in **master** branch,so this issue can be closed.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] mickey0524 opened a new issue #1481: logging 包代码多余
mickey0524 opened a new issue #1481: logging 包代码多余 URL: https://github.com/apache/rocketmq/issues/1481 logging/src/main/java/org/apache/rocketmq/logging/InnerLoggerFactory.java 文件中 284 行的判断是多余的，如果前面的 for 循环结束，说明 len == argArray.length，或者直接在 for 循环内就 return 了，因此此处没有必要使用 if https://user-images.githubusercontent.com/22164927/65502296-1c05b280-def5-11e9-9b9b-4cb6b1f19f08.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] wqliang commented on a change in pull request #1458: [ISSUE #1457] Dynamically effective namesrvAddr for name server auto-scaling
wqliang commented on a change in pull request #1458: [ISSUE #1457] Dynamically
effective namesrvAddr for name server auto-scaling
URL: https://github.com/apache/rocketmq/pull/1458#discussion_r327528761
##
File path:
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
##
@@ -493,6 +490,17 @@ private synchronized RemotingCommand
updateBrokerConfig(ChannelHandlerContext ct
return response;
}
+private void applyUpdatedConfig(Properties properties) {
+if (properties.containsKey(MixAll.DUP_NAMESRV_ADDR)) {
+String updatedNamesrvAddr =
this.brokerController.getBrokerConfig().getNamesrvAddr();
+
this.brokerController.getBrokerOuterAPI().updateNameServerAddressList(updatedNamesrvAddr);
Review comment:
[QUESTION] If `fetchNamesrvAddrByAddressServer` is true and namesrAddr is
null when broker startup, broker will update namesrv address from address
server periodically. After you update it , the scheduled task will overwrite
it at next period. Maybe you should cancle the scheduled task if it exist. Or
you can return some tips if such update schedule task exist. I think remind
user and let him decide whether or not update and cancle the task might be
better.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-spring] RongtongJin commented on issue #126: The checker is not available in transaction messages.
RongtongJin commented on issue #126: The checker is not available in transaction messages. URL: https://github.com/apache/rocketmq-spring/issues/126#issuecomment-534472806 I tried the function in my environment and check back was right. Check back needs to wait for a while. I used rocketmq-spring 2.0.3 as you did. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-spring] MartinDai commented on issue #143: RocketMQLocalTransactionListener auto config not support placeholder value
MartinDai commented on issue #143: RocketMQLocalTransactionListener auto config not support placeholder value URL: https://github.com/apache/rocketmq-spring/issues/143#issuecomment-534441302 > RocketMQLocalTransactionListener does not support resloving placeholder indeed. Welcome to submit a PR to fix it. OK,I will try to fix it and submit the PR in the near future. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-spring] RongtongJin commented on issue #143: RocketMQLocalTransactionListener auto config not support placeholder value
RongtongJin commented on issue #143: RocketMQLocalTransactionListener auto config not support placeholder value URL: https://github.com/apache/rocketmq-spring/issues/143#issuecomment-534436896 RocketMQLocalTransactionListener does not support resloving placeholder indeed. Welcome to submit a PR to fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing commented on issue #226: [master]how to do a simple flow-control when consumer is busy?
ShannonDing commented on issue #226: [master]how to do a simple flow-control when consumer is busy? URL: https://github.com/apache/rocketmq-client-go/issues/226#issuecomment-534404244 close due to #225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing closed issue #226: [master]how to do a simple flow-control when consumer is busy?
ShannonDing closed issue #226: [master]how to do a simple flow-control when consumer is busy? URL: https://github.com/apache/rocketmq-client-go/issues/226 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing closed issue #211: [native]The MessageId Unmarshal failed.
ShannonDing closed issue #211: [native]The MessageId Unmarshal failed. URL: https://github.com/apache/rocketmq-client-go/issues/211 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing commented on issue #211: [native]The MessageId Unmarshal failed.
ShannonDing commented on issue #211: [native]The MessageId Unmarshal failed. URL: https://github.com/apache/rocketmq-client-go/issues/211#issuecomment-534404022 close due to #210 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing commented on issue #217: [master]Want to send orderly message by simple shardingkey.
ShannonDing commented on issue #217: [master]Want to send orderly message by simple shardingkey. URL: https://github.com/apache/rocketmq-client-go/issues/217#issuecomment-534403257 close due to #222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing closed issue #217: [master]Want to send orderly message by simple shardingkey.
ShannonDing closed issue #217: [master]Want to send orderly message by simple shardingkey. URL: https://github.com/apache/rocketmq-client-go/issues/217 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing merged pull request #225: feat(consumer): add set maxcachesize api to support simple flow-control
ShannonDing merged pull request #225: feat(consumer): add set maxcachesize api to support simple flow-control URL: https://github.com/apache/rocketmq-client-go/pull/225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
