[GitHub] Jason918 commented on issue #178: [ROCKETMQ-290] Fix memory leak in WaitNotifyObject#waitingThreadTable

2017-12-14 Thread GitBox
Jason918 commented on issue #178: [ROCKETMQ-290] Fix memory leak in 
WaitNotifyObject#waitingThreadTable
URL: https://github.com/apache/rocketmq/pull/178#issuecomment-351899059
 
 
   @zhouxinyu Unit tests added, please check these out. 
   This bug actually has major impact on the performance 
   if this leaks happens repeatedly and  brokerRole is set to SYNC_MASTER.  
`org.apache.rocketmq.store.ha.WaitNotifyObject#wakeupAll` is called in 
`org.apache.rocketmq.store.CommitLog#handleHA` when broker is processing a 
SendMessageRequest. `WaitNotifyObject#wakeupAll `would iterate through all 
values in waitingThreadTable.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Jason918 commented on issue #178: [ROCKETMQ-290] Fix memory leak in WaitNotifyObject#waitingThreadTable

2017-12-14 Thread GitBox
Jason918 commented on issue #178: [ROCKETMQ-290] Fix memory leak in 
WaitNotifyObject#waitingThreadTable
URL: https://github.com/apache/rocketmq/pull/178#issuecomment-351899059
 
 
   @zhouxinyu Unit tests added, please check these out. 
   This bug actually has major impact on the performance 
   if this leaks happens repeatedly and  brokerRole is set to SYNC_MASTER.  
org.apache.rocketmq.store.ha.WaitNotifyObject#wakeupAll is called in 
org.apache.rocketmq.store.CommitLog#handleHA when broker is processing a 
SendMessageRequest. WaitNotifyObject#wakeupAll would iterate through all values 
in waitingThreadTable.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Jason918 commented on issue #178: [ROCKETMQ-290] Fix memory leak in WaitNotifyObject#waitingThreadTable

2017-12-14 Thread GitBox
Jason918 commented on issue #178: [ROCKETMQ-290] Fix memory leak in 
WaitNotifyObject#waitingThreadTable
URL: https://github.com/apache/rocketmq/pull/178#issuecomment-351899059
 
 
   @zhouxinyu Unit tests added, please check these out. 
   This bug actually has major impact on the performance 
   if this leaks happens repeatedly and  brokerRole is set to SYNC_MASTER.  
org.apache.rocketmq.store.ha.WaitNotifyObject#wakeupAll is called in 
org.apache.rocketmq.store.CommitLog#handleHA when broker is process a 
SendMessageRequest. WaitNotifyObject#wakeupAll would iterate through all values 
in waitingThreadTable.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Jason918 commented on issue #178: [ROCKETMQ-290] Fix memory leak in WaitNotifyObject#waitingThreadTable

2017-12-14 Thread GitBox
Jason918 commented on issue #178: [ROCKETMQ-290] Fix memory leak in 
WaitNotifyObject#waitingThreadTable
URL: https://github.com/apache/rocketmq/pull/178#issuecomment-351899059
 
 
   @zhouxinyu Unit tests added, please check these out. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services