[GitHub] [rocketmq-externals] lexingrensheng opened a new issue #419: rocketmq-connect-kafka support rocketmq-connector-runtime
lexingrensheng opened a new issue #419: rocketmq-connect-kafka support rocketmq-connector-runtime URL: https://github.com/apache/rocketmq-externals/issues/419 It is hoped that rocketmq-connect-kafka will support rocketmq-runtime instead of openmessage-connect-runtime in the future This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-exporter] liangyuanpeng opened a new pull request #7: [ISSUE #6]optimize code for metric dto and metricsController
liangyuanpeng opened a new pull request #7: [ISSUE #6]optimize code for metric dto and metricsController URL: https://github.com/apache/rocketmq-exporter/pull/7 ## What is the purpose of the change optimize code for metric dto and metricsController ## Brief changelog ## Verifying this change req url:port/metrics fixes #6 Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] vongosling removed a comment on issue #120: 2.0.0-rc1 Roadmap
vongosling removed a comment on issue #120: 2.0.0-rc1 Roadmap URL: https://github.com/apache/rocketmq-client-go/issues/120#issuecomment-530646277 @wenfengwang Do we need to continue opening this issue. I've seen we have released 2.0.0-rc1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing closed issue #183: Repeated consumption problem when changing consumeMessageBatchMaxSize
ShannonDing closed issue #183: Repeated consumption problem when changing consumeMessageBatchMaxSize URL: https://github.com/apache/rocketmq-client-go/issues/183 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing commented on issue #183: Repeated consumption problem when changing consumeMessageBatchMaxSize
ShannonDing commented on issue #183: Repeated consumption problem when changing consumeMessageBatchMaxSize URL: https://github.com/apache/rocketmq-client-go/issues/183#issuecomment-531571970 close due to #206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-externals] lexingrensheng opened a new issue #417: org.apache.rocketmq.replicator build error
lexingrensheng opened a new issue #417: org.apache.rocketmq.replicator build error URL: https://github.com/apache/rocketmq-externals/issues/417 mvn clean install -Prelease-all -DskipTest -U error Running org.apache.rocketmq.replicator.RmqSourceReplicatorTest Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.964 sec <<< FAILURE! buildWildcardRoute(org.apache.rocketmq.replicator.RmqSourceReplicatorTest) Time elapsed: 0.152 sec <<< ERROR! java.lang.NoSuchFieldException: defaultMQAdminExt at java.lang.Class.getDeclaredField(Class.java:2070) at org.apache.rocketmq.replicator.RmqSourceReplicatorTest.buildWildcardRoute(RmqSourceReplicatorTest.java:75) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) at org.junit.runners.ParentRunner.run(ParentRunner.java:309) at org.mockito.internal.runners.DefaultInternalRunner$1.run(DefaultInternalRunner.java:68) at org.mockito.internal.runners.DefaultInternalRunner.run(DefaultInternalRunner.java:74) at org.mockito.internal.runners.StrictRunner.run(StrictRunner.java:39) at org.mockito.junit.MockitoJUnitRunner.run(MockitoJUnitRunner.java:142) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75) Results : Tests in error: buildWildcardRoute(org.apache.rocketmq.replicator.RmqSourceReplicatorTest): defaultMQAdminExt Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 5.356 s [INFO] Finished at: 2019-09-15T22:30:39+08:00 [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on project rocketmq-replicator: There are test failures. [ERROR] [ERROR] Please refer to E:\githup\java\rocketmq-externals\rocketmq-replicator\target\surefire-reports for the individual test results. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[GitHub] [rocketmq-client-go] codecov-io edited a comment on issue #206: [ISSUE #183] add set consumeMessageBatchMaxSize and fixed count++ skip one message…
codecov-io edited a comment on issue #206: [ISSUE #183] add set consumeMessageBatchMaxSize and fixed count++ skip one message… URL: https://github.com/apache/rocketmq-client-go/pull/206#issuecomment-531538618 # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/206?src=pr=h1) Report > Merging [#206](https://codecov.io/gh/apache/rocketmq-client-go/pull/206?src=pr=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/d8d5e4605f5f78b6c9e4a66ca2be4c3dbd4e3395?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/rocketmq-client-go/pull/206?src=pr=tree) ```diff @@Coverage Diff @@ ## native #206 +/- ## == - Coverage 26.52% 26.51% -0.02% == Files 46 46 Lines4674 4677 +3 == Hits 1240 1240 - Misses 3262 3265 +3 Partials 172 172 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/206?src=pr=tree) | Coverage Δ | | |---|---|---| | [consumer/option.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/206/diff?src=pr=tree#diff-Y29uc3VtZXIvb3B0aW9uLmdv) | `28.57% <0%> (-1.62%)` | :arrow_down: | | [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/206/diff?src=pr=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `14.94% <0%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/206?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/206?src=pr=footer). Last update [d8d5e46...571efb4](https://codecov.io/gh/apache/rocketmq-client-go/pull/206?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io commented on issue #206: [ISSUE #183] add set consumeMessageBatchMaxSize and fixed count++ skip one message…
codecov-io commented on issue #206: [ISSUE #183] add set consumeMessageBatchMaxSize and fixed count++ skip one message… URL: https://github.com/apache/rocketmq-client-go/pull/206#issuecomment-531538618 # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/206?src=pr=h1) Report > Merging [#206](https://codecov.io/gh/apache/rocketmq-client-go/pull/206?src=pr=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/d8d5e4605f5f78b6c9e4a66ca2be4c3dbd4e3395?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/rocketmq-client-go/pull/206?src=pr=tree) ```diff @@Coverage Diff @@ ## native #206 +/- ## == - Coverage 26.52% 26.51% -0.02% == Files 46 46 Lines4674 4677 +3 == Hits 1240 1240 - Misses 3262 3265 +3 Partials 172 172 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/206?src=pr=tree) | Coverage Δ | | |---|---|---| | [consumer/option.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/206/diff?src=pr=tree#diff-Y29uc3VtZXIvb3B0aW9uLmdv) | `28.57% <0%> (-1.62%)` | :arrow_down: | | [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/206/diff?src=pr=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `14.94% <0%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/206?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/206?src=pr=footer). Last update [d8d5e46...571efb4](https://codecov.io/gh/apache/rocketmq-client-go/pull/206?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] Me1onRind commented on issue #183: Repeated consumption problem when changing consumeMessageBatchMaxSize
Me1onRind commented on issue #183: Repeated consumption problem when changing consumeMessageBatchMaxSize URL: https://github.com/apache/rocketmq-client-go/issues/183#issuecomment-531538587 I think I find the reason and I create a pull request https://github.com/apache/rocketmq-client-go/pull/206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing commented on issue #205: Open Api tp set consume message max size
ShannonDing commented on issue #205: Open Api tp set consume message max size URL: https://github.com/apache/rocketmq-client-go/pull/205#issuecomment-531545184 duplicate to #206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing merged pull request #206: [ISSUE #183] add set consumeMessageBatchMaxSize and fixed count++ skip one message…
ShannonDing merged pull request #206: [ISSUE #183] add set consumeMessageBatchMaxSize and fixed count++ skip one message… URL: https://github.com/apache/rocketmq-client-go/pull/206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] Me1onRind opened a new pull request #206: add set consumeMessageBatchMaxSize and fixed count++ skip one message…
Me1onRind opened a new pull request #206: add set consumeMessageBatchMaxSize
and fixed count++ skip one message…
URL: https://github.com/apache/rocketmq-client-go/pull/206
… bug
## What is the purpose of the change
In consumer/push_consumer.go func (pc *pushConsumer) consumeMessageCurrently
```go
for count := 0; count < len(msgs); count++ {
var subMsgs []*primitive.MessageExt
if count+pc.option.ConsumeMessageBatchMaxSize > len(msgs) {
subMsgs = msgs[count:]
count = len(msgs)
} else {
next := count + pc.option.ConsumeMessageBatchMaxSize
subMsgs = msgs[count:next]
count = next
}
//other codes
```
In count+pc.option.ConsumeMessageBatchMaxSize is less than len(msgs) branch,
the param count wii be set param next value, but there is count++ in for
statement, then it will skip one message. so I change
```go
count = next
```
to
```go
count = next - 1
```
## Brief changelog
add WithConsumeMessageBatchMaxSize function
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and
easily. Notice, `it would be helpful if you could finish the following 5
checklist(the last one is not necessary)before request the community to review
your PR`.
- [√] Make sure there is a [Github
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually
before you start working on it). Trivial changes like typos do not require a
Github issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue.
- [√] Format the pull request title like `[ISSUE #123] Fix UnknownException
when host config not exist`. Each commit in the pull request should have a
meaningful subject line and body.
- [√] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [√] Write necessary unit-test(over 80% coverage) to verify your logic
correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual
Contributor License Agreement](http://www.apache.org/licenses/#clas).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-exporter] liangyuanpeng opened a new issue #6: optimize code of metricsdto and controller
liangyuanpeng opened a new issue #6: optimize code of metricsdto and controller URL: https://github.com/apache/rocketmq-exporter/issues/6 **Is your feature request related to a problem? Please describe.** just optimize some code for dto and controller **Describe the solution you'd like** **Describe alternatives you've considered** **Additional context** Add any other context or screenshots about the feature request here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-spring] jiangshubian commented on issue #144: 请问如何设置消费者线程数,因为消费太慢
jiangshubian commented on issue #144: 请问如何设置消费者线程数,因为消费太慢 URL: https://github.com/apache/rocketmq-spring/issues/144#issuecomment-531642536 add more consumer thread This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] duhenglucky commented on a change in pull request #1417: [ISSUE #1416] Delete ConsumerGroupName && Clean offsetTable
duhenglucky commented on a change in pull request #1417: [ISSUE #1416] Delete
ConsumerGroupName && Clean offsetTable
URL: https://github.com/apache/rocketmq/pull/1417#discussion_r324515185
##
File path:
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
##
@@ -682,11 +682,24 @@ private RemotingCommand
deleteSubscriptionGroup(ChannelHandlerContext ctx,
log.info("deleteSubscriptionGroup called by {}",
RemotingHelper.parseChannelRemoteAddr(ctx.channel()));
this.brokerController.getSubscriptionGroupManager().deleteSubscriptionGroupConfig(requestHeader.getGroupName());
-
+// only cleanConsumerOffsetList maker
+
this.brokerController.getConsumerOffsetManager().cleanConsumerOffsetList(requestHeader.getGroupName());
response.setCode(ResponseCode.SUCCESS);
response.setRemark(null);
return response;
}
+
+ // private RemotingCommand cleanConsumerOffsetList(ChannelHandlerContext ctx,
Review comment:
@Liberxue could you remove these useless codes?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls commented on issue #1422: [RIP-16]Support request/response pattern
coveralls commented on issue #1422: [RIP-16]Support request/response pattern URL: https://github.com/apache/rocketmq/pull/1422#issuecomment-531618889 [](https://coveralls.io/builds/25651561) Coverage decreased (-0.6%) to 48.954% when pulling **cc0a5e391ea90e37936b7ba63b8c273f8cbcc660 on qqeasonchen:rocketmq-dev-rpc** into **faef36455e273f2a2e2ceedc9497e61b994f999d on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] duhenglucky commented on issue #1454: Please delete old releases from mirroring system
duhenglucky commented on issue #1454: Please delete old releases from mirroring system URL: https://github.com/apache/rocketmq/issues/1454#issuecomment-531623763 @sebbASF ok，we will clean up the historical version of RocketMQ in the near future. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] liuruiyiyang opened a new issue #1457: Updating broker config of namesrvAddr is not effective
liuruiyiyang opened a new issue #1457: Updating broker config of namesrvAddr is not effective URL: https://github.com/apache/rocketmq/issues/1457 **BUG REPORT** 1. Please describe the issue you observed: When use ```mqadmin updateBrokerConfig -c clusterName``` to update namesrvAddr config. The new parameter is not effective. - What did you do (The steps to reproduce)? Use ```mqadmin updateBrokerConfig -c clusterName -n oldNameServerList -k namesrvAddr -v newNameServerList ``` to update namesrvAddr config of a cluster - What did you expect to see? All brokers in the cluster changed their namesrvAddr and also the new namesrvAddr is effective by registering to new name server. namesrv log showing like ```register broker[0]to name server newAddress:9876 OK``` - What did you see instead? The new namesrvAddr is not effective. 2. Please tell us about your environment: MacOS and Linux This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-spring] SwpuEsine opened a new issue #144: 请问如何设置消费者线程数,因为消费太慢
SwpuEsine opened a new issue #144: 请问如何设置消费者线程数,因为消费太慢 URL: https://github.com/apache/rocketmq-spring/issues/144 请问如何设置消费者线程数,因为消费太慢,谢谢回答 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] duhenglucky commented on issue #1417: [ISSUE #1416] Delete ConsumerGroupName && Clean offsetTable
duhenglucky commented on issue #1417: [ISSUE #1416] Delete ConsumerGroupName && Clean offsetTable URL: https://github.com/apache/rocketmq/pull/1417#issuecomment-531647932 @Liberxue It seems that your code style check failed during CI process, so It would be better if you can fix this. and could you add some UI test to verify your code, moreover, it would be nice If you can consider forward compatibility issues, such as providing a configuration item to decide whether to completely remove. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] coveralls edited a comment on issue #1403: [issue #1400]do disk space detection in another thread
coveralls edited a comment on issue #1403: [issue #1400]do disk space detection in another thread URL: https://github.com/apache/rocketmq/pull/1403#issuecomment-523253029 [](https://coveralls.io/builds/25668131) Coverage decreased (-0.9%) to 49.658% when pulling **d4c4baf2336e30cd6237b9606b1d65916d57591a on qqeasonchen:dev_bing** into **90ae1167981ad586e84dd433c08395aeb92a4111 on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] coveralls edited a comment on issue #1422: [RIP-16]Support request/response pattern
coveralls edited a comment on issue #1422: [RIP-16]Support request/response pattern URL: https://github.com/apache/rocketmq/pull/1422#issuecomment-531618889 [](https://coveralls.io/builds/25668130) Coverage decreased (-0.7%) to 48.836% when pulling **53a6955e5b3945b2783fdc58900fca116410f505 on qqeasonchen:rocketmq-dev-rpc** into **faef36455e273f2a2e2ceedc9497e61b994f999d on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] zhanfffmmm commented on issue #1451: set value of ConsumeMessageBatchMaxSize 1024, but value the size is 32, this value is max?
zhanfffmmm commented on issue #1451: set value of ConsumeMessageBatchMaxSize 1024,but value the size is 32, this value is max? URL: https://github.com/apache/rocketmq/issues/1451#issuecomment-531619724 谢谢，@duhenglucky This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] zhanfffmmm closed issue #1451: set value of ConsumeMessageBatchMaxSize 1024, but value the size is 32, this value is max?
zhanfffmmm closed issue #1451: set value of ConsumeMessageBatchMaxSize 1024,but value the size is 32, this value is max? URL: https://github.com/apache/rocketmq/issues/1451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] duhenglucky opened a new issue #1456: Slave abnormal recover slow
duhenglucky opened a new issue #1456: Slave abnormal recover slow URL: https://github.com/apache/rocketmq/issues/1456 **BUG REPORT** 1. Please describe the issue you observed: After the slave server is shut down abnormally, the recovery process will be very slow when restarting. The reason is that the standby does not take the appendMessagesInner method, so there is no chance to update the PhysicMsgTimestamp time in the Checkpoint. - What did you do (The steps to reproduce)? - What did you expect to see? - What did you see instead? 2. Please tell us about your environment: 3. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc): This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] duhenglucky commented on issue #1456: Slave abnormal recover slow
duhenglucky commented on issue #1456: Slave abnormal recover slow URL: https://github.com/apache/rocketmq/issues/1456#issuecomment-531624305 Fixed in [PR](https://github.com/apache/rocketmq/pull/1455) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] duhenglucky opened a new pull request #1455: Fix slave recover slow issue
duhenglucky opened a new pull request #1455: Fix slave recover slow issue URL: https://github.com/apache/rocketmq/pull/1455 ## What is the purpose of the change Fix slave recover slow issue ## Brief changelog In the current design, there is no way to update the Checkpoint PhysicMsgTimestamp in the slave server, so the update logic for PhysicMsgTimestamp is added to the Reput logic. ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [x] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] liuruiyiyang opened a new pull request #1458: Fix issue 1457
liuruiyiyang opened a new pull request #1458: Fix issue 1457 URL: https://github.com/apache/rocketmq/pull/1458 ## What is the purpose of the change Fix issue #1457 ## Brief changelog 1. Update all broker config when using -c param in ```mqadmin updateBrokerConfig``` subcommand 2. Watch ```namesrvAddr``` param and make it effective dynamically for name server auto-scaling with a new switch config ```watchNamesrvAddr```. ## Verifying this change Use ```mqadmin updateBrokerConfig -c clusterName -n oldNameServerList -k namesrvAddr -v newNameServerList``` to see if all brokers in the cluster has log ```register broker[0]to name server newAddress:9876 OK``` Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] coveralls commented on issue #1458: [ISSUE #1457] Dynamically effective namesrvAddr for name server auto-scaling
coveralls commented on issue #1458: [ISSUE #1457] Dynamically effective namesrvAddr for name server auto-scaling URL: https://github.com/apache/rocketmq/pull/1458#issuecomment-531629156 [](https://coveralls.io/builds/25727329) Coverage decreased (-0.03%) to 49.506% when pulling **e3c70c1f148dba11e2294cf7717d7ff21c14ceae on liuruiyiyang:fix_issue_1457** into **faef36455e273f2a2e2ceedc9497e61b994f999d on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing opened a new issue #207: Support log level and log path set.
ShannonDing opened a new issue #207: Support log level and log path set. URL: https://github.com/apache/rocketmq-client-go/issues/207 *FEATURE REQUEST** 1. Please describe the feature you are requesting. now, the log level and log path is the default of logrus 2. Provide any additional detail on your proposed use case for this feature. add log level and log path support. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] coveralls commented on issue #1455: [ISSUE #1456]Fix slave recover slow issue
coveralls commented on issue #1455: [ISSUE #1456]Fix slave recover slow issue URL: https://github.com/apache/rocketmq/pull/1455#issuecomment-531626214 [](https://coveralls.io/builds/25727189) Coverage increased (+0.02%) to 49.559% when pulling **44153fd9c9021adb4567bda87e818838e45fa5dc on duhenglucky:slave_recover_slow** into **faef36455e273f2a2e2ceedc9497e61b994f999d on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq] navyaijm2017 commented on issue #1449: fastjson upgrade
navyaijm2017 commented on issue #1449: fastjson upgrade URL: https://github.com/apache/rocketmq/issues/1449#issuecomment-531625947 > When can this vulnerability patch be fixed? > fastjson 目前是 1.2.51 ，存在安全漏洞， 希望升级到1.2.60 。 亲，你已经提交补丁了，给力哈，4.6.0预计啥时候发布呢 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing closed pull request #205: Open Api tp set consume message max size
ShannonDing closed pull request #205: Open Api tp set consume message max size URL: https://github.com/apache/rocketmq-client-go/pull/205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Failed: duhenglucky/rocketmq#20 (slave_recover_slow - 44153fd)
Build Update for duhenglucky/rocketmq - Build: #20 Status: Failed Duration: 14 mins and 35 secs Commit: 44153fd (slave_recover_slow) Author: duhenglucky Message: Fix the slave abnormal recover slow issue View the changeset: https://github.com/duhenglucky/rocketmq/compare/ddb07ab13c70^...44153fd9c902 View the full build log and details: https://travis-ci.org/duhenglucky/rocketmq/builds/585376901?utm_medium=notification_source=email -- You can unsubscribe from build emails from the duhenglucky/rocketmq repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=22557420_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
[GitHub] [rocketmq-externals] lexingrensheng opened a new issue #418: rocketmq-connect-kafka
lexingrensheng opened a new issue #418: rocketmq-connect-kafka URL: https://github.com/apache/rocketmq-externals/issues/418 Connector should not rely on the runtime-related jar, the dependency should rely on oms, and if it depends on runtime, it will cause marven dependency conflict This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
