[GitHub] incubator-rocketmq issue #47: [ROCKETMQ-69]Add link to README.md for RocketM...

2017-01-20 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/47
  

[![Coverage 
Status](https://coveralls.io/builds/9778682/badge)](https://coveralls.io/builds/9778682)

Coverage increased (+0.008%) to 22.64% when pulling 
**532edaa7a38caa1d6e5b266931e032935af88ef1 on 
netroby:pr/add-link-to-rocketmq-home** into 
**b997c9743e155df8d330bad54479ac320e722a36 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #47: [ROCKETMQ-69]Add link to README.md for RocketM...

2017-01-20 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/47
  

[![Coverage 
Status](https://coveralls.io/builds/9778682/badge)](https://coveralls.io/builds/9778682)

Coverage increased (+0.008%) to 22.64% when pulling 
**532edaa7a38caa1d6e5b266931e032935af88ef1 on 
netroby:pr/add-link-to-rocketmq-home** into 
**b997c9743e155df8d330bad54479ac320e722a36 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #34: [ROCKETMQ-39] avoid duplicated codes.

2017-01-20 Thread WillemJiang 
Github user WillemJiang commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/34#discussion_r97189548
  
--- Diff: 
filtersrv/src/main/java/org/apache/rocketmq/filtersrv/FiltersrvStartup.java ---
@@ -139,7 +139,7 @@ public static FiltersrvController 
createController(String[] args) {
 
 Runtime.getRuntime().addShutdownHook(new 
ShutdownHookThread(log, new Callable() {
 @Override
-public Object call() throws Exception {
+public Void call() throws Exception {
 controller.shutdown();
 return null;
--- End diff --

When use the Void as the return signature, you don't need to use return in 
the function.  
Please remove the line of 144.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #47: [ROCKETMQ-69]Add link to README.md for RocketM...

2017-01-20 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/47
  

[![Coverage 
Status](https://coveralls.io/builds/9778675/badge)](https://coveralls.io/builds/9778675)

Coverage decreased (-0.02%) to 22.615% when pulling 
**fdad1d30aa6aa9157b594344ea7d94dea2a9494b on 
netroby:pr/add-link-to-rocketmq-home** into 
**b997c9743e155df8d330bad54479ac320e722a36 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #47: [ROCKETMQ-69]Add link to README.md for RocketM...

2017-01-20 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/47
  

[![Coverage 
Status](https://coveralls.io/builds/9778675/badge)](https://coveralls.io/builds/9778675)

Coverage decreased (-0.02%) to 22.615% when pulling 
**fdad1d30aa6aa9157b594344ea7d94dea2a9494b on 
netroby:pr/add-link-to-rocketmq-home** into 
**b997c9743e155df8d330bad54479ac320e722a36 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #47: [ROCKETMQ-69]Add link to README.md for RocketM...

2017-01-20 Thread netroby 
Github user netroby commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/47
  
I will change code , thanks.

Appreciate your time.

Netroby

2017-01-21 11:24 GMT+08:00 Willem Jiang :

> *@WillemJiang* commented on this pull request.
> --
>
> In README.md
> 

> :
>
> > @@ -22,6 +22,7 @@ It offers a variety of features as follows:
>  --
>
>  ## Learn it & Contact us
> +* Home: [https://rocketmq.apache.org](https://rocketmq.apache.org)
>
> It could be better to use <> instead of , as we don't need to change the
> display discription here.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #47: [ROCKETMQ-69]Add link to README.md for ...

2017-01-20 Thread WillemJiang 
Github user WillemJiang commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/47#discussion_r97189480
  
--- Diff: README.md ---
@@ -22,6 +22,7 @@ It offers a variety of features as follows:
 --
 
 ## Learn it & Contact us
+* Home: [https://rocketmq.apache.org](https://rocketmq.apache.org)
--- End diff --

It could be better to use <> instead of []() , as we don't need to change 
the display discription here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[ROCKETMQ-69]Add link to README.md for RocketMQ home

2017-01-20 Thread Netroby 
Dear dev team:

I create a new PR about to add link to README.md for RocketMQ home web page

Issue: https://issues.apache.org/jira/browse/ROCKETMQ-69
PR: https://github.com/apache/incubator-rocketmq/pull/47

By add link to RocketMQ home at https://rocketmq.apache.org
Will help user easy to find useful information.


Appreciate your time.

Netroby

[GitHub] incubator-rocketmq issue #35: [ROCKETMQ-42] Output is not friendly, when Mai...

2017-01-20 Thread wu-sheng 
Github user wu-sheng commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/35
  
I have already explain it before. Generally speaking, `log` is not 
initialized.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #35: [ROCKETMQ-42] Output is not friendly, when Mai...

2017-01-20 Thread wu-sheng 
Github user wu-sheng commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/35
  
@vongosling, your idea?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #35: [ROCKETMQ-42] Output is not friendly, when Mai...

2017-01-20 Thread wu-sheng 
Github user wu-sheng commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/35
  
I have known about @shroman 's issue. And I am sure he is right about that 
log is better than `e.printStackTrace()` or `system.out`. And here, there is a 
special scene.

Let's focus on `FiltersrvStartup.java`'s change logs. This `system.out` is 
unavoidable.
* `try-catch` block starts at line 74
*  Field `log` is initialized at line 128

If codes occur exception between these two lines, certainly be `catch`ed, 
and trigger `NullPointException` in catch.

Other changes like this one, this is why I only change these classes, as so 
many `System.out`s are used in project.

You see, this is also why we need discuss before merge or close. 😊


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---