[GitHub] incubator-rocketmq pull request #89: [ROCKETMQ-166] onException callback may...

[shroman]

Github user shroman commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/89#discussion_r115650526
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -306,6 +310,19 @@ public SendResult sendMessage(//
 final SendMessageContext context, // 11
 final DefaultMQProducerImpl producer // 12
 ) throws RemotingException, MQBrokerException, InterruptedException {
+
+byte[] msgBody = msg.getBody();
+Integer sysFlag = requestHeader.getSysFlag();
+if (null != sysFlag && ((sysFlag & MessageSysFlag.COMPRESSED_FLAG) 
== MessageSysFlag.COMPRESSED_FLAG)) {
+try {
+msgBody = UtilAll.compress(msgBody, zipCompressLevel);
+} catch (IOException e) {
+
requestHeader.setSysFlag(MessageSysFlag.clearCompressedFlag(sysFlag));
+log.error("tryToCompressMessage exception", e);
--- End diff --

I just wonder why both WARN and ERROR are needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #89: [ROCKETMQ-166] onException callback may...

[lizhanhui]

Github user lizhanhui commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/89#discussion_r115650129
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -306,6 +310,19 @@ public SendResult sendMessage(//
 final SendMessageContext context, // 11
 final DefaultMQProducerImpl producer // 12
 ) throws RemotingException, MQBrokerException, InterruptedException {
+
+byte[] msgBody = msg.getBody();
+Integer sysFlag = requestHeader.getSysFlag();
+if (null != sysFlag && ((sysFlag & MessageSysFlag.COMPRESSED_FLAG) 
== MessageSysFlag.COMPRESSED_FLAG)) {
+try {
+msgBody = UtilAll.compress(msgBody, zipCompressLevel);
+} catch (IOException e) {
+
requestHeader.setSysFlag(MessageSysFlag.clearCompressedFlag(sysFlag));
+log.error("tryToCompressMessage exception", e);
--- End diff --

You mean why we log error on failing to compress message body?  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #101: [ROCKETMQ-194] log appender support

[lizhanhui]

Github user lizhanhui commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/101
  
Hi, @lindzh could you further justify this PR? Aka, explain why it's 
reasonable to create a custom appender? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #102: Release 4.0.0 incubating db bugfix

[lizhanhui]

Github user lizhanhui commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/102
  
This issue has been fixed in the develop branch, could you please 
double-check?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #91: [ROCKETMQ-174]Fix spelling errors

[lizhanhui]

Github user lizhanhui commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/91
  
> please resolve the conflicts firstly, we have to be cautious about this 
PR.

Agree, this PR introduces too many trivial changes and I'd like abandon 
this PR and create several small changes, applying  divide-and-conquer strategy


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors

[lizhanhui]

Github user lizhanhui commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115647528
  
--- Diff: 
common/src/main/java/org/apache/rocketmq/common/protocol/route/TopicRouteData.java
 ---
@@ -27,23 +27,23 @@
 
 public class TopicRouteData extends RemotingSerializable {
 private String orderTopicConf;
-private List queueDatas;
-private List brokerDatas;
+private List queueDataList;
+private List brokerDataList;
--- End diff --

Right. looks we have to keep it intact.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors

[lizhanhui]

Github user lizhanhui commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115645553
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -907,10 +907,10 @@ public void queryMessage(
 final QueryMessageRequestHeader requestHeader,
 final long timeoutMillis,
 final InvokeCallback invokeCallback,
-final Boolean isUnqiueKey
+final Boolean isUnqueKey
--- End diff --

Thanks for point it out, unique key.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #93: [ROCKETMQ-178] Fix -p -m options

[lizhanhui]

Github user lizhanhui commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/93
  
> Any trouble is still ?

No. It's a trivial change and should have been merged/closed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #96: [ROCKETMQ-187]Measure the code coverage for In...

[lizhanhui]

Github user lizhanhui commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/96
  
It's good and looks it's already been merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #100: [ROCKETMQ-191] Fix socket options

[lizhanhui]

Github user lizhanhui closed the pull request at:

https://github.com/apache/incubator-rocketmq/pull/100


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #97: [ROCKETMQ-189] Misleading tip on consumeTimest...

[vongosling]

Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/97
  
IMO,if we could polish here. we 'd better tell what's wrong with your input 
and what's a valid input ,right ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #80: [ROCKETMQ-114] Add javadoc to codebase

[vongosling]

Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/80
  
What's wrong with this PR. if no other polish, suggest close it:-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #93: [ROCKETMQ-178] Fix -p -m options

[vongosling]

Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/93
  
Any trouble is still ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #102: Release 4.0.0 incubating db bugfix

[aftersss]

GitHub user aftersss opened a pull request:

https://github.com/apache/incubator-rocketmq/pull/102

Release 4.0.0 incubating db bugfix

bugfix, as the code shows.

stackTrace:
`2017-05-09 18:38:55 ERROR SendMessageThread_4 - do sync transfer other 
node, wait return, but failed, topic: BenchmarkTest tags: null client address: 
10.24.19.87
2017-05-09 18:38:55 WARN SendMessageThread_4 - putMessage not in lock 
eclipse time(ms)=1000, bodyLength=130
2017-05-09 18:38:55 WARN GroupTransferService - GroupTransferService 
service has exception.
java.lang.NullPointerException: null
at 
org.apache.rocketmq.store.ha.HAService$GroupTransferService.doWaitTransfer(HAService.java:278)
 ~[rocketmq-store-4.1.0-incubating-SNAPSHOT.jar:4.1.0-incubating-SNAPSHOT]
at 
org.apache.rocketmq.store.ha.HAService$GroupTransferService.run(HAService.java:301)
 ~[rocketmq-store-4.1.0-incubating-SNAPSHOT.jar:4.1.0-incubating-SNAPSHOT]
at java.lang.Thread.run(Thread.java:745) [na:1.8.0_121]`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aftersss/incubator-rocketmq 
release-4.0.0-incubating-db-bugfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rocketmq/pull/102.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #102






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

[dongeforever]

Github user dongeforever commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/87
  
@shroman In runbroker.sh and runserver.sh, some default options, such as 
-Xmx8g, are placed after the JVM_OPTS, so user-defined -Xmx will not take 
effect.

And if we put JAVA_OPT_EXT after all default options, it will replace the 
default ones.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #96: [ROCKETMQ-187]Measure the code coverage for In...

[dongeforever]

Github user dongeforever commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/96
  
The PR is better not to be merged by the original author.
@lizhanhui @zhouxinyu @shroman please help merge this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors

[vsair]

Github user vsair commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115478367
  
--- Diff: 
common/src/main/java/org/apache/rocketmq/common/protocol/header/QueryMessageResponseHeader.java
 ---
@@ -28,7 +28,7 @@
 @CFNotNull
 private Long indexLastUpdateTimestamp;
 @CFNotNull
-private Long indexLastUpdatePhyoffset;
+private Long indexLastUpdatePhyOffset;
--- End diff --

Protocol modification.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #91: [ROCKETMQ-174]Fix spelling errors

[vsair]

Github user vsair commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115478015
  
--- Diff: 
common/src/main/java/org/apache/rocketmq/common/protocol/route/TopicRouteData.java
 ---
@@ -27,23 +27,23 @@
 
 public class TopicRouteData extends RemotingSerializable {
 private String orderTopicConf;
-private List queueDatas;
-private List brokerDatas;
+private List queueDataList;
+private List brokerDataList;
--- End diff --

It is modification of protocol, IMO, it's improper for upgrade of server or 
client.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #91: [ROCKETMQ-174]Fix spelling errors

[vongosling]

Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/91
  
Agreed. Any other opinion for this PR? @lizhanhui please resolve the 
conflicts, we could merge this PR later~ 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #101: [ROCKETMQ-194] log appender support

[vongosling]

Github user vongosling commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115471708
  
--- Diff: logappender/README.md ---
@@ -0,0 +1,64 @@
+# RocketMQ-LogAppender   [![Build 
Status](https://travis-ci.org/rocketmq/rocketmq-logappender.svg?branch=master)](https://travis-ci.org/rocketmq/rocketmq-logappender)
 [![Coverage 
Status](https://coveralls.io/repos/github/rocketmq/rocketmq-logappender/badge.svg?branch=master)](https://coveralls.io/github/rocketmq/rocketmq-logappender?branch=master)
+
+
+## Introduction
+RocketMQ-LogAppender is a logging component implement of log4j,log4j2 and 
logback.Taking Apache RocketMQ as broker.
+All logs loged will be send to the topic you define.
+
+## Examples
+
+ log4j example
+
+> config detail
+
+```xml
+
+
+
+
+
+
+
+
+
+
+
+
+
+
--- End diff --

why not use single label as above?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #101: [ROCKETMQ-194] log appender support

[vongosling]

Github user vongosling commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115470775
  
--- Diff: logappender/README.md ---
@@ -0,0 +1,64 @@
+# RocketMQ-LogAppender   [![Build 
Status](https://travis-ci.org/rocketmq/rocketmq-logappender.svg?branch=master)](https://travis-ci.org/rocketmq/rocketmq-logappender)
 [![Coverage 
Status](https://coveralls.io/repos/github/rocketmq/rocketmq-logappender/badge.svg?branch=master)](https://coveralls.io/github/rocketmq/rocketmq-logappender?branch=master)
--- End diff --

Could we remove it if  we want it into parent modue, we can reuse rocektmq 
existing infra.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #101: [ROCKETMQ-194] log appender support

[vongosling]

Github user vongosling commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115472199
  
--- Diff: logappender/pom.xml ---
@@ -0,0 +1,122 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+org.apache.rocketmq
+rocketmq-all
+4.1.0-incubating-SNAPSHOT
+
+4.0.0
+rocketmq-logappender
+   jar
+rocketmq-logappender ${project.version}
+
+
+UTF-8
+false
+true
+1.7
+1.7
+
+
+
+
+
+org.slf4j
+slf4j-api
+1.7.7
+true
+
+
+
+log4j
+log4j
+1.2.17
+true
+
+
+
+org.apache.logging.log4j
+log4j-core
+2.7
+true
+
+
+
+
+ch.qos.logback
+logback-core
+1.1.2
--- End diff --

The latest version ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #101: [ROCKETMQ-194] log appender support

[vongosling]

Github user vongosling commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115472312
  
--- Diff: logappender/pom.xml ---
@@ -0,0 +1,122 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+org.apache.rocketmq
+rocketmq-all
+4.1.0-incubating-SNAPSHOT
+
+4.0.0
+rocketmq-logappender
+   jar
+rocketmq-logappender ${project.version}
+
+
+UTF-8
+false
+true
+1.7
+1.7
+
+
+
+
+
+org.slf4j
+slf4j-api
+1.7.7
+true
--- End diff --

We must consider the suitable dependency here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #101: [ROCKETMQ-194] log appender support

[vongosling]

Github user vongosling commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115473097
  
--- Diff: style/rmq_checkstyle.xml ---
@@ -30,6 +30,12 @@
 
 
 
+
+
+
+
--- End diff --

Why change this rule~


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #101: [ROCKETMQ-194] log appender support

[vongosling]

Github user vongosling commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115472704
  
--- Diff: 
logappender/src/main/java/org/apache/rocketmq/logappender/log4j/RocketmqLog4jAppender.java
 ---
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.logappender.log4j;
+
+import org.apache.rocketmq.common.message.Message;
+import org.apache.rocketmq.logappender.common.ProducerInstance;
+import org.apache.log4j.AppenderSkeleton;
+import org.apache.log4j.helpers.LogLog;
+import org.apache.log4j.spi.ErrorCode;
+import org.apache.log4j.spi.LoggingEvent;
+import org.apache.rocketmq.client.producer.MQProducer;
+
+/**
+ * Log4j Appender Component
+ */
+public class RocketmqLog4jAppender extends AppenderSkeleton {
+
+/**
+ * appended message tag define
--- End diff --

Capitalize the first letter~


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #101: [ROCKETMQ-194] log appender support

[vongosling]

Github user vongosling commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115471296
  
--- Diff: logappender/README.md ---
@@ -0,0 +1,64 @@
+# RocketMQ-LogAppender   [![Build 
Status](https://travis-ci.org/rocketmq/rocketmq-logappender.svg?branch=master)](https://travis-ci.org/rocketmq/rocketmq-logappender)
 [![Coverage 
Status](https://coveralls.io/repos/github/rocketmq/rocketmq-logappender/badge.svg?branch=master)](https://coveralls.io/github/rocketmq/rocketmq-logappender?branch=master)
+
+
+## Introduction
+RocketMQ-LogAppender is a logging component implement of log4j,log4j2 and 
logback.Taking Apache RocketMQ as broker.
--- End diff --

What is "implement of " It's confused. IMO, this project is used to send 
log message using RocektMQ. while log4j, log4j2 and logback is just a  adapter 
for SL4J


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq-site pull request #12: Add missing maven goal 'package' i...

[lizhanhui]

GitHub user lizhanhui opened a pull request:

https://github.com/apache/incubator-rocketmq-site/pull/12

Add missing maven goal 'package' in get-started document

As per title.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lizhanhui/incubator-rocketmq-site master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rocketmq-site/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12


commit 6c0c477a112eaa2c887da3d08cf57c8638724e6b
Author: Li Zhanhui 
Date:   2017-05-09T11:29:24Z

Add missing maven goal 'package' in get-started document




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #101: [ROCKETMQ-194] log appender support

[lindzh]

GitHub user lindzh opened a pull request:

https://github.com/apache/incubator-rocketmq/pull/101

[ROCKETMQ-194] log appender support

As Rocketmq is widely used,A log appender is also necessary.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lindzh/incubator-rocketmq log_appender

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rocketmq/pull/101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #101






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq-externals issue #21: add log appender support

[lindzh]

Github user lindzh commented on the issue:

https://github.com/apache/incubator-rocketmq-externals/pull/21
  
moved to rocketmq


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq-externals pull request #21: add log appender support

[lindzh]

Github user lindzh closed the pull request at:

https://github.com/apache/incubator-rocketmq-externals/pull/21


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---