[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/27 This Pull Request has been merged and it's safe to close this PR. @vincentWangKB --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq-externals issue #27: [ROCKETMQ-268]add rocketmq-cpp code
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq-externals/pull/27 This patch looks good enough to be merged. Thanks @vincentWangKB --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #154: [Rocketmq-285] file test error when make link
Github user zwillim commented on the issue: https://github.com/apache/incubator-rocketmq/pull/154 title modified --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #154: file test error when make link
Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/154 The title should be "[Rocketmq-285] file test error when make link" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #154: file test error when make link
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/154 [](https://coveralls.io/builds/13109931) Coverage decreased (-0.06%) to 38.712% when pulling **00d0fb673de8d8f5debe74a24179d6aa212d4ee4 on zwillim:patch-1** into **2ddb744b3157604ec87a82143c3100728589c6ec on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq pull request #154: file test error when make link
GitHub user zwillim reopened a pull request:
https://github.com/apache/incubator-rocketmq/pull/154
file test error when make link
line 62.
cannot test ${HOME}/tmpfs while making link to ./tmpfs
change "ln -s /dev/shm tmpfs" to "ln -s /dev/shm ${HOME}/tmpfs"
https://issues.apache.org/jira/browse/ROCKETMQ-285
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwillim/incubator-rocketmq patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #154
commit 00d0fb673de8d8f5debe74a24179d6aa212d4ee4
Author: willim.z
Date: 2017-08-25T02:35:57Z
logistic error
line 62.
cannot test ${HOME}/tmpfs while making link to ./tmpfs
change "ln -s /dev/shm tmpfs" to "ln -s /dev/shm ${HOME}/tmpfs"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #154: file test error when make link
Github user zwillim commented on the issue: https://github.com/apache/incubator-rocketmq/pull/154 modified as required. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq pull request #154: file test error when make link
Github user zwillim closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/154 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
