[GitHub] incubator-rocketmq pull request #104: [ROCKETMQ-201]Remove spaces before and...
Github user huangyiminghappy closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #121: Remove the code that is not useful in the loo...
Github user huangyiminghappy commented on the issue: https://github.com/apache/incubator-rocketmq/pull/121 https://issues.apache.org/jira/browse/ROCKETMQ-226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq pull request #121: Remove the code that is not useful in ...
GitHub user huangyiminghappy opened a pull request: https://github.com/apache/incubator-rocketmq/pull/121 Remove the code that is not useful in the loop[ROCKETMQ-226] Remove the code that is not useful in the loop You can merge this pull request into a Git repository by running: $ git pull https://github.com/huangyiminghappy/incubator-rocketmq Branch_0616 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/121.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #121 commit 0011c2fc9fd7092301e9ab87bb4b654bf7e90ae6 Author: huangyiming <huangyimingha...@163.com> Date: 2017-05-17T06:20:16Z Remove spaces before and after the properties commit 4492a1deb3be6e818dd18d48cdca49170dd67bd1 Author: huangyiming <huangyimingha...@163.com> Date: 2017-05-17T06:26:18Z Update MixAll.java Remove spaces before and after the properties commit 5d49dd476afae25c998376086ce17e7ef87f1c63 Author: huangyiming <huangyimingha...@163.com> Date: 2017-05-17T07:39:59Z Remove spaces before and after the properties commit a2894b66f2d9c7dcd0546b0146595b525ca4918c Author: huangyiming <huangyimingha...@163.com> Date: 2017-05-17T07:42:18Z Remove spaces before and after the properties commit 7ffc22e4514111953256a2eab68d8b6896511e69 Author: huangyiming <huangyimingha...@163.com> Date: 2017-05-17T08:11:07Z remove spaces before and after the properties commit 92f83bc14bd1da9c21228c3e3671bc8a67f5b288 Author: huangyiming <huangyimingha...@163.com> Date: 2017-05-17T08:18:16Z remove spaces before and after the properties commit d142037b053d568ac6ec45c3316abb41a760fde8 Author: huangyiming <huangyimingha...@163.com> Date: 2017-05-17T08:24:44Z remove spaces before and after the properties commit 86ee77b85a1568fb239c3437ff42dac374c19aee Author: huangyiming <huangyimingha...@163.com> Date: 2017-05-17T08:51:40Z remove spaces before and after the properties commit 42c2c65924557ebaa6f30e9f449694125fa6bcea Author: huangyiming <huangyimingha...@163.com> Date: 2017-05-18T02:54:21Z remove spaces before and after the properties commit 4ef07e4249daa9e9122a45bf195fb7f0e87246e1 Author: huangyiming <huangyimingha...@163.com> Date: 2017-05-18T10:15:32Z Remove spaces before and after the properties commit 818b159683b17224447749faa140b9ce12388730 Author: huangyiming <huangyimingha...@163.com> Date: 2017-06-16T06:45:52Z Remove spaces before and after the properties commit d485513ed51ca4b7206fbf962ab4801e90eeefae Author: huangyiming <huangyimingha...@163.com> Date: 2017-06-16T08:39:37Z Remove the code that is not useful in the loop --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq pull request #104: Remove spaces before and after the pro...
Github user huangyiminghappy commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/104#discussion_r120526362
--- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java ---
@@ -279,7 +279,7 @@ public static String properties2String(final Properties
properties) {
StringBuilder sb = new StringBuilder();
for (Map.Entry<Object, Object> entry : properties.entrySet()) {
if (entry.getValue() != null) {
-sb.append(entry.getKey().toString() + "=" +
entry.getValue().toString() + "\n");
+sb.append(entry.getKey().toString().trim() + "=" +
entry.getValue().toString().trim() + "\n");
--- End diff --
okï¼I try it, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #104: Remove spaces before and after the pro...
Github user huangyiminghappy commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/104#discussion_r117210642
--- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java ---
@@ -339,6 +339,8 @@ public static void properties2Object(final Properties
p, final Object object) {
String key = first.toLowerCase() + tmp;
String property = p.getProperty(key);
if (property != null) {
+// remove spaces before and after
--- End diff --
yes ,you are right,wo can add trim like this:
Add directly in properties2String is not accurate,because attribute and
value also may before or after blank,i commit and pull request ,please review
it ,thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #104: Remove spaces before and after the pro...
Github user huangyiminghappy commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/104#discussion_r117149430
--- Diff: common/src/main/java/org/apache/rocketmq/common/MixAll.java ---
@@ -339,6 +339,8 @@ public static void properties2Object(final Properties
p, final Object object) {
String key = first.toLowerCase() + tmp;
String property = p.getProperty(key);
if (property != null) {
+// remove spaces before and after
--- End diff --
ok,i remove the comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
