[GitHub] incubator-rocketmq-externals issue #29: update redis-replicator to 2.3.3 , f...

[vongosling]

Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq-externals/pull/29
  
Follow this checklist to help us incorporate your contribution quickly and 
easily:

- [ ]  Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/ROCKETMQ/issues/) filed for the 
change (usually before you start working on it). Trivial changes like typos do 
not require a JIRA issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue. 
- [ ] Format the pull request title like `[ROCKETMQ-XXX] Fix 
UnknownException when host config not exist`. Each commit in the pull request 
should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock 
a little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add integration-test in 
[test module](https://github.com/apache/incubator-rocketmq/tree/master/test).
- [ ]  Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
- [ ]  If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).



---

[GitHub] incubator-rocketmq-externals issue #29: update redis-replicator to 2.3.3 , f...

[leonchen83]

Github user leonchen83 commented on the issue:

https://github.com/apache/incubator-rocketmq-externals/pull/29
  
I can finish full test case this weekend. 
For now I only test replicate from redis . but not test data stream to 
RocketMQ.


---

[GitHub] incubator-rocketmq-externals issue #29: update redis-replicator to 2.3.3 , f...

[vongosling]

Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq-externals/pull/29
  
@leonchen83 Thanks for your contribution. BTW, have you test it in your 
local environment ?


---

[GitHub] incubator-rocketmq-externals issue #29: update redis-replicator to 2.3.3 , f...

[leonchen83]

Github user leonchen83 commented on the issue:

https://github.com/apache/incubator-rocketmq-externals/pull/29
  
@Zhang-Ke 
@vongosling 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---