[GitHub] incubator-rocketmq issue #1: Closing the channel. Fix for ROCKETMQ-2.

2016-12-22 Thread shroman
Github user shroman commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/1
  
@vongosling The unit test is included in the PR. I don't quite understand 
what else is needed...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-rocketmq issue #1: Closing the channel. Fix for ROCKETMQ-2.

2016-12-22 Thread vongosling
Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/1
  
@shroman 
Thanks for your PR, Could you paste some unit test for these question :-) . 
please see our contributing checklist, 
https://github.com/apache/incubator-rocketmq/blob/master/CONTRIBUTING.md


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---