[GitHub] incubator-rocketmq issue #147: [ROCKETMQ-266] Add a specific Exception messa...
Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 LGTM @zhouxinyu @vongosling any view? ---
[GitHub] incubator-rocketmq issue #147: [ROCKETMQ-266] Add a specific Exception messa...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 [](https://coveralls.io/builds/13183888) Coverage increased (+0.03%) to 38.743% when pulling **7d2f899e15d7ed4127657a49034bdae892e4174b on mark800:master** into **845830865fc37d0364a19cbd89ceaf8a30b37e1c on apache:develop**. ---
[GitHub] incubator-rocketmq issue #147: [ROCKETMQ-266] Add a specific Exception messa...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 [](https://coveralls.io/builds/12919598) Coverage increased (+0.05%) to 39.119% when pulling **1590ed252af50283ff402edd448076fffa95eb5b on mark800:master** into **332df78e2bb6caadfc6f471445ebb1f9d224 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #147: [ROCKETMQ-266] Add a specific Exception messa...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 [](https://coveralls.io/builds/12919598) Coverage increased (+0.05%) to 39.119% when pulling **1590ed252af50283ff402edd448076fffa95eb5b on mark800:master** into **332df78e2bb6caadfc6f471445ebb1f9d224 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #147: [ROCKETMQ-266] Add a specific Exception messa...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 [](https://coveralls.io/builds/12888375) Coverage increased (+0.007%) to 39.078% when pulling **5f5ee6d2089a146f8a3437ae939c28985b38aaaf on mark800:master** into **332df78e2bb6caadfc6f471445ebb1f9d224 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #147: [ROCKETMQ-266] Add a specific Exception messa...
Github user mark800 commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 The travis-ci's error log is : $ mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V Error: JAVA_HOME is not defined correctly. We cannot execute /usr/lib/jvm/java-7-oracle/bin/java The command "eval mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V " failed. It seems it is not the code's problem --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #147: [ROCKETMQ-266] Add a specific Exception messa...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 [](https://coveralls.io/builds/12879904) Coverage increased (+0.07%) to 39.137% when pulling **074e457a1c158b758079d5ca4197dcfa0fc9430b on mark800:master** into **332df78e2bb6caadfc6f471445ebb1f9d224 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #147: [ROCKETMQ-266] Add a specific Exception messa...
Github user mark800 commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 @Jaskey Thanks for your advice, I've updated the code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #147: [ROCKETMQ-266] Add a specific Exception messa...
Github user mark800 commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 @lindzh My opinion isï¼consumeThreadMax and consumeThreadMin are two separate configuration, if we only configure one parameter, it should work, or at least give a reasonable exception message. If the two configurations have to be used at the same time, we should combine them to one configure option. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #147: [ROCKETMQ-266] Add a specific Exception messa...
Github user lindzh commented on the issue: https://github.com/apache/incubator-rocketmq/pull/147 While consumeThreadMin is specified by a range,why not add consumeThreadMax to a range too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
