[GitHub] incubator-rocketmq issue #82: [ROCKETMQ-121]Support message filtering based ...
Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/82 @vsair Thanks for your clarification. I am just trying to go through the main logic of sql filter. For the point of #2, where is that code logic ? I search for usage of `getExpectConsumerNumUseFilter` but I find that it's only used to create a new bloom filter instance when starting , then how do broker detect that the configuration is changed? Are we saying the same thing. What I am concerned is that, if we change any configuration about the bloom filter, will broker works as usual to filter the expected messages as it did before. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #82: [ROCKETMQ-121]Support message filtering based ...
Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/82 @vsair I have two things to confirms, 1. if the old messages which exists before consumer subscribe with the filter expression must be filtered by decodng properties to do calculation ? 2. `expectConsumerNumUseFilter = 32` and `maxErrorRateOfBloomFilter = 20` can be configured and changed, what if I change this value and restart, does the calculated results in the ConsumeQueueExt updated accordingly? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #82: [ROCKETMQ-121]Support message filtering based ...
Github user vsair commented on the issue: https://github.com/apache/incubator-rocketmq/pull/82 @zhouxinyu Conflicts have been resolved. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #82: [ROCKETMQ-121]Support message filtering based ...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/82 [](https://coveralls.io/builds/11175865) Coverage increased (+3.3%) to 37.892% when pulling **09dca7851d7a85e4e609a5f34d6abd91dc092b91 on vsair:ROCKETMQ-121** into **42f78c281cbeb5072b04eaf03b1a8059b8d281a7 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #82: [ROCKETMQ-121]Support message filtering based ...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/82 [](https://coveralls.io/builds/11175865) Coverage increased (+3.3%) to 37.892% when pulling **09dca7851d7a85e4e609a5f34d6abd91dc092b91 on vsair:ROCKETMQ-121** into **42f78c281cbeb5072b04eaf03b1a8059b8d281a7 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #82: [ROCKETMQ-121]Support message filtering based ...
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/82 please @lizhanhui @shroman help to review this great PR :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #82: [ROCKETMQ-121]Support message filtering based ...
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/82 I think only servtoolâs module dependency, so there is no transitive dependency pollution on sdk, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #82: [ROCKETMQ-121]Support message filtering based ...
Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/82 Will look into this PR today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #82: [ROCKETMQ-121]Support message filtering based ...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/82 [](https://coveralls.io/builds/11031179) Coverage increased (+3.4%) to 35.262% when pulling **24f6ada53a4b3f0612461a0c69dc49b2508104b0 on vsair:ROCKETMQ-121** into **45a64fd6a8ab66a8b0eb30cbe2dffd59b19274f9 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #82: [ROCKETMQ-121]Support message filtering based ...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/82 [](https://coveralls.io/builds/11028471) Coverage increased (+3.7%) to 35.602% when pulling **069256828c512370c2b2aeb48d64481d5c6d1215 on vsair:ROCKETMQ-121** into **45a64fd6a8ab66a8b0eb30cbe2dffd59b19274f9 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #82: [ROCKETMQ-121]Support message filtering based ...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/82 [](https://coveralls.io/builds/11028471) Coverage increased (+3.7%) to 35.602% when pulling **069256828c512370c2b2aeb48d64481d5c6d1215 on vsair:ROCKETMQ-121** into **45a64fd6a8ab66a8b0eb30cbe2dffd59b19274f9 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #82: [ROCKETMQ-121]Support message filtering based ...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/82 [](https://coveralls.io/builds/11028471) Coverage increased (+3.7%) to 35.602% when pulling **069256828c512370c2b2aeb48d64481d5c6d1215 on vsair:ROCKETMQ-121** into **45a64fd6a8ab66a8b0eb30cbe2dffd59b19274f9 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #82: [ROCKETMQ-121]Support message filtering based ...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/82 [](https://coveralls.io/builds/10844981) Coverage increased (+3.7%) to 35.609% when pulling **67fe978f1a35c8c8ebdd1e70beb4944a4043c77a on vsair:ROCKETMQ-121** into **45a64fd6a8ab66a8b0eb30cbe2dffd59b19274f9 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #82: [ROCKETMQ-121]Support message filtering based ...
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/82 @shroman @lizhanhui How do you think about this feature~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #82: [Rocketmq 121]Support message filtering based ...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/82 [](https://coveralls.io/builds/10730651) Coverage increased (+3.8%) to 35.617% when pulling **a9cea30982d30ce7cc5b1842eb86e87fecc6e682 on vsair:ROCKETMQ-121** into **72e6def1441083c6c5a8c4b831eebefcbb618b56 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #82: [Rocketmq 121]Support message filtering based ...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/82 [](https://coveralls.io/builds/10730651) Coverage increased (+3.8%) to 35.617% when pulling **a9cea30982d30ce7cc5b1842eb86e87fecc6e682 on vsair:ROCKETMQ-121** into **72e6def1441083c6c5a8c4b831eebefcbb618b56 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-rocketmq issue #82: [Rocketmq 121]Support message filtering based ...
Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/82 [](https://coveralls.io/builds/10730651) Coverage increased (+3.8%) to 35.617% when pulling **a9cea30982d30ce7cc5b1842eb86e87fecc6e682 on vsair:ROCKETMQ-121** into **72e6def1441083c6c5a8c4b831eebefcbb618b56 on apache:develop**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
