Re: Merge the compiler-pr for distribution alignment?

[Greg Dove]

Hi Chris, I haven't followed the discussion until now, that seems pretty
clear to me. The compiler part merge sounds fine to me the way you describe
it - it sounds like it is something that is inevitable at some point, but
'harmless' at any point, right?
I'm sorry I have been a bit 'absent' because of workload, I will aim to
find time to test this during this week (irrespective of whether the
compiler change is merged or remains in the branch). I don't actually use
the IDE distribution, so I am probably not the best person to verify
anything with the distribution itself, but I can check and verify if
everything goes smoothly, at least.  fwiw, I still use Intellij with that
flex-mojos 'hack' to get it working, that you revealed, and I am constantly
grateful to you for sharing that!




On Mon, Mar 8, 2021 at 7:10 AM Christofer Dutz 
wrote:

> Ok ... here goes:
>
> I thought I had been clear with what I wanted to do, but it seems I
> haven't been clear enough:
> To build the new distribution, you need to checkout my feature branch in
> the asjs repo (feature/distribution-allignment)
>
> However, for this to work, you need a tiny change I have in the compiler
> repo, which creates an additional jar in the compiler's "compiler" module,
> that contains all the scripts in the bin directory. I need this so I can
> put the content in the distribution.
>
> I was proposing to only merge that change as it doesn't have any effect on
> the build of the other artifacts, but the CI server would start building
> the new artifact and make it possible for people to test my changes without
> having to checkout the changes in the compiler and building the compiler
> manually.
>
> As soon as we have the distribution in a form that it produces correct
> distributions ... then ... and only then, do I think we should merge these
> changes (all of them in the asjs repo) to develop, because then we would be
> able to technically do releases with Maven.
>
> And I'm not rushing the second merge (the one in asjs) ... This should
> take as long as it takes till the distribution is perfect.
> I just want the other one in as this simplifies things for others, that
> want to test the changes (which we clearly need)
>
> Chris
>
>
>
> -Ursprüngliche Nachricht-
> Von: Christofer Dutz 
> Gesendet: Sonntag, 7. März 2021 18:58
> An: dev@royale.apache.org
> Betreff: AW: Merge the compiler-pr for distribution alignment?
>
> Hi Piotr,
>
> Well, I'm not referring to my changes on asjs ... I'm referring to the
> changes on the compiler.
> All this does is create a new artifact. If you managed to build the
> compiler in my branch, then all that should have worked, worked.
>
> Chris
>
>
> -Ursprüngliche Nachricht-
> Von: Piotr Zarzycki 
> Gesendet: Sonntag, 7. März 2021 16:25
> An: dev@royale.apache.org
> Betreff: Re: Merge the compiler-pr for distribution alignment?
>
> When it will work for me I will be +1 for merge. When I tested on Friday
> it didn’t work, so I do see reason why it should be on dev.
>
> On Sun, 7 Mar 2021 at 16:07, Christofer Dutz 
> wrote:
>
> > It's not a hurry,
> >
> > But it's a side-effect free merge and if there are others wanting to
> > join in (Especially Ant folks will probably be interested) I thought
> > this would simplify things for these non-Maven-natives.
> >
> > Chris
> >
> > -Ursprüngliche Nachricht-
> > Von: Piotr Zarzycki 
> > Gesendet: Sonntag, 7. März 2021 15:29
> > An: dev@royale.apache.org
> > Betreff: Re: Merge the compiler-pr for distribution alignment?
> >
> > Chris,
> >
> > I personally don’t have any problems with testing when it’s on branch.
> > Not sure what’s the hurry with that?
> >
> > I should have time to make another test after your commit on
> > Monday/Tuesday.
> >
> > Thanks,
> > Piotr
> >
> > On Sun, 7 Mar 2021 at 14:43, Christofer Dutz
> > 
> > wrote:
> >
> > > Hi all,
> > >
> > > it would simplify testing the distribution stuff a lot, if this PR
> > > would be merged:
> > > Feature/distribution allignment by chrisdutz * Pull Request #180 *
> > > apache/royale-compiler (github.com)<
> > > https://github.com/apache/royale-compiler/pull/180>
> > >
> > > It simply packs all scripts in the compiler bin directory into an
> > > additional jar which can then be downloaded by maven.
> > >
> > > With this people wanting to test-drive the distribution changes
> > > don't also have to checkout and build the compiler.
> > >
> > > It shouldn't have any other side-effects.
> > >
> > > Chris
> > >
> > --
> >
> > Piotr Zarzycki
> >
> --
>
> Piotr Zarzycki
>

AW: Merge the compiler-pr for distribution alignment?

[Christofer Dutz]

Ok ... here goes:

I thought I had been clear with what I wanted to do, but it seems I haven't 
been clear enough:
To build the new distribution, you need to checkout my feature branch in the 
asjs repo (feature/distribution-allignment)

However, for this to work, you need a tiny change I have in the compiler repo, 
which creates an additional jar in the compiler's "compiler" module, that 
contains all the scripts in the bin directory. I need this so I can put the 
content in the distribution.

I was proposing to only merge that change as it doesn't have any effect on the 
build of the other artifacts, but the CI server would start building the new 
artifact and make it possible for people to test my changes without having to 
checkout the changes in the compiler and building the compiler manually.

As soon as we have the distribution in a form that it produces correct 
distributions ... then ... and only then, do I think we should merge these 
changes (all of them in the asjs repo) to develop, because then we would be 
able to technically do releases with Maven.

And I'm not rushing the second merge (the one in asjs) ... This should take as 
long as it takes till the distribution is perfect. 
I just want the other one in as this simplifies things for others, that want to 
test the changes (which we clearly need)

Chris



-Ursprüngliche Nachricht-
Von: Christofer Dutz  
Gesendet: Sonntag, 7. März 2021 18:58
An: dev@royale.apache.org
Betreff: AW: Merge the compiler-pr for distribution alignment?

Hi Piotr,

Well, I'm not referring to my changes on asjs ... I'm referring to the changes 
on the compiler.
All this does is create a new artifact. If you managed to build the compiler in 
my branch, then all that should have worked, worked.

Chris


-Ursprüngliche Nachricht-
Von: Piotr Zarzycki 
Gesendet: Sonntag, 7. März 2021 16:25
An: dev@royale.apache.org
Betreff: Re: Merge the compiler-pr for distribution alignment?

When it will work for me I will be +1 for merge. When I tested on Friday it 
didn’t work, so I do see reason why it should be on dev.

On Sun, 7 Mar 2021 at 16:07, Christofer Dutz 
wrote:

> It's not a hurry,
>
> But it's a side-effect free merge and if there are others wanting to 
> join in (Especially Ant folks will probably be interested) I thought 
> this would simplify things for these non-Maven-natives.
>
> Chris
>
> -Ursprüngliche Nachricht-
> Von: Piotr Zarzycki 
> Gesendet: Sonntag, 7. März 2021 15:29
> An: dev@royale.apache.org
> Betreff: Re: Merge the compiler-pr for distribution alignment?
>
> Chris,
>
> I personally don’t have any problems with testing when it’s on branch.
> Not sure what’s the hurry with that?
>
> I should have time to make another test after your commit on 
> Monday/Tuesday.
>
> Thanks,
> Piotr
>
> On Sun, 7 Mar 2021 at 14:43, Christofer Dutz 
> 
> wrote:
>
> > Hi all,
> >
> > it would simplify testing the distribution stuff a lot, if this PR 
> > would be merged:
> > Feature/distribution allignment by chrisdutz * Pull Request #180 * 
> > apache/royale-compiler (github.com)< 
> > https://github.com/apache/royale-compiler/pull/180>
> >
> > It simply packs all scripts in the compiler bin directory into an 
> > additional jar which can then be downloaded by maven.
> >
> > With this people wanting to test-drive the distribution changes 
> > don't also have to checkout and build the compiler.
> >
> > It shouldn't have any other side-effects.
> >
> > Chris
> >
> --
>
> Piotr Zarzycki
>
-- 

Piotr Zarzycki

AW: Merge the compiler-pr for distribution alignment?

[Christofer Dutz]

Hi Piotr,

Well, I'm not referring to my changes on asjs ... I'm referring to the changes 
on the compiler.
All this does is create a new artifact. If you managed to build the compiler in 
my branch, then all that should have worked, worked.

Chris


-Ursprüngliche Nachricht-
Von: Piotr Zarzycki  
Gesendet: Sonntag, 7. März 2021 16:25
An: dev@royale.apache.org
Betreff: Re: Merge the compiler-pr for distribution alignment?

When it will work for me I will be +1 for merge. When I tested on Friday it 
didn’t work, so I do see reason why it should be on dev.

On Sun, 7 Mar 2021 at 16:07, Christofer Dutz 
wrote:

> It's not a hurry,
>
> But it's a side-effect free merge and if there are others wanting to 
> join in (Especially Ant folks will probably be interested) I thought 
> this would simplify things for these non-Maven-natives.
>
> Chris
>
> -Ursprüngliche Nachricht-
> Von: Piotr Zarzycki 
> Gesendet: Sonntag, 7. März 2021 15:29
> An: dev@royale.apache.org
> Betreff: Re: Merge the compiler-pr for distribution alignment?
>
> Chris,
>
> I personally don’t have any problems with testing when it’s on branch.
> Not sure what’s the hurry with that?
>
> I should have time to make another test after your commit on 
> Monday/Tuesday.
>
> Thanks,
> Piotr
>
> On Sun, 7 Mar 2021 at 14:43, Christofer Dutz 
> 
> wrote:
>
> > Hi all,
> >
> > it would simplify testing the distribution stuff a lot, if this PR 
> > would be merged:
> > Feature/distribution allignment by chrisdutz * Pull Request #180 * 
> > apache/royale-compiler (github.com)< 
> > https://github.com/apache/royale-compiler/pull/180>
> >
> > It simply packs all scripts in the compiler bin directory into an 
> > additional jar which can then be downloaded by maven.
> >
> > With this people wanting to test-drive the distribution changes 
> > don't also have to checkout and build the compiler.
> >
> > It shouldn't have any other side-effects.
> >
> > Chris
> >
> --
>
> Piotr Zarzycki
>
-- 

Piotr Zarzycki

Re: Merge the compiler-pr for distribution alignment?

[Harbs]

No. If there are issues they should be resolved. I don’t understand Maven well 
enough to have a technical opinion.

I was just saying that it seems useful for a release, so I’m interested in this 
getting it resolved quickly.

Thanks,
Harbs

> On Mar 7, 2021, at 5:27 PM, Piotr Zarzycki  wrote:
> 
> Harbs,
> 
> Are you proposing merge this even with issue which I have ?
> 
> Thanks,
> Piotr
> 
> On Sun, 7 Mar 2021 at 16:24, Harbs  wrote:
> 
>> I’m interested in doing a release ASAP. This seems really useful for
>> releasing.
>> 
>> I’m also not sure if it makes sense to first integrate Josh’s work on
>> playerglobal.
>> 
>> Josh, are you finished that or is there more to do?
>> 
>> Thanks,
>> Harbs
>> 
>>> On Mar 7, 2021, at 3:43 PM, Christofer Dutz 
>> wrote:
>>> 
>>> Hi all,
>>> 
>>> it would simplify testing the distribution stuff a lot, if this PR would
>> be merged:
>>> Feature/distribution allignment by chrisdutz * Pull Request #180 *
>> apache/royale-compiler (github.com)<
>> https://github.com/apache/royale-compiler/pull/180>
>>> 
>>> It simply packs all scripts in the compiler bin directory into an
>> additional jar which can then be downloaded by maven.
>>> 
>>> With this people wanting to test-drive the distribution changes don't
>> also have to checkout and build the compiler.
>>> 
>>> It shouldn't have any other side-effects.
>>> 
>>> Chris
>> 
>> --
> 
> Piotr Zarzycki

Re: Merge the compiler-pr for distribution alignment?

[Piotr Zarzycki]

Harbs,

Are you proposing merge this even with issue which I have ?

Thanks,
Piotr

On Sun, 7 Mar 2021 at 16:24, Harbs  wrote:

> I’m interested in doing a release ASAP. This seems really useful for
> releasing.
>
> I’m also not sure if it makes sense to first integrate Josh’s work on
> playerglobal.
>
> Josh, are you finished that or is there more to do?
>
> Thanks,
> Harbs
>
> > On Mar 7, 2021, at 3:43 PM, Christofer Dutz 
> wrote:
> >
> > Hi all,
> >
> > it would simplify testing the distribution stuff a lot, if this PR would
> be merged:
> > Feature/distribution allignment by chrisdutz * Pull Request #180 *
> apache/royale-compiler (github.com)<
> https://github.com/apache/royale-compiler/pull/180>
> >
> > It simply packs all scripts in the compiler bin directory into an
> additional jar which can then be downloaded by maven.
> >
> > With this people wanting to test-drive the distribution changes don't
> also have to checkout and build the compiler.
> >
> > It shouldn't have any other side-effects.
> >
> > Chris
>
> --

Piotr Zarzycki

Re: Merge the compiler-pr for distribution alignment?

[Piotr Zarzycki]

*I don’t see the reason.

On Sun, 7 Mar 2021 at 16:25, Piotr Zarzycki 
wrote:

> When it will work for me I will be +1 for merge. When I tested on Friday
> it didn’t work, so I do see reason why it should be on dev.
>
> On Sun, 7 Mar 2021 at 16:07, Christofer Dutz 
> wrote:
>
>> It's not a hurry,
>>
>> But it's a side-effect free merge and if there are others wanting to join
>> in (Especially Ant folks will probably be interested)
>> I thought this would simplify things for these non-Maven-natives.
>>
>> Chris
>>
>> -Ursprüngliche Nachricht-
>> Von: Piotr Zarzycki 
>> Gesendet: Sonntag, 7. März 2021 15:29
>> An: dev@royale.apache.org
>> Betreff: Re: Merge the compiler-pr for distribution alignment?
>>
>> Chris,
>>
>> I personally don’t have any problems with testing when it’s on branch.
>> Not sure what’s the hurry with that?
>>
>> I should have time to make another test after your commit on
>> Monday/Tuesday.
>>
>> Thanks,
>> Piotr
>>
>> On Sun, 7 Mar 2021 at 14:43, Christofer Dutz 
>> wrote:
>>
>> > Hi all,
>> >
>> > it would simplify testing the distribution stuff a lot, if this PR
>> > would be merged:
>> > Feature/distribution allignment by chrisdutz * Pull Request #180 *
>> > apache/royale-compiler (github.com)<
>> > https://github.com/apache/royale-compiler/pull/180>
>> >
>> > It simply packs all scripts in the compiler bin directory into an
>> > additional jar which can then be downloaded by maven.
>> >
>> > With this people wanting to test-drive the distribution changes don't
>> > also have to checkout and build the compiler.
>> >
>> > It shouldn't have any other side-effects.
>> >
>> > Chris
>> >
>> --
>>
>> Piotr Zarzycki
>>
> --
>
> Piotr Zarzycki
>
-- 

Piotr Zarzycki

Re: Merge the compiler-pr for distribution alignment?

[Piotr Zarzycki]

When it will work for me I will be +1 for merge. When I tested on Friday it
didn’t work, so I do see reason why it should be on dev.

On Sun, 7 Mar 2021 at 16:07, Christofer Dutz 
wrote:

> It's not a hurry,
>
> But it's a side-effect free merge and if there are others wanting to join
> in (Especially Ant folks will probably be interested)
> I thought this would simplify things for these non-Maven-natives.
>
> Chris
>
> -Ursprüngliche Nachricht-
> Von: Piotr Zarzycki 
> Gesendet: Sonntag, 7. März 2021 15:29
> An: dev@royale.apache.org
> Betreff: Re: Merge the compiler-pr for distribution alignment?
>
> Chris,
>
> I personally don’t have any problems with testing when it’s on branch.
> Not sure what’s the hurry with that?
>
> I should have time to make another test after your commit on
> Monday/Tuesday.
>
> Thanks,
> Piotr
>
> On Sun, 7 Mar 2021 at 14:43, Christofer Dutz 
> wrote:
>
> > Hi all,
> >
> > it would simplify testing the distribution stuff a lot, if this PR
> > would be merged:
> > Feature/distribution allignment by chrisdutz * Pull Request #180 *
> > apache/royale-compiler (github.com)<
> > https://github.com/apache/royale-compiler/pull/180>
> >
> > It simply packs all scripts in the compiler bin directory into an
> > additional jar which can then be downloaded by maven.
> >
> > With this people wanting to test-drive the distribution changes don't
> > also have to checkout and build the compiler.
> >
> > It shouldn't have any other side-effects.
> >
> > Chris
> >
> --
>
> Piotr Zarzycki
>
-- 

Piotr Zarzycki

Re: Merge the compiler-pr for distribution alignment?

[Harbs]

I’m interested in doing a release ASAP. This seems really useful for releasing.

I’m also not sure if it makes sense to first integrate Josh’s work on 
playerglobal.

Josh, are you finished that or is there more to do?

Thanks,
Harbs

> On Mar 7, 2021, at 3:43 PM, Christofer Dutz  wrote:
> 
> Hi all,
> 
> it would simplify testing the distribution stuff a lot, if this PR would be 
> merged:
> Feature/distribution allignment by chrisdutz * Pull Request #180 * 
> apache/royale-compiler 
> (github.com)
> 
> It simply packs all scripts in the compiler bin directory into an additional 
> jar which can then be downloaded by maven.
> 
> With this people wanting to test-drive the distribution changes don't also 
> have to checkout and build the compiler.
> 
> It shouldn't have any other side-effects.
> 
> Chris

AW: Merge the compiler-pr for distribution alignment?

[Christofer Dutz]

It's not a hurry,

But it's a side-effect free merge and if there are others wanting to join in 
(Especially Ant folks will probably be interested)
I thought this would simplify things for these non-Maven-natives.

Chris

-Ursprüngliche Nachricht-
Von: Piotr Zarzycki  
Gesendet: Sonntag, 7. März 2021 15:29
An: dev@royale.apache.org
Betreff: Re: Merge the compiler-pr for distribution alignment?

Chris,

I personally don’t have any problems with testing when it’s on branch.
Not sure what’s the hurry with that?

I should have time to make another test after your commit on Monday/Tuesday.

Thanks,
Piotr

On Sun, 7 Mar 2021 at 14:43, Christofer Dutz 
wrote:

> Hi all,
>
> it would simplify testing the distribution stuff a lot, if this PR 
> would be merged:
> Feature/distribution allignment by chrisdutz * Pull Request #180 * 
> apache/royale-compiler (github.com)< 
> https://github.com/apache/royale-compiler/pull/180>
>
> It simply packs all scripts in the compiler bin directory into an 
> additional jar which can then be downloaded by maven.
>
> With this people wanting to test-drive the distribution changes don't 
> also have to checkout and build the compiler.
>
> It shouldn't have any other side-effects.
>
> Chris
>
-- 

Piotr Zarzycki

Merge the compiler-pr for distribution alignment?

[Christofer Dutz]

Hi all,

it would simplify testing the distribution stuff a lot, if this PR would be 
merged:
Feature/distribution allignment by chrisdutz * Pull Request #180 * 
apache/royale-compiler 
(github.com)

It simply packs all scripts in the compiler bin directory into an additional 
jar which can then be downloaded by maven.

With this people wanting to test-drive the distribution changes don't also have 
to checkout and build the compiler.

It shouldn't have any other side-effects.

Chris

AW: PRs ready for distribution alignment

[Christofer Dutz]

Hi Piotr,

if you don't enable the "option-with-swf" it's the JS-only version.
The reason for setting things up that way 5 years ago, was that we then knew 
that SWF was going to be fading out and JS to be the new standard.
So, we chose the default to work without having to accept Adobe License 
Agreements and build the JS-only version per default.

So, in order to build the full thing including SWF support, run this instead:

mvn clean install -DdistributionTargetFolder=d:\Work\royale_ide\distribution 
-Poption-with-swf

Chris

-Ursprüngliche Nachricht-
Von: Piotr Zarzycki  
Gesendet: Sonntag, 7. März 2021 13:13
An: dev@royale.apache.org
Betreff: Re: PRs ready for distribution alignment

Chris,

I have used on Friday version which has been build with following command:

mvn clean install -DdistributionTargetFolder=d:\Work\royale_ide\distribution

Which one is that ?

If this command build swf version - I think default should be ja only.

Thanks,
Piotr

On Sun, 7 Mar 2021 at 13:03, Christofer Dutz 
wrote:

> Hi all,
>
> I just pushed some changes handing the "without-swf" version.
> I now create the dummy files the FlashBuilder seems to require.
> Also does the build now clean out the "library-path" for the 
> without-swf version.
>
> So, it should now be more aligned with the Ant build.
>
> @Piotr ... Are you still using the "without-swf/JS-only" distribution 
> or the one with swf?
>
> Chris
>
> -Ursprüngliche Nachricht-
> Von: Piotr Zarzycki 
> Gesendet: Sonntag, 7. März 2021 12:46
> An: dev@royale.apache.org
> Betreff: Re: PRs ready for distribution alignment
>
> Yep it doesn’t, but I can build my project with that sdk and cannot 
> with maven distribution, so some configs has changed.
>
> On Sun, 7 Mar 2021 at 11:56, Christofer Dutz 
> 
> wrote:
>
> > Hi Piotr,
> >
> > So, I just downloaded the js-only version and that seems to be quite 
> > empty too.
> >
> > It does seem to contain airglobal and playerglobal, JewelTheme and a 
> > quite big lib called KeepsFBFromHanging.swc ... but in general this 
> > directory doesn't contain any of the Project swcs.
> >
> > Chris
> >
> >
> > -Ursprüngliche Nachricht-
> > Von: Christofer Dutz 
> > Gesendet: Freitag, 5. März 2021 18:07
> > An: dev@royale.apache.org
> > Betreff: AW: PRs ready for distribution alignment
> >
> > Hi Piotr,
> >
> > Guess I should have gotten the no-swf Ant version ... but I thought, 
> > if you do a JS compile it uses the js/libs and if it's a SWF, it 
> > uses
> "libs".
> > So right now, in case of the no-swf build, it doesn't add any of the 
> > swc's ... but I'll investigate the no-swf ANT version and work on 
> > that this weekend.
> >
> > So, for now it might make more sense to compare the "with-swf" versions.
> >
> > Chris
> >
> >
> > -Ursprüngliche Nachricht-
> > Von: Piotr Zarzycki 
> > Gesendet: Freitag, 5. März 2021 17:39
> > An: Apache Royale Development 
> > Betreff: Re: PRs ready for distribution alignment
> >
> > Just an observation. In Ant distribution frameworks/libs does 
> > exists, but it doesn't contains all those swc which you are seeing 
> > in stacktrace. It means that Maven distribution is somehow "telling"
> > trough maybe some configs that I should use frameworks/libs swc 
> > instead
> frameworks/js/libs...
> >
> > pt., 5 mar 2021 o 17:32 Christofer Dutz 
> > napisał(a):
> >
> > > Hi Piotr,
> > >
> > > It should work in both.
> > >
> > > Chris
> > >
> > >
> > > -Ursprüngliche Nachricht-
> > > Von: Piotr Zarzycki 
> > > Gesendet: Freitag, 5. März 2021 17:04
> > > An: Apache Royale Development 
> > > Betreff: Re: PRs ready for distribution alignment
> > >
> > > That options is working whether I build distribution in root 
> > > folder of sdk and "distribution" folder as well ?
> > >
> > > pt., 5 mar 2021 o 17:00 Christofer Dutz 
> > > 
> > > napisał(a):
> > >
> > > > Hi Piotr,
> > > >
> > > > If you don't explicitly define the profile "option-with-swf" 
> > > > it's the JS-only version.
> > > >
> > > > Chris
> > > >
> > > > -Ursprüngliche Nachricht-
> > > > Von: Piotr Zarzycki 
> > > > Gesendet: Freitag, 5. März 2021 16:11
> > > > An: Apache Royale Development 
> > > > Betreff: Re: PRs ready for distribution alignment
> > > >
> > > > Chris,
> > > >
> > > > frameworks/libs doesn't exists at all.
> > > >
> > > > What occurs to me that I actually don't know what kind of 
> > > > distribution package I'm building. Is it js-only distribution or 
> > > > is it js-swf distribution ?
> > > >
> > > > Thanks,
> > > > Piotr
> > > >
> > > > pt., 5 mar 2021 o 15:41 Christofer Dutz 
> > > > 
> > > > napisał(a):
> > > >
> > > > > Hi Piotr,
> > > > >
> > > > > this is strange ... from the log output it seems as if the 
> > > > > "frameworks/libs" doesn't contain any of the libraries.
> > > > > Could you please confirm if the directory really doesn't 
> > > > > contain
> > them?
> > > > >
> > > > > Chris
> > > > >
> > > > >
> > > > >
> > > > > -Ursprüngliche Nachricht-
> > 

Re: PRs ready for distribution alignment

[Piotr Zarzycki]

Chris,

I have used on Friday version which has been build with following command:

mvn clean install -DdistributionTargetFolder=d:\Work\royale_ide\distribution

Which one is that ?

If this command build swf version - I think default should be ja only.

Thanks,
Piotr

On Sun, 7 Mar 2021 at 13:03, Christofer Dutz 
wrote:

> Hi all,
>
> I just pushed some changes handing the "without-swf" version.
> I now create the dummy files the FlashBuilder seems to require.
> Also does the build now clean out the "library-path" for the without-swf
> version.
>
> So, it should now be more aligned with the Ant build.
>
> @Piotr ... Are you still using the "without-swf/JS-only" distribution or
> the one with swf?
>
> Chris
>
> -Ursprüngliche Nachricht-
> Von: Piotr Zarzycki 
> Gesendet: Sonntag, 7. März 2021 12:46
> An: dev@royale.apache.org
> Betreff: Re: PRs ready for distribution alignment
>
> Yep it doesn’t, but I can build my project with that sdk and cannot with
> maven distribution, so some configs has changed.
>
> On Sun, 7 Mar 2021 at 11:56, Christofer Dutz 
> wrote:
>
> > Hi Piotr,
> >
> > So, I just downloaded the js-only version and that seems to be quite
> > empty too.
> >
> > It does seem to contain airglobal and playerglobal, JewelTheme and a
> > quite big lib called KeepsFBFromHanging.swc ... but in general this
> > directory doesn't contain any of the Project swcs.
> >
> > Chris
> >
> >
> > -Ursprüngliche Nachricht-
> > Von: Christofer Dutz 
> > Gesendet: Freitag, 5. März 2021 18:07
> > An: dev@royale.apache.org
> > Betreff: AW: PRs ready for distribution alignment
> >
> > Hi Piotr,
> >
> > Guess I should have gotten the no-swf Ant version ... but I thought,
> > if you do a JS compile it uses the js/libs and if it's a SWF, it uses
> "libs".
> > So right now, in case of the no-swf build, it doesn't add any of the
> > swc's ... but I'll investigate the no-swf ANT version and work on that
> > this weekend.
> >
> > So, for now it might make more sense to compare the "with-swf" versions.
> >
> > Chris
> >
> >
> > -Ursprüngliche Nachricht-
> > Von: Piotr Zarzycki 
> > Gesendet: Freitag, 5. März 2021 17:39
> > An: Apache Royale Development 
> > Betreff: Re: PRs ready for distribution alignment
> >
> > Just an observation. In Ant distribution frameworks/libs does exists,
> > but it doesn't contains all those swc which you are seeing in
> > stacktrace. It means that Maven distribution is somehow "telling"
> > trough maybe some configs that I should use frameworks/libs swc instead
> frameworks/js/libs...
> >
> > pt., 5 mar 2021 o 17:32 Christofer Dutz 
> > napisał(a):
> >
> > > Hi Piotr,
> > >
> > > It should work in both.
> > >
> > > Chris
> > >
> > >
> > > -Ursprüngliche Nachricht-
> > > Von: Piotr Zarzycki 
> > > Gesendet: Freitag, 5. März 2021 17:04
> > > An: Apache Royale Development 
> > > Betreff: Re: PRs ready for distribution alignment
> > >
> > > That options is working whether I build distribution in root folder
> > > of sdk and "distribution" folder as well ?
> > >
> > > pt., 5 mar 2021 o 17:00 Christofer Dutz 
> > > napisał(a):
> > >
> > > > Hi Piotr,
> > > >
> > > > If you don't explicitly define the profile "option-with-swf" it's
> > > > the JS-only version.
> > > >
> > > > Chris
> > > >
> > > > -Ursprüngliche Nachricht-
> > > > Von: Piotr Zarzycki 
> > > > Gesendet: Freitag, 5. März 2021 16:11
> > > > An: Apache Royale Development 
> > > > Betreff: Re: PRs ready for distribution alignment
> > > >
> > > > Chris,
> > > >
> > > > frameworks/libs doesn't exists at all.
> > > >
> > > > What occurs to me that I actually don't know what kind of
> > > > distribution package I'm building. Is it js-only distribution or
> > > > is it js-swf distribution ?
> > > >
> > > > Thanks,
> > > > Piotr
> > > >
> > > > pt., 5 mar 2021 o 15:41 Christofer Dutz
> > > > 
> > > > napisał(a):
> > > >
> > > > > Hi Piotr,
> > > > >
> > > > > this is strange ... from the log output it seems as if the
> > > > > "frameworks/libs" doesn't contain any of the libraries.
> > > > > Could you please confirm if the directory really doesn't contain
> > them?
> > > > >
> > > > > Chris
> > > > >
> > > > >
> > > > >
> > > > > -Ursprüngliche Nachricht-
> > > > > Von: Piotr Zarzycki 
> > > > > Gesendet: Freitag, 5. März 2021 12:19
> > > > > An: Apache Royale Development 
> > > > > Betreff: Re: PRs ready for distribution alignment
> > > > >
> > > > > Hi Chris,
> > > > >
> > > > > Thanks for all work. After rebuilding whole framework I just
> > > > > tried produce distribution by going to the folder of it and do:
> > > > >
> > > > > mvn clean install
> > > > > -DdistributionTargetFolder=d:\Work\royale_ide\distribution
> > > > >
> > > > > It works without doing set
> > > > > distributionTargetFolder=d:\Work\royale_ide\distribution.
> > > > >
> > > > > I went to Moonshine and tried to build with produced
> > > > > distribution our project and I got following errors - I won't
> > > > > post here full 

AW: PRs ready for distribution alignment

[Christofer Dutz]

Hi all,

I just pushed some changes handing the "without-swf" version.
I now create the dummy files the FlashBuilder seems to require.
Also does the build now clean out the "library-path" for the without-swf 
version.

So, it should now be more aligned with the Ant build.

@Piotr ... Are you still using the "without-swf/JS-only" distribution or the 
one with swf?

Chris

-Ursprüngliche Nachricht-
Von: Piotr Zarzycki  
Gesendet: Sonntag, 7. März 2021 12:46
An: dev@royale.apache.org
Betreff: Re: PRs ready for distribution alignment

Yep it doesn’t, but I can build my project with that sdk and cannot with maven 
distribution, so some configs has changed.

On Sun, 7 Mar 2021 at 11:56, Christofer Dutz 
wrote:

> Hi Piotr,
>
> So, I just downloaded the js-only version and that seems to be quite 
> empty too.
>
> It does seem to contain airglobal and playerglobal, JewelTheme and a 
> quite big lib called KeepsFBFromHanging.swc ... but in general this 
> directory doesn't contain any of the Project swcs.
>
> Chris
>
>
> -Ursprüngliche Nachricht-
> Von: Christofer Dutz 
> Gesendet: Freitag, 5. März 2021 18:07
> An: dev@royale.apache.org
> Betreff: AW: PRs ready for distribution alignment
>
> Hi Piotr,
>
> Guess I should have gotten the no-swf Ant version ... but I thought, 
> if you do a JS compile it uses the js/libs and if it's a SWF, it uses "libs".
> So right now, in case of the no-swf build, it doesn't add any of the 
> swc's ... but I'll investigate the no-swf ANT version and work on that 
> this weekend.
>
> So, for now it might make more sense to compare the "with-swf" versions.
>
> Chris
>
>
> -Ursprüngliche Nachricht-
> Von: Piotr Zarzycki 
> Gesendet: Freitag, 5. März 2021 17:39
> An: Apache Royale Development 
> Betreff: Re: PRs ready for distribution alignment
>
> Just an observation. In Ant distribution frameworks/libs does exists, 
> but it doesn't contains all those swc which you are seeing in 
> stacktrace. It means that Maven distribution is somehow "telling" 
> trough maybe some configs that I should use frameworks/libs swc instead 
> frameworks/js/libs...
>
> pt., 5 mar 2021 o 17:32 Christofer Dutz 
> napisał(a):
>
> > Hi Piotr,
> >
> > It should work in both.
> >
> > Chris
> >
> >
> > -Ursprüngliche Nachricht-
> > Von: Piotr Zarzycki 
> > Gesendet: Freitag, 5. März 2021 17:04
> > An: Apache Royale Development 
> > Betreff: Re: PRs ready for distribution alignment
> >
> > That options is working whether I build distribution in root folder 
> > of sdk and "distribution" folder as well ?
> >
> > pt., 5 mar 2021 o 17:00 Christofer Dutz 
> > napisał(a):
> >
> > > Hi Piotr,
> > >
> > > If you don't explicitly define the profile "option-with-swf" it's 
> > > the JS-only version.
> > >
> > > Chris
> > >
> > > -Ursprüngliche Nachricht-
> > > Von: Piotr Zarzycki 
> > > Gesendet: Freitag, 5. März 2021 16:11
> > > An: Apache Royale Development 
> > > Betreff: Re: PRs ready for distribution alignment
> > >
> > > Chris,
> > >
> > > frameworks/libs doesn't exists at all.
> > >
> > > What occurs to me that I actually don't know what kind of 
> > > distribution package I'm building. Is it js-only distribution or 
> > > is it js-swf distribution ?
> > >
> > > Thanks,
> > > Piotr
> > >
> > > pt., 5 mar 2021 o 15:41 Christofer Dutz 
> > > 
> > > napisał(a):
> > >
> > > > Hi Piotr,
> > > >
> > > > this is strange ... from the log output it seems as if the 
> > > > "frameworks/libs" doesn't contain any of the libraries.
> > > > Could you please confirm if the directory really doesn't contain
> them?
> > > >
> > > > Chris
> > > >
> > > >
> > > >
> > > > -Ursprüngliche Nachricht-
> > > > Von: Piotr Zarzycki 
> > > > Gesendet: Freitag, 5. März 2021 12:19
> > > > An: Apache Royale Development 
> > > > Betreff: Re: PRs ready for distribution alignment
> > > >
> > > > Hi Chris,
> > > >
> > > > Thanks for all work. After rebuilding whole framework I just 
> > > > tried produce distribution by going to the folder of it and do:
> > > >
> > > > mvn clean install
> > > > -DdistributionTargetFolder=d:\Work\royale_ide\distribution
> > > >
> > > > It works without doing set
> > > > distributionTargetFolder=d:\Work\royale_ide\distribution.
> > > >
> > > > I went to Moonshine and tried to build with produced 
> > > > distribution our project and I got following errors - I won't 
> > > > post here full stacktrace [1]
> > > >
> > > > [1] https://paste.apache.org/c2qv1
> > > >
> > > > Thanks,
> > > > Piotr
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > pt., 5 mar 2021 o 10:10 Christofer Dutz 
> > > > 
> > > > napisał(a):
> > > >
> > > > > Hi all,
> > > > >
> > > > > I have, as far as I know, finished the work on aligning the 
> > > > > Maven built and the Ant built distribution.
> > > > > A few things have changed in the Maven distribution compared 
> > > > > to the earlier ones:
> > > > >
> > > > >
> > > > >   *   All scripts (in the bin and js/bin) directory 

Re: PRs ready for distribution alignment

[Piotr Zarzycki]

Yep it doesn’t, but I can build my project with that sdk and cannot with
maven distribution, so some configs has changed.

On Sun, 7 Mar 2021 at 11:56, Christofer Dutz 
wrote:

> Hi Piotr,
>
> So, I just downloaded the js-only version and that seems to be quite empty
> too.
>
> It does seem to contain airglobal and playerglobal, JewelTheme and a quite
> big lib called KeepsFBFromHanging.swc ... but in general this directory
> doesn't contain any of the Project swcs.
>
> Chris
>
>
> -Ursprüngliche Nachricht-
> Von: Christofer Dutz 
> Gesendet: Freitag, 5. März 2021 18:07
> An: dev@royale.apache.org
> Betreff: AW: PRs ready for distribution alignment
>
> Hi Piotr,
>
> Guess I should have gotten the no-swf Ant version ... but I thought, if
> you do a JS compile it uses the js/libs and if it's a SWF, it uses "libs".
> So right now, in case of the no-swf build, it doesn't add any of the swc's
> ... but I'll investigate the no-swf ANT version and work on that this
> weekend.
>
> So, for now it might make more sense to compare the "with-swf" versions.
>
> Chris
>
>
> -Ursprüngliche Nachricht-
> Von: Piotr Zarzycki 
> Gesendet: Freitag, 5. März 2021 17:39
> An: Apache Royale Development 
> Betreff: Re: PRs ready for distribution alignment
>
> Just an observation. In Ant distribution frameworks/libs does exists, but
> it doesn't contains all those swc which you are seeing in stacktrace. It
> means that Maven distribution is somehow "telling" trough maybe some
> configs that I should use frameworks/libs swc instead frameworks/js/libs...
>
> pt., 5 mar 2021 o 17:32 Christofer Dutz 
> napisał(a):
>
> > Hi Piotr,
> >
> > It should work in both.
> >
> > Chris
> >
> >
> > -Ursprüngliche Nachricht-
> > Von: Piotr Zarzycki 
> > Gesendet: Freitag, 5. März 2021 17:04
> > An: Apache Royale Development 
> > Betreff: Re: PRs ready for distribution alignment
> >
> > That options is working whether I build distribution in root folder of
> > sdk and "distribution" folder as well ?
> >
> > pt., 5 mar 2021 o 17:00 Christofer Dutz 
> > napisał(a):
> >
> > > Hi Piotr,
> > >
> > > If you don't explicitly define the profile "option-with-swf" it's
> > > the JS-only version.
> > >
> > > Chris
> > >
> > > -Ursprüngliche Nachricht-
> > > Von: Piotr Zarzycki 
> > > Gesendet: Freitag, 5. März 2021 16:11
> > > An: Apache Royale Development 
> > > Betreff: Re: PRs ready for distribution alignment
> > >
> > > Chris,
> > >
> > > frameworks/libs doesn't exists at all.
> > >
> > > What occurs to me that I actually don't know what kind of
> > > distribution package I'm building. Is it js-only distribution or is
> > > it js-swf distribution ?
> > >
> > > Thanks,
> > > Piotr
> > >
> > > pt., 5 mar 2021 o 15:41 Christofer Dutz 
> > > napisał(a):
> > >
> > > > Hi Piotr,
> > > >
> > > > this is strange ... from the log output it seems as if the
> > > > "frameworks/libs" doesn't contain any of the libraries.
> > > > Could you please confirm if the directory really doesn't contain
> them?
> > > >
> > > > Chris
> > > >
> > > >
> > > >
> > > > -Ursprüngliche Nachricht-
> > > > Von: Piotr Zarzycki 
> > > > Gesendet: Freitag, 5. März 2021 12:19
> > > > An: Apache Royale Development 
> > > > Betreff: Re: PRs ready for distribution alignment
> > > >
> > > > Hi Chris,
> > > >
> > > > Thanks for all work. After rebuilding whole framework I just tried
> > > > produce distribution by going to the folder of it and do:
> > > >
> > > > mvn clean install
> > > > -DdistributionTargetFolder=d:\Work\royale_ide\distribution
> > > >
> > > > It works without doing set
> > > > distributionTargetFolder=d:\Work\royale_ide\distribution.
> > > >
> > > > I went to Moonshine and tried to build with produced distribution
> > > > our project and I got following errors - I won't post here full
> > > > stacktrace [1]
> > > >
> > > > [1] https://paste.apache.org/c2qv1
> > > >
> > > > Thanks,
> > > > Piotr
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > pt., 5 mar 2021 o 10:10 Christofer Dutz
> > > > 
> > > > napisał(a):
> > > >
> > > > > Hi all,
> > > > >
> > > > > I have, as far as I know, finished the work on aligning the
> > > > > Maven built and the Ant built distribution.
> > > > > A few things have changed in the Maven distribution compared to
> > > > > the earlier ones:
> > > > >
> > > > >
> > > > >   *   All scripts (in the bin and js/bin) directory are now
> identical
> > > to
> > > > > the ones in the Ant distribution.
> > > > >   *   The manifests are no longer contained in a "manifests"
> > directory
> > > > but
> > > > > are in the same location as they are for the Ant build.
> > > > >   *   I now include the sources of the projects, which should
> > simplify
> > > > > debugging.
> > > > >
> > > > > The probably most important change is that I no longer have
> > > > > copies of the scripts and main manifests in the distribution
> resources.
> > > > > These resources now only contain the empty dummy files needed 

AW: PRs ready for distribution alignment

[Christofer Dutz]

Hi Piotr,

So, I just downloaded the js-only version and that seems to be quite empty too.

It does seem to contain airglobal and playerglobal, JewelTheme and a quite big 
lib called KeepsFBFromHanging.swc ... but in general this directory doesn't 
contain any of the Project swcs.

Chris


-Ursprüngliche Nachricht-
Von: Christofer Dutz  
Gesendet: Freitag, 5. März 2021 18:07
An: dev@royale.apache.org
Betreff: AW: PRs ready for distribution alignment

Hi Piotr,

Guess I should have gotten the no-swf Ant version ... but I thought, if you do 
a JS compile it uses the js/libs and if it's a SWF, it uses "libs". So right 
now, in case of the no-swf build, it doesn't add any of the swc's ... but I'll 
investigate the no-swf ANT version and work on that this weekend. 

So, for now it might make more sense to compare the "with-swf" versions.

Chris


-Ursprüngliche Nachricht-
Von: Piotr Zarzycki 
Gesendet: Freitag, 5. März 2021 17:39
An: Apache Royale Development 
Betreff: Re: PRs ready for distribution alignment

Just an observation. In Ant distribution frameworks/libs does exists, but it 
doesn't contains all those swc which you are seeing in stacktrace. It means 
that Maven distribution is somehow "telling" trough maybe some configs that I 
should use frameworks/libs swc instead frameworks/js/libs...

pt., 5 mar 2021 o 17:32 Christofer Dutz 
napisał(a):

> Hi Piotr,
>
> It should work in both.
>
> Chris
>
>
> -Ursprüngliche Nachricht-
> Von: Piotr Zarzycki 
> Gesendet: Freitag, 5. März 2021 17:04
> An: Apache Royale Development 
> Betreff: Re: PRs ready for distribution alignment
>
> That options is working whether I build distribution in root folder of 
> sdk and "distribution" folder as well ?
>
> pt., 5 mar 2021 o 17:00 Christofer Dutz 
> napisał(a):
>
> > Hi Piotr,
> >
> > If you don't explicitly define the profile "option-with-swf" it's 
> > the JS-only version.
> >
> > Chris
> >
> > -Ursprüngliche Nachricht-
> > Von: Piotr Zarzycki 
> > Gesendet: Freitag, 5. März 2021 16:11
> > An: Apache Royale Development 
> > Betreff: Re: PRs ready for distribution alignment
> >
> > Chris,
> >
> > frameworks/libs doesn't exists at all.
> >
> > What occurs to me that I actually don't know what kind of 
> > distribution package I'm building. Is it js-only distribution or is 
> > it js-swf distribution ?
> >
> > Thanks,
> > Piotr
> >
> > pt., 5 mar 2021 o 15:41 Christofer Dutz 
> > napisał(a):
> >
> > > Hi Piotr,
> > >
> > > this is strange ... from the log output it seems as if the 
> > > "frameworks/libs" doesn't contain any of the libraries.
> > > Could you please confirm if the directory really doesn't contain them?
> > >
> > > Chris
> > >
> > >
> > >
> > > -Ursprüngliche Nachricht-
> > > Von: Piotr Zarzycki 
> > > Gesendet: Freitag, 5. März 2021 12:19
> > > An: Apache Royale Development 
> > > Betreff: Re: PRs ready for distribution alignment
> > >
> > > Hi Chris,
> > >
> > > Thanks for all work. After rebuilding whole framework I just tried 
> > > produce distribution by going to the folder of it and do:
> > >
> > > mvn clean install
> > > -DdistributionTargetFolder=d:\Work\royale_ide\distribution
> > >
> > > It works without doing set
> > > distributionTargetFolder=d:\Work\royale_ide\distribution.
> > >
> > > I went to Moonshine and tried to build with produced distribution 
> > > our project and I got following errors - I won't post here full 
> > > stacktrace [1]
> > >
> > > [1] https://paste.apache.org/c2qv1
> > >
> > > Thanks,
> > > Piotr
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > pt., 5 mar 2021 o 10:10 Christofer Dutz 
> > > 
> > > napisał(a):
> > >
> > > > Hi all,
> > > >
> > > > I have, as far as I know, finished the work on aligning the 
> > > > Maven built and the Ant built distribution.
> > > > A few things have changed in the Maven distribution compared to 
> > > > the earlier ones:
> > > >
> > > >
> > > >   *   All scripts (in the bin and js/bin) directory are now identical
> > to
> > > > the ones in the Ant distribution.
> > > >   *   The manifests are no longer contained in a "manifests"
> directory
> > > but
> > > > are in the same location as they are for the Ant build.
> > > >   *   I now include the sources of the projects, which should
> simplify
> > > > debugging.
> > > >
> > > > The probably most important change is that I no longer have 
> > > > copies of the scripts and main manifests in the distribution resources.
> > > > These resources now only contain the empty dummy files needed by 
> > > > FlashBuilder. It seems these were updated in the project, but 
> > > > the copies weren't. Therefore, the scripts as well as the 
> > > > manifests weren't identical in Ant and Maven distributions. I 
> > > > solved that problem by now taking the exact same files and 
> > > > copying them in the assembly. The manifests needed minor 
> > > > tweaking which I am now doing via
> > > an XSLT in the build.
> > > >
> > > > Also did I refactor everything 

Re: mx:ComboBox using prompt and labelFunction questions

[Yishay Weiss]

Hi,

Before we start a thread on how to add prompt to mx:ComboBox can you just 
confirm that you've seen the walkthrough [1] ?

[1] Getting MX Alert To Run · apache/royale-asjs Wiki 
(github.com)

Thanks


From: gbarbosa 
Sent: Thursday, March 4, 2021 4:57 PM
To: dev@royale.apache.org 
Subject: RE: mx:ComboBox using prompt and labelFunction questions

Hi yishayw,

I appreciate the response. I've read the linked wiki page and while it was a
great start to stubbing out components the main focus of that page is to get
your app to compile.

What was not obvious to me was how you go about adding properties and
implementing them, to a MXRoyale component. They talked about adding beads
and strands, but when I looked in the source code there didn't seem to be
beads or strands.

What I'm trying to make simpler is the process of determining if something
is a bug in royale vs something that is not implemented. Take mx:ComboBox
prompt for example. I'm not seeing any goog:DEBUG statements so it should be
implemented correct?



--
Sent from: http://apache-royale-development.20373.n8.nabble.com/