Ok ... here goes:
I thought I had been clear with what I wanted to do, but it seems I haven't
been clear enough:
To build the new distribution, you need to checkout my feature branch in the
asjs repo (feature/distribution-allignment)
However, for this to work, you need a tiny change I have in the compiler repo,
which creates an additional jar in the compiler's "compiler" module, that
contains all the scripts in the bin directory. I need this so I can put the
content in the distribution.
I was proposing to only merge that change as it doesn't have any effect on the
build of the other artifacts, but the CI server would start building the new
artifact and make it possible for people to test my changes without having to
checkout the changes in the compiler and building the compiler manually.
As soon as we have the distribution in a form that it produces correct
distributions ... then ... and only then, do I think we should merge these
changes (all of them in the asjs repo) to develop, because then we would be
able to technically do releases with Maven.
And I'm not rushing the second merge (the one in asjs) ... This should take as
long as it takes till the distribution is perfect.
I just want the other one in as this simplifies things for others, that want to
test the changes (which we clearly need)
Chris
-Ursprüngliche Nachricht-
Von: Christofer Dutz
Gesendet: Sonntag, 7. März 2021 18:58
An: dev@royale.apache.org
Betreff: AW: Merge the compiler-pr for distribution alignment?
Hi Piotr,
Well, I'm not referring to my changes on asjs ... I'm referring to the changes
on the compiler.
All this does is create a new artifact. If you managed to build the compiler in
my branch, then all that should have worked, worked.
Chris
-Ursprüngliche Nachricht-
Von: Piotr Zarzycki
Gesendet: Sonntag, 7. März 2021 16:25
An: dev@royale.apache.org
Betreff: Re: Merge the compiler-pr for distribution alignment?
When it will work for me I will be +1 for merge. When I tested on Friday it
didn’t work, so I do see reason why it should be on dev.
On Sun, 7 Mar 2021 at 16:07, Christofer Dutz
wrote:
> It's not a hurry,
>
> But it's a side-effect free merge and if there are others wanting to
> join in (Especially Ant folks will probably be interested) I thought
> this would simplify things for these non-Maven-natives.
>
> Chris
>
> -Ursprüngliche Nachricht-
> Von: Piotr Zarzycki
> Gesendet: Sonntag, 7. März 2021 15:29
> An: dev@royale.apache.org
> Betreff: Re: Merge the compiler-pr for distribution alignment?
>
> Chris,
>
> I personally don’t have any problems with testing when it’s on branch.
> Not sure what’s the hurry with that?
>
> I should have time to make another test after your commit on
> Monday/Tuesday.
>
> Thanks,
> Piotr
>
> On Sun, 7 Mar 2021 at 14:43, Christofer Dutz
>
> wrote:
>
> > Hi all,
> >
> > it would simplify testing the distribution stuff a lot, if this PR
> > would be merged:
> > Feature/distribution allignment by chrisdutz * Pull Request #180 *
> > apache/royale-compiler (github.com)<
> > https://github.com/apache/royale-compiler/pull/180>
> >
> > It simply packs all scripts in the compiler bin directory into an
> > additional jar which can then be downloaded by maven.
> >
> > With this people wanting to test-drive the distribution changes
> > don't also have to checkout and build the compiler.
> >
> > It shouldn't have any other side-effects.
> >
> > Chris
> >
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
