RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
Works, thanks.
From: Alex Harui
Sent: Saturday, March 21, 2020 7:34:03 AM
To: dev@royale.apache.org
Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
OK, looks like CanvasLayout was not behaving. I pushed a change for it.
On 3/20/20, 10:19 AM, "Yishay Weiss" wrote:
It’s the same code [1] as below.
[1]
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fqr5i4&data=02%7C01%7Caharui%40adobe.com%7C678378365e9e4f2e08e708d7ccf2d6db%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637203215668587546&sdata=X7WUYeBWTI0s%2BpbDaNjQ2Ro%2BJI8aKPVhyaSfVQvXD7I%3D&reserved=0
From: Yishay Weiss<mailto:yishayj...@hotmail.com>
Sent: Friday, March 20, 2020 11:08 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
With percentages. With fixed dimensions it does work.
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Wednesday, March 18, 2020 6:50 PM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
How is the width/height set on the ADG?
-Alex
On 3/18/20, 12:23 AM, "Yishay Weiss" wrote:
Panel looks fixed, thanks. My ADG is suddenly not showing any data
though. I’ll need to investigate that later…
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Tuesday, March 17, 2020 9:32 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged
event rules
Try with my latest commit.
On 3/16/20, 11:21 PM, "Yishay Weiss" wrote:
Mxml looks like this [1]. SuperPanel extends Panel. I’m not sure
I’m at liberty to post SuperPanel’s source, but if you can’t reproduce the
problem with the non-custom controls then I could work on it maybe next week.
[1]
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fqr5i4&data=02%7C01%7Caharui%40adobe.com%7C678378365e9e4f2e08e708d7ccf2d6db%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637203215668587546&sdata=X7WUYeBWTI0s%2BpbDaNjQ2Ro%2BJI8aKPVhyaSfVQvXD7I%3D&reserved=0
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Monday, March 16, 2020 6:24 PM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing
widthChanged/heightChanged/sizeChanged event rules
There was a change made to mx:Panel to not run as many layouts.
What does the MXML for the broken mx:Panel look like? I probably missed a case.
-Alex
On 3/16/20, 1:57 AM, "Yishay Weiss" wrote:
I won’t have time to investigate it today. Rolling back to
d3e27d65344ad27912000e1e3205b96243d8828e
fixes it.
From: Yishay Weiss<mailto:yishayj...@hotmail.com>
Sent: Monday, March 16, 2020 10:09 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: RE: Layouts: Changing
widthChanged/heightChanged/sizeChanged event rules
MX|Panel
From: Yishay Weiss
Sent: Monday, March 16, 2020 10:08:49 AM
To: dev@royale.apache.org
Subject: RE: Layouts: Changing
widthChanged/heightChanged/sizeChanged event rules
I’ve just updated Royale and am seeing weird behavior in Panel
layout. The content is taking up all the space and obliterating the title and
the rest of the chrome elements. Not sure if it’s related to these changes.
Will try to isolate it.
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Saturday, March 14, 2020 7:12 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Layouts: Changing
widthChanged/heightChanged/sizeChanged event rules
Hi,
I am wanting to change the way UIBase setWidthAndHeight
dispatches its events to cut down on the number of layout passes.
Right now, if you change both the width and height of a
component, you get 3 events (widthChanged, heightChanged, sizeChanged). I want
to change that so that you only get sizeChanged. This change would cause the
"meaning" of widthChanged to mean that only the width changed during a resize
so you can optimize some of the layout code and similar for heightChanged.
And thus, you will only ever get one event out of setWidthAndHeight, it will
either be:
- "widthChanged" mea
Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
OK, looks like CanvasLayout was not behaving. I pushed a change for it.
On 3/20/20, 10:19 AM, "Yishay Weiss" wrote:
It’s the same code [1] as below.
[1]
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fqr5i4&data=02%7C01%7Caharui%40adobe.com%7C678378365e9e4f2e08e708d7ccf2d6db%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637203215668587546&sdata=X7WUYeBWTI0s%2BpbDaNjQ2Ro%2BJI8aKPVhyaSfVQvXD7I%3D&reserved=0
From: Yishay Weiss<mailto:yishayj...@hotmail.com>
Sent: Friday, March 20, 2020 11:08 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
With percentages. With fixed dimensions it does work.
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Wednesday, March 18, 2020 6:50 PM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
How is the width/height set on the ADG?
-Alex
On 3/18/20, 12:23 AM, "Yishay Weiss" wrote:
Panel looks fixed, thanks. My ADG is suddenly not showing any data
though. I’ll need to investigate that later…
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Tuesday, March 17, 2020 9:32 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged
event rules
Try with my latest commit.
On 3/16/20, 11:21 PM, "Yishay Weiss" wrote:
Mxml looks like this [1]. SuperPanel extends Panel. I’m not sure
I’m at liberty to post SuperPanel’s source, but if you can’t reproduce the
problem with the non-custom controls then I could work on it maybe next week.
[1]
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fqr5i4&data=02%7C01%7Caharui%40adobe.com%7C678378365e9e4f2e08e708d7ccf2d6db%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637203215668587546&sdata=X7WUYeBWTI0s%2BpbDaNjQ2Ro%2BJI8aKPVhyaSfVQvXD7I%3D&reserved=0
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Monday, March 16, 2020 6:24 PM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing
widthChanged/heightChanged/sizeChanged event rules
There was a change made to mx:Panel to not run as many layouts.
What does the MXML for the broken mx:Panel look like? I probably missed a case.
-Alex
On 3/16/20, 1:57 AM, "Yishay Weiss" wrote:
I won’t have time to investigate it today. Rolling back to
d3e27d65344ad27912000e1e3205b96243d8828e
fixes it.
From: Yishay Weiss<mailto:yishayj...@hotmail.com>
Sent: Monday, March 16, 2020 10:09 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: RE: Layouts: Changing
widthChanged/heightChanged/sizeChanged event rules
MX|Panel
From: Yishay Weiss
Sent: Monday, March 16, 2020 10:08:49 AM
To: dev@royale.apache.org
Subject: RE: Layouts: Changing
widthChanged/heightChanged/sizeChanged event rules
I’ve just updated Royale and am seeing weird behavior in Panel
layout. The content is taking up all the space and obliterating the title and
the rest of the chrome elements. Not sure if it’s related to these changes.
Will try to isolate it.
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Saturday, March 14, 2020 7:12 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Layouts: Changing
widthChanged/heightChanged/sizeChanged event rules
Hi,
I am wanting to change the way UIBase setWidthAndHeight
dispatches its events to cut down on the number of layout passes.
Right now, if you change both the width and height of a
component, you get 3 events (widthChanged, heightChanged, sizeChanged). I want
to change that so that you only get sizeChanged. This change would cause the
"meaning" of widthChanged to mean that only the width changed during a resize
so you can optimize some of the layout code and similar for heightChanged.
And thus, you will only ever get one event out of setWidthAndHeight, it will
either be:
- "widthChanged" meaning that only the width has changed
- "heightChanged" meaning t
RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
It’s the same code [1] as below.
[1] https://paste.apache.org/qr5i4
From: Yishay Weiss<mailto:yishayj...@hotmail.com>
Sent: Friday, March 20, 2020 11:08 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
With percentages. With fixed dimensions it does work.
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Wednesday, March 18, 2020 6:50 PM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
How is the width/height set on the ADG?
-Alex
On 3/18/20, 12:23 AM, "Yishay Weiss" wrote:
Panel looks fixed, thanks. My ADG is suddenly not showing any data though.
I’ll need to investigate that later…
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Tuesday, March 17, 2020 9:32 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
Try with my latest commit.
On 3/16/20, 11:21 PM, "Yishay Weiss" wrote:
Mxml looks like this [1]. SuperPanel extends Panel. I’m not sure I’m at
liberty to post SuperPanel’s source, but if you can’t reproduce the problem
with the non-custom controls then I could work on it maybe next week.
[1]
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fqr5i4&data=02%7C01%7Caharui%40adobe.com%7C12cc4d5e156f405db6b508d7cb0d44a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637201130157695217&sdata=eQp6bUABX6f%2Fr66%2FhE%2BvAww0Ey5I56ueipo2fbLAZU8%3D&reserved=0
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Monday, March 16, 2020 6:24 PM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged
event rules
There was a change made to mx:Panel to not run as many layouts. What
does the MXML for the broken mx:Panel look like? I probably missed a case.
-Alex
On 3/16/20, 1:57 AM, "Yishay Weiss" wrote:
I won’t have time to investigate it today. Rolling back to
d3e27d65344ad27912000e1e3205b96243d8828e
fixes it.
From: Yishay Weiss<mailto:yishayj...@hotmail.com>
Sent: Monday, March 16, 2020 10:09 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: RE: Layouts: Changing
widthChanged/heightChanged/sizeChanged event rules
MX|Panel
From: Yishay Weiss
Sent: Monday, March 16, 2020 10:08:49 AM
To: dev@royale.apache.org
Subject: RE: Layouts: Changing
widthChanged/heightChanged/sizeChanged event rules
I’ve just updated Royale and am seeing weird behavior in Panel
layout. The content is taking up all the space and obliterating the title and
the rest of the chrome elements. Not sure if it’s related to these changes.
Will try to isolate it.
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Saturday, March 14, 2020 7:12 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Layouts: Changing widthChanged/heightChanged/sizeChanged
event rules
Hi,
I am wanting to change the way UIBase setWidthAndHeight dispatches
its events to cut down on the number of layout passes.
Right now, if you change both the width and height of a component,
you get 3 events (widthChanged, heightChanged, sizeChanged). I want to change
that so that you only get sizeChanged. This change would cause the "meaning"
of widthChanged to mean that only the width changed during a resize so you can
optimize some of the layout code and similar for heightChanged. And thus, you
will only ever get one event out of setWidthAndHeight, it will either be:
- "widthChanged" meaning that only the width has changed
- "heightChanged" meaning that only the height has changed
- "sizeChanged" meaning that both width and height have changed
Does anyone know of any code that would break if we made this
change? Everywhere I look, code listens to all 3 and does not react
differently so sometimes lays out 3 times, often once before the height has
changed.
Thoughts?
-Alex
RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
With percentages. With fixed dimensions it does work.
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Wednesday, March 18, 2020 6:50 PM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
How is the width/height set on the ADG?
-Alex
On 3/18/20, 12:23 AM, "Yishay Weiss" wrote:
Panel looks fixed, thanks. My ADG is suddenly not showing any data though.
I’ll need to investigate that later…
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Tuesday, March 17, 2020 9:32 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
Try with my latest commit.
On 3/16/20, 11:21 PM, "Yishay Weiss" wrote:
Mxml looks like this [1]. SuperPanel extends Panel. I’m not sure I’m at
liberty to post SuperPanel’s source, but if you can’t reproduce the problem
with the non-custom controls then I could work on it maybe next week.
[1]
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fqr5i4&data=02%7C01%7Caharui%40adobe.com%7C12cc4d5e156f405db6b508d7cb0d44a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637201130157695217&sdata=eQp6bUABX6f%2Fr66%2FhE%2BvAww0Ey5I56ueipo2fbLAZU8%3D&reserved=0
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Monday, March 16, 2020 6:24 PM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged
event rules
There was a change made to mx:Panel to not run as many layouts. What
does the MXML for the broken mx:Panel look like? I probably missed a case.
-Alex
On 3/16/20, 1:57 AM, "Yishay Weiss" wrote:
I won’t have time to investigate it today. Rolling back to
d3e27d65344ad27912000e1e3205b96243d8828e
fixes it.
From: Yishay Weiss<mailto:yishayj...@hotmail.com>
Sent: Monday, March 16, 2020 10:09 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: RE: Layouts: Changing
widthChanged/heightChanged/sizeChanged event rules
MX|Panel
From: Yishay Weiss
Sent: Monday, March 16, 2020 10:08:49 AM
To: dev@royale.apache.org
Subject: RE: Layouts: Changing
widthChanged/heightChanged/sizeChanged event rules
I’ve just updated Royale and am seeing weird behavior in Panel
layout. The content is taking up all the space and obliterating the title and
the rest of the chrome elements. Not sure if it’s related to these changes.
Will try to isolate it.
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Saturday, March 14, 2020 7:12 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Layouts: Changing widthChanged/heightChanged/sizeChanged
event rules
Hi,
I am wanting to change the way UIBase setWidthAndHeight dispatches
its events to cut down on the number of layout passes.
Right now, if you change both the width and height of a component,
you get 3 events (widthChanged, heightChanged, sizeChanged). I want to change
that so that you only get sizeChanged. This change would cause the "meaning"
of widthChanged to mean that only the width changed during a resize so you can
optimize some of the layout code and similar for heightChanged. And thus, you
will only ever get one event out of setWidthAndHeight, it will either be:
- "widthChanged" meaning that only the width has changed
- "heightChanged" meaning that only the height has changed
- "sizeChanged" meaning that both width and height have changed
Does anyone know of any code that would break if we made this
change? Everywhere I look, code listens to all 3 and does not react
differently so sometimes lays out 3 times, often once before the height has
changed.
Thoughts?
-Alex
Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
How is the width/height set on the ADG?
-Alex
On 3/18/20, 12:23 AM, "Yishay Weiss" wrote:
Panel looks fixed, thanks. My ADG is suddenly not showing any data though.
I’ll need to investigate that later…
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Tuesday, March 17, 2020 9:32 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
Try with my latest commit.
On 3/16/20, 11:21 PM, "Yishay Weiss" wrote:
Mxml looks like this [1]. SuperPanel extends Panel. I’m not sure I’m at
liberty to post SuperPanel’s source, but if you can’t reproduce the problem
with the non-custom controls then I could work on it maybe next week.
[1]
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fqr5i4&data=02%7C01%7Caharui%40adobe.com%7C12cc4d5e156f405db6b508d7cb0d44a2%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637201130157695217&sdata=eQp6bUABX6f%2Fr66%2FhE%2BvAww0Ey5I56ueipo2fbLAZU8%3D&reserved=0
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Monday, March 16, 2020 6:24 PM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged
event rules
There was a change made to mx:Panel to not run as many layouts. What
does the MXML for the broken mx:Panel look like? I probably missed a case.
-Alex
On 3/16/20, 1:57 AM, "Yishay Weiss" wrote:
I won’t have time to investigate it today. Rolling back to
d3e27d65344ad27912000e1e3205b96243d8828e
fixes it.
From: Yishay Weiss<mailto:yishayj...@hotmail.com>
Sent: Monday, March 16, 2020 10:09 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: RE: Layouts: Changing
widthChanged/heightChanged/sizeChanged event rules
MX|Panel
From: Yishay Weiss
Sent: Monday, March 16, 2020 10:08:49 AM
To: dev@royale.apache.org
Subject: RE: Layouts: Changing
widthChanged/heightChanged/sizeChanged event rules
I’ve just updated Royale and am seeing weird behavior in Panel
layout. The content is taking up all the space and obliterating the title and
the rest of the chrome elements. Not sure if it’s related to these changes.
Will try to isolate it.
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Saturday, March 14, 2020 7:12 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Layouts: Changing widthChanged/heightChanged/sizeChanged
event rules
Hi,
I am wanting to change the way UIBase setWidthAndHeight dispatches
its events to cut down on the number of layout passes.
Right now, if you change both the width and height of a component,
you get 3 events (widthChanged, heightChanged, sizeChanged). I want to change
that so that you only get sizeChanged. This change would cause the "meaning"
of widthChanged to mean that only the width changed during a resize so you can
optimize some of the layout code and similar for heightChanged. And thus, you
will only ever get one event out of setWidthAndHeight, it will either be:
- "widthChanged" meaning that only the width has changed
- "heightChanged" meaning that only the height has changed
- "sizeChanged" meaning that both width and height have changed
Does anyone know of any code that would break if we made this
change? Everywhere I look, code listens to all 3 and does not react
differently so sometimes lays out 3 times, often once before the height has
changed.
Thoughts?
-Alex
Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
Yishay, In my case, I added width and height in : > Panel looks fixed, thanks. My ADG is suddenly not showing any data though. > I’ll need to investigate that later… > > From: Alex Harui<mailto:aha...@adobe.com.INVALID> > Sent: Tuesday, March 17, 2020 9:32 AM > To: dev@royale.apache.org<mailto:dev@royale.apache.org> > Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged > event rules > > Try with my latest commit. > > On 3/16/20, 11:21 PM, "Yishay Weiss" wrote: > > Mxml looks like this [1]. SuperPanel extends Panel. I’m not sure I’m > at liberty to post SuperPanel’s source, but if you can’t reproduce the > problem with the non-custom controls then I could work on it maybe next > week. > > [1] > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fqr5i4&data=02%7C01%7Caharui%40adobe.com%7C6d6282ad2e8e4d5edd3708d7ca3b75d4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637200229041858023&sdata=HLLC5Ula130rXXtxnzU0oywPc1USYtO2mYnUwwwWY%2Fk%3D&reserved=0 > > From: Alex Harui<mailto:aha...@adobe.com.INVALID> > Sent: Monday, March 16, 2020 6:24 PM > To: dev@royale.apache.org<mailto:dev@royale.apache.org> > Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged > event rules > > There was a change made to mx:Panel to not run as many layouts. What > does the MXML for the broken mx:Panel look like? I probably missed a case. > > -Alex > > On 3/16/20, 1:57 AM, "Yishay Weiss" wrote: > > I won’t have time to investigate it today. Rolling back to > d3e27d65344ad27912000e1e3205b96243d8828e > fixes it. > > From: Yishay Weiss<mailto:yishayj...@hotmail.com> > Sent: Monday, March 16, 2020 10:09 AM > To: dev@royale.apache.org<mailto:dev@royale.apache.org> > Subject: RE: Layouts: Changing > widthChanged/heightChanged/sizeChanged event rules > > MX|Panel > > ____________ > From: Yishay Weiss > Sent: Monday, March 16, 2020 10:08:49 AM > To: dev@royale.apache.org > Subject: RE: Layouts: Changing > widthChanged/heightChanged/sizeChanged event rules > > > I’ve just updated Royale and am seeing weird behavior in Panel > layout. The content is taking up all the space and obliterating the title > and the rest of the chrome elements. Not sure if it’s related to these > changes. Will try to isolate it. > > > > From: Alex Harui<mailto:aha...@adobe.com.INVALID> > Sent: Saturday, March 14, 2020 7:12 AM > To: dev@royale.apache.org<mailto:dev@royale.apache.org> > Subject: Layouts: Changing widthChanged/heightChanged/sizeChanged > event rules > > > > Hi, > > I am wanting to change the way UIBase setWidthAndHeight dispatches > its events to cut down on the number of layout passes. > > Right now, if you change both the width and height of a component, > you get 3 events (widthChanged, heightChanged, sizeChanged). I want to > change that so that you only get sizeChanged. This change would cause the > "meaning" of widthChanged to mean that only the width changed during a > resize so you can optimize some of the layout code and similar for > heightChanged. And thus, you will only ever get one event out of > setWidthAndHeight, it will either be: > > - "widthChanged" meaning that only the width has changed > - "heightChanged" meaning that only the height has changed > - "sizeChanged" meaning that both width and height have changed > > Does anyone know of any code that would break if we made this > change? Everywhere I look, code listens to all 3 and does not react > differently so sometimes lays out 3 times, often once before the height has > changed. > > Thoughts? > -Alex > > > > > > > -- Shoichiro Takeshita 武下 祥一郎
RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
Panel looks fixed, thanks. My ADG is suddenly not showing any data though. I’ll
need to investigate that later…
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Tuesday, March 17, 2020 9:32 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
Try with my latest commit.
On 3/16/20, 11:21 PM, "Yishay Weiss" wrote:
Mxml looks like this [1]. SuperPanel extends Panel. I’m not sure I’m at
liberty to post SuperPanel’s source, but if you can’t reproduce the problem
with the non-custom controls then I could work on it maybe next week.
[1]
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fqr5i4&data=02%7C01%7Caharui%40adobe.com%7C6d6282ad2e8e4d5edd3708d7ca3b75d4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637200229041858023&sdata=HLLC5Ula130rXXtxnzU0oywPc1USYtO2mYnUwwwWY%2Fk%3D&reserved=0
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Monday, March 16, 2020 6:24 PM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
There was a change made to mx:Panel to not run as many layouts. What does
the MXML for the broken mx:Panel look like? I probably missed a case.
-Alex
On 3/16/20, 1:57 AM, "Yishay Weiss" wrote:
I won’t have time to investigate it today. Rolling back to
d3e27d65344ad27912000e1e3205b96243d8828e
fixes it.
From: Yishay Weiss<mailto:yishayj...@hotmail.com>
Sent: Monday, March 16, 2020 10:09 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: RE: Layouts: Changing widthChanged/heightChanged/sizeChanged
event rules
MX|Panel
From: Yishay Weiss
Sent: Monday, March 16, 2020 10:08:49 AM
To: dev@royale.apache.org
Subject: RE: Layouts: Changing widthChanged/heightChanged/sizeChanged
event rules
I’ve just updated Royale and am seeing weird behavior in Panel layout.
The content is taking up all the space and obliterating the title and the rest
of the chrome elements. Not sure if it’s related to these changes. Will try to
isolate it.
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Saturday, March 14, 2020 7:12 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
Hi,
I am wanting to change the way UIBase setWidthAndHeight dispatches its
events to cut down on the number of layout passes.
Right now, if you change both the width and height of a component, you
get 3 events (widthChanged, heightChanged, sizeChanged). I want to change that
so that you only get sizeChanged. This change would cause the "meaning" of
widthChanged to mean that only the width changed during a resize so you can
optimize some of the layout code and similar for heightChanged. And thus, you
will only ever get one event out of setWidthAndHeight, it will either be:
- "widthChanged" meaning that only the width has changed
- "heightChanged" meaning that only the height has changed
- "sizeChanged" meaning that both width and height have changed
Does anyone know of any code that would break if we made this change?
Everywhere I look, code listens to all 3 and does not react differently so
sometimes lays out 3 times, often once before the height has changed.
Thoughts?
-Alex
Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
Try with my latest commit.
On 3/16/20, 11:21 PM, "Yishay Weiss" wrote:
Mxml looks like this [1]. SuperPanel extends Panel. I’m not sure I’m at
liberty to post SuperPanel’s source, but if you can’t reproduce the problem
with the non-custom controls then I could work on it maybe next week.
[1]
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fqr5i4&data=02%7C01%7Caharui%40adobe.com%7C6d6282ad2e8e4d5edd3708d7ca3b75d4%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637200229041858023&sdata=HLLC5Ula130rXXtxnzU0oywPc1USYtO2mYnUwwwWY%2Fk%3D&reserved=0
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Monday, March 16, 2020 6:24 PM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
There was a change made to mx:Panel to not run as many layouts. What does
the MXML for the broken mx:Panel look like? I probably missed a case.
-Alex
On 3/16/20, 1:57 AM, "Yishay Weiss" wrote:
I won’t have time to investigate it today. Rolling back to
d3e27d65344ad27912000e1e3205b96243d8828e
fixes it.
From: Yishay Weiss<mailto:yishayj...@hotmail.com>
Sent: Monday, March 16, 2020 10:09 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: RE: Layouts: Changing widthChanged/heightChanged/sizeChanged
event rules
MX|Panel
From: Yishay Weiss
Sent: Monday, March 16, 2020 10:08:49 AM
To: dev@royale.apache.org
Subject: RE: Layouts: Changing widthChanged/heightChanged/sizeChanged
event rules
I’ve just updated Royale and am seeing weird behavior in Panel layout.
The content is taking up all the space and obliterating the title and the rest
of the chrome elements. Not sure if it’s related to these changes. Will try to
isolate it.
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Saturday, March 14, 2020 7:12 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
Hi,
I am wanting to change the way UIBase setWidthAndHeight dispatches its
events to cut down on the number of layout passes.
Right now, if you change both the width and height of a component, you
get 3 events (widthChanged, heightChanged, sizeChanged). I want to change that
so that you only get sizeChanged. This change would cause the "meaning" of
widthChanged to mean that only the width changed during a resize so you can
optimize some of the layout code and similar for heightChanged. And thus, you
will only ever get one event out of setWidthAndHeight, it will either be:
- "widthChanged" meaning that only the width has changed
- "heightChanged" meaning that only the height has changed
- "sizeChanged" meaning that both width and height have changed
Does anyone know of any code that would break if we made this change?
Everywhere I look, code listens to all 3 and does not react differently so
sometimes lays out 3 times, often once before the height has changed.
Thoughts?
-Alex
RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
Mxml looks like this [1]. SuperPanel extends Panel. I’m not sure I’m at liberty
to post SuperPanel’s source, but if you can’t reproduce the problem with the
non-custom controls then I could work on it maybe next week.
[1] https://paste.apache.org/qr5i4
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Monday, March 16, 2020 6:24 PM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
There was a change made to mx:Panel to not run as many layouts. What does the
MXML for the broken mx:Panel look like? I probably missed a case.
-Alex
On 3/16/20, 1:57 AM, "Yishay Weiss" wrote:
I won’t have time to investigate it today. Rolling back to
d3e27d65344ad27912000e1e3205b96243d8828e
fixes it.
From: Yishay Weiss<mailto:yishayj...@hotmail.com>
Sent: Monday, March 16, 2020 10:09 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
MX|Panel
From: Yishay Weiss
Sent: Monday, March 16, 2020 10:08:49 AM
To: dev@royale.apache.org
Subject: RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
I’ve just updated Royale and am seeing weird behavior in Panel layout. The
content is taking up all the space and obliterating the title and the rest of
the chrome elements. Not sure if it’s related to these changes. Will try to
isolate it.
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Saturday, March 14, 2020 7:12 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
Hi,
I am wanting to change the way UIBase setWidthAndHeight dispatches its
events to cut down on the number of layout passes.
Right now, if you change both the width and height of a component, you get
3 events (widthChanged, heightChanged, sizeChanged). I want to change that so
that you only get sizeChanged. This change would cause the "meaning" of
widthChanged to mean that only the width changed during a resize so you can
optimize some of the layout code and similar for heightChanged. And thus, you
will only ever get one event out of setWidthAndHeight, it will either be:
- "widthChanged" meaning that only the width has changed
- "heightChanged" meaning that only the height has changed
- "sizeChanged" meaning that both width and height have changed
Does anyone know of any code that would break if we made this change?
Everywhere I look, code listens to all 3 and does not react differently so
sometimes lays out 3 times, often once before the height has changed.
Thoughts?
-Alex
Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
There was a change made to mx:Panel to not run as many layouts. What does the
MXML for the broken mx:Panel look like? I probably missed a case.
-Alex
On 3/16/20, 1:57 AM, "Yishay Weiss" wrote:
I won’t have time to investigate it today. Rolling back to
d3e27d65344ad27912000e1e3205b96243d8828e
fixes it.
From: Yishay Weiss<mailto:yishayj...@hotmail.com>
Sent: Monday, March 16, 2020 10:09 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
MX|Panel
From: Yishay Weiss
Sent: Monday, March 16, 2020 10:08:49 AM
To: dev@royale.apache.org
Subject: RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
I’ve just updated Royale and am seeing weird behavior in Panel layout. The
content is taking up all the space and obliterating the title and the rest of
the chrome elements. Not sure if it’s related to these changes. Will try to
isolate it.
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Saturday, March 14, 2020 7:12 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
Hi,
I am wanting to change the way UIBase setWidthAndHeight dispatches its
events to cut down on the number of layout passes.
Right now, if you change both the width and height of a component, you get
3 events (widthChanged, heightChanged, sizeChanged). I want to change that so
that you only get sizeChanged. This change would cause the "meaning" of
widthChanged to mean that only the width changed during a resize so you can
optimize some of the layout code and similar for heightChanged. And thus, you
will only ever get one event out of setWidthAndHeight, it will either be:
- "widthChanged" meaning that only the width has changed
- "heightChanged" meaning that only the height has changed
- "sizeChanged" meaning that both width and height have changed
Does anyone know of any code that would break if we made this change?
Everywhere I look, code listens to all 3 and does not react differently so
sometimes lays out 3 times, often once before the height has changed.
Thoughts?
-Alex
RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
I won’t have time to investigate it today. Rolling back to d3e27d65344ad27912000e1e3205b96243d8828e fixes it. From: Yishay Weiss<mailto:yishayj...@hotmail.com> Sent: Monday, March 16, 2020 10:09 AM To: dev@royale.apache.org<mailto:dev@royale.apache.org> Subject: RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules MX|Panel From: Yishay Weiss Sent: Monday, March 16, 2020 10:08:49 AM To: dev@royale.apache.org Subject: RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules I’ve just updated Royale and am seeing weird behavior in Panel layout. The content is taking up all the space and obliterating the title and the rest of the chrome elements. Not sure if it’s related to these changes. Will try to isolate it. From: Alex Harui<mailto:aha...@adobe.com.INVALID> Sent: Saturday, March 14, 2020 7:12 AM To: dev@royale.apache.org<mailto:dev@royale.apache.org> Subject: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules Hi, I am wanting to change the way UIBase setWidthAndHeight dispatches its events to cut down on the number of layout passes. Right now, if you change both the width and height of a component, you get 3 events (widthChanged, heightChanged, sizeChanged). I want to change that so that you only get sizeChanged. This change would cause the "meaning" of widthChanged to mean that only the width changed during a resize so you can optimize some of the layout code and similar for heightChanged. And thus, you will only ever get one event out of setWidthAndHeight, it will either be: - "widthChanged" meaning that only the width has changed - "heightChanged" meaning that only the height has changed - "sizeChanged" meaning that both width and height have changed Does anyone know of any code that would break if we made this change? Everywhere I look, code listens to all 3 and does not react differently so sometimes lays out 3 times, often once before the height has changed. Thoughts? -Alex
RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
MX|Panel From: Yishay Weiss Sent: Monday, March 16, 2020 10:08:49 AM To: dev@royale.apache.org Subject: RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules I’ve just updated Royale and am seeing weird behavior in Panel layout. The content is taking up all the space and obliterating the title and the rest of the chrome elements. Not sure if it’s related to these changes. Will try to isolate it. From: Alex Harui<mailto:aha...@adobe.com.INVALID> Sent: Saturday, March 14, 2020 7:12 AM To: dev@royale.apache.org<mailto:dev@royale.apache.org> Subject: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules Hi, I am wanting to change the way UIBase setWidthAndHeight dispatches its events to cut down on the number of layout passes. Right now, if you change both the width and height of a component, you get 3 events (widthChanged, heightChanged, sizeChanged). I want to change that so that you only get sizeChanged. This change would cause the "meaning" of widthChanged to mean that only the width changed during a resize so you can optimize some of the layout code and similar for heightChanged. And thus, you will only ever get one event out of setWidthAndHeight, it will either be: - "widthChanged" meaning that only the width has changed - "heightChanged" meaning that only the height has changed - "sizeChanged" meaning that both width and height have changed Does anyone know of any code that would break if we made this change? Everywhere I look, code listens to all 3 and does not react differently so sometimes lays out 3 times, often once before the height has changed. Thoughts? -Alex
RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
I’ve just updated Royale and am seeing weird behavior in Panel layout. The content is taking up all the space and obliterating the title and the rest of the chrome elements. Not sure if it’s related to these changes. Will try to isolate it. From: Alex Harui<mailto:aha...@adobe.com.INVALID> Sent: Saturday, March 14, 2020 7:12 AM To: dev@royale.apache.org<mailto:dev@royale.apache.org> Subject: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules Hi, I am wanting to change the way UIBase setWidthAndHeight dispatches its events to cut down on the number of layout passes. Right now, if you change both the width and height of a component, you get 3 events (widthChanged, heightChanged, sizeChanged). I want to change that so that you only get sizeChanged. This change would cause the "meaning" of widthChanged to mean that only the width changed during a resize so you can optimize some of the layout code and similar for heightChanged. And thus, you will only ever get one event out of setWidthAndHeight, it will either be: - "widthChanged" meaning that only the width has changed - "heightChanged" meaning that only the height has changed - "sizeChanged" meaning that both width and height have changed Does anyone know of any code that would break if we made this change? Everywhere I look, code listens to all 3 and does not react differently so sometimes lays out 3 times, often once before the height has changed. Thoughts? -Alex
Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
I pushed the changes. DG makes many fewer layout passes in Serkan's example.
-Alex
On 3/14/20, 5:55 AM, "Yishay Weiss" wrote:
Good idea. Pretty sure it won’t break anything in our apps.
From: Alex Harui<mailto:aha...@adobe.com.INVALID>
Sent: Saturday, March 14, 2020 7:12 AM
To: dev@royale.apache.org<mailto:dev@royale.apache.org>
Subject: Layouts: Changing widthChanged/heightChanged/sizeChanged event
rules
Hi,
I am wanting to change the way UIBase setWidthAndHeight dispatches its
events to cut down on the number of layout passes.
Right now, if you change both the width and height of a component, you get
3 events (widthChanged, heightChanged, sizeChanged). I want to change that so
that you only get sizeChanged. This change would cause the "meaning" of
widthChanged to mean that only the width changed during a resize so you can
optimize some of the layout code and similar for heightChanged. And thus, you
will only ever get one event out of setWidthAndHeight, it will either be:
- "widthChanged" meaning that only the width has changed
- "heightChanged" meaning that only the height has changed
- "sizeChanged" meaning that both width and height have changed
Does anyone know of any code that would break if we made this change?
Everywhere I look, code listens to all 3 and does not react differently so
sometimes lays out 3 times, often once before the height has changed.
Thoughts?
-Alex
Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
On 3/15/20, 2:59 AM, "Carlos Rovira" wrote: > > Maybe you can explain what 100% means for Jewel DG and what component > needed an actual number. > In Jewel DG, the build components are the same as in Basic, but we use flex to ease how it appears in screen (flex column to make header over listArea, then listArea uses Horizontal layout to layout columns. Then internal columns need to find the width measure via columnWidth values (that could be not set or set some). So width 100% means, that DG needs to get all the width available space and then if a column has collumnWidth, that column knows the exact pixels in width. But the rest must calculate how many pixels are left and give the proportion part to each of those columns left. The height algorithm seems to work right. The width algorithm is working for all cases except width set to a percentage. IMO, if you are using width=100% to mean what it means in CSS for just about everything else in Jewel, you may want to reconsider the API of DataGridColumn in Jewel. Otherwise, you will be struggling to catch the width setter and block it from being set on element.styles and then trying to compute actual numbers instead. That's how MXRoyale works, but MXRoyale does not use any other browser layout like display="flex" or even display="blocK" so it always computes sizes. MXRoyale does that because in Flex, width=100% did not mean what it means in CSS. In Flex it means 100% of the available space after other fixed sized children are accounted for, and then a relative scaling of there are other children with % such that the total of percentages > 100. IMO, you are not under any obligation to use % in the Flex way in only one component in Jewel. I would recommend that you add other APIs instead. Yeah, that will mean that folks used to Flex DG will stumble a bit when migrating, but I think anyone who chooses Jewel has given up on 100% backward compatibility to get a modern UI and have touched their old UI in many places already or tossed the old UI and are starting over. So, DGColumn APIs that more directly map to CSS FlexBox relative weighting might be best. It is relatively well-documented on the internet and using the browser to lay it out will perform better. My 2 cents, -Alex
Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
Hi Alex, El dom., 15 mar. 2020 a las 2:11, Alex Harui () escribió: > HI Carlos, > > You might be describing a different problem than I originally thought. > > Besides the issue of sizedToContent vs "sized by parent", there is > separate problem where, early in the lifecycle of some components, you > can't get the browser to tell you the width/height of the component. I 'd like to have some infrastructure for that, maybe I could try to have in Jewel, since I think is important (maybe StyledUIBase or StyledLayoutBase), so I can ensure we have needed things consistently cross components. > I see some other uses of requestAnimationFrame in the Royale code. It > may be that someone handled a similar problem the same way. I'd be afraid > that with a timer/frame the user might see the UI for a split second in its > ugly form then snap into place. I've been lucky enough to find other > solutions, but I'm not going to guarantee there is always some other > solution. > I think requestAnimationFrame is the best way to go, since from what I experimented, each browser has different timings so while setting sufficient time out to cover all vendors, seems nothing is as performant as rAF calls since make you run the needed code as soon as you have the requisites available. > > Regarding your topics, I'm not sure we can guarantee only one way of > dealing with children. It really should be up to the component set. In a > truly basic app, there shouldn't need to be any visiting of children by the > layouts. It really should just be creating HTMLElements, setting > attributes including display="flex", etc. It shouldn't require other code. > Right, don't think Basic will needed. Although see that in fact Basic is sending more events for sizing childs than Jewel at this moment. In fact Jewel got that recently due to deal with the problems stated in this thread. While that should be real for Basic, we need to cover things in the sets that will be really used (MXRoyale and Jewel), with clear patterns so people can make a component reading the basis in some docs. I think we need to explore the better way, so others does not have to do such research and just go a concrete way of doing things that ensure they get the work done. > But other component sets might, and MXRoyale for visits every child and > uses sizeChanged. I would think sizeChanged would be best for most > component sets, but maybe layoutNeeded will work. layoutNeeded is > primarily intended for the beads to talk to a layout in the same > components. It is occasionally used to kick off a layout in some other > component based on an event. It might be that some other event gets sent > to each child to say "hey, you should now have a valid size". > both events could do mostly the same, and could cause things be done twice. I see that sizeChanged should work when people change w or h, and maybe that should change some measure things. But layout call use to use w and has well to do the layout things. So both seems very coupled and its difficult for me to think they could work isolated. Seems both are related to each other and should run the same code each time component signal any of those events. > > It probably depends on what width="100%" means in your app/component set. > In MXRoyale, it does not mean what it would in CSS so the styles.width is > not set to 100% and the old Flex layout runs and assigns a number instead. > And thus sizeChanged is sent. > In Jewel: * CSS: tries to define most of the things. CSS rules define behaviors and AS code assign that rules when needed. So if a layout is "horizontal" and "variableRowHeight", it should get className="layout horizontal variableRowHeight", if then they get a gap, then adds up a gap rule as well, if gets a Viewport with scrolling, then get "viewport scroll"... * Sizes:, I don't try to impose w o h, in Royale. But CSS can set some w or h. That means that Royale could not set w or h, but CSS could do that. So I'm trying to work from "non defaults" sizes (no w or h), that mean that a Jewel List without width or height will render as a dot in screen (almost invisible in the screen), but SimpleButton (that is Button without Text), will render some width/height due to paddings applied. For pixel width, I think there's no problem and all is ok. The real problem is when we define % w or h. Since we need to wait for real measure. That's use to happen at some time that could be get with the rAF hack I did. Maybe that hack is right, but just need to be set in a place that makes its use more "part of the framework" or even send some framework event to signal "you as a user will get the w or h that you expect". > > Maybe you can explain what 100% means for Jewel DG and what component > needed an actual number. > In Jewel DG, the build components are the same as in Basic, but we use flex to ease how it appears in screen (flex column to make header over listArea, then listArea uses Horizontal layout t
Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
HI Carlos, You might be describing a different problem than I originally thought. Besides the issue of sizedToContent vs "sized by parent", there is separate problem where, early in the lifecycle of some components, you can't get the browser to tell you the width/height of the component. I see some other uses of requestAnimationFrame in the Royale code. It may be that someone handled a similar problem the same way. I'd be afraid that with a timer/frame the user might see the UI for a split second in its ugly form then snap into place. I've been lucky enough to find other solutions, but I'm not going to guarantee there is always some other solution. Regarding your topics, I'm not sure we can guarantee only one way of dealing with children. It really should be up to the component set. In a truly basic app, there shouldn't need to be any visiting of children by the layouts. It really should just be creating HTMLElements, setting attributes including display="flex", etc. It shouldn't require other code. But other component sets might, and MXRoyale for visits every child and uses sizeChanged. I would think sizeChanged would be best for most component sets, but maybe layoutNeeded will work. layoutNeeded is primarily intended for the beads to talk to a layout in the same components. It is occasionally used to kick off a layout in some other component based on an event. It might be that some other event gets sent to each child to say "hey, you should now have a valid size". It probably depends on what width="100%" means in your app/component set. In MXRoyale, it does not mean what it would in CSS so the styles.width is not set to 100% and the old Flex layout runs and assigns a number instead. And thus sizeChanged is sent. Maybe you can explain what 100% means for Jewel DG and what component needed an actual number. HTH, -Alex On 3/14/20, 4:57 PM, "Carlos Rovira" wrote: Hi Alex, I did some research already during last weeks a spend many hours trying things. Some things I did: 1.- Layouts (for now the 4 horizontal and vertical main layouts) that are the most used, since are in Cards, HGroup, VGroup,..., loop over the childs and send "layoutNeeded" event. (In the second DG TDJ example I put an slider to change the card height, and the inner DG with height="100%" works as expected, but all thanks to the "requestAnimationFrame" loop that waits for the height. For this to work you need to set the parent Card height to some concrete pixel height. Then DG can be height="100%" I would want to make this work removing the "requestAnimationFrame" hack. 2.- I think the same could be applied to width="100%" as well based on the loop hack from 1.- and setting parent Card width to a fixed width. 3.- Maybe nesting some containers with the first to fixed h or w, but the rest chain of components to 100%, could not work. Still untested. 4.- After the recent email from Piotr in the other Jewel DG thread, I think we need some convention on how to operate always with the two main events: * sizeChanged * layoutNeeded We should have clear a metodology for all components (Card, HGroup, DataGrid,...whatever). Should we layouts dispatch layoutNeeded on childs? or instead "sizeChanged"? or both? I think this is important If we make some algorithm that make us "industrialize" how we should implement always the same, I think that would be what all want. 5.- To get proper width and height (real pixels) if we have percentage w o h: Maybe we should implement some internal code that ensure this at UIBase (or even up in the hierarchy), or in LayoutBase. At the end we need to ease those values to the user when "layout()" (in a component's layout ) run. IOW, if we do at the start of the layout method ´trace(host.width)", we should get the right value, no matter if they are using pixel or percent values. Let me know if you agree with these exposed points. Thanks Carlos El sáb., 14 mar. 2020 a las 17:46, Alex Harui () escribió: > Hi Carlos, > > I've been looking at the number of times the AdvancedDataGrid gets layed > out in an example from Serkan. That helped me propose this event change. > > I see a few other things as well. As I mentioned on some thread recently, > the view and layout have to consider several scenarios: > > 1) sized to content > 2) sized by parent > > And for ADG: > 3) no data provider > 4) empty data provider > 5) data provider set later (usually by server results) > > And probably some more. I'm still looking into it. I don't have a > proposal yet, but my first thought was that the View should be responsible > for the intelligence that blocks layout passes until the last pos
Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
Hi Alex, I did some research already during last weeks a spend many hours trying things. Some things I did: 1.- Layouts (for now the 4 horizontal and vertical main layouts) that are the most used, since are in Cards, HGroup, VGroup,..., loop over the childs and send "layoutNeeded" event. (In the second DG TDJ example I put an slider to change the card height, and the inner DG with height="100%" works as expected, but all thanks to the "requestAnimationFrame" loop that waits for the height. For this to work you need to set the parent Card height to some concrete pixel height. Then DG can be height="100%" I would want to make this work removing the "requestAnimationFrame" hack. 2.- I think the same could be applied to width="100%" as well based on the loop hack from 1.- and setting parent Card width to a fixed width. 3.- Maybe nesting some containers with the first to fixed h or w, but the rest chain of components to 100%, could not work. Still untested. 4.- After the recent email from Piotr in the other Jewel DG thread, I think we need some convention on how to operate always with the two main events: * sizeChanged * layoutNeeded We should have clear a metodology for all components (Card, HGroup, DataGrid,...whatever). Should we layouts dispatch layoutNeeded on childs? or instead "sizeChanged"? or both? I think this is important If we make some algorithm that make us "industrialize" how we should implement always the same, I think that would be what all want. 5.- To get proper width and height (real pixels) if we have percentage w o h: Maybe we should implement some internal code that ensure this at UIBase (or even up in the hierarchy), or in LayoutBase. At the end we need to ease those values to the user when "layout()" (in a component's layout ) run. IOW, if we do at the start of the layout method ´trace(host.width)", we should get the right value, no matter if they are using pixel or percent values. Let me know if you agree with these exposed points. Thanks Carlos El sáb., 14 mar. 2020 a las 17:46, Alex Harui () escribió: > Hi Carlos, > > I've been looking at the number of times the AdvancedDataGrid gets layed > out in an example from Serkan. That helped me propose this event change. > > I see a few other things as well. As I mentioned on some thread recently, > the view and layout have to consider several scenarios: > > 1) sized to content > 2) sized by parent > > And for ADG: > 3) no data provider > 4) empty data provider > 5) data provider set later (usually by server results) > > And probably some more. I'm still looking into it. I don't have a > proposal yet, but my first thought was that the View should be responsible > for the intelligence that blocks layout passes until the last possible > event. I think layouts are much more re-usable so they shouldn't carry > that logic. The View can determine, for example, that the component has a > percentage height/width and thus know that until there is a sizeChanged > event, skip all other attempts to layout. But as I mentioned elsewhere, > that may mean that some of our layouts will need to visit each child. This > already happens in the MXRoyale set because the MXRoyale code is running > old Flex layouts in absolute positioning because we want to override > browser layouts, but isn't true in Basic. Some layouts set display="flex" > and the browser does the work and there is no loop to visit each child to > send a sizeChanged event. > > Let's get through this event change first, and hopefully I'll have time to > further optimize ADG, and then I might have time to dig through the Jewel > DG. But if you have time to do the analysis yourself, I think you want to > try to understand the "why" for the various layout passes and see if you > can build in some intelligence around which passes are important in various > scenarios. > > HTH, > -Alex > > On 3/14/20, 3:40 AM, "Carlos Rovira" wrote: > > Hi Alex, > > don't know of code that would break, but I think that would be the > right > thing to do. So better fix to comply with that change. > > What I'm more concern is about getting the pixel width or height when > sizeChanged or layoutNeeded are thrown from layouts. > As I stated before in other thread I had some issues, and yesterday > Piotr > reported another issue in DataGrid when width="100%" (or any other > percentage). I could "hack" height using low level js > requestAnimationFrame, but don't know how to fix percentage width > problems. > > I don't find any way to make calculations in Royale to get the real > pixel > width value when a component has width set to some percentage value. > The > only way I'm seeing right now is to make some js low level hack with > calc(% > -px) in style.width. I think now that we have some infrastructure and > examples with Cards, HGroups/VGroups, and more, is a good time to have > some > easy way to get to the layout() method
Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
Hi Carlos, I've been looking at the number of times the AdvancedDataGrid gets layed out in an example from Serkan. That helped me propose this event change. I see a few other things as well. As I mentioned on some thread recently, the view and layout have to consider several scenarios: 1) sized to content 2) sized by parent And for ADG: 3) no data provider 4) empty data provider 5) data provider set later (usually by server results) And probably some more. I'm still looking into it. I don't have a proposal yet, but my first thought was that the View should be responsible for the intelligence that blocks layout passes until the last possible event. I think layouts are much more re-usable so they shouldn't carry that logic. The View can determine, for example, that the component has a percentage height/width and thus know that until there is a sizeChanged event, skip all other attempts to layout. But as I mentioned elsewhere, that may mean that some of our layouts will need to visit each child. This already happens in the MXRoyale set because the MXRoyale code is running old Flex layouts in absolute positioning because we want to override browser layouts, but isn't true in Basic. Some layouts set display="flex" and the browser does the work and there is no loop to visit each child to send a sizeChanged event. Let's get through this event change first, and hopefully I'll have time to further optimize ADG, and then I might have time to dig through the Jewel DG. But if you have time to do the analysis yourself, I think you want to try to understand the "why" for the various layout passes and see if you can build in some intelligence around which passes are important in various scenarios. HTH, -Alex On 3/14/20, 3:40 AM, "Carlos Rovira" wrote: Hi Alex, don't know of code that would break, but I think that would be the right thing to do. So better fix to comply with that change. What I'm more concern is about getting the pixel width or height when sizeChanged or layoutNeeded are thrown from layouts. As I stated before in other thread I had some issues, and yesterday Piotr reported another issue in DataGrid when width="100%" (or any other percentage). I could "hack" height using low level js requestAnimationFrame, but don't know how to fix percentage width problems. I don't find any way to make calculations in Royale to get the real pixel width value when a component has width set to some percentage value. The only way I'm seeing right now is to make some js low level hack with calc(% -px) in style.width. I think now that we have some infrastructure and examples with Cards, HGroups/VGroups, and more, is a good time to have some easy way to get to the layout() method (or other handler) and get directly width or height instead of 0 in the case we are using some % value. Now that I have to work on the fix for Piotr, what do you think about to take you a look and see that real case problem? Piotr committed yesterday that DataGrid example to TDJ. If you want we can work over it together and try what you think it could be a good option. Would be that possible? Thanks Carlos El sáb., 14 mar. 2020 a las 6:12, Alex Harui () escribió: > Hi, > > I am wanting to change the way UIBase setWidthAndHeight dispatches its > events to cut down on the number of layout passes. > > Right now, if you change both the width and height of a component, you get > 3 events (widthChanged, heightChanged, sizeChanged). I want to change that > so that you only get sizeChanged. This change would cause the "meaning" of > widthChanged to mean that only the width changed during a resize so you can > optimize some of the layout code and similar for heightChanged. And thus, > you will only ever get one event out of setWidthAndHeight, it will either > be: > > - "widthChanged" meaning that only the width has changed > - "heightChanged" meaning that only the height has changed > - "sizeChanged" meaning that both width and height have changed > > Does anyone know of any code that would break if we made this change? > Everywhere I look, code listens to all 3 and does not react differently so > sometimes lays out 3 times, often once before the height has changed. > > Thoughts? > -Alex > > -- Carlos Rovira https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cfa7e4b2f9a89428f2a8008d7c8042840%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637197792495218994&sdata=S05NKAMcGMjcdqZ5eQd81P7Sbb3NJB0TLkrysJS9b%2B8%3D&reserved=0
RE: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
Good idea. Pretty sure it won’t break anything in our apps. From: Alex Harui<mailto:aha...@adobe.com.INVALID> Sent: Saturday, March 14, 2020 7:12 AM To: dev@royale.apache.org<mailto:dev@royale.apache.org> Subject: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules Hi, I am wanting to change the way UIBase setWidthAndHeight dispatches its events to cut down on the number of layout passes. Right now, if you change both the width and height of a component, you get 3 events (widthChanged, heightChanged, sizeChanged). I want to change that so that you only get sizeChanged. This change would cause the "meaning" of widthChanged to mean that only the width changed during a resize so you can optimize some of the layout code and similar for heightChanged. And thus, you will only ever get one event out of setWidthAndHeight, it will either be: - "widthChanged" meaning that only the width has changed - "heightChanged" meaning that only the height has changed - "sizeChanged" meaning that both width and height have changed Does anyone know of any code that would break if we made this change? Everywhere I look, code listens to all 3 and does not react differently so sometimes lays out 3 times, often once before the height has changed. Thoughts? -Alex
Re: Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
Hi Alex, don't know of code that would break, but I think that would be the right thing to do. So better fix to comply with that change. What I'm more concern is about getting the pixel width or height when sizeChanged or layoutNeeded are thrown from layouts. As I stated before in other thread I had some issues, and yesterday Piotr reported another issue in DataGrid when width="100%" (or any other percentage). I could "hack" height using low level js requestAnimationFrame, but don't know how to fix percentage width problems. I don't find any way to make calculations in Royale to get the real pixel width value when a component has width set to some percentage value. The only way I'm seeing right now is to make some js low level hack with calc(% -px) in style.width. I think now that we have some infrastructure and examples with Cards, HGroups/VGroups, and more, is a good time to have some easy way to get to the layout() method (or other handler) and get directly width or height instead of 0 in the case we are using some % value. Now that I have to work on the fix for Piotr, what do you think about to take you a look and see that real case problem? Piotr committed yesterday that DataGrid example to TDJ. If you want we can work over it together and try what you think it could be a good option. Would be that possible? Thanks Carlos El sáb., 14 mar. 2020 a las 6:12, Alex Harui () escribió: > Hi, > > I am wanting to change the way UIBase setWidthAndHeight dispatches its > events to cut down on the number of layout passes. > > Right now, if you change both the width and height of a component, you get > 3 events (widthChanged, heightChanged, sizeChanged). I want to change that > so that you only get sizeChanged. This change would cause the "meaning" of > widthChanged to mean that only the width changed during a resize so you can > optimize some of the layout code and similar for heightChanged. And thus, > you will only ever get one event out of setWidthAndHeight, it will either > be: > > - "widthChanged" meaning that only the width has changed > - "heightChanged" meaning that only the height has changed > - "sizeChanged" meaning that both width and height have changed > > Does anyone know of any code that would break if we made this change? > Everywhere I look, code listens to all 3 and does not react differently so > sometimes lays out 3 times, often once before the height has changed. > > Thoughts? > -Alex > > -- Carlos Rovira http://about.me/carlosrovira
Layouts: Changing widthChanged/heightChanged/sizeChanged event rules
Hi, I am wanting to change the way UIBase setWidthAndHeight dispatches its events to cut down on the number of layout passes. Right now, if you change both the width and height of a component, you get 3 events (widthChanged, heightChanged, sizeChanged). I want to change that so that you only get sizeChanged. This change would cause the "meaning" of widthChanged to mean that only the width changed during a resize so you can optimize some of the layout code and similar for heightChanged. And thus, you will only ever get one event out of setWidthAndHeight, it will either be: - "widthChanged" meaning that only the width has changed - "heightChanged" meaning that only the height has changed - "sizeChanged" meaning that both width and height have changed Does anyone know of any code that would break if we made this change? Everywhere I look, code listens to all 3 and does not react differently so sometimes lays out 3 times, often once before the height has changed. Thoughts? -Alex
