Re: [royale-asjs] branch feature/new_merge updated: Added ignores
Very helpful, I'll have this into account from now on
thanks! :)
El mié., 5 sept. 2018 a las 20:21, Harbs () escribió:
> Not sure what you’re asking.
>
> Any function which has an as statement or function typecasting (i.e.
> _stand as IEventDispatcher or IEventDispatcher(_strand)) will output a
> Language.as call unless you add a @royaleignorecoercion comment with the
> fully classified class name.
>
> There’s also @royaleemitcoercion for cases where the “as” or typecast is
> important.
>
> So, if you do:
>
> var foo:Foo is baz as Foo;
> If(foo){// if the typecast failed we have null
> // do something
> }
>
> You’d want to make sure we have Language.as called and you’d use
> @royaleemitcoercion.
>
> In most cases, we’d want clean js code and you’d use @royaleignorecoercion.
>
> Is that helpful?
>
> Harbs
>
> > On Sep 5, 2018, at 8:15 PM, Carlos Rovira
> wrote:
> >
> > Hi Harbs,
> >
> > in order to add this comments myself, how do I need to have into account.
> > This part is still a bit obscure for me
> > thanks
> >
> > Carlos
> >
> >
> > El mié., 5 sept. 2018 a las 15:15, escribió:
> >
> >> This is an automated email from the ASF dual-hosted git repository.
> >>
> >> harbs pushed a commit to branch feature/new_merge
> >> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> >>
> >>
> >> The following commit(s) were added to refs/heads/feature/new_merge by
> this
> >> push:
> >> new 7b24e79 Added ignores
> >> 7b24e79 is described below
> >>
> >> commit 7b24e79964407e4e2093373ce51aaf32142e6927
> >> Author: Harbs
> >> AuthorDate: Wed Sep 5 16:15:20 2018 +0300
> >>
> >>Added ignores
> >> ---
> >> .../jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as |
> 2
> >> ++
> >> .../beads/itemRenderers/RemoveListItemRendererForArrayListData.as |
> 4
> >>
> >> 2 files changed, 6 insertions(+)
> >>
> >> diff --git
> >>
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as
> >>
> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as
> >> index 188dba2..36311b8 100644
> >> ---
> >>
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as
> >> +++
> >>
> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as
> >> @@ -122,6 +122,8 @@ package org.apache.royale.jewel.beads.itemRenderers
> >> * @playerversion Flash 10.2
> >> * @playerversion AIR 2.6
> >> * @productversion Royale 0.9.4
> >> +* @royaleignorecoercion
> >> org.apache.royale.core.ISelectableItemRenderer
> >> +* @royaleignorecoercion
> >> org.apache.royale.events.IEventDispatcher
> >> */
> >>protected function
> >> handleItemAdded(event:CollectionEvent):void
> >>{
> >> diff --git
> >>
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/RemoveListItemRendererForArrayListData.as
> >>
> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/RemoveListItemRendererForArrayListData.as
> >> index 98aa953..d591553 100644
> >> ---
> >>
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/RemoveListItemRendererForArrayListData.as
> >> +++
> >>
> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/RemoveListItemRendererForArrayListData.as
> >> @@ -114,6 +114,8 @@ package org.apache.royale.jewel.beads.itemRenderers
> >> * @playerversion Flash 10.2
> >> * @playerversion AIR 2.6
> >> * @productversion Royale 0.9.4
> >> +* @royaleignorecoercion
> >> org.apache.royale.core.ISelectableItemRenderer
> >> +* @royaleignorecoercion
> >> org.apache.royale.events.IEventDispatcher
> >> */
> >>protected function
> >> handleItemRemoved(event:CollectionEvent):void
> >>{
> >> @@ -141,6 +143,7 @@ package org.apache.royale.jewel.beads.itemRenderers
> >> * @playerversion Flash 10.2
> >> * @playerversion AIR 2.6
> >> * @productversion Royale 0.9.4
> >> +* @royaleignorecoercion
> >> org.apache.royale.core.IDataProviderModel
> >> */
> >>public function get dataProviderModel():
> IDataProviderModel
> >>{
> >> @@ -160,6 +163,7 @@ package org.apache.royale.jewel.beads.itemRenderers
> >> * @playerversion Flash 10.2
> >> * @playerversion AIR 2.6
> >> * @productversion Royale 0.9.4
> >> +* @royaleignorecoercion
> >> org.apache.royale.core.IStrandWithModelView
> >>
Re: [royale-asjs] branch feature/new_merge updated: Added ignores
Not sure what you’re asking.
Any function which has an as statement or function typecasting (i.e. _stand as
IEventDispatcher or IEventDispatcher(_strand)) will output a Language.as call
unless you add a @royaleignorecoercion comment with the fully classified class
name.
There’s also @royaleemitcoercion for cases where the “as” or typecast is
important.
So, if you do:
var foo:Foo is baz as Foo;
If(foo){// if the typecast failed we have null
// do something
}
You’d want to make sure we have Language.as called and you’d use
@royaleemitcoercion.
In most cases, we’d want clean js code and you’d use @royaleignorecoercion.
Is that helpful?
Harbs
> On Sep 5, 2018, at 8:15 PM, Carlos Rovira wrote:
>
> Hi Harbs,
>
> in order to add this comments myself, how do I need to have into account.
> This part is still a bit obscure for me
> thanks
>
> Carlos
>
>
> El mié., 5 sept. 2018 a las 15:15, escribió:
>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> harbs pushed a commit to branch feature/new_merge
>> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>>
>>
>> The following commit(s) were added to refs/heads/feature/new_merge by this
>> push:
>> new 7b24e79 Added ignores
>> 7b24e79 is described below
>>
>> commit 7b24e79964407e4e2093373ce51aaf32142e6927
>> Author: Harbs
>> AuthorDate: Wed Sep 5 16:15:20 2018 +0300
>>
>>Added ignores
>> ---
>> .../jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as | 2
>> ++
>> .../beads/itemRenderers/RemoveListItemRendererForArrayListData.as | 4
>>
>> 2 files changed, 6 insertions(+)
>>
>> diff --git
>> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as
>> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as
>> index 188dba2..36311b8 100644
>> ---
>> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as
>> +++
>> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as
>> @@ -122,6 +122,8 @@ package org.apache.royale.jewel.beads.itemRenderers
>> * @playerversion Flash 10.2
>> * @playerversion AIR 2.6
>> * @productversion Royale 0.9.4
>> +* @royaleignorecoercion
>> org.apache.royale.core.ISelectableItemRenderer
>> +* @royaleignorecoercion
>> org.apache.royale.events.IEventDispatcher
>> */
>>protected function
>> handleItemAdded(event:CollectionEvent):void
>>{
>> diff --git
>> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/RemoveListItemRendererForArrayListData.as
>> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/RemoveListItemRendererForArrayListData.as
>> index 98aa953..d591553 100644
>> ---
>> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/RemoveListItemRendererForArrayListData.as
>> +++
>> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/RemoveListItemRendererForArrayListData.as
>> @@ -114,6 +114,8 @@ package org.apache.royale.jewel.beads.itemRenderers
>> * @playerversion Flash 10.2
>> * @playerversion AIR 2.6
>> * @productversion Royale 0.9.4
>> +* @royaleignorecoercion
>> org.apache.royale.core.ISelectableItemRenderer
>> +* @royaleignorecoercion
>> org.apache.royale.events.IEventDispatcher
>> */
>>protected function
>> handleItemRemoved(event:CollectionEvent):void
>>{
>> @@ -141,6 +143,7 @@ package org.apache.royale.jewel.beads.itemRenderers
>> * @playerversion Flash 10.2
>> * @playerversion AIR 2.6
>> * @productversion Royale 0.9.4
>> +* @royaleignorecoercion
>> org.apache.royale.core.IDataProviderModel
>> */
>>public function get dataProviderModel(): IDataProviderModel
>>{
>> @@ -160,6 +163,7 @@ package org.apache.royale.jewel.beads.itemRenderers
>> * @playerversion Flash 10.2
>> * @playerversion AIR 2.6
>> * @productversion Royale 0.9.4
>> +* @royaleignorecoercion
>> org.apache.royale.core.IStrandWithModelView
>> */
>>public function get
>> itemRendererParent():IItemRendererParent
>>{
>>
>>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
Re: [royale-asjs] branch feature/new_merge updated: Added ignores
Hi Harbs,
in order to add this comments myself, how do I need to have into account.
This part is still a bit obscure for me
thanks
Carlos
El mié., 5 sept. 2018 a las 15:15, escribió:
> This is an automated email from the ASF dual-hosted git repository.
>
> harbs pushed a commit to branch feature/new_merge
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
>
> The following commit(s) were added to refs/heads/feature/new_merge by this
> push:
> new 7b24e79 Added ignores
> 7b24e79 is described below
>
> commit 7b24e79964407e4e2093373ce51aaf32142e6927
> Author: Harbs
> AuthorDate: Wed Sep 5 16:15:20 2018 +0300
>
> Added ignores
> ---
> .../jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as | 2
> ++
> .../beads/itemRenderers/RemoveListItemRendererForArrayListData.as | 4
>
> 2 files changed, 6 insertions(+)
>
> diff --git
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as
> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as
> index 188dba2..36311b8 100644
> ---
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as
> +++
> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/AddListItemRendererForArrayListData.as
> @@ -122,6 +122,8 @@ package org.apache.royale.jewel.beads.itemRenderers
> * @playerversion Flash 10.2
> * @playerversion AIR 2.6
> * @productversion Royale 0.9.4
> +* @royaleignorecoercion
> org.apache.royale.core.ISelectableItemRenderer
> +* @royaleignorecoercion
> org.apache.royale.events.IEventDispatcher
> */
> protected function
> handleItemAdded(event:CollectionEvent):void
> {
> diff --git
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/RemoveListItemRendererForArrayListData.as
> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/RemoveListItemRendererForArrayListData.as
> index 98aa953..d591553 100644
> ---
> a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/RemoveListItemRendererForArrayListData.as
> +++
> b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/itemRenderers/RemoveListItemRendererForArrayListData.as
> @@ -114,6 +114,8 @@ package org.apache.royale.jewel.beads.itemRenderers
> * @playerversion Flash 10.2
> * @playerversion AIR 2.6
> * @productversion Royale 0.9.4
> +* @royaleignorecoercion
> org.apache.royale.core.ISelectableItemRenderer
> +* @royaleignorecoercion
> org.apache.royale.events.IEventDispatcher
> */
> protected function
> handleItemRemoved(event:CollectionEvent):void
> {
> @@ -141,6 +143,7 @@ package org.apache.royale.jewel.beads.itemRenderers
> * @playerversion Flash 10.2
> * @playerversion AIR 2.6
> * @productversion Royale 0.9.4
> +* @royaleignorecoercion
> org.apache.royale.core.IDataProviderModel
> */
> public function get dataProviderModel(): IDataProviderModel
> {
> @@ -160,6 +163,7 @@ package org.apache.royale.jewel.beads.itemRenderers
> * @playerversion Flash 10.2
> * @playerversion AIR 2.6
> * @productversion Royale 0.9.4
> +* @royaleignorecoercion
> org.apache.royale.core.IStrandWithModelView
> */
> public function get
> itemRendererParent():IItemRendererParent
> {
>
>
--
Carlos Rovira
http://about.me/carlosrovira
