[jira] [Commented] (S2GRAPH-222) Support Not logical operator in WhereParser.
[
https://issues.apache.org/jira/browse/S2GRAPH-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515412#comment-16515412
]
ASF GitHub Bot commented on S2GRAPH-222:
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-s2graph/pull/174
> Support Not logical operator in WhereParser.
> -
>
> Key: S2GRAPH-222
> URL: https://issues.apache.org/jira/browse/S2GRAPH-222
> Project: S2Graph
> Issue Type: New Feature
> Components: s2core
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
>Priority: Minor
>
> `And/Or` operator is implemented as a logical operator, but `Not` is not
> implemented in WhereParser.
> This is illustrated by following examples.
> Following query works only because we added hardcoded implementation on `not
> in` as predicates.
> {noformat}
> query {
> s2graph {
> User(id: 1) {
> id
> Friends(limit: 10, filter: "friend_name not in ('steamshon')") {
> User {
> id
> }
> }
> }
> }
> }
> {noformat}
> I believe implementing `Not` as a logical operator is more general, so below
> is my suggestion.
> {noformat}
> query {
> s2graph {
> User(id: 1) {
> id
> Friends(limit: 10, filter: "NOT (friend_name in ('steamshon'))") {
> User {
> id
> }
> }
> }
> }
> }
> {noformat}
> In this way, we don't need to implement not case for all predicates, such as
> `in`, `between`, `contains`, `eq`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (S2GRAPH-222) Support Not logical operator in WhereParser.
[
https://issues.apache.org/jira/browse/S2GRAPH-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515371#comment-16515371
]
Daewon Jeong commented on S2GRAPH-222:
--
[~steamshon]
I agree with the addition of the Like statement.
But so far, it's a good idea to separate it into separate issues.
The current issue (S2GRAPH-222) is that it is better to limit the scope to what
is now implemented.
> Support Not logical operator in WhereParser.
> -
>
> Key: S2GRAPH-222
> URL: https://issues.apache.org/jira/browse/S2GRAPH-222
> Project: S2Graph
> Issue Type: New Feature
> Components: s2core
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
>Priority: Minor
>
> `And/Or` operator is implemented as a logical operator, but `Not` is not
> implemented in WhereParser.
> This is illustrated by following examples.
> Following query works only because we added hardcoded implementation on `not
> in` as predicates.
> {noformat}
> query {
> s2graph {
> User(id: 1) {
> id
> Friends(limit: 10, filter: "friend_name not in ('steamshon')") {
> User {
> id
> }
> }
> }
> }
> }
> {noformat}
> I believe implementing `Not` as a logical operator is more general, so below
> is my suggestion.
> {noformat}
> query {
> s2graph {
> User(id: 1) {
> id
> Friends(limit: 10, filter: "NOT (friend_name in ('steamshon'))") {
> User {
> id
> }
> }
> }
> }
> }
> {noformat}
> In this way, we don't need to implement not case for all predicates, such as
> `in`, `between`, `contains`, `eq`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (S2GRAPH-222) Support Not logical operator in WhereParser.
[
https://issues.apache.org/jira/browse/S2GRAPH-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513352#comment-16513352
]
Daewon Jeong commented on S2GRAPH-222:
--
[~steamshon]
I think `Where Parser` should follow the grammar of the where clause of
standard SQL.
If follow the syntax of the standard SQL clause, user can easily predict usage.
I think that the revised contents have been modified well in the parts which
had been previously implemented incorrectly (not the general processing but
specifically the `NOT IN` processing)
But for a more predictable syntax, I think it would be better to implement all
the `NOT condition` clauses of the type supported by the standard SQL.
> Support Not logical operator in WhereParser.
> -
>
> Key: S2GRAPH-222
> URL: https://issues.apache.org/jira/browse/S2GRAPH-222
> Project: S2Graph
> Issue Type: New Feature
> Components: s2core
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
>Priority: Minor
>
> `And/Or` operator is implemented as a logical operator, but `Not` is not
> implemented in WhereParser.
> This is illustrated by following examples.
> Following query works only because we added hardcoded implementation on `not
> in` as predicates.
> {noformat}
> query {
> s2graph {
> User(id: 1) {
> id
> Friends(limit: 10, filter: "friend_name not in ('steamshon')") {
> User {
> id
> }
> }
> }
> }
> }
> {noformat}
> I believe implementing `Not` as a logical operator is more general, so below
> is my suggestion.
> {noformat}
> query {
> s2graph {
> User(id: 1) {
> id
> Friends(limit: 10, filter: "NOT (friend_name in ('steamshon'))") {
> User {
> id
> }
> }
> }
> }
> }
> {noformat}
> In this way, we don't need to implement not case for all predicates, such as
> `in`, `between`, `contains`, `eq`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (S2GRAPH-222) Support Not logical operator in WhereParser.
[
https://issues.apache.org/jira/browse/S2GRAPH-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513258#comment-16513258
]
DOYUNG YOON commented on S2GRAPH-222:
-
[~daewon]
Since my changes are very small, I opened
[https://github.com/apache/incubator-s2graph/pull/174].
Seems like you have feedback on this, and I would appreciate elaborate it.
> Support Not logical operator in WhereParser.
> -
>
> Key: S2GRAPH-222
> URL: https://issues.apache.org/jira/browse/S2GRAPH-222
> Project: S2Graph
> Issue Type: New Feature
> Components: s2core
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
>Priority: Minor
>
> `And/Or` operator is implemented as a logical operator, but `Not` is not
> implemented in WhereParser.
> This is illustrated by following examples.
> Following query works only because we added hardcoded implementation on `not
> in` as predicates.
> {noformat}
> query {
> s2graph {
> User(id: 1) {
> id
> Friends(limit: 10, filter: "friend_name not in ('steamshon')") {
> User {
> id
> }
> }
> }
> }
> }
> {noformat}
> I believe implementing `Not` as a logical operator is more general, so below
> is my suggestion.
> {noformat}
> query {
> s2graph {
> User(id: 1) {
> id
> Friends(limit: 10, filter: "NOT (friend_name in ('steamshon'))") {
> User {
> id
> }
> }
> }
> }
> }
> {noformat}
> In this way, we don't need to implement not case for all predicates, such as
> `in`, `between`, `contains`, `eq`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (S2GRAPH-222) Support Not logical operator in WhereParser.
[
https://issues.apache.org/jira/browse/S2GRAPH-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513257#comment-16513257
]
ASF GitHub Bot commented on S2GRAPH-222:
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/174
[S2GRAPH-222]: Support Not logical operator in WhereParser.
- add 'NOT' logical operator.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-222
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/174.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #174
commit f288680c46c23ac90fba1741baf494c061921277
Author: DO YUNG YOON
Date: 2018-06-15T02:21:17Z
add Not logical operator on WhereParser.
commit 428c453506d3f89d22135f2518dc2a601f5070f8
Author: DO YUNG YOON
Date: 2018-06-15T02:45:55Z
remove not in.
> Support Not logical operator in WhereParser.
> -
>
> Key: S2GRAPH-222
> URL: https://issues.apache.org/jira/browse/S2GRAPH-222
> Project: S2Graph
> Issue Type: New Feature
> Components: s2core
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
>Priority: Minor
>
> `And/Or` operator is implemented as a logical operator, but `Not` is not
> implemented in WhereParser.
> This is illustrated by following examples.
> Following query works only because we added hardcoded implementation on `not
> in` as predicates.
> {noformat}
> query {
> s2graph {
> User(id: 1) {
> id
> Friends(limit: 10, filter: "friend_name not in ('steamshon')") {
> User {
> id
> }
> }
> }
> }
> }
> {noformat}
> I believe implementing `Not` as a logical operator is more general, so below
> is my suggestion.
> {noformat}
> query {
> s2graph {
> User(id: 1) {
> id
> Friends(limit: 10, filter: "NOT (friend_name in ('steamshon'))") {
> User {
> id
> }
> }
> }
> }
> }
> {noformat}
> In this way, we don't need to implement not case for all predicates, such as
> `in`, `between`, `contains`, `eq`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (S2GRAPH-222) Support Not logical operator in WhereParser.
[
https://issues.apache.org/jira/browse/S2GRAPH-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513243#comment-16513243
]
Daewon Jeong commented on S2GRAPH-222:
--
[~steamshon] I'm interested in the issue.
Is it okay to assign this issue to me?
> Support Not logical operator in WhereParser.
> -
>
> Key: S2GRAPH-222
> URL: https://issues.apache.org/jira/browse/S2GRAPH-222
> Project: S2Graph
> Issue Type: New Feature
> Components: s2core
>Reporter: DOYUNG YOON
>Assignee: DOYUNG YOON
>Priority: Minor
>
> `And/Or` operator is implemented as a logical operator, but `Not` is not
> implemented in WhereParser.
> This is illustrated by following examples.
> Following query works only because we added hardcoded implementation on `not
> in` as predicates.
> {noformat}
> query {
> s2graph {
> User(id: 1) {
> id
> Friends(limit: 10, filter: "friend_name not in ('steamshon')") {
> User {
> id
> }
> }
> }
> }
> }
> {noformat}
> I believe implementing `Not` as a logical operator is more general, so below
> is my suggestion.
> {noformat}
> query {
> s2graph {
> User(id: 1) {
> id
> Friends(limit: 10, filter: "NOT (friend_name in ('steamshon'))") {
> User {
> id
> }
> }
> }
> }
> }
> {noformat}
> In this way, we don't need to implement not case for all predicates, such as
> `in`, `between`, `contains`, `eq`.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
