I haven't had a chance to finish reviewing this yet, but one I thing I noticed off the bat is that you used sha1 and md5 to sign it. Both of those are deprecated. You should be using sha256 or sha512. See https://www.apache.org/dev/release-signing.html
Alan. On Mon, Feb 3, 2020 at 12:50 PM Maciej Grzenda <mgrze...@apache.org> wrote: > Hi, > > Good to see new release candidate. > > +1 > > Thanks, > > Maciej > > On 2020-01-23 04:29, Corey Sterling wrote: > > Hi all, > > > > Please vote on releasing the following release candidate as Apache SAMOA > > (incubating) version 0.5.0. > > > > This release will be the third release for SAMOA in the incubator. > > > > ------------------------------------------------------------- > > The commit to be voted on is in the branch > "releases/0.5.0-incubating-RC1" > > (commit b5f5ddc2f782ddb4fe8bd68cb0cf466e4af489c4): > > > https://git-wip-us.apache.org/repos/asf?p=incubator-samoa.git;a=commit;h=b5f5ddc2f782ddb4fe8bd68cb0cf466e4af489c4 > > > > Tag v0.5.0-incubating: > > > https://git-wip-us.apache.org/repos/asf?p=incubator-samoa.git;a=commit;h=495a23be7b7bb2d52ecd670aa422d48acc0f30f1 > > > > Release artifacts are signed with the following key: > > https://people.apache.org/keys/committer/csterling > > > > The staging repository for this release can be found at: > > > https://repository.apache.org/content/repositories/staging/org/apache/samoa/samoa/0.5.0-incubating/ > > > > The developer's version artifacts: > > > https://dist.apache.org/repos/dist/dev/incubator/samoa/0.5.0-incubating-rc1/ > > > > ------------------------------------------------------------- > > > > Please vote on releasing this package as Apache SAMOA 0.5.0 (incubating). > > > > The vote is open for the next 72 hours and passes if a majority of at > least > > three +1 PPMC votes are cast. > > > > [ ] +1 Release this package as Apache SAMOA 0.5.0 (incubating) > > [ ] -1 Do not release this package because ... > > > > I'm +1 (non-binding) on the release. > > > > Cheers, > > > > Corey. > > > >
