Re: Review Request 50317: SAMZA-978: update md files to resolve inconsistent links, broken links and some confusing sentences

[Jagadish Venkatraman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50317/#review143173
---


Ship it!




I'm not sure if we have a way to test updates to html documentation (basically 
to ensure that we don't break html formatting. Could we run a http server to 
host the samza web page on our local host?
Yi/Navina can provide more context.


docs/learn/documentation/versioned/container/samza-container.md (line 107)


For consistency, we can maybe use the name broadcast-stream1 and 
broadcast-stream2. What do you think?


- Jagadish Venkatraman


On July 22, 2016, 12:26 a.m., Fred Ji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50317/
> ---
> 
> (Updated July 22, 2016, 12:26 a.m.)
> 
> 
> Review request for samza, Jon Bringhurst, Jagadish Venkatraman, and Yi Pan 
> (Data Infrastructure).
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> 1. resolve the inconsistent next section link at the end of each section on 
> samza.apache.org/learn/documentation/0.10/; 
> 2. resolove some broken links such as Coda Hale's metrics library and Linux 
> CGroup; 
> 3. update some sentences or rephrase to make description clearer.
> 
> 
> Diffs
> -
> 
>   docs/learn/documentation/versioned/api/overview.md 
> 6712344e84e19883b857e00549db2acb101c7e0e 
>   docs/learn/documentation/versioned/comparisons/mupd8.md 
> 53417f91019c08d470d101685b6c40dad112bb18 
>   docs/learn/documentation/versioned/comparisons/storm.md 
> 58cb50895e7a419a7bede8911cd5b7f21fb487c4 
>   docs/learn/documentation/versioned/container/coordinator-stream.md 
> 98c1a845cda5ca2a53ee58b55508fc93492b982d 
>   docs/learn/documentation/versioned/container/event-loop.md 
> 116238312df7071747cbbc14bc9c46f558755195 
>   docs/learn/documentation/versioned/container/metrics.md 
> 0423155537b0095b9efcfb40757e8de17b640ffd 
>   docs/learn/documentation/versioned/container/samza-container.md 
> 55bec9813ca006757db046e6e85259b4d2e8c770 
>   docs/learn/documentation/versioned/container/state-management.md 
> 320392cd4412b459a093ab9657b7264cee42958b 
>   docs/learn/documentation/versioned/container/windowing.md 
> b10e5d4eba61cb5da026af828d89d558457a6b16 
>   docs/learn/documentation/versioned/hdfs/producer.md 
> 0865a351b48c0b00e32282d2d7e44dfeae09b4ec 
>   docs/learn/documentation/versioned/index.html 
> 1e79bd6f39ee67b5a2b74222d647342990bbbe23 
>   docs/learn/documentation/versioned/yarn/isolation.md 
> a76f6fd0f93482c085b15bb1b2c313a913508bcc 
>   docs/learn/documentation/versioned/yarn/yarn-host-affinity.md 
> af6367da4f5611e208c9fb8426554c4a9c4ad6c8 
> 
> Diff: https://reviews.apache.org/r/50317/diff/
> 
> 
> Testing
> ---
> 
> Basic unit tests and checkstyleTest passed.
> 1. Run unit tests:
>   ./gradlew clean build
> 2. Check if your code follows the coding conventions:
>   ./gradlew checkstyleMain checkstyleTest
> 
> 
> Thanks,
> 
> Fred Ji
> 
>

Review Request 50318: SAMZA-979: Fix for KafkaCheckpointMigration not registering source correctly

[Xinyu Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50318/
---

Review request for samza, Navina Ramesh and Yi Pan (Data Infrastructure).


Repository: samza


Description
---

After the thread-safe kafka producer change, all producer need to register the 
source before publishing to it. The registering of KafkaCheckpointMigration 
happens in the wrong place. Move it after the producer is created.

Also find an extra logging introduced by the change. Remove it during this fix.


Diffs
-

  samza-core/src/main/scala/org/apache/samza/checkpoint/OffsetManager.scala 
7245902c69c751a4e8853745de46adf5553d45f5 
  
samza-kafka/src/main/scala/org/apache/samza/migration/KafkaCheckpointMigration.scala
 5d2641ab1e54d49f7b983bc526762cfb50f2911b 

Diff: https://reviews.apache.org/r/50318/diff/


Testing
---

Tested by locally deployed jobs.

Passed gradle tests.


Thanks,

Xinyu Liu

Re: Review Request 50317: SAMZA-978: update md files to resolve inconsistent links, broken links and some confusing sentences

[Fred Ji]

> On July 22, 2016, 12:37 a.m., Jake Maes wrote:
> > docs/learn/documentation/versioned/index.html, lines 48-49
> > 
> >
> > I'm not sure these should be nested in the Overview page. They are 
> > critical parts of the API and we want users to be able to find them easily.

Thanks for the comments. These two are on the main list when we go to 
https://samza.apache.org/ (left column list including "Documentation" which is 
for this doc, and "Configuration", "Javadocs", and etc.), so users can find 
them as easily as "Hello Samza", "FAQ".  

We may not want to list "Configuration" and "Javadocs" again in the table for 
https://samza.apache.org/learn/documentation/0.10/ as another individual 
sections, and also, all sections in 
https://samza.apache.org/learn/documentation/0.10/ are following the same 
format except "Configuration" and "Javadocs".


- Fred


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50317/#review143165
---


On July 22, 2016, 12:26 a.m., Fred Ji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50317/
> ---
> 
> (Updated July 22, 2016, 12:26 a.m.)
> 
> 
> Review request for samza, Jon Bringhurst, Jagadish Venkatraman, and Yi Pan 
> (Data Infrastructure).
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> 1. resolve the inconsistent next section link at the end of each section on 
> samza.apache.org/learn/documentation/0.10/; 
> 2. resolove some broken links such as Coda Hale's metrics library and Linux 
> CGroup; 
> 3. update some sentences or rephrase to make description clearer.
> 
> 
> Diffs
> -
> 
>   docs/learn/documentation/versioned/api/overview.md 
> 6712344e84e19883b857e00549db2acb101c7e0e 
>   docs/learn/documentation/versioned/comparisons/mupd8.md 
> 53417f91019c08d470d101685b6c40dad112bb18 
>   docs/learn/documentation/versioned/comparisons/storm.md 
> 58cb50895e7a419a7bede8911cd5b7f21fb487c4 
>   docs/learn/documentation/versioned/container/coordinator-stream.md 
> 98c1a845cda5ca2a53ee58b55508fc93492b982d 
>   docs/learn/documentation/versioned/container/event-loop.md 
> 116238312df7071747cbbc14bc9c46f558755195 
>   docs/learn/documentation/versioned/container/metrics.md 
> 0423155537b0095b9efcfb40757e8de17b640ffd 
>   docs/learn/documentation/versioned/container/samza-container.md 
> 55bec9813ca006757db046e6e85259b4d2e8c770 
>   docs/learn/documentation/versioned/container/state-management.md 
> 320392cd4412b459a093ab9657b7264cee42958b 
>   docs/learn/documentation/versioned/container/windowing.md 
> b10e5d4eba61cb5da026af828d89d558457a6b16 
>   docs/learn/documentation/versioned/hdfs/producer.md 
> 0865a351b48c0b00e32282d2d7e44dfeae09b4ec 
>   docs/learn/documentation/versioned/index.html 
> 1e79bd6f39ee67b5a2b74222d647342990bbbe23 
>   docs/learn/documentation/versioned/yarn/isolation.md 
> a76f6fd0f93482c085b15bb1b2c313a913508bcc 
>   docs/learn/documentation/versioned/yarn/yarn-host-affinity.md 
> af6367da4f5611e208c9fb8426554c4a9c4ad6c8 
> 
> Diff: https://reviews.apache.org/r/50317/diff/
> 
> 
> Testing
> ---
> 
> Basic unit tests and checkstyleTest passed.
> 1. Run unit tests:
>   ./gradlew clean build
> 2. Check if your code follows the coding conventions:
>   ./gradlew checkstyleMain checkstyleTest
> 
> 
> Thanks,
> 
> Fred Ji
> 
>

Re: Review Request 50317: SAMZA-978: update md files to resolve inconsistent links, broken links and some confusing sentences

[Jake Maes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50317/#review143165
---




docs/learn/documentation/versioned/index.html 


I'm not sure these should be nested in the Overview page. They are critical 
parts of the API and we want users to be able to find them easily.


- Jake Maes


On July 22, 2016, 12:26 a.m., Fred Ji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50317/
> ---
> 
> (Updated July 22, 2016, 12:26 a.m.)
> 
> 
> Review request for samza, Jon Bringhurst, Jagadish Venkatraman, and Yi Pan 
> (Data Infrastructure).
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> 1. resolve the inconsistent next section link at the end of each section on 
> samza.apache.org/learn/documentation/0.10/; 
> 2. resolove some broken links such as Coda Hale's metrics library and Linux 
> CGroup; 
> 3. update some sentences or rephrase to make description clearer.
> 
> 
> Diffs
> -
> 
>   docs/learn/documentation/versioned/api/overview.md 
> 6712344e84e19883b857e00549db2acb101c7e0e 
>   docs/learn/documentation/versioned/comparisons/mupd8.md 
> 53417f91019c08d470d101685b6c40dad112bb18 
>   docs/learn/documentation/versioned/comparisons/storm.md 
> 58cb50895e7a419a7bede8911cd5b7f21fb487c4 
>   docs/learn/documentation/versioned/container/coordinator-stream.md 
> 98c1a845cda5ca2a53ee58b55508fc93492b982d 
>   docs/learn/documentation/versioned/container/event-loop.md 
> 116238312df7071747cbbc14bc9c46f558755195 
>   docs/learn/documentation/versioned/container/metrics.md 
> 0423155537b0095b9efcfb40757e8de17b640ffd 
>   docs/learn/documentation/versioned/container/samza-container.md 
> 55bec9813ca006757db046e6e85259b4d2e8c770 
>   docs/learn/documentation/versioned/container/state-management.md 
> 320392cd4412b459a093ab9657b7264cee42958b 
>   docs/learn/documentation/versioned/container/windowing.md 
> b10e5d4eba61cb5da026af828d89d558457a6b16 
>   docs/learn/documentation/versioned/hdfs/producer.md 
> 0865a351b48c0b00e32282d2d7e44dfeae09b4ec 
>   docs/learn/documentation/versioned/index.html 
> 1e79bd6f39ee67b5a2b74222d647342990bbbe23 
>   docs/learn/documentation/versioned/yarn/isolation.md 
> a76f6fd0f93482c085b15bb1b2c313a913508bcc 
>   docs/learn/documentation/versioned/yarn/yarn-host-affinity.md 
> af6367da4f5611e208c9fb8426554c4a9c4ad6c8 
> 
> Diff: https://reviews.apache.org/r/50317/diff/
> 
> 
> Testing
> ---
> 
> Basic unit tests and checkstyleTest passed.
> 1. Run unit tests:
>   ./gradlew clean build
> 2. Check if your code follows the coding conventions:
>   ./gradlew checkstyleMain checkstyleTest
> 
> 
> Thanks,
> 
> Fred Ji
> 
>

Re: Review Request 50317: SAMZA-978: update md files to resolve inconsistent links, broken links and some confusing sentences

[Fred Ji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50317/
---

(Updated July 22, 2016, 12:26 a.m.)


Review request for samza, Jon Bringhurst, Jagadish Venkatraman, and Yi Pan 
(Data Infrastructure).


Changes
---

added tests done and added more people in the reviewers list.


Repository: samza


Description (updated)
---

1. resolve the inconsistent next section link at the end of each section on 
samza.apache.org/learn/documentation/0.10/; 
2. resolove some broken links such as Coda Hale's metrics library and Linux 
CGroup; 
3. update some sentences or rephrase to make description clearer.


Diffs
-

  docs/learn/documentation/versioned/api/overview.md 
6712344e84e19883b857e00549db2acb101c7e0e 
  docs/learn/documentation/versioned/comparisons/mupd8.md 
53417f91019c08d470d101685b6c40dad112bb18 
  docs/learn/documentation/versioned/comparisons/storm.md 
58cb50895e7a419a7bede8911cd5b7f21fb487c4 
  docs/learn/documentation/versioned/container/coordinator-stream.md 
98c1a845cda5ca2a53ee58b55508fc93492b982d 
  docs/learn/documentation/versioned/container/event-loop.md 
116238312df7071747cbbc14bc9c46f558755195 
  docs/learn/documentation/versioned/container/metrics.md 
0423155537b0095b9efcfb40757e8de17b640ffd 
  docs/learn/documentation/versioned/container/samza-container.md 
55bec9813ca006757db046e6e85259b4d2e8c770 
  docs/learn/documentation/versioned/container/state-management.md 
320392cd4412b459a093ab9657b7264cee42958b 
  docs/learn/documentation/versioned/container/windowing.md 
b10e5d4eba61cb5da026af828d89d558457a6b16 
  docs/learn/documentation/versioned/hdfs/producer.md 
0865a351b48c0b00e32282d2d7e44dfeae09b4ec 
  docs/learn/documentation/versioned/index.html 
1e79bd6f39ee67b5a2b74222d647342990bbbe23 
  docs/learn/documentation/versioned/yarn/isolation.md 
a76f6fd0f93482c085b15bb1b2c313a913508bcc 
  docs/learn/documentation/versioned/yarn/yarn-host-affinity.md 
af6367da4f5611e208c9fb8426554c4a9c4ad6c8 

Diff: https://reviews.apache.org/r/50317/diff/


Testing (updated)
---

Basic unit tests and checkstyleTest passed.
1. Run unit tests:
  ./gradlew clean build
2. Check if your code follows the coding conventions:
  ./gradlew checkstyleMain checkstyleTest


Thanks,

Fred Ji

Review Request 50317: SAMZA-978: update md files to resolve inconsistent links, broken links and some confusing sentences

[Fred Ji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50317/
---

Review request for samza.


Repository: samza


Description
---

1. resolve the inconsistent next section link at the end of each section on 
samza.apache.org/learn/documentation/0.10/; 2. resolove some broken links such 
as Coda Hale's metrics library and Linux CGroup; 3. update some sentences or 
rephrase to make description clearer.


Diffs
-

  docs/learn/documentation/versioned/api/overview.md 
6712344e84e19883b857e00549db2acb101c7e0e 
  docs/learn/documentation/versioned/comparisons/mupd8.md 
53417f91019c08d470d101685b6c40dad112bb18 
  docs/learn/documentation/versioned/comparisons/storm.md 
58cb50895e7a419a7bede8911cd5b7f21fb487c4 
  docs/learn/documentation/versioned/container/coordinator-stream.md 
98c1a845cda5ca2a53ee58b55508fc93492b982d 
  docs/learn/documentation/versioned/container/event-loop.md 
116238312df7071747cbbc14bc9c46f558755195 
  docs/learn/documentation/versioned/container/metrics.md 
0423155537b0095b9efcfb40757e8de17b640ffd 
  docs/learn/documentation/versioned/container/samza-container.md 
55bec9813ca006757db046e6e85259b4d2e8c770 
  docs/learn/documentation/versioned/container/state-management.md 
320392cd4412b459a093ab9657b7264cee42958b 
  docs/learn/documentation/versioned/container/windowing.md 
b10e5d4eba61cb5da026af828d89d558457a6b16 
  docs/learn/documentation/versioned/hdfs/producer.md 
0865a351b48c0b00e32282d2d7e44dfeae09b4ec 
  docs/learn/documentation/versioned/index.html 
1e79bd6f39ee67b5a2b74222d647342990bbbe23 
  docs/learn/documentation/versioned/yarn/isolation.md 
a76f6fd0f93482c085b15bb1b2c313a913508bcc 
  docs/learn/documentation/versioned/yarn/yarn-host-affinity.md 
af6367da4f5611e208c9fb8426554c4a9c4ad6c8 

Diff: https://reviews.apache.org/r/50317/diff/


Testing
---


Thanks,

Fred Ji

Re: "publishToMavenLocal" task not found in gradlew

[Fred Ji]

Hi Ankita,

The command "./gradlew publishToMavenLocal" is to be run in Samza project,
not "hello-samza" project. In your case, you may just skip this command
since "bin/grid bootstrap" would already build a Samza package for you
(hello-samza/deploy/samza).

Thanks,

Fred

On Thu, Jul 21, 2016 at 2:15 PM, Ankita Karandikar  wrote:

> Hi,
>
> While running the project Hello-Samza from the tutorials provided on the
> web, I was unable to fire the following command on my terminal:
>
> *
> ./gradlew publishToMavenLocal
> ***
>
> Please suggest.
>
> Note: Please find below the result of the command ./gradlew tasks for your
> reference
>
>
>
> ***
>
> Build tasks
>
> ---
>
> assemble - Assembles the outputs of this project.
>
> build - Assembles and tests this project.
>
> buildDependents - Assembles and tests this project and all projects that
> depend on it.
>
> buildNeeded - Assembles and tests this project and all projects it depends
> on.
>
> classes - Assembles classes 'main'.
>
> clean - Deletes the build directory.
>
> jar - Assembles a jar archive containing the main classes.
>
> testClasses - Assembles classes 'test'.
>
>
> Build Setup tasks
>
> -
>
> init - Initializes a new Gradle build. [incubating]
>
>
> Documentation tasks
>
> ---
>
> javadoc - Generates Javadoc API documentation for the main source code.
>
>
> Help tasks
>
> --
>
> components - Displays the components produced by root project
> 'hello-samza'. [incubating]
>
> dependencies - Displays all dependencies declared in root project
> 'hello-samza'.
>
> dependencyInsight - Displays the insight into a specific dependency in root
> project 'hello-samza'.
>
> help - Displays a help message.
>
> projects - Displays the sub-projects of root project 'hello-samza'.
>
> properties - Displays the properties of root project 'hello-samza'.
>
> tasks - Displays the tasks runnable from root project 'hello-samza'.
>
>
> IDE tasks
>
> -
>
> cleanEclipse - Cleans all Eclipse files.
>
> eclipse - Generates all Eclipse files.
>
>
> Verification tasks
>
> --
>
> check - Runs all checks.
>
> test - Runs the unit tests.
>
>
> Other tasks
>
> ---
>
> dumpWikiEdits
>
> dumpWikiRaw
>
> dumpWikiStats
>
> listKafkaTopics
>
> runWikiFeed
>
> runWikiParser
>
> runWikiStats
>
> stopGrid
>
> wrapper - Updates gradlew and supporting files.
>
>
> 
>
> AKARANDIKAR-E366-MPR13:hello-samza akarandikar$ ./gradlew tasks | grep
> publishToMavenLocal
>
> AKARANDIKAR-E366-MPR13:hello-samza akarandikar$
>
> ***
>
> Thanks.
>
> Regards,
>
> Ankita
>

"publishToMavenLocal" task not found in gradlew

[Ankita Karandikar]

Hi,

While running the project Hello-Samza from the tutorials provided on the
web, I was unable to fire the following command on my terminal:

*
./gradlew publishToMavenLocal
***

Please suggest.

Note: Please find below the result of the command ./gradlew tasks for your
reference



***

Build tasks

---

assemble - Assembles the outputs of this project.

build - Assembles and tests this project.

buildDependents - Assembles and tests this project and all projects that
depend on it.

buildNeeded - Assembles and tests this project and all projects it depends
on.

classes - Assembles classes 'main'.

clean - Deletes the build directory.

jar - Assembles a jar archive containing the main classes.

testClasses - Assembles classes 'test'.


Build Setup tasks

-

init - Initializes a new Gradle build. [incubating]


Documentation tasks

---

javadoc - Generates Javadoc API documentation for the main source code.


Help tasks

--

components - Displays the components produced by root project
'hello-samza'. [incubating]

dependencies - Displays all dependencies declared in root project
'hello-samza'.

dependencyInsight - Displays the insight into a specific dependency in root
project 'hello-samza'.

help - Displays a help message.

projects - Displays the sub-projects of root project 'hello-samza'.

properties - Displays the properties of root project 'hello-samza'.

tasks - Displays the tasks runnable from root project 'hello-samza'.


IDE tasks

-

cleanEclipse - Cleans all Eclipse files.

eclipse - Generates all Eclipse files.


Verification tasks

--

check - Runs all checks.

test - Runs the unit tests.


Other tasks

---

dumpWikiEdits

dumpWikiRaw

dumpWikiStats

listKafkaTopics

runWikiFeed

runWikiParser

runWikiStats

stopGrid

wrapper - Updates gradlew and supporting files.



AKARANDIKAR-E366-MPR13:hello-samza akarandikar$ ./gradlew tasks | grep
publishToMavenLocal

AKARANDIKAR-E366-MPR13:hello-samza akarandikar$

***

Thanks.

Regards,

Ankita