[GitHub] samza pull request #255: SAMZA-1382: added Zk communication protocol version...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/samza/pull/255


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[VOTE] Apache Samza 0.13.1 RC0

[Navina R (Apache)]

Ran check-all on my Mac and it passes.

+1 (binding)

Thanks!
Navina

On Tue, Aug 22, 2017 at 4:20 PM, Fred Haifeng Ji 
wrote:

> +cc nav...@apache.org
>
>
> On Tue, Aug 22, 2017 at 11:19 AM, Fred Haifeng Ji 
> wrote:
>
>> Thanks to those who already tested the RC and voted.
>>
>> Due to the weekend and the eclipse day, we are extending the vote till
>> 1pm Wednesday 8/23.
>>
>> Thanks,
>>
>> Fred
>>
>> On Tue, Aug 22, 2017 at 9:59 AM, Jagadish Venkatraman <
>> jagadish1...@gmail.com> wrote:
>>
>>> Ran check-all.sh, and it succeeded!
>>>
>>> +1 (non binding)
>>>
>>> On Mon, Aug 21, 2017 at 4:34 PM, xinyu liu 
>>> wrote:
>>>
>>> > Built the src, and ran the tests using check-all.sh. Most of the tests
>>> ran
>>> > fine. There was an transient test failure (
>>> > https://issues.apache.org/jira/browse/SAMZA-1405), which seems to be
>>> > caused
>>> > by the testing env (further investigation needed). I reran the tests
>>> again
>>> > and it passed. Since this test doesn't affect the build itself, I am +1
>>> > (non-binding).
>>> >
>>> > Thanks,
>>> > Xinyu
>>> >
>>> > On Mon, Aug 21, 2017 at 2:24 PM, Yi Pan  wrote:
>>> >
>>> > > Downloaded the source, compiled and ran the integration tests. All
>>> > passed.
>>> > >
>>> > > +1 (binding) w/ the following minor comments:
>>> > > # Please make a note in the release note that this version requires
>>> JDK
>>> > > 1.8.0.112+ (I have test w/ JDK 1.8.0.121)
>>> > > # Please make sure that we publish artifacts compiled w/ Scala 2.10,
>>> > Scala
>>> > > 2.11, and Scala 2.12
>>> > >
>>> > > -Yi
>>> > >
>>> > > On Fri, Aug 18, 2017 at 11:59 AM, Fred Haifeng Ji <
>>> haifeng...@gmail.com>
>>> > > wrote:
>>> > >
>>> > > > This is a call for a vote on a release of Apache Samza 0.13.1.
>>> Thanks
>>> > to
>>> > > > everyone who has contributed to this release.
>>> > > >
>>> > > > The release candidate can be downloaded from here:
>>> > > > http://home.apache.org/~navina/samza-0.13.1-rc0/
>>> > > >
>>> > > >
>>> > > > The release candidate is signed with pgp key A211312E, which can be
>>> > found
>>> > > > on keyservers:
>>> > > > http://pgp.mit.edu/pks/lookup?op=get&search=0xEDFD8F9AA211312E
>>> > > >
>>> > > >
>>> > > > The git tag is release-0.13.1-rc0 and signed with the same pgp key:
>>> > > > https://git-wip-us.apache.org/repos/asf?p=samza.git;a=tag;h=
>>> > > > refs/tags/release-0.13.1-rc0
>>> > > >
>>> > > > Test binaries have been published to Maven's staging repository,
>>> and
>>> > are
>>> > > > available here:
>>> > > > *https://repository.apache.org/content/repositories/
>>> > orgapachesamza-1030/
>>> > > > >> > orgapachesamza-1030/
>>> > > >*
>>> > > >
>>> > > >
>>> > > > 29 issues were resolved for this release: https://issues.apache
>>> > > > .org/jira/issues/?jql=project%20%3D%2012314526%20AND%20fixVe
>>> > > > rsion%20%3D%2012340845%20ORDER%20BY%20priority%20DESC%2C%20k
>>> ey%20ASC
>>> > > >
>>> > > >
>>> > > > The vote will be open for 72 hours (ending at 1:00PM Monday,
>>> > 08/21/2017).
>>> > > >
>>> > > > Please download the release candidate, check the hashes/signature,
>>> > build
>>> > > it
>>> > > > and test it, and then please vote:
>>> > > >
>>> > > >
>>> > > > [ ] +1 approve
>>> > > >
>>> > > > [ ] +0 no opinion
>>> > > >
>>> > > > [ ] -1 disapprove (and reason why)
>>> > > >
>>> > > >
>>> > > > --
>>> > > > Fred Ji
>>> > > >
>>> > >
>>> >
>>>
>>>
>>>
>>> --
>>> Jagadish V,
>>> Graduate Student,
>>> Department of Computer Science,
>>> Stanford University
>>>
>>
>>
>>
>> --
>> Haifeng (Fred)  Ji
>>
>
>
>
> --
> Haifeng (Fred)  Ji
>

Re: [VOTE] Apache Samza 0.13.1 RC0

[Fred Haifeng Ji]

+cc nav...@apache.org

On Tue, Aug 22, 2017 at 11:19 AM, Fred Haifeng Ji 
wrote:

> Thanks to those who already tested the RC and voted.
>
> Due to the weekend and the eclipse day, we are extending the vote till 1pm
> Wednesday 8/23.
>
> Thanks,
>
> Fred
>
> On Tue, Aug 22, 2017 at 9:59 AM, Jagadish Venkatraman <
> jagadish1...@gmail.com> wrote:
>
>> Ran check-all.sh, and it succeeded!
>>
>> +1 (non binding)
>>
>> On Mon, Aug 21, 2017 at 4:34 PM, xinyu liu  wrote:
>>
>> > Built the src, and ran the tests using check-all.sh. Most of the tests
>> ran
>> > fine. There was an transient test failure (
>> > https://issues.apache.org/jira/browse/SAMZA-1405), which seems to be
>> > caused
>> > by the testing env (further investigation needed). I reran the tests
>> again
>> > and it passed. Since this test doesn't affect the build itself, I am +1
>> > (non-binding).
>> >
>> > Thanks,
>> > Xinyu
>> >
>> > On Mon, Aug 21, 2017 at 2:24 PM, Yi Pan  wrote:
>> >
>> > > Downloaded the source, compiled and ran the integration tests. All
>> > passed.
>> > >
>> > > +1 (binding) w/ the following minor comments:
>> > > # Please make a note in the release note that this version requires
>> JDK
>> > > 1.8.0.112+ (I have test w/ JDK 1.8.0.121)
>> > > # Please make sure that we publish artifacts compiled w/ Scala 2.10,
>> > Scala
>> > > 2.11, and Scala 2.12
>> > >
>> > > -Yi
>> > >
>> > > On Fri, Aug 18, 2017 at 11:59 AM, Fred Haifeng Ji <
>> haifeng...@gmail.com>
>> > > wrote:
>> > >
>> > > > This is a call for a vote on a release of Apache Samza 0.13.1.
>> Thanks
>> > to
>> > > > everyone who has contributed to this release.
>> > > >
>> > > > The release candidate can be downloaded from here:
>> > > > http://home.apache.org/~navina/samza-0.13.1-rc0/
>> > > >
>> > > >
>> > > > The release candidate is signed with pgp key A211312E, which can be
>> > found
>> > > > on keyservers:
>> > > > http://pgp.mit.edu/pks/lookup?op=get&search=0xEDFD8F9AA211312E
>> > > >
>> > > >
>> > > > The git tag is release-0.13.1-rc0 and signed with the same pgp key:
>> > > > https://git-wip-us.apache.org/repos/asf?p=samza.git;a=tag;h=
>> > > > refs/tags/release-0.13.1-rc0
>> > > >
>> > > > Test binaries have been published to Maven's staging repository, and
>> > are
>> > > > available here:
>> > > > *https://repository.apache.org/content/repositories/
>> > orgapachesamza-1030/
>> > > > > > orgapachesamza-1030/
>> > > >*
>> > > >
>> > > >
>> > > > 29 issues were resolved for this release: https://issues.apache
>> > > > .org/jira/issues/?jql=project%20%3D%2012314526%20AND%20fixVe
>> > > > rsion%20%3D%2012340845%20ORDER%20BY%20priority%20DESC%2C%
>> 20key%20ASC
>> > > >
>> > > >
>> > > > The vote will be open for 72 hours (ending at 1:00PM Monday,
>> > 08/21/2017).
>> > > >
>> > > > Please download the release candidate, check the hashes/signature,
>> > build
>> > > it
>> > > > and test it, and then please vote:
>> > > >
>> > > >
>> > > > [ ] +1 approve
>> > > >
>> > > > [ ] +0 no opinion
>> > > >
>> > > > [ ] -1 disapprove (and reason why)
>> > > >
>> > > >
>> > > > --
>> > > > Fred Ji
>> > > >
>> > >
>> >
>>
>>
>>
>> --
>> Jagadish V,
>> Graduate Student,
>> Department of Computer Science,
>> Stanford University
>>
>
>
>
> --
> Haifeng (Fred)  Ji
>



-- 
Haifeng (Fred)  Ji

Re: [VOTE] Apache Samza 0.13.1 RC0

[Navina Ramesh]

Ran check-all on Mac. Build looks good.


+1 (binding)


Thanks!
Navina


From: Fred Haifeng Ji 
Sent: Tuesday, August 22, 2017 11:19 AM
To: dev@samza.apache.org
Subject: Re: [VOTE] Apache Samza 0.13.1 RC0

[You don't often get email from haifeng...@gmail.com. Learn why this is 
important at http://aka.ms/LearnAboutSenderIdentification.]

Thanks to those who already tested the RC and voted.

Due to the weekend and the eclipse day, we are extending the vote till 1pm
Wednesday 8/23.

Thanks,

Fred

On Tue, Aug 22, 2017 at 9:59 AM, Jagadish Venkatraman <
jagadish1...@gmail.com> wrote:

> Ran check-all.sh, and it succeeded!
>
> +1 (non binding)
>
> On Mon, Aug 21, 2017 at 4:34 PM, xinyu liu  wrote:
>
> > Built the src, and ran the tests using check-all.sh. Most of the tests
> ran
> > fine. There was an transient test failure (
> > https://issues.apache.org/jira/browse/SAMZA-1405), which seems to be
> > caused
> > by the testing env (further investigation needed). I reran the tests
> again
> > and it passed. Since this test doesn't affect the build itself, I am +1
> > (non-binding).
> >
> > Thanks,
> > Xinyu
> >
> > On Mon, Aug 21, 2017 at 2:24 PM, Yi Pan  wrote:
> >
> > > Downloaded the source, compiled and ran the integration tests. All
> > passed.
> > >
> > > +1 (binding) w/ the following minor comments:
> > > # Please make a note in the release note that this version requires JDK
> > > 1.8.0.112+ (I have test w/ JDK 1.8.0.121)
> > > # Please make sure that we publish artifacts compiled w/ Scala 2.10,
> > Scala
> > > 2.11, and Scala 2.12
> > >
> > > -Yi
> > >
> > > On Fri, Aug 18, 2017 at 11:59 AM, Fred Haifeng Ji <
> haifeng...@gmail.com>
> > > wrote:
> > >
> > > > This is a call for a vote on a release of Apache Samza 0.13.1. Thanks
> > to
> > > > everyone who has contributed to this release.
> > > >
> > > > The release candidate can be downloaded from here:
> > > > http://home.apache.org/~navina/samza-0.13.1-rc0/
> > > >
> > > >
> > > > The release candidate is signed with pgp key A211312E, which can be
> > found
> > > > on keyservers:
> > > > http://pgp.mit.edu/pks/lookup?op=get&search=0xEDFD8F9AA211312E
> > > >
> > > >
> > > > The git tag is release-0.13.1-rc0 and signed with the same pgp key:
> > > > https://git-wip-us.apache.org/repos/asf?p=samza.git;a=tag;h=
> > > > refs/tags/release-0.13.1-rc0
> > > >
> > > > Test binaries have been published to Maven's staging repository, and
> > are
> > > > available here:
> > > > *https://repository.apache.org/content/repositories/
> > orgapachesamza-1030/
> > > >  > orgapachesamza-1030/
> > > >*
> > > >
> > > >
> > > > 29 issues were resolved for this release: https://issues.apache
> > > > .org/jira/issues/?jql=project%20%3D%2012314526%20AND%20fixVe
> > > > rsion%20%3D%2012340845%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC
> > > >
> > > >
> > > > The vote will be open for 72 hours (ending at 1:00PM Monday,
> > 08/21/2017).
> > > >
> > > > Please download the release candidate, check the hashes/signature,
> > build
> > > it
> > > > and test it, and then please vote:
> > > >
> > > >
> > > > [ ] +1 approve
> > > >
> > > > [ ] +0 no opinion
> > > >
> > > > [ ] -1 disapprove (and reason why)
> > > >
> > > >
> > > > --
> > > > Fred Ji
> > > >
> > >
> >
>
>
>
> --
> Jagadish V,
> Graduate Student,
> Department of Computer Science,
> Stanford University
>



--
Haifeng (Fred)  Ji

[GitHub] samza pull request #282: Coordination utils factory

[sborya]

GitHub user sborya opened a pull request:

https://github.com/apache/samza/pull/282

Coordination utils factory

Some refactoring and cleanup.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sborya/samza CoordinationUtilsFactory

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/samza/pull/282.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #282


commit 9de7539727e227c92f67be4ae0d9de4a8a1ae26c
Author: Boris Shkolnik 
Date:   2017-08-22T17:36:18Z

created the factory

commit b6363ccfe6bb458047df11fff3e012e06cdd79b8
Author: Boris Shkolnik 
Date:   2017-08-22T18:42:56Z

removed reset, added close() per interface




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache Samza 0.13.1 RC0

[Fred Haifeng Ji]

Thanks to those who already tested the RC and voted.

Due to the weekend and the eclipse day, we are extending the vote till 1pm
Wednesday 8/23.

Thanks,

Fred

On Tue, Aug 22, 2017 at 9:59 AM, Jagadish Venkatraman <
jagadish1...@gmail.com> wrote:

> Ran check-all.sh, and it succeeded!
>
> +1 (non binding)
>
> On Mon, Aug 21, 2017 at 4:34 PM, xinyu liu  wrote:
>
> > Built the src, and ran the tests using check-all.sh. Most of the tests
> ran
> > fine. There was an transient test failure (
> > https://issues.apache.org/jira/browse/SAMZA-1405), which seems to be
> > caused
> > by the testing env (further investigation needed). I reran the tests
> again
> > and it passed. Since this test doesn't affect the build itself, I am +1
> > (non-binding).
> >
> > Thanks,
> > Xinyu
> >
> > On Mon, Aug 21, 2017 at 2:24 PM, Yi Pan  wrote:
> >
> > > Downloaded the source, compiled and ran the integration tests. All
> > passed.
> > >
> > > +1 (binding) w/ the following minor comments:
> > > # Please make a note in the release note that this version requires JDK
> > > 1.8.0.112+ (I have test w/ JDK 1.8.0.121)
> > > # Please make sure that we publish artifacts compiled w/ Scala 2.10,
> > Scala
> > > 2.11, and Scala 2.12
> > >
> > > -Yi
> > >
> > > On Fri, Aug 18, 2017 at 11:59 AM, Fred Haifeng Ji <
> haifeng...@gmail.com>
> > > wrote:
> > >
> > > > This is a call for a vote on a release of Apache Samza 0.13.1. Thanks
> > to
> > > > everyone who has contributed to this release.
> > > >
> > > > The release candidate can be downloaded from here:
> > > > http://home.apache.org/~navina/samza-0.13.1-rc0/
> > > >
> > > >
> > > > The release candidate is signed with pgp key A211312E, which can be
> > found
> > > > on keyservers:
> > > > http://pgp.mit.edu/pks/lookup?op=get&search=0xEDFD8F9AA211312E
> > > >
> > > >
> > > > The git tag is release-0.13.1-rc0 and signed with the same pgp key:
> > > > https://git-wip-us.apache.org/repos/asf?p=samza.git;a=tag;h=
> > > > refs/tags/release-0.13.1-rc0
> > > >
> > > > Test binaries have been published to Maven's staging repository, and
> > are
> > > > available here:
> > > > *https://repository.apache.org/content/repositories/
> > orgapachesamza-1030/
> > > >  > orgapachesamza-1030/
> > > >*
> > > >
> > > >
> > > > 29 issues were resolved for this release: https://issues.apache
> > > > .org/jira/issues/?jql=project%20%3D%2012314526%20AND%20fixVe
> > > > rsion%20%3D%2012340845%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC
> > > >
> > > >
> > > > The vote will be open for 72 hours (ending at 1:00PM Monday,
> > 08/21/2017).
> > > >
> > > > Please download the release candidate, check the hashes/signature,
> > build
> > > it
> > > > and test it, and then please vote:
> > > >
> > > >
> > > > [ ] +1 approve
> > > >
> > > > [ ] +0 no opinion
> > > >
> > > > [ ] -1 disapprove (and reason why)
> > > >
> > > >
> > > > --
> > > > Fred Ji
> > > >
> > >
> >
>
>
>
> --
> Jagadish V,
> Graduate Student,
> Department of Computer Science,
> Stanford University
>



-- 
Haifeng (Fred)  Ji

Re: [VOTE] Apache Samza 0.13.1 RC0

[Jagadish Venkatraman]

Ran check-all.sh, and it succeeded!

+1 (non binding)

On Mon, Aug 21, 2017 at 4:34 PM, xinyu liu  wrote:

> Built the src, and ran the tests using check-all.sh. Most of the tests ran
> fine. There was an transient test failure (
> https://issues.apache.org/jira/browse/SAMZA-1405), which seems to be
> caused
> by the testing env (further investigation needed). I reran the tests again
> and it passed. Since this test doesn't affect the build itself, I am +1
> (non-binding).
>
> Thanks,
> Xinyu
>
> On Mon, Aug 21, 2017 at 2:24 PM, Yi Pan  wrote:
>
> > Downloaded the source, compiled and ran the integration tests. All
> passed.
> >
> > +1 (binding) w/ the following minor comments:
> > # Please make a note in the release note that this version requires JDK
> > 1.8.0.112+ (I have test w/ JDK 1.8.0.121)
> > # Please make sure that we publish artifacts compiled w/ Scala 2.10,
> Scala
> > 2.11, and Scala 2.12
> >
> > -Yi
> >
> > On Fri, Aug 18, 2017 at 11:59 AM, Fred Haifeng Ji 
> > wrote:
> >
> > > This is a call for a vote on a release of Apache Samza 0.13.1. Thanks
> to
> > > everyone who has contributed to this release.
> > >
> > > The release candidate can be downloaded from here:
> > > http://home.apache.org/~navina/samza-0.13.1-rc0/
> > >
> > >
> > > The release candidate is signed with pgp key A211312E, which can be
> found
> > > on keyservers:
> > > http://pgp.mit.edu/pks/lookup?op=get&search=0xEDFD8F9AA211312E
> > >
> > >
> > > The git tag is release-0.13.1-rc0 and signed with the same pgp key:
> > > https://git-wip-us.apache.org/repos/asf?p=samza.git;a=tag;h=
> > > refs/tags/release-0.13.1-rc0
> > >
> > > Test binaries have been published to Maven's staging repository, and
> are
> > > available here:
> > > *https://repository.apache.org/content/repositories/
> orgapachesamza-1030/
> > >  orgapachesamza-1030/
> > >*
> > >
> > >
> > > 29 issues were resolved for this release: https://issues.apache
> > > .org/jira/issues/?jql=project%20%3D%2012314526%20AND%20fixVe
> > > rsion%20%3D%2012340845%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC
> > >
> > >
> > > The vote will be open for 72 hours (ending at 1:00PM Monday,
> 08/21/2017).
> > >
> > > Please download the release candidate, check the hashes/signature,
> build
> > it
> > > and test it, and then please vote:
> > >
> > >
> > > [ ] +1 approve
> > >
> > > [ ] +0 no opinion
> > >
> > > [ ] -1 disapprove (and reason why)
> > >
> > >
> > > --
> > > Fred Ji
> > >
> >
>



-- 
Jagadish V,
Graduate Student,
Department of Computer Science,
Stanford University

Re: Noise in Logs After Upgrade to 0.13

[Jeremiah Adams]

Thanks Prateek. That got me pointed in the right direction. 


Jeremiah Adams
Software Engineer
www.helixeducation.com
Blog | Twitter | Facebook | LinkedIn


From: prateek...@gmail.com  on behalf of Prateek 
Maheshwari 
Sent: Monday, August 21, 2017 2:30 PM
To: dev@samza.apache.org
Subject: Re: Noise in Logs After Upgrade to 0.13

Hi Jeremiah,

Can you check if your classpath has multiple SLF4J bindings and if it's
picking something other than log4j (e.g. logback) instead? If that's the
case, the other implementation might not have an explicit configuration and
default to logging everything to stdout.

You can verify by checking your container stdout/stderr. Does it have the
following warning: "Class path contains multiple SLF4J bindings."? If so,
the actual implementation being used should also be logged there.

See also: 
https://url.serverdata.net/?awlO-UmmFnWx_wSI8MvtKW5LGgUjiO2iklWCRFNGuk8CUdk_RewWk16unIcyD0E_Lxq1Ez-4Wa-UfndnLCrKQOA~~

Thanks,
Prateek

On Mon, Aug 21, 2017 at 11:44 AM, Jeremiah Adams 
wrote:

> I am seeing tons of noise in container logs after upgrading to samza 0.13.
> Changes to my job's log4j properties aren't affecting this output. Also,
> logs are now pointing output to stdout instead of the samza-cotnainer-n.log
> file.
>
>
> 18:42:19.761 [SAMZA-JVM-METRICS] DEBUG org.apache.samza.metrics.JvmMetrics
> - updating jvm metrics?
>
>
> What log4j file do I need to edit to correct this?
>
> Jeremiah Adams
> Software Engineer
> https://url.serverdata.net/?ahfhEufaAWbezBrUFPG98ZJcterGfIerU3ZwsA3Gv_C0~
> Blog
>  | 
> Twitter HelixEducation> | 
> Facebook
>  |
> LinkedIn
>