Re: [VOTE] Apache Samza 1.5.0 RC1

2020-06-12 Thread Yang Zhang
Done, https://issues.apache.org/jira/browse/SAMZA-2548.

Best,
Yang

On Fri, Jun 12, 2020 at 9:45 AM Yi Pan  wrote:

> Hey, Yang,
>
> Can you open a JIRA for this failure? This is again related to a test code
> using sleep() trying to make sure that the test is completed before
> verification.
>
> -Yi
>
> On Fri, Jun 12, 2020 at 8:01 AM Yang Zhang 
> wrote:
>
> > Being late to the party. Verified apache-samza-1.5.0-src.tgz in both
> Linux
> > and Mac.
> >
> > Linux (pass):
> >  - check-all.sh
> >  - yarn integration tests
> >  - standalone integration tests.
> >
> > Mac (fail, may be due to my mac local setup):
> >  - check-all.sh fails (can be reproduced)
> >
> > testBatchOperationTriggeredByTimer FAILED
> >
> > java.lang.AssertionError: expected:<0> but was:<100>
> >
> > at org.junit.Assert.fail(Assert.java:88)
> >
> > at org.junit.Assert.failNotEquals(Assert.java:834)
> >
> > at org.junit.Assert.assertEquals(Assert.java:645)
> >
> > at org.junit.Assert.assertEquals(Assert.java:631)
> >
> > at
> >
> >
> org.apache.samza.table.batching.TestBatchProcessor$TestBatchTriggered.testBatchOperationTriggeredByTimer(TestBatchProcessor.java:144)
> >
> >
> > 1303 tests completed, 1 failed, 3 skipped
> >
> > +0 no opinion (non binding)
> >
> >
> > On Thu, Jun 11, 2020 at 4:02 PM Boris S  wrote:
> >
> > > +1 (binding)
> > >
> > >- verified signatures
> > >- ran check-all
> > >- ran integration tests.
> > >
> > >
> > > On Mon, Jun 8, 2020 at 5:16 PM Bharath Kumara Subramanian <
> > > codin.mart...@gmail.com> wrote:
> > >
> > > > Hi all,
> > > >
> > > > This is a call for a vote on a release of Apache Samza 1.5.0. We are
> > > > excited to see some new features and improvements in this release.
> > > >
> > > > The release candidate can be downloaded from here:
> > > > http://home.apache.org/~bharathkk/samza-1.5.0-rc1/
> > > >
> > > > The release candidate is signed with pgp key F3B965A6B192DAB7, which
> is
> > > > included in the repository's KEYS file:
> > > > https://github.com/apache/samza/blob/master/KEYS
> > > >
> > > > or to directly see the public key here:
> > > >
> > > >
> > >
> >
> https://keyserver.ubuntu.com/pks/lookup?search=Bharath+Kumarasubramanian=on=index
> > > >
> > > > The git tag is release-1.5.0-rc0 and signed with the same pgp key
> > above:
> > > >
> > > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=samza.git;a=tag;h=refs/tags/release-1.5.0-rc1
> > > >
> > > > Test binaries have been published to Maven's staging repository, and
> > are
> > > > available here:
> > > >
> > https://repository.apache.org/content/repositories/orgapachesamza-1080/
> > > >
> > > > The vote will be open for 72 hours (end at 05:15pm Tuesday,
> > 06/11/2021).
> > > > Please download the release candidate, check the hashes/signature,
> > build
> > > it
> > > > and test it, and vote:
> > > >
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove (and reason why)
> > > >
> > > > I ran check-all.sh and integration tests (both YARN and standalone)
> > > passed.
> > > >
> > > > +1 on my end for the release.
> > > >
> > > > Thanks,
> > > > Bharath
> > > >
> > >
> >
>


Re: [VOTE] Apache Samza 1.5.0 RC1

2020-06-12 Thread Yi Pan
Hey, Yang,

Can you open a JIRA for this failure? This is again related to a test code
using sleep() trying to make sure that the test is completed before
verification.

-Yi

On Fri, Jun 12, 2020 at 8:01 AM Yang Zhang  wrote:

> Being late to the party. Verified apache-samza-1.5.0-src.tgz in both Linux
> and Mac.
>
> Linux (pass):
>  - check-all.sh
>  - yarn integration tests
>  - standalone integration tests.
>
> Mac (fail, may be due to my mac local setup):
>  - check-all.sh fails (can be reproduced)
>
> testBatchOperationTriggeredByTimer FAILED
>
> java.lang.AssertionError: expected:<0> but was:<100>
>
> at org.junit.Assert.fail(Assert.java:88)
>
> at org.junit.Assert.failNotEquals(Assert.java:834)
>
> at org.junit.Assert.assertEquals(Assert.java:645)
>
> at org.junit.Assert.assertEquals(Assert.java:631)
>
> at
>
> org.apache.samza.table.batching.TestBatchProcessor$TestBatchTriggered.testBatchOperationTriggeredByTimer(TestBatchProcessor.java:144)
>
>
> 1303 tests completed, 1 failed, 3 skipped
>
> +0 no opinion (non binding)
>
>
> On Thu, Jun 11, 2020 at 4:02 PM Boris S  wrote:
>
> > +1 (binding)
> >
> >- verified signatures
> >- ran check-all
> >- ran integration tests.
> >
> >
> > On Mon, Jun 8, 2020 at 5:16 PM Bharath Kumara Subramanian <
> > codin.mart...@gmail.com> wrote:
> >
> > > Hi all,
> > >
> > > This is a call for a vote on a release of Apache Samza 1.5.0. We are
> > > excited to see some new features and improvements in this release.
> > >
> > > The release candidate can be downloaded from here:
> > > http://home.apache.org/~bharathkk/samza-1.5.0-rc1/
> > >
> > > The release candidate is signed with pgp key F3B965A6B192DAB7, which is
> > > included in the repository's KEYS file:
> > > https://github.com/apache/samza/blob/master/KEYS
> > >
> > > or to directly see the public key here:
> > >
> > >
> >
> https://keyserver.ubuntu.com/pks/lookup?search=Bharath+Kumarasubramanian=on=index
> > >
> > > The git tag is release-1.5.0-rc0 and signed with the same pgp key
> above:
> > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=samza.git;a=tag;h=refs/tags/release-1.5.0-rc1
> > >
> > > Test binaries have been published to Maven's staging repository, and
> are
> > > available here:
> > >
> https://repository.apache.org/content/repositories/orgapachesamza-1080/
> > >
> > > The vote will be open for 72 hours (end at 05:15pm Tuesday,
> 06/11/2021).
> > > Please download the release candidate, check the hashes/signature,
> build
> > it
> > > and test it, and vote:
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove (and reason why)
> > >
> > > I ran check-all.sh and integration tests (both YARN and standalone)
> > passed.
> > >
> > > +1 on my end for the release.
> > >
> > > Thanks,
> > > Bharath
> > >
> >
>


Re: [VOTE] Apache Samza 1.5.0 RC1

2020-06-12 Thread Yang Zhang
Being late to the party. Verified apache-samza-1.5.0-src.tgz in both Linux
and Mac.

Linux (pass):
 - check-all.sh
 - yarn integration tests
 - standalone integration tests.

Mac (fail, may be due to my mac local setup):
 - check-all.sh fails (can be reproduced)

testBatchOperationTriggeredByTimer FAILED

java.lang.AssertionError: expected:<0> but was:<100>

at org.junit.Assert.fail(Assert.java:88)

at org.junit.Assert.failNotEquals(Assert.java:834)

at org.junit.Assert.assertEquals(Assert.java:645)

at org.junit.Assert.assertEquals(Assert.java:631)

at
org.apache.samza.table.batching.TestBatchProcessor$TestBatchTriggered.testBatchOperationTriggeredByTimer(TestBatchProcessor.java:144)


1303 tests completed, 1 failed, 3 skipped

+0 no opinion (non binding)


On Thu, Jun 11, 2020 at 4:02 PM Boris S  wrote:

> +1 (binding)
>
>- verified signatures
>- ran check-all
>- ran integration tests.
>
>
> On Mon, Jun 8, 2020 at 5:16 PM Bharath Kumara Subramanian <
> codin.mart...@gmail.com> wrote:
>
> > Hi all,
> >
> > This is a call for a vote on a release of Apache Samza 1.5.0. We are
> > excited to see some new features and improvements in this release.
> >
> > The release candidate can be downloaded from here:
> > http://home.apache.org/~bharathkk/samza-1.5.0-rc1/
> >
> > The release candidate is signed with pgp key F3B965A6B192DAB7, which is
> > included in the repository's KEYS file:
> > https://github.com/apache/samza/blob/master/KEYS
> >
> > or to directly see the public key here:
> >
> >
> https://keyserver.ubuntu.com/pks/lookup?search=Bharath+Kumarasubramanian=on=index
> >
> > The git tag is release-1.5.0-rc0 and signed with the same pgp key above:
> >
> >
> https://gitbox.apache.org/repos/asf?p=samza.git;a=tag;h=refs/tags/release-1.5.0-rc1
> >
> > Test binaries have been published to Maven's staging repository, and are
> > available here:
> > https://repository.apache.org/content/repositories/orgapachesamza-1080/
> >
> > The vote will be open for 72 hours (end at 05:15pm Tuesday, 06/11/2021).
> > Please download the release candidate, check the hashes/signature, build
> it
> > and test it, and vote:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> > I ran check-all.sh and integration tests (both YARN and standalone)
> passed.
> >
> > +1 on my end for the release.
> >
> > Thanks,
> > Bharath
> >
>