[GitHub] samza pull request #869: SAMZA-2022: Integrate startpoints with SystemConsum...

2019-01-22 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/samza/pull/869


---


[GitHub] samza pull request #869: SAMZA-2022: Integrate startpoints with SystemConsum...

2018-12-21 Thread dnishimura
GitHub user dnishimura opened a pull request:

https://github.com/apache/samza/pull/869

SAMZA-2022: Integrate startpoints with SystemConsumers

This PR integrates the `Startpoint` with the `SystemConsumers` multiplexer 
class. The general logic is if there is a `Startpoint` for an SSP in a task and 
the `SystemConsumer` implements the `StartpointVisitor` interface, it will 
apply the visitor method via `Startpoint#apply(SystemStreamPartition, 
StartpointVisitor)`. Otherwise, the 
`SystemConsumer#register(SystemStreamPartition, checkpointOffset:String)` 
method is called as it currently does.

@shanthoosh @cameronlee314 @prateekm - Please take a look... after the 
break is fine. If I don't respond to comments within 24-48 hours during my 
leave, please feel free to hijack this PR into another PR. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dnishimura/samza 
samza-2022-startpoint-systemconsumers-integ

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/samza/pull/869.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #869


commit 2aa244e8cdfdecd88aeba1c2be38acbb8cef5ac2
Author: Daniel Nishimura 
Date:   2018-12-20T20:09:36Z

SAMZA-2022: Integrate startpoints with SystemConsumers




---