[GitHub] samza pull request #890: Bugfix : Passing localityManager to JobModel when c...

2019-01-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/samza/pull/890


---


[GitHub] samza pull request #890: Bugfix : Passing localityManager to JobModel when c...

2019-01-23 Thread rmatharu
GitHub user rmatharu opened a pull request:

https://github.com/apache/samza/pull/890

Bugfix : Passing localityManager to JobModel when created from 
JobModelManager

Samza Standalone required JobModel refactoring, due to which jobModelRef 
(and localityManager) is set explicitly in JobModelManager: 
https://github.com/apache/samza/pull/790.

However the JobModel instances with the localityManager (jobModelRef) was 
not being used when apply() was being called on the JobModelManager by the 
ClusterBasedJC.
Due to which host-locality was not being read, causing host affinity to 
break in YARN.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rmatharu/samza bugfix-localityManager

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/samza/pull/890.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #890


commit 261501925584f89b1340035fb49f6bf7c61f5e66
Author: Ray Matharu 
Date:   2019-01-23T23:44:00Z

Bugfix : Passing localityManager when created in JobModelManager

commit bde2d67a798e7507228e8b07b434bb15e0f6ba1e
Author: Ray Matharu 
Date:   2019-01-23T23:45:04Z

removing comment




---