Re: Review Request 50682: SAMZA-993 Fix logging bug for some scala versions

2016-08-01 Thread Fred Ji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50682/#review144420
---


Ship it!




Ship It!

- Fred Ji


On Aug. 2, 2016, 12:13 a.m., Jake Maes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50682/
> ---
> 
> (Updated Aug. 2, 2016, 12:13 a.m.)
> 
> 
> Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, 
> Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data 
> Infrastructure).
> 
> 
> Bugs: SAMZA-993
> https://issues.apache.org/jira/browse/SAMZA-993
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> SAMZA-993 Fix logging bug for some scala versions
> 
> 
> Diffs
> -
> 
>   samza-core/src/main/scala/org/apache/samza/util/Logging.scala 
> 9a4ed897d58e90d61fdde14dd51ac5ba2d9edd36 
> 
> Diff: https://reviews.apache.org/r/50682/diff/
> 
> 
> Testing
> ---
> 
> Running checkall now...
> 
> 
> Thanks,
> 
> Jake Maes
> 
>



Re: Review Request 50682: SAMZA-993 Fix logging bug for some scala versions

2016-08-01 Thread Xinyu Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50682/#review144417
---


Ship it!




+1. thanks for the quick fix!

- Xinyu Liu


On Aug. 2, 2016, 12:13 a.m., Jake Maes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50682/
> ---
> 
> (Updated Aug. 2, 2016, 12:13 a.m.)
> 
> 
> Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, 
> Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data 
> Infrastructure).
> 
> 
> Bugs: SAMZA-993
> https://issues.apache.org/jira/browse/SAMZA-993
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> SAMZA-993 Fix logging bug for some scala versions
> 
> 
> Diffs
> -
> 
>   samza-core/src/main/scala/org/apache/samza/util/Logging.scala 
> 9a4ed897d58e90d61fdde14dd51ac5ba2d9edd36 
> 
> Diff: https://reviews.apache.org/r/50682/diff/
> 
> 
> Testing
> ---
> 
> Running checkall now...
> 
> 
> Thanks,
> 
> Jake Maes
> 
>



Re: Review Request 50682: SAMZA-993 Fix logging bug for some scala versions

2016-08-01 Thread Navina Ramesh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50682/#review144414
---


Ship it!




Ship It!

- Navina Ramesh


On Aug. 2, 2016, 12:13 a.m., Jake Maes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50682/
> ---
> 
> (Updated Aug. 2, 2016, 12:13 a.m.)
> 
> 
> Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, 
> Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data 
> Infrastructure).
> 
> 
> Bugs: SAMZA-993
> https://issues.apache.org/jira/browse/SAMZA-993
> 
> 
> Repository: samza
> 
> 
> Description
> ---
> 
> SAMZA-993 Fix logging bug for some scala versions
> 
> 
> Diffs
> -
> 
>   samza-core/src/main/scala/org/apache/samza/util/Logging.scala 
> 9a4ed897d58e90d61fdde14dd51ac5ba2d9edd36 
> 
> Diff: https://reviews.apache.org/r/50682/diff/
> 
> 
> Testing
> ---
> 
> Running checkall now...
> 
> 
> Thanks,
> 
> Jake Maes
> 
>



Review Request 50682: SAMZA-993 Fix logging bug for some scala versions

2016-08-01 Thread Jake Maes

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50682/
---

Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, 
Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data 
Infrastructure).


Bugs: SAMZA-993
https://issues.apache.org/jira/browse/SAMZA-993


Repository: samza


Description
---

SAMZA-993 Fix logging bug for some scala versions


Diffs
-

  samza-core/src/main/scala/org/apache/samza/util/Logging.scala 
9a4ed897d58e90d61fdde14dd51ac5ba2d9edd36 

Diff: https://reviews.apache.org/r/50682/diff/


Testing
---

Running checkall now...


Thanks,

Jake Maes