[GitHub] Yongyao commented on issue #11: SDAP-36 MUDROD Storage unit test suite

2018-04-27 Thread GitBox 
Yongyao commented on issue #11: SDAP-36 MUDROD Storage unit test suite
URL: 
https://github.com/apache/incubator-sdap-mudrod/pull/11#issuecomment-385013485
 
 
   @lewismc Thanks for the explanation. Now I see why we need the embedded 
server. Sure, I will go over the guideline with him next week.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Yongyao commented on issue #11: SDAP-36 MUDROD Storage unit test suite

2018-04-26 Thread GitBox 
Yongyao commented on issue #11: SDAP-36 MUDROD Storage unit test suite
URL: 
https://github.com/apache/incubator-sdap-mudrod/pull/11#issuecomment-384704662
 
 
   @lewismc Kejin has added the embedded ES server as you suggested, but he got 
stuck because the client 
(https://github.com/Yongyao/incubator-sdap-mudrod/blob/SDAP-36/core/src/test/java/org/apache/sdap/mudrod/driver/ESDriverTest.java#L53)
 he got through this approach is null. I am actually a little confused with the 
embedded server approach. Why do you need it? The sample code you provided 
seems to create a ES client, which is the same as the one we created through 
ESdriver.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services