[jira] [Commented] (SDAP-84) Fix bugs in FeatureBasedSimilarity.java
[
https://issues.apache.org/jira/browse/SDAP-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487526#comment-16487526
]
ASF GitHub Bot commented on SDAP-84:
lewismc closed pull request #25: SDAP-84
URL: https://github.com/apache/incubator-sdap-mudrod/pull/25
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core/src/main/java/org/apache/sdap/mudrod/recommendation/process/FeatureBasedSimilarity.java
b/core/src/main/java/org/apache/sdap/mudrod/recommendation/process/FeatureBasedSimilarity.java
index c7c7497..3a18795 100644
---
a/core/src/main/java/org/apache/sdap/mudrod/recommendation/process/FeatureBasedSimilarity.java
+++
b/core/src/main/java/org/apache/sdap/mudrod/recommendation/process/FeatureBasedSimilarity.java
@@ -194,7 +194,11 @@ public void normalizeVariableWeight(ESDriver es) {
}
}
-double weight = totalSim / totalWeight;
+double weight = 0.0;
+if(totalWeight != 0){
+ weight = totalSim / totalWeight;
+}
+
UpdateRequest ur = es.generateUpdateRequest(indexName,
variableSimType, hit.getId(), "weight", weight);
es.getBulkProcessor().add(ur);
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix bugs in FeatureBasedSimilarity.java
> ---
>
> Key: SDAP-84
> URL: https://issues.apache.org/jira/browse/SDAP-84
> Project: Apache Science Data Analytics Platform
> Issue Type: Bug
> Components: mudrod
>Reporter: Yun Li
>Priority: Major
> Fix For: 0.1
>
>
> Fix bugs in FeatureBasedSimilarity.java @[~lewismc]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SDAP-84) Fix bugs in FeatureBasedSimilarity.java
[ https://issues.apache.org/jira/browse/SDAP-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487527#comment-16487527 ] ASF GitHub Bot commented on SDAP-84: lewismc commented on issue #25: SDAP-84 URL: https://github.com/apache/incubator-sdap-mudrod/pull/25#issuecomment-391401647 @quintinali Please clean up JIRA This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix bugs in FeatureBasedSimilarity.java > --- > > Key: SDAP-84 > URL: https://issues.apache.org/jira/browse/SDAP-84 > Project: Apache Science Data Analytics Platform > Issue Type: Bug > Components: mudrod >Reporter: Yun Li >Priority: Major > Fix For: 0.1 > > > Fix bugs in FeatureBasedSimilarity.java @[~lewismc] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SDAP-84) Fix bugs in FeatureBasedSimilarity.java
[ https://issues.apache.org/jira/browse/SDAP-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482794#comment-16482794 ] ASF GitHub Bot commented on SDAP-84: asfgit commented on issue #25: SDAP-84 URL: https://github.com/apache/incubator-sdap-mudrod/pull/25#issuecomment-390729602 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix bugs in FeatureBasedSimilarity.java > --- > > Key: SDAP-84 > URL: https://issues.apache.org/jira/browse/SDAP-84 > Project: Apache Science Data Analytics Platform > Issue Type: Bug > Components: mudrod >Reporter: Yun Li >Priority: Major > Fix For: 0.1 > > > Fix bugs in FeatureBasedSimilarity.java @[~lewismc] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SDAP-84) Fix bugs in FeatureBasedSimilarity.java
[ https://issues.apache.org/jira/browse/SDAP-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482793#comment-16482793 ] ASF GitHub Bot commented on SDAP-84: quintinali opened a new pull request #25: SDAP-84 URL: https://github.com/apache/incubator-sdap-mudrod/pull/25 Fixed bugs in FeatureBasedSimilarity This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix bugs in FeatureBasedSimilarity.java > --- > > Key: SDAP-84 > URL: https://issues.apache.org/jira/browse/SDAP-84 > Project: Apache Science Data Analytics Platform > Issue Type: Bug > Components: mudrod >Reporter: Yun Li >Priority: Major > Fix For: 0.1 > > > Fix bugs in FeatureBasedSimilarity.java @[~lewismc] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
