Re: JTS 1.16.2

[Felix Cheung]

I believe this is the jts discussion in the other thread.

On Mon, Nov 16, 2020 at 12:54 PM Netanel Malka  wrote:

> Hi Jia,
> I tried to use the branch sedona-1.0-doc but the artifact for 1.16.2 is
> not in the Maven Central so I cannot compile the project.
>
> I got:
> The POM for org.locationtech.jts:jts-core:jar:1.16.2 is missing, no
> dependency information available
>
> I searched for the artifact here:
> https://mvnrepository.com/artifact/org.locationtech.jts/jts-core
> And also in the JCenter repo here:
>
> https://bintray.com/bintray/jcenter/org.locationtech.jts%3Ajts-core#files/org/locationtech/jts/jts-core
>
> As you can see there is no artifact for 1.16.2 only for 1.16.1 or 1.17.x
>
> Can you downgrade to 1.16.1 or upgrade to 1.17.1?
>
> Thanks.
>

Re: First Sedona release

[Jim Hughes]

Hi Jia,

Thanks for putting up the PRs.  Martin and I have commented on them.  If 
you are interested in a more real-time discussion than the PRs, Martin 
and I are both in the JTS Gitter (https://gitter.im/locationtech/jts).


To ask directly, please do not fork JTS.  You will be unable to publish 
1.16.2 artifacts on Maven central.  Finding another way to do this will 
cause confusion.


Cheers,

Jim

On 11/16/20 2:28 AM, Jia Yu wrote:

Dear all,

Thanks for all your suggestions.

1. To completely solve the long-overdue JTS issue, I made a Sedona PR and
two JTS PRs. @Jim Hughes  , @Paweł Kociński
 , I, and probably Martin from JTS will take
care of these PRs in the coming days.
(1) Sedona PR: https://github.com/apache/incubator-sedona/pull/488
(2) JTS PR: https://github.com/locationtech/jts/pull/633
https://github.com/locationtech/jts/pull/634

2. To move forward with the first release, I have deleted the "SNAPSHOT" in
my JTS 1.16 fork.
Most likely, we have to move forward with my JTS 1.16 fork in the first
Sedona release because of the conflict among JTStoGeoJSON, GeoTools, and
JTS 1.17.
So @Netanel Malka   could you please do another
dry-run on the Sedona first release on this Sedona branch: sedona-1.0-doc:
https://github.com/apache/incubator-sedona/tree/sedona-1.0-doc

Thanks,
Jia

On Thu, Nov 12, 2020 at 11:36 AM Jim Hughes  wrote:


Hi Mo,

I can definitely help.  The first step will be for Jia to push a PR for
the JTS changes.  (Since they are his changes, I cannot do this on his
behalf.)

  From talking to the lead JTS developer, he wanted to see the previous
PR (from months/a year+ ago) split up.  I think the initial PR should be
used to discuss what changes are sensible for JTS and where we'll need
to push some of the changes to Sedona.

Concretely, I noticed that the Sedona JTS fork changes the toString on
Geometry to include printing out the userData.  I imagine that may cause
trouble for downstream JTS users, so it'd be good to find an
alternative.  One suggestion would to be add a static method in Sedona
for printing a Geometry with its userData object.

Cheers,

Jim

On 11/12/20 12:32 PM, Mohamed Sarwat wrote:

Folks,

I totally agree with Jim on that. Jim, would you like to take the lead

on that - I trust that you can bring this task to completion. Jia, would
you please let us know how we can incorporate the changes into the JTS
master branch?

Thanks,


On Nov 12, 2020, at 10:10 AM, Jim Hughes  wrote:

Hi all,

As a JTS committer, I have tried to request that the Sedona project

discuss the desired changes to JTS previously.  I'd still encourage that.

JTS is an active project and I feel that maintaining a fork of JTS is

unnecessary and inappropriate.

Cheers,

Jim


On 11/11/20 9:04 PM, Felix Cheung wrote:
Ah. You will need to publish it in order for the dependency chain to

work

on Maven Central

However, since you are not the project owner there you might need to
publish that under a different artifact id.

In general, it would be best to avoid hard forking another project like
this.



On Wed, Nov 11, 2020 at 1:05 PM Jia Yu  wrote:

Hi Netanel,

That links to this git submodule:
https://github.com/jiayuasu/jts/blob/1.16.x/modules/core/pom.xml#L6

I can easily fix this by changing the version number here to 1.16.2
excluding "SNAPSHOT":
https://github.com/jiayuasu/jts/blob/1.16.x/modules/core/pom.xml#L6

Will this solve the problem?

On Wed, Nov 11, 2020 at 7:40 AM Netanel Malka 
wrote:


Hi Folks,

I tried to make a release (dry-run) following by
publishing-maven-artifacts
, and I
encountered an issue.

On sedona-core, we have jts-core as a dependency with the SNAPSHOT
version.
(link
<


https://github.com/apache/incubator-sedona/blob/2e60fc07b0eae78ccae3876d970e677fc9319c40/core/pom.xml#L37

)

As a prerequisite to the release process, we cannot have

dependencies in a

SNAPSHOT version.


Do you have any clue about how to solve this?


On Mon, 9 Nov 2020 at 21:22, Netanel Malka 

wrote:

OK. Thanks Felix.


Updates:

*
*   Opened a ticket for INFRA to Enable Nexus Access For Sedona<
https://issues.apache.org/jira/browse/INFRA-21085>
*   Followed this<
https://infra.apache.org/publishing-maven-artifacts.html> guide to

test

the maven release process
*   I hope to create a PR soon for adjusting the build to deploy

to

the

ASF Nexus repository
*   The key that signs the artifacts were created and tested.

Do we want to create a candidate release for the current master

branch?

Netanel Malka,
Big Data Consultant
[Description: Description: Description: Description:
cid:image001.jpg@01C85203.36A2AF30]

From: Felix Cheung 
Sent: Wednesday, November 4, 2020 19:57
To: dev@sedona.apache.org
Cc: Jinxuan Wu; Mohamed Sarwat; Netanel Malka; Paweł Kociński;

Zongsi

Zhang

Subject: Re: First Sedona release

1) No you don’t need KEYS file in github only on the release share

JTS 1.16.2

[Netanel Malka]

Hi Jia,
I tried to use the branch sedona-1.0-doc but the artifact for 1.16.2 is not in 
the Maven Central so I cannot compile the project.

I got:
The POM for org.locationtech.jts:jts-core:jar:1.16.2 is missing, no dependency 
information available

I searched for the artifact here:
https://mvnrepository.com/artifact/org.locationtech.jts/jts-core
And also in the JCenter repo here:
https://bintray.com/bintray/jcenter/org.locationtech.jts%3Ajts-core#files/org/locationtech/jts/jts-core

As you can see there is no artifact for 1.16.2 only for 1.16.1 or 1.17.x

Can you downgrade to 1.16.1 or upgrade to 1.17.1?

Thanks.