Re: [VOTE] Graduate Apache Sedona (incubating) to a Top Level Project

[Paweł Kociński]

If my vote counts :)
+1 binding

śr., 22 cze 2022 o 07:12 Jia Yu  napisał(a):

> Dear all,
>
> We need one more +1 binding vote for this :-)
>
> Thanks,
> Jia
>
> On Sat, Jun 18, 2022 at 10:04 PM Netanel Malka 
> wrote:
>
>> +1
>>
>> On Sun, 19 Jun 2022, 4:32 Mo Sarwat  wrote:
>>
>> > +1
>> >
>> >
>> > On Sat, Jun 18, 2022 at 6:05 PM Jia Yu  wrote:
>> >
>> > > Dear all in the community,
>> > >
>> > > I am starting a vote to graduate Apache Sedona (incubating) as a Top
>> > Level
>> > > Project.
>> > >
>> > > After a community discussion [1], we gathered a lot of feedback that
>> > > the community supported Sedona to graduate from the Apache incubator
>> > > as a top-level Apache project.
>> > >
>> > > Sedona has been incubating since 07-19-2020. For almost 2 years, the
>> > > Sedona community has made great progress and grown rapidly under the
>> > > guidance of our mentors. We believe the Sedona project has met the
>> > > conditions for graduation. Project maturity model is detailed in [2],
>> > > and the summary on the state of the community are listed below.
>> > >
>> > > Sedona joined the Apache Incubator on July 19 2020. As of May 29 2022
>> > >
>> > > ***Community statistics***
>> > >
>> > > - number of contributions (commits) since incubation
>> > > 265
>> > > Overall: 965
>> > > 27% of the commits were added since incubation.
>> > >
>> > > - number of contributors (and growth since incubation)
>> > > 40
>> > > Overall: 74
>> > > 54% of the contributors joined since incubation
>> > >
>> > > - email discussions since incubation: 798 threads on
>> > dev@sedona.apache.org
>> > >
>> > > - releases: 5
>> > >
>> > > - number of release managers: 2 (Jia Yu and Paweł Kociński)
>> > >
>> > > - affiliations of committers / PPMC members
>> > > Paweł Kociński: GetInData (Poland)
>> > > Netanel Malka: Sela Group (Israel)
>> > > Jinxuan Wu: Bloomberg (US)
>> > > Zongsi Zhang: Grab (Singapore)
>> > > Jia Yu: Washington State University (US)
>> > > Mohame Sarwat: Arizona State University (US)
>> > > Yitao Li: SafeGraph (US)
>> > >
>> > > - new committers or PPMC members since incubation
>> > > Yitao Li: SafeGraph
>> > >
>> > > - monthly downloads:
>> > > over 500k from Maven Central, PyPi and CRAN.
>> > >
>> > > ***Code, License, and Copyright***
>> > >
>> > > Sedona community maintains project code on GitHub, and all modules
>> > > code is under Apache 2.0 license. We have reviewed all the
>> > > dependencies and ensured they do not bring any license issues [3]. All
>> > > the status files, license headers, and copyright are up to date.
>> > >
>> > > ***Quality***
>> > >
>> > > Sedona community created 5 GitHub Workflows [4], which cover
>> > > compilation, unit testing, integration testing, etc. All code patches
>> > need
>> > > to pass these
>> > > pipelines first. In addition, Sedona has a matching Pull Request
>> > > template and commit requirements to ensure that all commits have
>> > > corresponding classification and traceability.
>> > >
>> > > ***Independence***
>> > >
>> > > All of the 7 PPMC members are spread across 7 different
>> > > organizations.
>> > >
>> > > For these reasons, we initiate this vote on whether to graduate Sedona
>> > > from Apache Incubator, everyone from the Sedona community has the
>> > > right to vote, please vote on graduating Sedona from Apache Incubator:
>> > >
>> > > [ ] +1 yes, I support Sedona to graduate from the Apache incubator and
>> > > become a top-level Apache project.
>> > >
>> > > [ ] +0 no opinion
>> > >
>> > > [ ] -1 no, the Sedona project is not ready to graduate, because ...
>> > >
>> > > This vote will be open for at least 72 hours or until receive 3 +1
>> vote
>> > > from PPMC.
>> > >
>> > > [1] https://lists.apache.org/thread/svd06kp5dojvw7pyk731tbrzkqfhjzbs
>> > > [2] https://issues.apache.org/jira/browse/SEDONA-81
>> > > [3] https://github.com/apache/incubator-sedona/blob/master/LICENSE
>> > > [4]
>> > >
>> https://github.com/apache/incubator-sedona/tree/master/.github/workflows
>> > >
>> >
>>
>

[ANNOUNCE] Apache Sedona 1.2.0-incubating released

[Paweł Kociński]

Dear all,

We are happy to report that we have released Apache Sedona (incubating)
1.2.0-incubating. Thank you again for your help.

Apache Sedona (incubating) is a cluster computing system for processing
large-scale spatial data.

Vote thread (
https://lists.apache.org/thread/fwssqf9vdcyb142wt92pcdnxjxjol8jc):
Vote result thread (
https://lists.apache.org/thread/xqpf44wqqr0ozhxkf30c6y674ltc6623):

Website:
http://sedona.apache.org/

Release notes:
https://github.com/apache/incubator-sedona/blob/sedona-1.2.0-incubating/docs/setup/release-notes.md

Download links:
https://github.com/apache/incubator-sedona/releases/tag/sedona-1.2.0-incubating

Additional resources:
Get started: http://sedona.apache.org/setup/overview/
Tutorials: http://sedona.apache.org/tutorial/rdd/
Mailing list: dev@sedona.apache.org
Twitter: https://twitter.com/ApacheSedona
Gitter: https://gitter.im/apache/sedona

Regards,
Apache Sedona (incubating) Team

[RESULT][VOTE] Release Apache Sedona 1.2.0-incubating-rc2

[Paweł Kociński]

Dear all,

The vote closes now as 72hr have passed. The vote PASSES with

+? (binding): themosar...@gmail.com, yita...@apache.org
+? (non-binding):
No -1 votes

The vote thread (https://lists.apache.org/list.html?dev@sedona.apache.org):

I will now bring the vote to gene...@incubator.apache.org to get
approval by the IPMC. If this vote passes too, the release is accepted and
will be published.

Regards,
Paweł

[VOTE] Release Apache Sedona 1.2.0-incubating-rc2

[Paweł Kociński]

Hi all,

This is a call for vote on Apache Sedona 1.2.0-incubating-rc2 (previous was
stopped due to changes in the NOTICE file). Please refer to the changes
listed at the bottom of this email.

Release notes:
https://github.com/apache/incubator-sedona/blob/sedona-1.2.0-incubating-rc2/docs/setup/release-notes.md

Build instructions:
https://github.com/apache/incubator-sedona/blob/sedona-1.2.0-incubating-rc2/docs/setup/compile.md

GitHub tag:
https://github.com/apache/incubator-sedona/releases/tag/sedona-1.2.0-incubating-rc2

GPG public key to verify the Release:
https://dist.apache.org/repos/dist/dev/incubator/sedona/KEYS

Source code and binaries:
https://dist.apache.org/repos/dist/dev/incubator/sedona/1.2.0-incubating-rc2/

The vote will be open for at least 72 hours or until a majority of at least
3 "approve" PMC votes are cast

Please vote accordingly:

[ ] +1 approve

[ ] +0 no opinion

[ ] -1 disapprove with the reason

Checklist for reference (because of DISCLAIMER-WIP, other checklist items
are not blockers):

[ ] Download links are valid.

[ ] Checksums and PGP signatures are valid.

[ ] DISCLAIMER is included.

[ ] Source code artifacts have correct names matching the current release.

For a detailed checklist  please refer to:
https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist


Changes after previous release candidate (rc-1)
- Notice file has been fixed in the pr
https://github.com/apache/incubator-sedona/pull/594/files

Re: [VOTE] Release Apache Sedona 1.2.0-incubating-rc2

[Paweł Kociński]

Apologies, I sent from wrong email address, please ignore this message I
will send from apache domain shortly.

wt., 5 kwi 2022 o 08:30 Paweł Kociński 
napisał(a):

> Hi all,
>
> This is a call for vote on Apache Sedona 1.2.0-incubating-rc2 (previous
> was stopped due to changes in the NOTICE file). Please refer to the changes
> listed at the bottom of this email.
>
> Release notes:
>
> https://github.com/apache/incubator-sedona/blob/sedona-1.2.0-incubating-rc2/docs/setup/release-notes.md
>
> Build instructions:
>
> https://github.com/apache/incubator-sedona/blob/sedona-1.2.0-incubating-rc2/docs/setup/compile.md
>
> GitHub tag:
>
> https://github.com/apache/incubator-sedona/releases/tag/sedona-1.2.0-incubating-rc2
>
> GPG public key to verify the Release:
> https://dist.apache.org/repos/dist/dev/incubator/sedona/KEYS
>
> Source code and binaries:
>
> https://dist.apache.org/repos/dist/dev/incubator/sedona/1.2.0-incubating-rc2/
>
> The vote will be open for at least 72 hours or until a majority of at
> least 3 "approve" PMC votes are cast
>
> Please vote accordingly:
>
> [ ] +1 approve
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
> Checklist for reference (because of DISCLAIMER-WIP, other checklist items
> are not blockers):
>
> [ ] Download links are valid.
>
> [ ] Checksums and PGP signatures are valid.
>
> [ ] DISCLAIMER is included.
>
> [ ] Source code artifacts have correct names matching the current release.
>
> For a detailed checklist  please refer to:
>
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>
> 
> Changes after previous release candidate (rc-1)
> - Notice file has been fixed in the pr
> https://github.com/apache/incubator-sedona/pull/594/files
>

[VOTE] Release Apache Sedona 1.2.0-incubating-rc2

[Paweł Kociński]

Hi all,

This is a call for vote on Apache Sedona 1.2.0-incubating-rc2 (previous was
stopped due to changes in the NOTICE file). Please refer to the changes
listed at the bottom of this email.

Release notes:
https://github.com/apache/incubator-sedona/blob/sedona-1.2.0-incubating-rc2/docs/setup/release-notes.md

Build instructions:
https://github.com/apache/incubator-sedona/blob/sedona-1.2.0-incubating-rc2/docs/setup/compile.md

GitHub tag:
https://github.com/apache/incubator-sedona/releases/tag/sedona-1.2.0-incubating-rc2

GPG public key to verify the Release:
https://dist.apache.org/repos/dist/dev/incubator/sedona/KEYS

Source code and binaries:
https://dist.apache.org/repos/dist/dev/incubator/sedona/1.2.0-incubating-rc2/

The vote will be open for at least 72 hours or until a majority of at least
3 "approve" PMC votes are cast

Please vote accordingly:

[ ] +1 approve

[ ] +0 no opinion

[ ] -1 disapprove with the reason

Checklist for reference (because of DISCLAIMER-WIP, other checklist items
are not blockers):

[ ] Download links are valid.

[ ] Checksums and PGP signatures are valid.

[ ] DISCLAIMER is included.

[ ] Source code artifacts have correct names matching the current release.

For a detailed checklist  please refer to:
https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist


Changes after previous release candidate (rc-1)
- Notice file has been fixed in the pr
https://github.com/apache/incubator-sedona/pull/594/files

[RESULT][VOTE] Release Apache Sedona 1.2.0-incubating-rc1

[Paweł Kociński]

Dear all,

The vote closes now as 72hr have passed. The vote PASSES with

+? (binding): ji...@apache.org, netanel...@gmail.com, themosar...@gmail.com
+? (non-binding):
No -1 votes

The vote thread (Permalink from https://lists.apache.org/list.html):

I will now bring the vote to gene...@incubator.apache.org to get
approval by the IPMC. If this vote passes too, the release is accepted and
will be published.

Regards,
Paweł

[VOTE] Release Apache Sedona 1.2.0-incubating-rc1

[Paweł Kociński]

Hi all,

This is a call for vote on Apache Sedona 1.2.0-incubating-rc1. Please refer
to the changes listed at the bottom of this email.

Release notes:
https://github.com/apache/incubator-sedona/blob/sedona-1.2.0-incubating-rc1/docs/setup/release-notes.md

Build instructions:
https://github.com/apache/incubator-sedona/blob/sedona-1.2.0-incubating-rc1/docs/setup/compile.md

GitHub tag:
https://github.com/apache/incubator-sedona/releases/tag/sedona-1.2.0-incubating-rc1

GPG public key to verify the Release:
https://downloads.apache.org/incubator/sedona/KEYS

Source code and binaries:
https://dist.apache.org/repos/dist/dev/incubator/sedona/1.2.0-incubating-rc1/

The vote will be open for at least 72 hours or until a majority of at least
3 "approve" PMC votes are cast

Please vote accordingly:

[ ] +1 approve

[ ] +0 no opinion

[ ] -1 disapprove with the reason

Checklist for reference (because of DISCLAIMER-WIP, other checklist items
are not blockers):

[ ] Download links are valid.

[ ] Checksums and PGP signatures are valid.

[ ] DISCLAIMER is included.

[ ] Source code artifacts have correct names matching the current release.

For a detailed checklist  please refer to:
https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist



Changes according to the comments on the previous release
Original comment (Permalink from https://lists.apache.org/list.html):
https://lists.apache.org/thread/d2wbfqmmrnvd8wlfgyynt87xq8cs1k4v

1. NOTICE file
Fixed (see https://github.com/apache/incubator-sedona/pull/594)

2. headers for R workflow scripts
Added (see https://github.com/apache/incubator-sedona/pull/594)

3. checksum and signature name on Sedona website download page
Fixed (see https://sedona.apache.org/download/)

Regards,
Paweł

Re: [DISCUSS] Graduate Sedona to Top Level Project

[Paweł Kociński]

That sounds awesome. Can I help you somehow with the process ?


W dniu pt., 10.12.2021 o 01:56 Jia Yu  napisał(a):

> Dear all,
>
> It has been 16 months since Apache Sedona joined the Apache Incubator in
> July 2020. We have made 4 Apache releases so far. I think it is a good time
> to start the discussion of  graduating Apache Sedona from the incubator to
> become a Top Level Project.
>
> For graduation, to the best of my knowledge, we need to follow the
> graduation guideline [1] and podling status report [2]. After a brief
> evaluation, I think most of the remaining steps are to clear up the
> copyright issues.
>
> Please feel free to chime in if you think there are any blockers.
> Meanwhile, I will start to fix the issues on our way to graduation.
>
> [1] https://incubator.apache.org/guides/graduation.html
> [2] https://incubator.apache.org/projects/sedona.html
>
> Thanks,
> Jia
>

Re: [VOTE] Release Apache Sedona 1.1.1-incubating-rc1

[Paweł Kociński]

+1

W dniu czw., 18.11.2021 o 00:24 Mohamed Sarwat  napisał(a):

> +1
>
>
> On Nov 17, 2021, at 4:21 PM, Jia Yu  wrote:
>
> 
>
> Folks,
>
> We need 2 more binding votes in order to pass. Please cast your vote when
> you have time.
>
> Thank you so much!
> Jia
>
> On Sun, Nov 14, 2021 at 10:17 AM Netanel Malka 
> wrote:
>
>> +1
>>
>> Great work!
>>
>> On Sun, Nov 14, 2021, 20:13 Adam Binford  wrote:
>>
>> > +1 (non-binding)
>> >
>> > On Sun, Nov 14, 2021, 3:00 AM Jia Yu  wrote:
>> >
>> >> Hi all, This is a call for vote on Apache Sedona 1.1.1-incubating-rc1.
>> >> Please refer to the changes listed at the bottom of this email. Release
>> >> notes:
>> >>
>> >>
>> https://github.com/apache/incubator-sedona/blob/sedona-1.1.1-incubating-rc1/docs/download/release-notes.md
>> 
>> >> Build instructions:
>> >>
>> >>
>> https://github.com/apache/incubator-sedona/blob/sedona-1.1.1-incubating-rc1/docs/download/compile.md
>> 
>> >> GitHub tag:
>> >>
>> >>
>> https://github.com/apache/incubator-sedona/releases/tag/sedona-1.1.1-incubating-rc1
>> 
>> >> GPG public key to verify the Release:
>> >> https://dist.apache.org/repos/dist/dev/incubator/sedona/KEYS
>> 
>> Source code
>> >> and binaries:
>> >>
>> >>
>> https://dist.apache.org/repos/dist/dev/incubator/sedona/1.1.1-incubating-rc1/
>> 
>> >> The vote will be open for at least 72 hours or until a majority of at
>> >> least
>> >> 3 "approve" PMC votes are cast Please vote accordingly: [ ] +1 approve
>> [ ]
>> >> +0 no opinion [ ] -1 disapprove with the reason Checklist for reference
>> >> (because of DISCLAIMER-WIP, other checklist items are not blockers): [
>> ]
>> >> Download links are valid. [ ] Checksums and PGP signatures are valid.
>> [ ]
>> >> DISCLAIMER is included. [ ] Source code artifacts have correct names
>> >> matching the current release. For a detailed checklist please refer to:
>> >>
>> >>
>> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>> 
>> >>
>> >
>>
>

Re: [VOTE] Release Apache Sedona 1.1.0-incubating-rc1

[Paweł Kociński]

+1

pt., 1 paź 2021, 11:59 użytkownik Netanel Malka 
napisał:

> +1
>
> @Paweł Kociński 
> Yes. but Jia revert the PR so it won't be included in that release.
> I will try to look into this soon.
>
>
> On Fri, 1 Oct 2021 at 08:18, Paweł Kociński 
> wrote:
>
>> Hi,
>> Is this issue still remain the problem ?
>> https://github.com/apache/incubator-sedona/commit/a0ed49da0b62ce591d858e5dccd5cebb69a8e695#comments
>>
>> Regards,
>> Paweł
>>
>> czw., 30 wrz 2021 o 15:44 Mo Sarwat  napisał(a):
>>
>>> +1
>>>
>>> On Wed, Sep 29, 2021 at 9:38 PM Jia Yu  wrote:
>>>
>>>> CC several key members in the community
>>>>
>>>>
>>>>
>>>> On Wed, Sep 29, 2021 at 9:31 PM Jia Yu  wrote:
>>>>
>>>> > Hi all,
>>>> >
>>>> > This is a call for vote on Apache Sedona 1.1.0-incubating-rc1. Please
>>>> > refer to the changes listed at the bottom of this email.
>>>> >
>>>> > Release notes:
>>>> >
>>>> >
>>>> https://github.com/apache/incubator-sedona/blob/sedona-1.1.0-incubating-rc1/docs/download/release-notes.md
>>>> >
>>>> > Build instructions:
>>>> >
>>>> >
>>>> https://github.com/apache/incubator-sedona/blob/sedona-1.1.0-incubating-rc1/docs/download/compile.md
>>>> >
>>>> > GitHub tag:
>>>> >
>>>> >
>>>> https://github.com/apache/incubator-sedona/releases/tag/sedona-1.1.0-incubating-rc1
>>>> >
>>>> > GPG public key to verify the Release:
>>>> > https://dist.apache.org/repos/dist/dev/incubator/sedona/KEYS
>>>> >
>>>> > Source code and binaries:
>>>> >
>>>> >
>>>> https://dist.apache.org/repos/dist/dev/incubator/sedona/1.1.0-incubating-rc1/
>>>> >
>>>> > The vote will be open for at least 72 hours or until a majority of at
>>>> > least 3 "approve" PMC votes are cast
>>>> >
>>>> > Please vote accordingly:
>>>> >
>>>> > [ ] +1 approve
>>>> >
>>>> > [ ] +0 no opinion
>>>> >
>>>> > [ ] -1 disapprove with the reason
>>>> >
>>>> > Checklist for reference (because of DISCLAIMER-WIP, other checklist
>>>> items
>>>> > are not blockers):
>>>> >
>>>> > [ ] Download links are valid.
>>>> >
>>>> > [ ] Checksums and PGP signatures are valid.
>>>> >
>>>> > [ ] DISCLAIMER is included.
>>>> >
>>>> > [ ] Source code artifacts have correct names matching the current
>>>> release.
>>>> >
>>>> > For a detailed checklist  please refer to:
>>>> >
>>>> >
>>>> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>>>> >
>>>> > 
>>>> > Changes according to the comments on the previous release
>>>> > Original comment (Permalink from https://lists.apache.org/list.html):
>>>> >
>>>> >
>>>> https://lists.apache.org/thread.html/rcc3252c2afda7761afb205eb00a2f8a5d71256fc7f4d631efc879629%40%3Cgeneral.incubator.apache.org%3E
>>>> >
>>>> > 1. Fix the header issue in the BSD license
>>>> > This has been fixed.
>>>> >
>>>> > [1]
>>>> >
>>>> https://github.com/apache/incubator-sedona/blob/sedona-1.1.0-incubating-rc1/zeppelin/index.js
>>>> > [2]
>>>> >
>>>> https://github.com/apache/incubator-sedona/blob/sedona-1.1.0-incubating-rc1/licenses/LICENSE-zeppelin-helium-plugin
>>>> >
>>>> > 2. Add the license for scalastyle_config.xml
>>>> >
>>>> > [3]
>>>> >
>>>> https://github.com/apache/incubator-sedona/blob/sedona-1.1.0-incubating-rc1/LICENSE#L210
>>>> >
>>>> > 3. Replace NASA HDF data with some alternatives to avoid the legal
>>>> issue
>>>> >
>>>> > All NASA data has been removed from the repo.
>>>> >
>>>>
>>>
>
> --
> Best regards,
> Netanel Malka.
>

Re: [VOTE] Release Apache Sedona 1.1.0-incubating-rc1

[Paweł Kociński]

Hi,
Is this issue still remain the problem ?
https://github.com/apache/incubator-sedona/commit/a0ed49da0b62ce591d858e5dccd5cebb69a8e695#comments

Regards,
Paweł

czw., 30 wrz 2021 o 15:44 Mo Sarwat  napisał(a):

> +1
>
> On Wed, Sep 29, 2021 at 9:38 PM Jia Yu  wrote:
>
>> CC several key members in the community
>>
>>
>>
>> On Wed, Sep 29, 2021 at 9:31 PM Jia Yu  wrote:
>>
>> > Hi all,
>> >
>> > This is a call for vote on Apache Sedona 1.1.0-incubating-rc1. Please
>> > refer to the changes listed at the bottom of this email.
>> >
>> > Release notes:
>> >
>> >
>> https://github.com/apache/incubator-sedona/blob/sedona-1.1.0-incubating-rc1/docs/download/release-notes.md
>> >
>> > Build instructions:
>> >
>> >
>> https://github.com/apache/incubator-sedona/blob/sedona-1.1.0-incubating-rc1/docs/download/compile.md
>> >
>> > GitHub tag:
>> >
>> >
>> https://github.com/apache/incubator-sedona/releases/tag/sedona-1.1.0-incubating-rc1
>> >
>> > GPG public key to verify the Release:
>> > https://dist.apache.org/repos/dist/dev/incubator/sedona/KEYS
>> >
>> > Source code and binaries:
>> >
>> >
>> https://dist.apache.org/repos/dist/dev/incubator/sedona/1.1.0-incubating-rc1/
>> >
>> > The vote will be open for at least 72 hours or until a majority of at
>> > least 3 "approve" PMC votes are cast
>> >
>> > Please vote accordingly:
>> >
>> > [ ] +1 approve
>> >
>> > [ ] +0 no opinion
>> >
>> > [ ] -1 disapprove with the reason
>> >
>> > Checklist for reference (because of DISCLAIMER-WIP, other checklist
>> items
>> > are not blockers):
>> >
>> > [ ] Download links are valid.
>> >
>> > [ ] Checksums and PGP signatures are valid.
>> >
>> > [ ] DISCLAIMER is included.
>> >
>> > [ ] Source code artifacts have correct names matching the current
>> release.
>> >
>> > For a detailed checklist  please refer to:
>> >
>> >
>> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>> >
>> > 
>> > Changes according to the comments on the previous release
>> > Original comment (Permalink from https://lists.apache.org/list.html):
>> >
>> >
>> https://lists.apache.org/thread.html/rcc3252c2afda7761afb205eb00a2f8a5d71256fc7f4d631efc879629%40%3Cgeneral.incubator.apache.org%3E
>> >
>> > 1. Fix the header issue in the BSD license
>> > This has been fixed.
>> >
>> > [1]
>> >
>> https://github.com/apache/incubator-sedona/blob/sedona-1.1.0-incubating-rc1/zeppelin/index.js
>> > [2]
>> >
>> https://github.com/apache/incubator-sedona/blob/sedona-1.1.0-incubating-rc1/licenses/LICENSE-zeppelin-helium-plugin
>> >
>> > 2. Add the license for scalastyle_config.xml
>> >
>> > [3]
>> >
>> https://github.com/apache/incubator-sedona/blob/sedona-1.1.0-incubating-rc1/LICENSE#L210
>> >
>> > 3. Replace NASA HDF data with some alternatives to avoid the legal issue
>> >
>> > All NASA data has been removed from the repo.
>> >
>>
>

Re: Will publish Sedona new version 1.1.0 soon

[Paweł Kociński]

Hi,
About  https://issues.apache.org/jira/browse/SEDONA-59, first option seems
most reasonable, we can assume that spark is already installed and does not
cause any confusion while installing with tools like poetry and pipenv.
Best Regards,
Paweł

śr., 25 sie 2021 o 11:18 Jia Yu  napisał(a):

> Sedona committers, contributors and users,
>
> The new Sedona version is long overdue because of this PySpark <= 3.0.1
> bug in Pipfile. I promise I will roll out the new version in the next 1 or
> 2 weeks regardless of the progress of all pending PRs. The new version will
> be 1.1.0 which contains the major update of R language bindings and Sedona
> raster support.
>
> @Paweł Kociński  Can you check out the
> proposal in https://issues.apache.org/jira/browse/SEDONA-59 ? Is it a
> good idea?
>
> Please let me know if you have any questions :-)
>
> Thanks,
> Jia Yu
>

Re: [VOTE] Release Apache Sedona 1.0.1-incubating-rc1

[Paweł Kociński]

+1 binding
it looks good to me

śr., 19 maj 2021 o 06:57 Jia Yu  napisał(a):

> Hi all,
>
> This is a call for vote on Apache Sedona 1.0.1-incubating-rc1. Please
> refer to the changes listed at the bottom of this email.
>
> Release notes:
>
> https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/docs/download/release-notes.md
>
> Build instructions:
>
> https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/docs/download/compile.md
>
> GitHub tag:
>
> https://github.com/apache/incubator-sedona/releases/tag/sedona-1.0.1-incubating-rc1
>
> GPG public key to verify the Release:
> https://dist.apache.org/repos/dist/dev/incubator/sedona/KEYS
>
> Source code and binaries:
>
> https://dist.apache.org/repos/dist/dev/incubator/sedona/1.0.1-incubating-rc1/
>
> The vote will be open for at least 72 hours or until a majority of at
> least 3 +1 PMC votes are cast
>
> Please vote accordingly:
>
> [ ] +1 approve
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
> Checklist for reference (because of DISCLAIMER-WIP, other checklist items
> are not blockers):
>
> [ ] Download links are valid.
>
> [ ] Checksums and PGP signatures are valid.
>
> [ ] DISCLAIMER is included.
>
> [ ] Source code artifacts have correct names matching the current release.
>
> For a detailed checklist  please refer to:
>
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>
> 
> Changes according to the comments of Justin Mclean on the 1.0.0-incubating
> release
> Original comment URL:
> https://lists.apache.org/thread.html/r828873cbb2685dcfb0719680f3aac6dbf982720fcd9cd5f69a26ec55%40%3Cgeneral.incubator.apache.org%3E
>
> 1. There are some test files I think I like to know where they come from
> e.g. county_small_wkb.tsv and what license the contents are under.
>
> License for test data has been added to Sedona license
>
> https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/LICENSE
>
> 2. The LICENSE here seems odd why does it have "Copyright (c) 2019-2020,
> Apache Sedona” in it?
>
> The issue has been fixed. The license for zeppelin plugin has been added
> to LICENSE as well.
>
> https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/LICENSE
>
> 3. Please put instructions on how to build in the release, instructions
> can change over time so pointing to a URL may not be helpful when trying to
> build older versions.
>
> Build instruction has been added to svn/dist/dev
>
> https://dist.apache.org/repos/dist/dev/incubator/sedona/1.0.1-incubating-rc1/
>

Re: Develop new features/fix bugs

[Paweł Kociński]

Hi Jia,
Do we have some estimates about next release ? I think it is good idea to
create JIRA tasks from that link
https://lists.apache.org/thread.html/r4ebf7c253fff77900cac8b6ad478c8f4808b707062dd8c6b40853a6f%40%3Cdev.sedona.apache.org%3E.
I can focus on point Implement loading geospatial data sources (geojson,
osm) and postgis direct support.
Regards,
Paweł

czw., 18 lut 2021 o 06:38 Jia Yu  napisał(a):

> H Netanel,
>
> Thanks for asking. I think there are a couple of issues to be improved, as
> listed here:
> https://lists.apache.org/thread.html/r4ebf7c253fff77900cac8b6ad478c8f4808b707062dd8c6b40853a6f%40%3Cdev.sedona.apache.org%3E
>
> On the list given by Pawel and my thoughts, I think the most important
> thing to be fixed is that (sorted by importance):
>
> 1. Replace the object serializer in RDD API with the WKB serializer you
> wrote before, currently only DataFrame API uses WKB based serializer. In
> Sedona-core, there is a small benchmark that can test the performance of
> the WKB serializer.
> 2. Allow broadcast join for big+small data frames, or at least give users
> a way to force the broadcast join. Currently, once the optimized Sedona
> join is enabled, the broadcast join is automatically disabled.
> 3. Allow null spatial objects in SpatialRDD and DataFrame. Or at least
> give users a meaningful exception:
> https://issues.apache.org/jira/browse/SEDONA-4
>
> Pawel was working on some improvements for GeoJSON loading. So we can
> leave it for him.
>
> Do you have any other issues you want to work on?
>
> Thanks,
> Jia
>
> On Wed, Feb 17, 2021 at 5:35 AM Netanel Malka  wrote:
>
>> Hi Jia,
>> Are there any features that we want to develop? or fix some bugs?
>>
>> My free time now allows me to make some contributions to the project.
>>
>> Thanks,
>>
>>

Re: Sedona 1.0 Maven release is staged

[Paweł Kociński]

Hi Jia,
Merry Christmas and Happy New Year to everyone.
I can definitely do that but I am not sure about the steps which I should
follow to upload package under Apache project. Also should we sync this
processes, I mean Maven and PyPI release ?

Regards,
Pawel

śr., 30 gru 2020 o 08:43 Jia Yu  napisał(a):

> Dear all,
>
> Merry Christmas and Happy New Year!
>
> After months of hard work, we are finally close to the Sedona
> 1.0.0-incubator release. I have staged Sedona 1.0.0 official release on
> Nexus. This is a thread for collecting final feedback rather than a voting
> thread.
>
> 1. I would like to ask all of you to take a look at the staged Maven
> releases (12 Sedona modules in total). Please learn how to access Nexus
> from [1][2]
>
> @Mohamed Sarwat  @Netanel Malka  Would
> you please take a look at the staged releases?
>
> @Felix Cheung   Felix, could you please take a
> look at the release as well? Your opinion is very important. If you think
> everything is good, then I will call for a vote.
>
> 2. Python release on PyPi
> @Paweł Kociński  Pawel, could you please
> publish Sedona 1.0.0-incubator-SNAPSHOT to PyPi? Then we will use that to
> call for a vote.
>
> I know many of you may be on vacation so no need to rush.
>
> [1]
> https://central.sonatype.org/pages/releasing-the-deployment.html#locate-and-examine-your-staging-repository
> [2] Sedona staged website: https://sedona.staged.apache.org/
>

Re: First Sedona release

[Paweł Kociński]

I should finish documentation update today/tomorrow (with notebooks also).
Regards, Paweł

niedz., 20 gru 2020 o 19:12 Netanel Malka  napisał(a):

> That's great!!
> Hope to try it today.
>
>
> On Fri, 18 Dec 2020 at 10:36, Jia Yu  wrote:
>
>> Hi Netanel and Paweł,
>>
>> The JTS issue has resolved. I am now waiting for JTS 1.18 release but we
>> are currently using 1.17.1 + copied files. So we are good anyway.
>>
>> So the next step will be documentation and stage the first release.
>> Although I really want to resolve the ST_Transform lock contention issue,
>> it requires a new ST_FlipCoordinate which may take a few days. I will see
>> whether I can finish this by Christmas but not sure.
>>
>> @Netanel Malka  Could you please compile the master
>> branch and try to deploy a SNAPSHOT release on your own? I have pushed a
>> few snapshots but I would like to see whether you can do it too. Please
>> follow the steps here:
>> https://gist.github.com/jiayuasu/849e1f3bf7a2dd11593ca27c14e9e92d
>>
>> @Paweł Kociński  Step 1. Could you please
>> update
>> the new Python Adaptor documentation? Step 2. Could you please try to
>> deploy a SNAPSHOT release to PyPI? You can find some help here:
>> https://incubator.apache.org/guides/distribution.html
>>
>> Thank you very much!
>> Jia
>>
>>
>> On Thu, Dec 10, 2020 at 3:26 PM Jim Hughes  wrote:
>>
>> > Hi Jia,
>> >
>> > A JTS 1.18.0 release would not be just for Apache Sedona.;) Getting it
>> > out sooner would let others projects adopt it sooner (I'm thinking of
>> > GeoTools and GeoServer).  I'm excited to see the improvements to the
>> > overlay operations...
>> >
>> > I've traded some emails and chats with Martin.  It sounds like he is ok
>> > with cutting JTS 1.18.0 in the next week; I'll be working with him and
>> > Jody to do our best to make that happen.
>> >
>> > Anyhow, in terms of shading, there are few things I'd suggest. First,
>> > I'd suggest that libraries which can function as libraries have a
>> > version of the jar which does not include any dependencies.  If you go
>> > along with that, sedona-core should produce a jar on its own and another
>> > module could build a "batteries included" jar for users to drop into
>> Spark.
>> >
>> > Separate from that, I'd recommend that when you copy entire files into a
>> > project that you change the package for those classes. Concretely, you
>> > could just prepend org.apache.sedona to the package names for those 5
>> > classes.  (This assumes that it is possible.  Sometimes there may be
>> > issues around package protected access, etc.)
>> >
>> > As it stands right now, if a user tries to use Sedona with any other
>> > library that pulls in JTS, then they will be at the mercy of the class
>> > loading order.  If the JTS jar comes in elsewhere, your versions of the
>> > RTree may not be loaded!  The exception would look like a JTS issue and
>> > it be fairly confusing for most people to debug.
>> >
>> > With those issues taken together, a user could load up a sedona-core jar
>> > (which wouldn't have JTS or org.wololo.geojson) with a different version
>> > of JTS potentially provided by another project and be able to use Sedona
>> > and other projects together.
>> >
>> > Thanks for working through the issues to be able to use a release of
>> > JTS.  Hopefully we can knock this out over the next week, and if not,
>> > you do have an approach which would let you release Sedona.
>> >
>> > Cheers,
>> >
>> > Jim
>> >
>> > On 12/10/2020 2:33 PM, Jia Yu wrote:
>> > > Hi Jim,
>> > >
>> > > Thanks for your feedback.
>> > >
>> > > 1. I indeed asked Martin, Jody, and you in the JTS Gitter chat. It
>> looks
>> > > like Martin still needs some time to fix some functions. In fact, I
>> feel
>> > it
>> > > is inappropriate to push Martin, an OSS contributor, to draw a release
>> > just
>> > > for us :)
>> > > 2. I also saw your comment on the GitHub PR. My current solution in
>> that
>> > PR
>> > > is that use JTS 1.17.1 official release + 5 copied JTS index classes.
>> I
>> > > also use the maven shade plugin to filter out the 5 corresponding
>> classes
>> > > in JTS 1.17.1 jar (
>> > >
>> >
>> https://github.com/a

Re: First Sedona release

[Paweł Kociński]

Hi,
I saw some users reported need to improve Python RDD API in two scenarios:
- converting spatial flat join result to df
- saving spatial flat join result directly to external storage

Currently SerDe between jvm and Python causes additional time needed to
compute the result. I have a local branch with tests where this
functionality is available (need 3-4 days to make it 100% ready), in two
above scenarios there will be almost no difference between Python and Scala
or Java API. Should I create PR to include this feature within the first
Sedona release ?
Regards,
Paweł

pon., 16 lis 2020 o 08:29 Jia Yu  napisał(a):

> Dear all,
>
> Thanks for all your suggestions.
>
> 1. To completely solve the long-overdue JTS issue, I made a Sedona PR and
> two JTS PRs. @Jim Hughes  , @Paweł Kociński
>  , I, and probably Martin from JTS will take
> care of these PRs in the coming days.
> (1) Sedona PR: https://github.com/apache/incubator-sedona/pull/488
> (2) JTS PR: https://github.com/locationtech/jts/pull/633
> https://github.com/locationtech/jts/pull/634
>
> 2. To move forward with the first release, I have deleted the "SNAPSHOT"
> in my JTS 1.16 fork.
> Most likely, we have to move forward with my JTS 1.16 fork in the first
> Sedona release because of the conflict among JTStoGeoJSON, GeoTools, and
> JTS 1.17.
> So @Netanel Malka   could you please do another
> dry-run on the Sedona first release on this Sedona branch: sedona-1.0-doc:
> https://github.com/apache/incubator-sedona/tree/sedona-1.0-doc
>
> Thanks,
> Jia
>
> On Thu, Nov 12, 2020 at 11:36 AM Jim Hughes  wrote:
>
>> Hi Mo,
>>
>> I can definitely help.  The first step will be for Jia to push a PR for
>> the JTS changes.  (Since they are his changes, I cannot do this on his
>> behalf.)
>>
>>  From talking to the lead JTS developer, he wanted to see the previous
>> PR (from months/a year+ ago) split up.  I think the initial PR should be
>> used to discuss what changes are sensible for JTS and where we'll need
>> to push some of the changes to Sedona.
>>
>> Concretely, I noticed that the Sedona JTS fork changes the toString on
>> Geometry to include printing out the userData.  I imagine that may cause
>> trouble for downstream JTS users, so it'd be good to find an
>> alternative.  One suggestion would to be add a static method in Sedona
>> for printing a Geometry with its userData object.
>>
>> Cheers,
>>
>> Jim
>>
>> On 11/12/20 12:32 PM, Mohamed Sarwat wrote:
>> > Folks,
>> >
>> > I totally agree with Jim on that. Jim, would you like to take the lead
>> on that - I trust that you can bring this task to completion. Jia, would
>> you please let us know how we can incorporate the changes into the JTS
>> master branch?
>> >
>> > Thanks,
>> >
>> >> On Nov 12, 2020, at 10:10 AM, Jim Hughes  wrote:
>> >>
>> >> Hi all,
>> >>
>> >> As a JTS committer, I have tried to request that the Sedona project
>> discuss the desired changes to JTS previously.  I'd still encourage that.
>> >>
>> >> JTS is an active project and I feel that maintaining a fork of JTS is
>> unnecessary and inappropriate.
>> >>
>> >> Cheers,
>> >>
>> >> Jim
>> >>
>> >>> On 11/11/20 9:04 PM, Felix Cheung wrote:
>> >>> Ah. You will need to publish it in order for the dependency chain to
>> work
>> >>> on Maven Central
>> >>>
>> >>> However, since you are not the project owner there you might need to
>> >>> publish that under a different artifact id.
>> >>>
>> >>> In general, it would be best to avoid hard forking another project
>> like
>> >>> this.
>> >>>
>> >>>
>> >>>> On Wed, Nov 11, 2020 at 1:05 PM Jia Yu 
>> wrote:
>> >>>>
>> >>>> Hi Netanel,
>> >>>>
>> >>>> That links to this git submodule:
>> >>>> https://github.com/jiayuasu/jts/blob/1.16.x/modules/core/pom.xml#L6
>> >>>>
>> >>>> I can easily fix this by changing the version number here to 1.16.2
>> >>>> excluding "SNAPSHOT":
>> >>>> https://github.com/jiayuasu/jts/blob/1.16.x/modules/core/pom.xml#L6
>> >>>>
>> >>>> Will this solve the problem?
>> >>>>
>> >>>> On Wed, Nov 11, 2020 at 7:40 AM Netanel Malka 
>> >>>> wrote:
>> >>>>

Re: Support Spark 2.4 in Sedona 1.0

[Paweł Kociński]

Hi Jia,
I think we should support spark 2.4, a lot of users still use it. More than
that I think more users still have jobs written in spark 2.4 than 3.0.  We
will use an additional branch for that use case ? I mean Spark 2.4 with
scala 2.12 is important one.
Regards,
Paweł

pon., 9 lis 2020 o 20:44 Jia Yu  napisał(a):

> Dear all,
>
> In Sedona 1.0, we definitely will support Spark 3.0. But I wonder whether
> we should support Spark 2.4.
>
> In order to support Spark 2.4, we need to do the following
>
> 1. Compile the source using Scala 2.11. Sedona master branch currently is
> compiled by Scala 2.12 and Java 1.8
> 2. For the Scala code of Sedona-SQL and Viz-SQL, I need to change the (1)
> UDF registration hook (2) the SQL aggregation function format
> 3. In the future releases of Sedona, use git cherry-pick to pick important
> features back to the Spark 2.4 branch. This is what I did in GeoSpark to
> support Spark 2.1, 2.2, 2.3
>
> GeoSpark 1.2.0 - 1.3.1 support Spark 2.4 already. We can simply leave it
> that way and just support Spark 3.0.
>
> Do you think we should support Spark 2.4 in the future release?
>
> Thanks,
> Jia Yu
>

Re: Apache Sedona

[Paweł Kociński]

- Grant support for Scala 2.12 and Spark 3.0
I meant here Python.

- Implement loading geospatial data sources (geojson, shapefile, osm, wkb,
wkt) from Dataframe API like
-- spark.read.format("geojson").load(path)

 It is possible and I think it will be easier for users to load the data
(Also agree that is not priority).

- Add broadcast join for joining big and small dataframe

Agree

- Fix issue with 3D geometries while loading shapefile

Exactly

- Add support for multiline geojson (I have some code on my local branch)

We have to write our own in that case, it will require some amount of work
but is doable.

- Add direct writing to geospatial databases like PostgreSQL

I have to analyze spark code and will be back with a solution

- Remove NullPointer exception when there is null value within data or data
is wrong within some rows.

I meant SQL functions, some time they should replace the value with
null/Option instead of raising null pointer exception.

- geohash spatial join

I think in some cases it can be more suitable for users. It should not be
tough to implement but it brings additional value.

pt., 21 sie 2020 o 11:08 Jia Yu  napisał(a):

> Hi Paweł and CCed sedona-dev and other committers,
>
> Please find my opinion below.
>
> - Grant support for Scala 2.12 and Spark 3.0
> Jia: the Scala and Java code in the master branch has supported Spark 3.0+
> 2.12. We need to support the following: Sedona Scala 2.12 support for other
> Spark versions and Scala 2.12 support in all Python APIs.
>
> - Implement loading geospatial data sources (geojson, shapefile, osm, wkb,
> wkt) from Dataframe API like
> -- spark.read.format("geojson").load(path)
> Jia: Direct DataFrame API support requires a bit more coding effort. I am
> actually not sure whether this func in DF is extensible. But if so, I am
> not against it. But it is not the top priority.
>
> - Add broadcast join for joining big and small dataframe
> Jia: Yes, we should have it here:
> https://github.com/DataSystemsLab/GeoSpark/blob/master/sql/src/main/scala/org/apache/spark/sql/geosparksql/strategy/join/TraitJoinQueryExec.scala#L67
> - Fix issue with 3D geometries while loading shapefile
> Jia: How do we fix it? Convert it to a 2D geoms and discard the Z
> dimension or M dimension?
>
> - Add support for multiline geojson (I have some code on my local branch)
> Jia: This is not easy. In Spark, its DF has a readjson API:
> https://spark.apache.org/docs/latest/sql-data-sources-json.html Not sure
> whether we can leverage this.
>
> - Add direct writing to geospatial databases like PostgreSQL
> Jia: Good point. Any particular challenge on this?
>
> - Add more geospatial functions
> Jia: Agree.
>
> - Remove NullPointer exception when there is null value within data or
> data is wrong within some rows
> Jia: I believe this has been solved by "allowTopologyInvalidGeometries"
> and "skipSyntaxInvalidGeometries"
> https://datasystemslab.github.io/GeoSpark/tutorial/rdd/#create-a-generic-spatialrdd-behavoir-changed-in-v120
>
> - geohash spatial join
> Jia: Yes, we can do that. But will it bring in any benefit as opposed to
> the existing spatial join algorithm?
>
> Thanks,
> Jia
>
> On Wed, Aug 19, 2020 at 10:22 AM Paweł Kociński 
> wrote:
>
>> Hi Jia,
>> I hope you are fine. Do we have some features to add to Apache Sedona
>> after the code will be merged ?
>> My ideas of tasks:
>> - Grant support for Scala 2.12 and Spark 3.0
>> - Implement loading geospatial data sources (geojson, shapefile, osm,
>> wkb, wkt) from Dataframe API like
>> -- spark.read.format("geojson").load(path)
>> I have some code, but code migration is holding me back
>>
>> [image: image.png]
>> - Add broadcast join for joining big and small dataframe
>> - Fix issue with 3D geometries while loading shapefile
>> - Add support for multiline geojson (I have some code on my local branch)
>> - Add direct writing to geospatial databases like PostgreSQL
>> - Add more geospatial functions
>> - Remove NullPointer exception when there is null value within data or
>> data is wrong within some rows
>> - geohash spatial join
>>
>> What do you think?
>>
>> Regards,
>> Paweł
>>
>>
>> pon., 17 sie 2020 o 07:45 Jia Yu  napisał(a):
>>
>>> Hello Paweł,
>>>
>>> I just posted the current situation into priv...@sedona.apache.org. The
>>> current problem is I have made everything ready to be imported to ASF
>>> GitHub repo (https://github.com/apache/incubator-sedona). But one
>>> committer (Masha from Facebook) who made thousands of lines of contribution
>>> to GeoSpark still didn't submit 

Re: Use JTS as a dependency instead of JTSPlus

[Paweł Kociński]

Hi,
>From my point of view, Python API needs only a few changes in that case.
First of all, few type annotation names change (Python API already has some
proxy object which holds shapely geometry and user data as a
separate attribute), If the new object has getter  *getUserData, *the
change should be minimal. And those are changes for RDD API. SQL API should
not require changes due to the fact that translation between Dataframe and
RDD is hidden for Python (I assume that GeometryUDT will remain the same).

Regards,
Pawel

pon., 10 sie 2020 o 07:08 Georg Heiler  napisał(a):

> I agree with @Jia Yu  and think it is better to
> move forward with the wrapper.
>
> Best,
> Georg
>
> Am Mo., 10. Aug. 2020 um 01:41 Uhr schrieb Jia Yu :
>
>> Hi Netanel, CCed Pawel (GeoSpark Python), Georg (who might be also
>> interested in this issue), Sedona-dev
>>
>> I think reflection would be a neat solution but it may bring
>> technical debt in the future and cause problems to the python API.
>>
>> In the long run, a wrapper around JTS geometry would be a better solution
>> although we may need to change many places in the code.
>>
>> Folks, what do you think?
>>
>> Thanks,
>> Jia
>>
>> On Sun, Aug 9, 2020 at 7:49 AM Netanel Malka 
>> wrote:
>>
>>> Hi,
>>> Currently, we are having some problems with userData on Geometry.
>>> The problems are:
>>>
>>>1. Geometry toString function doesn't take userData into account
>>>2. Geometry equals function doesn't take userData into account
>>>
>>>
>>> Our proposed solution is to wrap Geometry with a proxy object, that
>>> holds the Geometry and handles other columns instead of using Goemtery user
>>> data.
>>> Another possible solution is using reflection to change methods on
>>> Geometry itself
>>>
>>> What do you think we should do?
>>>
>>> Thanks. Regards
>>>
>>> On Thu, Jul 23, 2020, 21:32 Jia Yu  wrote:
>>>
 Hi Netanel,

 Sorry. I somehow missed this email. The only test that GeoSpark does
 not cover for JTSplus is this one:
 https://github.com/jiayuasu/JTSplus/blob/master/src/test/java/jtsplustest/GeometryToStringTest.java

 If you can add this back to GeoSpark, I think you are good to go.

 Thanks,
 Jia

 On Thu, Jul 23, 2020 at 6:08 AM Netanel Malka 
 wrote:

> Hi,
> Have you had time to look at this?
>
> Best regards,
> Netanel Malka.
>
> -- Forwarded message -
> From: Netanel Malka 
> Date: Tue, 7 Jul 2020 at 11:06
> Subject: Re: Use JTS as a dependency instead of JTSPlus
> To: Jia Yu 
>
>
> OK.
> We saw that in Geometry the userData field changed from null to "", is
> it crucial? because this is a change that I believe that JTS won't accept.
>
> Also, does GeoSpark tests are covered JTSPlus changes? If all the
> geospark tests are working, does it mean that we didn't break anything?
>
>
> On Thu, 2 Jul 2020 at 18:54, Jia Yu  wrote:
>
>> HI Netanel,
>>
>> Thanks for your work on this.
>>
>> userData in Envelope can be ignored. We will no longer support
>> userData in Envelope.
>>
>> Userdata field is used to hold non-spatial attributes in GeoSpark
>> core. When print a spatial object, userData will be printed out as a WKT
>> string.
>>
>> In GeoSpark, I think it only calls the getUserData or setUserData,
>> but the majority of the work was done in JTSplus. When check the equality
>> of two objects in JTSplus, we also check the UserData but JTS by default
>> does not check that.
>>
>>
>> We communicate via mail since this thread is gonna be long.
>>
>> Thanks,
>> Jia
>>
>> 
>>
>> Jia Yu
>>
>> Ph.D. in Computer Science
>>
>> Arizona State University 
>>
>> Reach me via: Homepage  | GitHub
>> 
>>
>>
>> On Thu, Jul 2, 2020 at 3:01 AM Netanel Malka 
>> wrote:
>>
>>> Hi,
>>> how are you?
>>>
>>> I am working on this issue
>>>  which I and
>>> my friends trying to upgrade the JTS version on GeoSpark.
>>> We are facing the userData field on Envelope which arent exists on
>>> JTS.
>>> Based on this PR  I
>>> saw it's deprecated, can we ignore it?
>>>
>>> Also, We started to search for the using of userData for Geometry on
>>> GeoSpark and we found only this place:
>>> added equality of userData in Circle
>>> 
>>>
>>> We would like to know if there are *more places* that we need to
>>> implement the equals on *userData*.
>>>
>>> *p.s.*
>>> Did a mail is a convenient communication channel for