Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

2016-09-22 Thread Li Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52138/#review150116
---




sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
 (line 217)


require -> requires



sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
 (line 229)


From the comment, seems you want to update eventIDBefore before 
fetchFullUpdate() in the while loop



sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
 (line 252)


I think we don't need 'currentRetries == maxRetriesForHMSSnapshot' here



sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
 (line 257)


why set fullUpdateComplete to false here?
Seems fullUpdateComplete is always false now.


- Li Li


On Sept. 23, 2016, 12:50 a.m., Hao Hao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52138/
> ---
> 
> (Updated Sept. 23, 2016, 12:50 a.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Anne Yu, Li Li, and Sravya 
> Tirukkovalur.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-1463: Ensure HMS point-in-time snapshot consistency
> 
> The implemented logic is:
> 1. Read current HMS notification ID_initial
> 2. Read HMS metadata state
> 3. Read current notification ID_new
> 4. If ID_initial != ID_new then discard the current state and goto 1.
>  
> Use configurable property: sentry.hms.snapshot.retries.max.count for max 
> number of retry.
> 
> Change-Id: I7590076b875bd97b2fb340008926ea5995896d72
> 
> 
> Diffs
> -
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
>  894fcc966b511ccf309599fd10960f9a11ae8e96 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java
>  abc3f58d21bb774427a34399b6e9f51a37ba51db 
> 
> Diff: https://reviews.apache.org/r/52138/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hao Hao
> 
>

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

2016-09-22 Thread Hao Hao 


> On Sept. 22, 2016, 12:39 a.m., Alexander Kolbasov wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java,
> >  line 212
> > 
> >
> > Is the TODO: read currentEventID still relevant?

Yeah, in the case when Sentry DB already stored a full snapshot need to read 
from DB. Will update the comment.


- Hao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52138/#review149928
---


On Sept. 22, 2016, 8:39 p.m., Hao Hao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52138/
> ---
> 
> (Updated Sept. 22, 2016, 8:39 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Anne Yu, Li Li, and Sravya 
> Tirukkovalur.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-1463: Ensure HMS point-in-time snapshot consistency
> 
> The implemented logic is:
> 1. Read current HMS notification ID_initial
> 2. Read HMS metadata state
> 3. Read current notification ID_new
> 4. If ID_initial != ID_new then discard the current state and goto 1.
>  
> Use configurable property: sentry.hms.snapshot.retries.max.count for max 
> number of retry.
> 
> Change-Id: I7590076b875bd97b2fb340008926ea5995896d72
> 
> 
> Diffs
> -
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
>  894fcc966b511ccf309599fd10960f9a11ae8e96 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java
>  abc3f58d21bb774427a34399b6e9f51a37ba51db 
> 
> Diff: https://reviews.apache.org/r/52138/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hao Hao
> 
>

Re: Review Request 52150: SENTRY-1478: Disable fencing in Sentry store for Active/Active

2016-09-22 Thread Anne Yu 


> On Sept. 22, 2016, 7:56 p.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java,
> >  line 97
> > 
> >
> > I think we may still want to keep the activator code, and just disable 
> > fencing in sentry store. So we can have a backup as active/passive model.
> 
> Li Li wrote:
> you are right. Even for active / active mode, we still have only 1 deamon 
> that fetch the snapshot from hms and write to backend db, so we'd Besides, we 
> can keep the activator code. Besides, we can use it for internal testing / 
> debugging that resolve Anne the concern.

Thanks! Yes.


- Anne


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52150/#review150040
---


On Sept. 22, 2016, 5:27 a.m., Li Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52150/
> ---
> 
> (Updated Sept. 22, 2016, 5:27 a.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Anne Yu, Hao Hao, and Sravya 
> Tirukkovalur.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Keep the Fencer and Activator classes and disable fencing that brought by 
> SENTRY-1317 and SENTRY-1399, including some tests cases (e.g. TestActivator).
> 
> 
> Diffs
> -
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
>  6f8239dcf2ae23962efe6bb0edf12d3c14e1a038 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
>  39e55c3d9cb17ed498aaad98f1c490401c12030b 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  e2b92f919c8d4f2bb347ee70c5c623559d57002a 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
>  894fcc966b511ccf309599fd10960f9a11ae8e96 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java
>  353d461d84eb8438506e4bb209828feb98183fa7 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java
>  74977193760dd1958bdafaa3d6dac1ba27d81f32 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreIntegrationBase.java
>  c52197f1ca514604a01ce4f4d9d7d35de30994a0 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java
>  fd10a7a23bcc21786323a27f36aba918f77e819c 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestFencer.java
>  42b67ba4078d998a069aa6600b1ab24011b7dd26 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
>  06342063965a0e6b295fbdbaf2dfc517a2045d60 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java
>  98f18314d387a831707ba5f06836ae41926878db 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryVersion.java
>  e401859ab492c1d2a7634361fa301b3350661929 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestActivator.java
>  60cfc735832433fb4dbeae1c2d617dd713fc3f3e 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java
>  57d579cc6179319e3525424d652d224323e21457 
> 
> Diff: https://reviews.apache.org/r/52150/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Li Li
> 
>

Re: Review Request 52150: SENTRY-1478: Disable fencing in Sentry store for Active/Active

2016-09-22 Thread Li Li 


> On Sept. 22, 2016, 7:56 p.m., Hao Hao wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java,
> >  line 97
> > 
> >
> > I think we may still want to keep the activator code, and just disable 
> > fencing in sentry store. So we can have a backup as active/passive model.

you are right. Even for active / active mode, we still have only 1 deamon that 
fetch the snapshot from hms and write to backend db, so we'd Besides, we can 
keep the activator code. Besides, we can use it for internal testing / 
debugging that resolve Anne the concern.


- Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52150/#review150040
---


On Sept. 22, 2016, 5:27 a.m., Li Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52150/
> ---
> 
> (Updated Sept. 22, 2016, 5:27 a.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Anne Yu, Hao Hao, and Sravya 
> Tirukkovalur.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Keep the Fencer and Activator classes and disable fencing that brought by 
> SENTRY-1317 and SENTRY-1399, including some tests cases (e.g. TestActivator).
> 
> 
> Diffs
> -
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
>  6f8239dcf2ae23962efe6bb0edf12d3c14e1a038 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
>  39e55c3d9cb17ed498aaad98f1c490401c12030b 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  e2b92f919c8d4f2bb347ee70c5c623559d57002a 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
>  894fcc966b511ccf309599fd10960f9a11ae8e96 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java
>  353d461d84eb8438506e4bb209828feb98183fa7 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java
>  74977193760dd1958bdafaa3d6dac1ba27d81f32 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreIntegrationBase.java
>  c52197f1ca514604a01ce4f4d9d7d35de30994a0 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java
>  fd10a7a23bcc21786323a27f36aba918f77e819c 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestFencer.java
>  42b67ba4078d998a069aa6600b1ab24011b7dd26 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
>  06342063965a0e6b295fbdbaf2dfc517a2045d60 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java
>  98f18314d387a831707ba5f06836ae41926878db 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryVersion.java
>  e401859ab492c1d2a7634361fa301b3350661929 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestActivator.java
>  60cfc735832433fb4dbeae1c2d617dd713fc3f3e 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java
>  57d579cc6179319e3525424d652d224323e21457 
> 
> Diff: https://reviews.apache.org/r/52150/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Li Li
> 
>

Re: Review Request 52150: SENTRY-1478: Disable fencing in Sentry store for Active/Active

2016-09-22 Thread Li Li 


> On Sept. 22, 2016, 6:34 p.m., Sravya Tirukkovalur wrote:
> > Thanks for the patch Li Li! This change seems to be from design V2.1. I 
> > think it makes sense to mention that in the jira and also wait for a few 
> > days for the community to review the new design before moving ahead. What 
> > do you think?

thanks, Sravya! I agree.


- Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52150/#review150043
---


On Sept. 22, 2016, 5:27 a.m., Li Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52150/
> ---
> 
> (Updated Sept. 22, 2016, 5:27 a.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Anne Yu, Hao Hao, and Sravya 
> Tirukkovalur.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Keep the Fencer and Activator classes and disable fencing that brought by 
> SENTRY-1317 and SENTRY-1399, including some tests cases (e.g. TestActivator).
> 
> 
> Diffs
> -
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
>  6f8239dcf2ae23962efe6bb0edf12d3c14e1a038 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
>  39e55c3d9cb17ed498aaad98f1c490401c12030b 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  e2b92f919c8d4f2bb347ee70c5c623559d57002a 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
>  894fcc966b511ccf309599fd10960f9a11ae8e96 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java
>  353d461d84eb8438506e4bb209828feb98183fa7 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java
>  74977193760dd1958bdafaa3d6dac1ba27d81f32 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreIntegrationBase.java
>  c52197f1ca514604a01ce4f4d9d7d35de30994a0 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java
>  fd10a7a23bcc21786323a27f36aba918f77e819c 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestFencer.java
>  42b67ba4078d998a069aa6600b1ab24011b7dd26 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
>  06342063965a0e6b295fbdbaf2dfc517a2045d60 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java
>  98f18314d387a831707ba5f06836ae41926878db 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryVersion.java
>  e401859ab492c1d2a7634361fa301b3350661929 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestActivator.java
>  60cfc735832433fb4dbeae1c2d617dd713fc3f3e 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java
>  57d579cc6179319e3525424d652d224323e21457 
> 
> Diff: https://reviews.apache.org/r/52150/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Li Li
> 
>

Re: Review Request 52138: SENTRY-1463: Ensure HMS point-in-time snapshot consistency

2016-09-22 Thread Li Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52138/#review150070
---




sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
 (line 206)


return if client == null, and throw / log the exception



sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
 (line 216)


could we change the currentEventID to a different name, since we have a var 
with the same name in line 64



sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
 (line 219)


I think we should give up if fetchFullUpdate() fails, since 
FullUpdateInitializer also has retry, and retry here is just to fetch the 
latest snapshot.



sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
 (line 220)


Shall we update currentEventID before retry?
Shall we use !equals instead of != ?


- Li Li


On Sept. 22, 2016, 8:39 p.m., Hao Hao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52138/
> ---
> 
> (Updated Sept. 22, 2016, 8:39 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Anne Yu, Li Li, and Sravya 
> Tirukkovalur.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> SENTRY-1463: Ensure HMS point-in-time snapshot consistency
> 
> The implemented logic is:
> 1. Read current HMS notification ID_initial
> 2. Read HMS metadata state
> 3. Read current notification ID_new
> 4. If ID_initial != ID_new then discard the current state and goto 1.
>  
> Use configurable property: sentry.hms.snapshot.retries.max.count for max 
> number of retry.
> 
> Change-Id: I7590076b875bd97b2fb340008926ea5995896d72
> 
> 
> Diffs
> -
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
>  894fcc966b511ccf309599fd10960f9a11ae8e96 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java
>  abc3f58d21bb774427a34399b6e9f51a37ba51db 
> 
> Diff: https://reviews.apache.org/r/52138/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hao Hao
> 
>

Re: Review Request 52150: SENTRY-1478: Disable fencing in Sentry store for Active/Active

2016-09-22 Thread Anne Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52150/#review150038
---



Not mean to object check-in this patch. Just a question, after this patch, 
server.isActive() will also be disabled? In that case, how can one 
programmatically disabe any active server(s) and get the status of any 
server(s)? It seems a userful tool for future and internal testing/debugging. 
Thanks.

- Anne Yu


On Sept. 22, 2016, 5:27 a.m., Li Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52150/
> ---
> 
> (Updated Sept. 22, 2016, 5:27 a.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Anne Yu, Hao Hao, and Sravya 
> Tirukkovalur.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Keep the Fencer and Activator classes and disable fencing that brought by 
> SENTRY-1317 and SENTRY-1399, including some tests cases (e.g. TestActivator).
> 
> 
> Diffs
> -
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
>  6f8239dcf2ae23962efe6bb0edf12d3c14e1a038 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java
>  39e55c3d9cb17ed498aaad98f1c490401c12030b 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  e2b92f919c8d4f2bb347ee70c5c623559d57002a 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
>  894fcc966b511ccf309599fd10960f9a11ae8e96 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java
>  353d461d84eb8438506e4bb209828feb98183fa7 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java
>  74977193760dd1958bdafaa3d6dac1ba27d81f32 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreIntegrationBase.java
>  c52197f1ca514604a01ce4f4d9d7d35de30994a0 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java
>  fd10a7a23bcc21786323a27f36aba918f77e819c 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestFencer.java
>  42b67ba4078d998a069aa6600b1ab24011b7dd26 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
>  06342063965a0e6b295fbdbaf2dfc517a2045d60 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java
>  98f18314d387a831707ba5f06836ae41926878db 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryVersion.java
>  e401859ab492c1d2a7634361fa301b3350661929 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestActivator.java
>  60cfc735832433fb4dbeae1c2d617dd713fc3f3e 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java
>  57d579cc6179319e3525424d652d224323e21457 
> 
> Diff: https://reviews.apache.org/r/52150/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Li Li
> 
>