Re: Review Request 64179: SENTRY-2079: Sentry HA leader monitor does not work due to a mix of curator versions in the classpath

2017-11-30 Thread kalyan kumar kalvagadda via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64179/#review192434
---


Ship it!




Ship It!

- kalyan kumar kalvagadda


On Nov. 29, 2017, 10:37 p.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64179/
> ---
> 
> (Updated Nov. 29, 2017, 10:37 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: sentry-2079
> https://issues.apache.org/jira/browse/sentry-2079
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> This patch excludes other curator dependencies that do conflict with Sentry 
> curator dependencies.
> It also shade the curator deps to avoid other components dealing with curator 
> to conflict with Sentry curator.
> 
> This patch is necessary to make Sentry HA mode work again.
> 
> 
> Diffs
> -
> 
>   pom.xml 63adf66861436833a282c126670ef61e30a7672a 
>   sentry-binding/sentry-binding-solr/pom.xml 
> 0db76bb50ac8a9714d6ecb280ad8449d1c3b5d3e 
>   sentry-provider/sentry-provider-db/pom.xml 
> d4fd9bd780071fcad72b5c5be77a454d329bdca3 
>   sentry-tests/sentry-tests-solr/pom.xml 
> c7125bd40723f626558c9203195f9d2e009b636a 
> 
> 
> Diff: https://reviews.apache.org/r/64179/diff/1/
> 
> 
> Testing
> ---
> 
> I configured Sentry HA with this patch and is working.
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Review Request 64241: SENTRY-2081: Update the LICENSE.txt with the license information of distributed jars

2017-11-30 Thread kalyan kumar kalvagadda via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64241/
---

Review request for sentry, Alexander Kolbasov, Brian Towles, Colm O 
hEigeartaigh, and Sergio Pena.


Bugs: SENTRY-2081
https://issues.apache.org/jira/browse/SENTRY-2081


Repository: sentry


Description
---

As per https://www.apache.org/dev/licensing-howto.html , sentry should update 
the LICENSE.txt file with license information of all the jars that sentry is 
distributing along with the pointer to the LICENSE files of the dependencies.


Diffs
-

  pom.xml 3aedd3b38b067f9d32bf5ad1792bbb3df1378cf7 
  sentry-dist/pom.xml 4c69535660b132943c7cdc2419fff140a0909a48 
  sentry-dist/src/license/THIRD-PARTY.ftl PRE-CREATION 
  sentry-dist/src/license/THIRD-PARTY.properties PRE-CREATION 
  sentry-dist/src/license/override-THIRD-PARTY.properties PRE-CREATION 
  sentry-dist/src/main/assembly/bin.xml 
5727fc964bc139a5bd5490132efad13db6cbcf44 
  sentry-dist/src/main/resources/licences/Apache_2_0_license.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/BSD_2-clause.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/BSD_License.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_1_0.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_1_1.txt PRE-CREATION 
  sentry-dist/src/main/resources/licences/CDDL_2.txt PRE-CREATION 
  
sentry-dist/src/main/resources/licences/Eclipse_Public_License_-_Version_1_0.txt
 PRE-CREATION 
  sentry-dist/src/main/resources/licences/MIT_License.txt PRE-CREATION 
  
sentry-dist/src/main/resources/licences/Mozilla_Public_License_Version_1_1.txt 
PRE-CREATION 
  
sentry-dist/src/main/resources/licences/The_Apache_Software_License,_Version_1_1.txt
 PRE-CREATION 
  
sentry-dist/src/main/resources/licences/The_Apache_Software_License,_Version_2_0.txt
 PRE-CREATION 
  sentry-dist/src/main/resources/licences/The_BSD_3-Clause_License.txt 
PRE-CREATION 
  sentry-dist/src/main/resources/licences/the apache software license, version 
2.0 - license-2.0.txt PRE-CREATION 


Diff: https://reviews.apache.org/r/64241/diff/1/


Testing
---

Made sure that LICENSE.txt file generated in sentry-dist/target directory has 
the license informaion of all the jars that sentry is distributing.


Thanks,

kalyan kumar kalvagadda

Re: Review Request 64230: SENTRY-2082: Exclude javax.servlet-3.0.0.v201112011016.jar from Sentry dist

2017-11-30 Thread kalyan kumar kalvagadda via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64230/#review192424
---


Ship it!




Ship It!

- kalyan kumar kalvagadda


On Nov. 30, 2017, 11:05 p.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64230/
> ---
> 
> (Updated Nov. 30, 2017, 11:05 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: SENTRY-2082
> https://issues.apache.org/jira/browse/SENTRY-2082
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> The javax.servlet-3.0.0.v201112011016.jar transitive dependency is causing 
> some error exceptions on the Sentry 2.0 distribution in some Mac environments.
> 
> 
> Diffs
> -
> 
>   pom.xml 948f88cff41dc816f083995f795cff6b4b416f28 
> 
> 
> Diff: https://reviews.apache.org/r/64230/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Re: Review Request 64230: SENTRY-2082: Exclude javax.servlet-3.0.0.v201112011016.jar from Sentry dist

2017-11-30 Thread Alexander Kolbasov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64230/#review192423
---


Ship it!




Ship It!

- Alexander Kolbasov


On Nov. 30, 2017, 11:05 p.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64230/
> ---
> 
> (Updated Nov. 30, 2017, 11:05 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: SENTRY-2082
> https://issues.apache.org/jira/browse/SENTRY-2082
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> The javax.servlet-3.0.0.v201112011016.jar transitive dependency is causing 
> some error exceptions on the Sentry 2.0 distribution in some Mac environments.
> 
> 
> Diffs
> -
> 
>   pom.xml 948f88cff41dc816f083995f795cff6b4b416f28 
> 
> 
> Diff: https://reviews.apache.org/r/64230/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

2017-11-30 Thread Arjun Mishra via Review Board 


> On Nov. 30, 2017, 11:07 p.m., Vadim Spector wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
> > Lines 346 (patched)
> > 
> >
> > Is getting empty snapshot while creating full snapshot normal? If not, 
> > perhaps info() or warn() would be better? Also, would not hurt including 
> > snapshotInfo.getId() into the log.

So it is usually the first case to hit, or the first cause of a full snap shot. 
So yes the chances of hitting this is high. The reason why it is debug is, as 
Sergio suggested, that if Sentry service is started, and no "work" is being 
done on HMS, we will always trigger creating a full snapshot. Only snapshot 
will be empty, so we will continue to trigger it. In which case this would be 
logged every 0.5 sec


- Arjun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63881/#review192387
---


On Nov. 30, 2017, 10:41 p.m., Arjun Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63881/
> ---
> 
> (Updated Nov. 30, 2017, 10:41 p.m.)
> 
> 
> Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and 
> Vadim Spector.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Currently we only seem to log when all conditions that lead to getting a 
> snapshot are validated, and eventually a full snapshot is received. However, 
> if for some reason a particular condition was invalid we don't log as to why. 
> This leaves no room for knowing definitely what might have been the reason as 
> to why a snapshot was not received from HMS.
> 
> 
> Diffs
> -
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  f32a745ed 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
>  c1471d118 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
>  eccb40fb6 
> 
> 
> Diff: https://reviews.apache.org/r/63881/diff/6/
> 
> 
> Testing
> ---
> 
> mvn -f sentry-provider/sentry-provider-db/pom.xml test
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

2017-11-30 Thread Vadim Spector via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63881/#review192387
---




sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
Lines 346 (patched)


Is getting empty snapshot while creating full snapshot normal? If not, 
perhaps info() or warn() would be better? Also, would not hurt including 
snapshotInfo.getId() into the log.



sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
Lines 152 (patched)


logging eventIdBefore may be useful at this point



sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
Line 202 (original), 203 (patched)


Would it be worth logging normal execution flow inside this loop? It is 
still exceptional in a way that it's inside full update logic, right? Should 
not be too many iterations before currentEventId and eventIdAfter catch up with 
each other, is it right? Something like "{} updates received, currentEventId 
{}, eventIdAfter {}".

Also, in theory returned event IDs should be sequential, but this is HMS, 
so who knows what can happen? The logic breaks out of the loop if the event ID 
reaches or exceeds the desired value, but if sequence numbers are out of order 
we can get gaps with hard to debug HDFS sync problems. The least we can do is 
warn() about sequence numbers being non-sequential, something like

if (event.getEventId() != (currentEventId+1)) {
  LOGGER.warn(...);
}


- Vadim Spector


On Nov. 30, 2017, 10:41 p.m., Arjun Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63881/
> ---
> 
> (Updated Nov. 30, 2017, 10:41 p.m.)
> 
> 
> Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and 
> Vadim Spector.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Currently we only seem to log when all conditions that lead to getting a 
> snapshot are validated, and eventually a full snapshot is received. However, 
> if for some reason a particular condition was invalid we don't log as to why. 
> This leaves no room for knowing definitely what might have been the reason as 
> to why a snapshot was not received from HMS.
> 
> 
> Diffs
> -
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  f32a745ed 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
>  c1471d118 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
>  eccb40fb6 
> 
> 
> Diff: https://reviews.apache.org/r/63881/diff/6/
> 
> 
> Testing
> ---
> 
> mvn -f sentry-provider/sentry-provider-db/pom.xml test
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>

Review Request 64230: SENTRY-2082: Exclude javax.servlet-3.0.0.v201112011016.jar from Sentry dist

2017-11-30 Thread Sergio Pena via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64230/
---

Review request for sentry.


Bugs: SENTRY-2082
https://issues.apache.org/jira/browse/SENTRY-2082


Repository: sentry


Description
---

The javax.servlet-3.0.0.v201112011016.jar transitive dependency is causing some 
error exceptions on the Sentry 2.0 distribution in some Mac environments.


Diffs
-

  pom.xml 948f88cff41dc816f083995f795cff6b4b416f28 


Diff: https://reviews.apache.org/r/64230/diff/1/


Testing
---


Thanks,

Sergio Pena

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

2017-11-30 Thread Arjun Mishra via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63881/
---

(Updated Nov. 30, 2017, 10:41 p.m.)


Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and 
Vadim Spector.


Repository: sentry


Description
---

Currently we only seem to log when all conditions that lead to getting a 
snapshot are validated, and eventually a full snapshot is received. However, if 
for some reason a particular condition was invalid we don't log as to why. This 
leaves no room for knowing definitely what might have been the reason as to why 
a snapshot was not received from HMS.


Diffs (updated)
-

  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
 f32a745ed 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
 c1471d118 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
 eccb40fb6 


Diff: https://reviews.apache.org/r/63881/diff/6/

Changes: https://reviews.apache.org/r/63881/diff/5-6/


Testing
---

mvn -f sentry-provider/sentry-provider-db/pom.xml test


Thanks,

Arjun Mishra

Re: [VOTE] Release Sentry version 2.0.0

2017-11-30 Thread Kalyan Kumar Kalvagadda 
I will start the voting for RC2 addressing the concerns.

-Kalyan

On Thu, Nov 30, 2017 at 10:36 AM, Alexander Kolbasov 
wrote:

> Given that the licensing exercise isn't complete, I suggest revoking the
> vote on the release until it is complete.
>
> - Alex
>
> On Thu, Nov 30, 2017 at 7:11 AM, Kalyan Kumar Kalvagadda <
> kkal...@cloudera.com> wrote:
>
> > here are my next steps towards being compliant to apache licensing
> >
> > 1. Stop distributing jar which are licensed under GPL and LGPL only as
> they
> > are not allowed to be distributed. (Please refer
> > http://www.apache.org/legal/resolved.html#category-a)
> > 2. See if we can stop distributing jars which are not licensed by Apache.
> > 2. Document the rest of them in the LICENSE.txt following the guidelines
> > mentioned in (https://www.apache.org/dev/licensing-howto.html)
> >
> > -Kalyan
> >
> > On Thu, Nov 30, 2017 at 4:40 AM, Colm O hEigeartaigh <
> cohei...@apache.org>
> > wrote:
> >
> > > Hi Kalyan,
> > >
> > > You need to read the following page, which lays it all out:
> > >
> > > https://www.apache.org/dev/licensing-howto.html
> > >
> > > In particular, there are two things you need to do:
> > >
> > > a) Go through the list of dependencies and isolate the non-Apache
> > licensed
> > > jars. Include that license in a "licenses" directory and point to it in
> > our
> > > LICENSE.txt (note - it must be a permissive license, for example we
> can't
> > > bundle LGPL jars that are not dual licensed):
> > >
> > > From the howto:
> > >
> > > "In LICENSE, add a pointer  to the
> dependency's
> > > license within the distribution and a short note summarizing its
> > licensing:
> > >
> > > This product bundles SuperWidget 1.2.3, which is available under a
> > > "3-clause BSD" license.  For details, see deps/superwidget/.
> > > "
> > >
> > > b) For all dependencies INCLUDING Apache licensed dependencies, you
> need
> > > to go to the source for each dependency and see if it has a NOTICE file
> > > with copyright notices that are non-Apache. If so they need to be
> > included
> > > in our NOTICE file.
> > >
> > > From the howto:
> > >
> > > "If the dependency supplies a NOTICE file, its contents must be
> analyzed
> > > and the relevant portions bubbled up into the top-level NOTICE file."
> > >
> > > Colm.
> > >
> > >
> > > On Wed, Nov 29, 2017 at 8:59 PM, Kalyan Kumar Kalvagadda <
> > > kkal...@cloudera.com> wrote:
> > >
> > >> I have gathered all license information for all the dependencies using
> > >> license-maven-plugin.
> > >> Here is the file attached.
> > >>
> > >> Is there a particular format I should be using to update the license
> > file
> > >> in the repo?
> > >>
> > >> -Kalyan
> > >>
> > >> On Wed, Nov 29, 2017 at 1:52 PM, Colm O hEigeartaigh <
> > cohei...@apache.org
> > >> > wrote:
> > >>
> > >>> Hi Kalyan,
> > >>>
> > >>> Anything Apache related you can immediately discount - so Hadoop,
> Hive,
> > >>> HBase, Solr, Zookeeper, etc. I would suggest just deleting those jars
> > >>> from
> > >>> the list and googling the remaining jars to see what the license is.
> > >>>
> > >>> Colm.
> > >>>
> > >>> On Wed, Nov 29, 2017 at 6:55 PM, Kalyan Kumar Kalvagadda <
> > >>> kkal...@cloudera.com> wrote:
> > >>>
> > >>> > I'm trying to gather the license information for the dependencies.
> > I'm
> > >>> > trying to use Apache Maven Project Info Reports Plugin
> > >>> >  reports-plugin/
> > >
> > >>> .
> > >>> >
> > >>> > Does anyone has a better suggestion?
> > >>> >
> > >>> > -Kalyan
> > >>> >
> > >>> > On Wed, Nov 29, 2017 at 12:32 PM, Sergio Pena <
> > >>> sergio.p...@cloudera.com>
> > >>> > wrote:
> > >>> >
> > >>> > > I don't have that issue.
> > >>> > >
> > >>> > > I downloaded the 2.0 tar.gz that is already signed and install it
> > on
> > >>> an
> > >>> > > Ubuntu 16.04 machine with Hive 2.3.2. It has been running in a
> > single
> > >>> > node
> > >>> > > mode. I could check HMS notifications being pulled and updated,
> and
> > >>> > > checking the permissions.
> > >>> > >
> > >>> > > On Wed, Nov 29, 2017 at 12:20 PM, Kalyan Kumar Kalvagadda <
> > >>> > > kkal...@cloudera.com> wrote:
> > >>> > >
> > >>> > > > Sergio,
> > >>> > > >
> > >>> > > > I know that you tried to start sentry standalone, Did you see
> > this
> > >>> > issue?
> > >>> > > >
> > >>> > > >
> > >>> > > > -Kalyan
> > >>> > > >
> > >>> > > > On Wed, Nov 29, 2017 at 12:16 PM, Alexander Kolbasov <
> > >>> > ak...@cloudera.com
> > >>> > > >
> > >>> > > > wrote:
> > >>> > > >
> > >>> > > > > I tried to start Sentry server on Mac and got a weird error
> . I
> > >>> am
> > >>> > > > running
> > >>> > > > > from the dist directory that I just built with mvn clean
> > install
> > >>> on
> > >>> > the
> > >>> > > > > 2.0.0 branch.
> > >>> > > > >
> > >>> > > > > 17/11/29 10:13:25 ERROR thrift.SentryService: Error starting
> > >>> server
> > >>> > > > > java.lang.SecurityException:

Re: Review Request 64220: SENTRY-2080: Stop distributing jars with GPL and LGPL licenses only

2017-11-30 Thread Na Li via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64220/#review192329
---


Ship it!




Ship It!

- Na Li


On Nov. 30, 2017, 6:36 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64220/
> ---
> 
> (Updated Nov. 30, 2017, 6:36 p.m.)
> 
> 
> Review request for sentry, Brian Towles and Colm O hEigeartaigh.
> 
> 
> Bugs: SENTRY-2080
> https://issues.apache.org/jira/browse/SENTRY-2080
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> There are couple of jars that sentry is distributing which have LGPL license. 
> As per http://www.apache.org/legal/resolved.html#category-a apache components 
> should not be doing that. This patch will stop sentry from distributing 
> jackson-jaxrs and jackson-xc artifacts from group org.codehaus.jackson which 
> have LGPL license only.
> 
> 
> Diffs
> -
> 
>   sentry-dist/pom.xml 4c69535 
> 
> 
> Diff: https://reviews.apache.org/r/64220/diff/1/
> 
> 
> Testing
> ---
> 
> Made sure that sentry is not distributing jackson-jaxrs and jackson-xc 
> artifacts.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Review Request 64220: SENTRY-2080: Stop distributing jars with GPL and LGPL licenses only

2017-11-30 Thread kalyan kumar kalvagadda via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64220/
---

Review request for sentry, Brian Towles and Colm O hEigeartaigh.


Bugs: SENTRY-2080
https://issues.apache.org/jira/browse/SENTRY-2080


Repository: sentry


Description
---

There are couple of jars that sentry is distributing which have LGPL license. 
As per http://www.apache.org/legal/resolved.html#category-a apache components 
should not be doing that. This patch will stop sentry from distributing 
jackson-jaxrs and jackson-xc artifacts from group org.codehaus.jackson which 
have LGPL license only.


Diffs
-

  sentry-dist/pom.xml 4c69535 


Diff: https://reviews.apache.org/r/64220/diff/1/


Testing
---


Thanks,

kalyan kumar kalvagadda

Re: Review Request 63775: SENTRY-1543 dropOrRenamePrivilegeForAllRoles() has confusing code

2017-11-30 Thread Steve Moist via Review Board 


> On Nov. 15, 2017, 7:11 p.m., Sergio Pena wrote:
> > The subject of the review board must match the JIRA subject. You could 
> > either change the JIRA or the Review subject to match the correct fix.
> > 
> > The getUniqueMSentryPrivilege() is still confusing. Any idea of the 
> > difference in both methods? Seems getMSentryPrivileges() lacks of the grant 
> > option and unique query. The unique query is used to avoid datanucleus to 
> > return a list, so this is ok, but how does the grant option being the only 
> > difference between a list and a single privilege?

My understanding is that getMSentryPrivileges is mainly used to get all the 
associated roles for a privelege.  I'll take a deeper look into how grant 
affects it.


- Steve


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63775/#review191083
---


On Nov. 15, 2017, 9:47 p.m., Steve Moist wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63775/
> ---
> 
> (Updated Nov. 15, 2017, 9:47 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: SENTRY-1543
> https://issues.apache.org/jira/browse/SENTRY-1543
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Renamed methods to be more clear in their use since they both have the same 
> name but function and query differently.
> 
> 
> Diffs
> -
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  7217dea7 
> 
> 
> Diff: https://reviews.apache.org/r/63775/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests ran.
> 
> 
> Thanks,
> 
> Steve Moist
> 
>

Re: Review Request 63964: SENTRY-2049: Remove hive-authz2 profile from the sentry-dist module

2017-11-30 Thread Sergio Pena via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63964/#review192306
---


Ship it!




Ship It!

- Sergio Pena


On Nov. 27, 2017, 9:36 p.m., Steve Moist wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63964/
> ---
> 
> (Updated Nov. 27, 2017, 9:36 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: SENTRY-2049
> https://issues.apache.org/jira/browse/SENTRY-2049
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Remove hive-authz2 profile from the sentry-dist module
> 
> 
> Diffs
> -
> 
>   sentry-dist/pom.xml f4662957 
> 
> 
> Diff: https://reviews.apache.org/r/63964/diff/2/
> 
> 
> Testing
> ---
> 
> unit tests ran.
> 
> 
> Thanks,
> 
> Steve Moist
> 
>

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

2017-11-30 Thread Sergio Pena via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63881/#review192305
---


Ship it!




Ship It!

- Sergio Pena


On Nov. 29, 2017, 5:43 p.m., Arjun Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63881/
> ---
> 
> (Updated Nov. 29, 2017, 5:43 p.m.)
> 
> 
> Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and 
> Vadim Spector.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Currently we only seem to log when all conditions that lead to getting a 
> snapshot are validated, and eventually a full snapshot is received. However, 
> if for some reason a particular condition was invalid we don't log as to why. 
> This leaves no room for knowing definitely what might have been the reason as 
> to why a snapshot was not received from HMS.
> 
> 
> Diffs
> -
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  f32a745ed 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
>  c1471d118 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
>  eccb40fb6 
> 
> 
> Diff: https://reviews.apache.org/r/63881/diff/5/
> 
> 
> Testing
> ---
> 
> mvn -f sentry-provider/sentry-provider-db/pom.xml test
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>

Re: Review Request 63881: SENTRY-2040: When getting Snapshots from HMS we need more logging around cases when a snapshot is not being received

2017-11-30 Thread Sergio Pena via Review Board 


> On Nov. 29, 2017, 4:50 p.m., Sergio Pena wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
> > Lines 251-252 (patched)
> > 
> >
> > This line is making me some noise. If a user upgrades  their cluster, 
> > then the MSentryHmsNotification table will be empty initially; and if the 
> > user does not execute any DDL command for a long time, then this message 
> > will appear every 500ms on the log.
> > 
> > Is this log message necessary here?
> 
> Arjun Mishra wrote:
> Yeah it can be debug. I'll change it
> 
> Na Li wrote:
> Sergio, in this case, sentry will keep on getting full snapshot when 
> upser upgrade their cluster, and not execute any DDL command for a long time. 
> It is not desirable. We should re-visit this logic on when to get full 
> snapshot.

Agree. I think we should write a snapshot even if it is empty.

This below code is the one returning if an attempt to create a snapshot doesn't 
do anything. We may need to persist the snapshot ID at least if it is empty.

private long createFullSnapshot() {
PathsImage snapshotInfo = client.getFullSnapshot();
if (snapshotInfo.getPathImage().isEmpty()) {
   return snapshotInfo.getId();
}
}


- Sergio


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63881/#review192133
---


On Nov. 29, 2017, 5:43 p.m., Arjun Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63881/
> ---
> 
> (Updated Nov. 29, 2017, 5:43 p.m.)
> 
> 
> Review request for sentry, kalyan kumar kalvagadda, Na Li, Sergio Pena, and 
> Vadim Spector.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Currently we only seem to log when all conditions that lead to getting a 
> snapshot are validated, and eventually a full snapshot is received. However, 
> if for some reason a particular condition was invalid we don't log as to why. 
> This leaves no room for knowing definitely what might have been the reason as 
> to why a snapshot was not received from HMS.
> 
> 
> Diffs
> -
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  f32a745ed 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
>  c1471d118 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
>  eccb40fb6 
> 
> 
> Diff: https://reviews.apache.org/r/63881/diff/5/
> 
> 
> Testing
> ---
> 
> mvn -f sentry-provider/sentry-provider-db/pom.xml test
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>

Re: [VOTE] Release Sentry version 2.0.0

2017-11-30 Thread Alexander Kolbasov 
Given that the licensing exercise isn't complete, I suggest revoking the
vote on the release until it is complete.

- Alex

On Thu, Nov 30, 2017 at 7:11 AM, Kalyan Kumar Kalvagadda <
kkal...@cloudera.com> wrote:

> here are my next steps towards being compliant to apache licensing
>
> 1. Stop distributing jar which are licensed under GPL and LGPL only as they
> are not allowed to be distributed. (Please refer
> http://www.apache.org/legal/resolved.html#category-a)
> 2. See if we can stop distributing jars which are not licensed by Apache.
> 2. Document the rest of them in the LICENSE.txt following the guidelines
> mentioned in (https://www.apache.org/dev/licensing-howto.html)
>
> -Kalyan
>
> On Thu, Nov 30, 2017 at 4:40 AM, Colm O hEigeartaigh 
> wrote:
>
> > Hi Kalyan,
> >
> > You need to read the following page, which lays it all out:
> >
> > https://www.apache.org/dev/licensing-howto.html
> >
> > In particular, there are two things you need to do:
> >
> > a) Go through the list of dependencies and isolate the non-Apache
> licensed
> > jars. Include that license in a "licenses" directory and point to it in
> our
> > LICENSE.txt (note - it must be a permissive license, for example we can't
> > bundle LGPL jars that are not dual licensed):
> >
> > From the howto:
> >
> > "In LICENSE, add a pointer  to the dependency's
> > license within the distribution and a short note summarizing its
> licensing:
> >
> > This product bundles SuperWidget 1.2.3, which is available under a
> > "3-clause BSD" license.  For details, see deps/superwidget/.
> > "
> >
> > b) For all dependencies INCLUDING Apache licensed dependencies, you need
> > to go to the source for each dependency and see if it has a NOTICE file
> > with copyright notices that are non-Apache. If so they need to be
> included
> > in our NOTICE file.
> >
> > From the howto:
> >
> > "If the dependency supplies a NOTICE file, its contents must be analyzed
> > and the relevant portions bubbled up into the top-level NOTICE file."
> >
> > Colm.
> >
> >
> > On Wed, Nov 29, 2017 at 8:59 PM, Kalyan Kumar Kalvagadda <
> > kkal...@cloudera.com> wrote:
> >
> >> I have gathered all license information for all the dependencies using
> >> license-maven-plugin.
> >> Here is the file attached.
> >>
> >> Is there a particular format I should be using to update the license
> file
> >> in the repo?
> >>
> >> -Kalyan
> >>
> >> On Wed, Nov 29, 2017 at 1:52 PM, Colm O hEigeartaigh <
> cohei...@apache.org
> >> > wrote:
> >>
> >>> Hi Kalyan,
> >>>
> >>> Anything Apache related you can immediately discount - so Hadoop, Hive,
> >>> HBase, Solr, Zookeeper, etc. I would suggest just deleting those jars
> >>> from
> >>> the list and googling the remaining jars to see what the license is.
> >>>
> >>> Colm.
> >>>
> >>> On Wed, Nov 29, 2017 at 6:55 PM, Kalyan Kumar Kalvagadda <
> >>> kkal...@cloudera.com> wrote:
> >>>
> >>> > I'm trying to gather the license information for the dependencies.
> I'm
> >>> > trying to use Apache Maven Project Info Reports Plugin
> >>> >  >
> >>> .
> >>> >
> >>> > Does anyone has a better suggestion?
> >>> >
> >>> > -Kalyan
> >>> >
> >>> > On Wed, Nov 29, 2017 at 12:32 PM, Sergio Pena <
> >>> sergio.p...@cloudera.com>
> >>> > wrote:
> >>> >
> >>> > > I don't have that issue.
> >>> > >
> >>> > > I downloaded the 2.0 tar.gz that is already signed and install it
> on
> >>> an
> >>> > > Ubuntu 16.04 machine with Hive 2.3.2. It has been running in a
> single
> >>> > node
> >>> > > mode. I could check HMS notifications being pulled and updated, and
> >>> > > checking the permissions.
> >>> > >
> >>> > > On Wed, Nov 29, 2017 at 12:20 PM, Kalyan Kumar Kalvagadda <
> >>> > > kkal...@cloudera.com> wrote:
> >>> > >
> >>> > > > Sergio,
> >>> > > >
> >>> > > > I know that you tried to start sentry standalone, Did you see
> this
> >>> > issue?
> >>> > > >
> >>> > > >
> >>> > > > -Kalyan
> >>> > > >
> >>> > > > On Wed, Nov 29, 2017 at 12:16 PM, Alexander Kolbasov <
> >>> > ak...@cloudera.com
> >>> > > >
> >>> > > > wrote:
> >>> > > >
> >>> > > > > I tried to start Sentry server on Mac and got a weird error . I
> >>> am
> >>> > > > running
> >>> > > > > from the dist directory that I just built with mvn clean
> install
> >>> on
> >>> > the
> >>> > > > > 2.0.0 branch.
> >>> > > > >
> >>> > > > > 17/11/29 10:13:25 ERROR thrift.SentryService: Error starting
> >>> server
> >>> > > > > java.lang.SecurityException: class
> "javax.servlet.DispatcherType"
> >>> 's
> >>> > > > signer
> >>> > > > > information does not match signer information of other classes
> >>> in the
> >>> > > > same
> >>> > > > > package
> >>> > > > > at java.lang.ClassLoader.checkCer
> >>> ts(ClassLoader.java:898)
> >>> > > > > at java.lang.ClassLoader.preDefineClass(ClassLoader.
> >>> > java:668)
> >>> > > > > at java.lang.ClassLoader.defineCl
> >>>

Re: [VOTE] Release Sentry version 2.0.0

2017-11-30 Thread Kalyan Kumar Kalvagadda 
here are my next steps towards being compliant to apache licensing

1. Stop distributing jar which are licensed under GPL and LGPL only as they
are not allowed to be distributed. (Please refer
http://www.apache.org/legal/resolved.html#category-a)
2. See if we can stop distributing jars which are not licensed by Apache.
2. Document the rest of them in the LICENSE.txt following the guidelines
mentioned in (https://www.apache.org/dev/licensing-howto.html)

-Kalyan

On Thu, Nov 30, 2017 at 4:40 AM, Colm O hEigeartaigh 
wrote:

> Hi Kalyan,
>
> You need to read the following page, which lays it all out:
>
> https://www.apache.org/dev/licensing-howto.html
>
> In particular, there are two things you need to do:
>
> a) Go through the list of dependencies and isolate the non-Apache licensed
> jars. Include that license in a "licenses" directory and point to it in our
> LICENSE.txt (note - it must be a permissive license, for example we can't
> bundle LGPL jars that are not dual licensed):
>
> From the howto:
>
> "In LICENSE, add a pointer  to the dependency's
> license within the distribution and a short note summarizing its licensing:
>
> This product bundles SuperWidget 1.2.3, which is available under a
> "3-clause BSD" license.  For details, see deps/superwidget/.
> "
>
> b) For all dependencies INCLUDING Apache licensed dependencies, you need
> to go to the source for each dependency and see if it has a NOTICE file
> with copyright notices that are non-Apache. If so they need to be included
> in our NOTICE file.
>
> From the howto:
>
> "If the dependency supplies a NOTICE file, its contents must be analyzed
> and the relevant portions bubbled up into the top-level NOTICE file."
>
> Colm.
>
>
> On Wed, Nov 29, 2017 at 8:59 PM, Kalyan Kumar Kalvagadda <
> kkal...@cloudera.com> wrote:
>
>> I have gathered all license information for all the dependencies using
>> license-maven-plugin.
>> Here is the file attached.
>>
>> Is there a particular format I should be using to update the license file
>> in the repo?
>>
>> -Kalyan
>>
>> On Wed, Nov 29, 2017 at 1:52 PM, Colm O hEigeartaigh > > wrote:
>>
>>> Hi Kalyan,
>>>
>>> Anything Apache related you can immediately discount - so Hadoop, Hive,
>>> HBase, Solr, Zookeeper, etc. I would suggest just deleting those jars
>>> from
>>> the list and googling the remaining jars to see what the license is.
>>>
>>> Colm.
>>>
>>> On Wed, Nov 29, 2017 at 6:55 PM, Kalyan Kumar Kalvagadda <
>>> kkal...@cloudera.com> wrote:
>>>
>>> > I'm trying to gather the license information for the dependencies. I'm
>>> > trying to use Apache Maven Project Info Reports Plugin
>>> > 
>>> .
>>> >
>>> > Does anyone has a better suggestion?
>>> >
>>> > -Kalyan
>>> >
>>> > On Wed, Nov 29, 2017 at 12:32 PM, Sergio Pena <
>>> sergio.p...@cloudera.com>
>>> > wrote:
>>> >
>>> > > I don't have that issue.
>>> > >
>>> > > I downloaded the 2.0 tar.gz that is already signed and install it on
>>> an
>>> > > Ubuntu 16.04 machine with Hive 2.3.2. It has been running in a single
>>> > node
>>> > > mode. I could check HMS notifications being pulled and updated, and
>>> > > checking the permissions.
>>> > >
>>> > > On Wed, Nov 29, 2017 at 12:20 PM, Kalyan Kumar Kalvagadda <
>>> > > kkal...@cloudera.com> wrote:
>>> > >
>>> > > > Sergio,
>>> > > >
>>> > > > I know that you tried to start sentry standalone, Did you see this
>>> > issue?
>>> > > >
>>> > > >
>>> > > > -Kalyan
>>> > > >
>>> > > > On Wed, Nov 29, 2017 at 12:16 PM, Alexander Kolbasov <
>>> > ak...@cloudera.com
>>> > > >
>>> > > > wrote:
>>> > > >
>>> > > > > I tried to start Sentry server on Mac and got a weird error . I
>>> am
>>> > > > running
>>> > > > > from the dist directory that I just built with mvn clean install
>>> on
>>> > the
>>> > > > > 2.0.0 branch.
>>> > > > >
>>> > > > > 17/11/29 10:13:25 ERROR thrift.SentryService: Error starting
>>> server
>>> > > > > java.lang.SecurityException: class "javax.servlet.DispatcherType"
>>> 's
>>> > > > signer
>>> > > > > information does not match signer information of other classes
>>> in the
>>> > > > same
>>> > > > > package
>>> > > > > at java.lang.ClassLoader.checkCer
>>> ts(ClassLoader.java:898)
>>> > > > > at java.lang.ClassLoader.preDefineClass(ClassLoader.
>>> > java:668)
>>> > > > > at java.lang.ClassLoader.defineCl
>>> ass(ClassLoader.java:761)
>>> > > > > at
>>> > > > > java.security.SecureClassLoader.defineClass(
>>> > > SecureClassLoader.java:142)
>>> > > > > at java.net.URLClassLoader.defineClass(URLClassLoader.
>>> > > java:467)
>>> > > > > at java.net.URLClassLoader.access$100(URLClassLoader.
>>> > java:73)
>>> > > > > at java.net.URLClassLoader$1.run(
>>> URLClassLoader.java:368)
>>> > > > > at java.net.URLClassLoader$1.run(
>>> URLClassLoader.java:362)
>>> > > > > at

Re: Review Request 63596: SENTRY-1951 - Old SentryStore.retrieveFullPathsImage() should be removed

2017-11-30 Thread Xinran Tinney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63596/#review192298
---




sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
Lines 3574-3580 (patched)


Since this part is repeating through multiple files, is it helpful to 
create a function and call the function?


- Xinran Tinney


On Nov. 29, 2017, 5:23 p.m., Arjun Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63596/
> ---
> 
> (Updated Nov. 29, 2017, 5:23 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, Na 
> Li, Sergio Pena, and Vadim Spector.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> The old retrieveFullPathsImage() method in SentryStore is no longer used by 
> actual code (retrieveFullPathsImageUpdate(final String[] prefixes) is used 
> instead. It was preserved because it is used by test which now doesn't make 
> much sense.
> 
> 
> Diffs
> -
> 
>   
> sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestImageRetriever.java
>  b355630e7 
>   
> sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestSentryHDFSServiceProcessor.java
>  f09d1b228 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  f32a745ed 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
>  24b11f724 
> 
> 
> Diff: https://reviews.apache.org/r/63596/diff/5/
> 
> 
> Testing
> ---
> 
> mvn -f sentry-provider/sentry-provider-db/pom.xml test -Dtest=TestSentryStore
> mvn -f sentry-hdfs/sentry-hdfs-service/pom.xml test 
> -Dtest=TestSentryHDFSServiceProcessor
> mvn -f sentry-hdfs/sentry-hdfs-service/pom.xml test 
> -Dtest=TestImageRetriever.java
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>

Re: [VOTE] Release Sentry version 2.0.0

2017-11-30 Thread Colm O hEigeartaigh 
Hi Kalyan,

You need to read the following page, which lays it all out:

https://www.apache.org/dev/licensing-howto.html

In particular, there are two things you need to do:

a) Go through the list of dependencies and isolate the non-Apache licensed
jars. Include that license in a "licenses" directory and point to it in our
LICENSE.txt (note - it must be a permissive license, for example we can't
bundle LGPL jars that are not dual licensed):

>From the howto:

"In LICENSE, add a pointer  to the dependency's
license within the distribution and a short note summarizing its licensing:

This product bundles SuperWidget 1.2.3, which is available under a
"3-clause BSD" license.  For details, see deps/superwidget/.
"

b) For all dependencies INCLUDING Apache licensed dependencies, you need to
go to the source for each dependency and see if it has a NOTICE file with
copyright notices that are non-Apache. If so they need to be included in
our NOTICE file.

>From the howto:

"If the dependency supplies a NOTICE file, its contents must be analyzed
and the relevant portions bubbled up into the top-level NOTICE file."

Colm.


On Wed, Nov 29, 2017 at 8:59 PM, Kalyan Kumar Kalvagadda <
kkal...@cloudera.com> wrote:

> I have gathered all license information for all the dependencies using
> license-maven-plugin.
> Here is the file attached.
>
> Is there a particular format I should be using to update the license file
> in the repo?
>
> -Kalyan
>
> On Wed, Nov 29, 2017 at 1:52 PM, Colm O hEigeartaigh 
> wrote:
>
>> Hi Kalyan,
>>
>> Anything Apache related you can immediately discount - so Hadoop, Hive,
>> HBase, Solr, Zookeeper, etc. I would suggest just deleting those jars from
>> the list and googling the remaining jars to see what the license is.
>>
>> Colm.
>>
>> On Wed, Nov 29, 2017 at 6:55 PM, Kalyan Kumar Kalvagadda <
>> kkal...@cloudera.com> wrote:
>>
>> > I'm trying to gather the license information for the dependencies. I'm
>> > trying to use Apache Maven Project Info Reports Plugin
>> >  .
>> >
>> > Does anyone has a better suggestion?
>> >
>> > -Kalyan
>> >
>> > On Wed, Nov 29, 2017 at 12:32 PM, Sergio Pena > >
>> > wrote:
>> >
>> > > I don't have that issue.
>> > >
>> > > I downloaded the 2.0 tar.gz that is already signed and install it on
>> an
>> > > Ubuntu 16.04 machine with Hive 2.3.2. It has been running in a single
>> > node
>> > > mode. I could check HMS notifications being pulled and updated, and
>> > > checking the permissions.
>> > >
>> > > On Wed, Nov 29, 2017 at 12:20 PM, Kalyan Kumar Kalvagadda <
>> > > kkal...@cloudera.com> wrote:
>> > >
>> > > > Sergio,
>> > > >
>> > > > I know that you tried to start sentry standalone, Did you see this
>> > issue?
>> > > >
>> > > >
>> > > > -Kalyan
>> > > >
>> > > > On Wed, Nov 29, 2017 at 12:16 PM, Alexander Kolbasov <
>> > ak...@cloudera.com
>> > > >
>> > > > wrote:
>> > > >
>> > > > > I tried to start Sentry server on Mac and got a weird error . I am
>> > > > running
>> > > > > from the dist directory that I just built with mvn clean install
>> on
>> > the
>> > > > > 2.0.0 branch.
>> > > > >
>> > > > > 17/11/29 10:13:25 ERROR thrift.SentryService: Error starting
>> server
>> > > > > java.lang.SecurityException: class "javax.servlet.DispatcherType"
>> 's
>> > > > signer
>> > > > > information does not match signer information of other classes in
>> the
>> > > > same
>> > > > > package
>> > > > > at java.lang.ClassLoader.checkCerts(ClassLoader.java:898)
>> > > > > at java.lang.ClassLoader.preDefineClass(ClassLoader.
>> > java:668)
>> > > > > at java.lang.ClassLoader.defineCl
>> ass(ClassLoader.java:761)
>> > > > > at
>> > > > > java.security.SecureClassLoader.defineClass(
>> > > SecureClassLoader.java:142)
>> > > > > at java.net.URLClassLoader.defineClass(URLClassLoader.
>> > > java:467)
>> > > > > at java.net.URLClassLoader.access$100(URLClassLoader.
>> > java:73)
>> > > > > at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
>> > > > > at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
>> > > > > at java.security.AccessController.doPrivileged(Native
>> > Method)
>> > > > > at java.net.URLClassLoader.findClass(URLClassLoader.java:
>> > 361)
>> > > > > at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>> > > > > at sun.misc.Launcher$AppClassLoader.loadClass(
>> > > Launcher.java:331)
>> > > > > at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>> > > > > at
>> > > > > org.apache.sentry.service.thrift.SentryService.startSentryWe
>> bServer(
>> > > > > SentryService.java:422)
>> > > > > at
>> > > > > org.apache.sentry.service.thrift.SentryService.
>> > > > > runServer(SentryService.java:268)
>> > > > > at
>> > > > > org.apache.sentry.service.thrift.SentryService.call(