Re: Review Request 67934: SENTRY-2233: Add e2e tests for testing HDFS sync for owner privileges.

[Na Li via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67934/#review207769
---


Ship it!




Ship It!

- Na Li


On Aug. 22, 2018, 8:38 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67934/
> ---
> 
> (Updated Aug. 22, 2018, 8:38 p.m.)
> 
> 
> Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2233
> https://issues.apache.org/jira/browse/SENTRY-2233
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Add tests to verify owner privileges are synchronized to HDFS ACL's where 
> owner can be a role/user.
> 
> 
> Diffs
> -
> 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java
>  e730dd583ac8521ffae4576c63226cabd35cabcc 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java
>  9535dee395162687de2a4b4354f75080a5562635 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java
>  0339c7bcfe9def5d06c0b70b24f2c33cdf56e76e 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java
>  f70b6abd3d95a2b2e5995648c112600108421652 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
>  c085a0cd1c364f7572797d65e5f054eac3c9ce8c 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivilegesWithGrantOption.java
>  c2ccb24d304cec9dc6f56642ee13fc9a06e9c19a 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java
>  c8fc019ec35164b704c1570553d6fc6d561ff525 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
>  f0cf9604893c9c1a3b291e3b7b535bc144d36467 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java
>  061900a4bd4d53532957e4fccddd5054c6022a0b 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationTogglingConf.java
>  7f1ec7b627db53f5eb7b02de01e5cfa22e1d0e20 
> 
> 
> Diff: https://reviews.apache.org/r/67934/diff/4/
> 
> 
> Testing
> ---
> 
> Added tests to verify HDFS ACL for owner privileges.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 67934: SENTRY-2233: Add e2e tests for testing HDFS sync for owner privileges.

[kalyan kumar kalvagadda via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67934/
---

(Updated Aug. 22, 2018, 8:38 p.m.)


Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.


Changes
---

addressed review comment.


Bugs: SENTRY-2233
https://issues.apache.org/jira/browse/SENTRY-2233


Repository: sentry


Description
---

Add tests to verify owner privileges are synchronized to HDFS ACL's where owner 
can be a role/user.


Diffs (updated)
-

  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java
 e730dd583ac8521ffae4576c63226cabd35cabcc 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java
 9535dee395162687de2a4b4354f75080a5562635 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java
 0339c7bcfe9def5d06c0b70b24f2c33cdf56e76e 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java
 f70b6abd3d95a2b2e5995648c112600108421652 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
 c085a0cd1c364f7572797d65e5f054eac3c9ce8c 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivilegesWithGrantOption.java
 c2ccb24d304cec9dc6f56642ee13fc9a06e9c19a 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java
 c8fc019ec35164b704c1570553d6fc6d561ff525 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
 f0cf9604893c9c1a3b291e3b7b535bc144d36467 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java
 061900a4bd4d53532957e4fccddd5054c6022a0b 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationTogglingConf.java
 7f1ec7b627db53f5eb7b02de01e5cfa22e1d0e20 


Diff: https://reviews.apache.org/r/67934/diff/4/

Changes: https://reviews.apache.org/r/67934/diff/3-4/


Testing
---

Added tests to verify HDFS ACL for owner privileges.


Thanks,

kalyan kumar kalvagadda

Re: Review Request 68444: SENTRY-2318: Sentry listener should log the failure if grant/revoke of owner privilege fails

[Sergio Pena via Review Board]

> On Aug. 21, 2018, 7:52 p.m., Sergio Pena wrote:
> > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java
> > Lines 265-268 (original), 265-268 (patched)
> > 
> >
> > Agree with Lina. We cannot throw an exception in HMS as the listener is 
> > run after HMS already committed the operation. This may cause HMS to retry 
> > the commit .
> 
> kalyan kumar kalvagadda wrote:
> Just looked at the HMS code closely. This exception will cause HMS to 
> retry. This is wrong behavior in HMS for a failure in Post Event Listener.

HMS should not throw the exception back to HS2 for post-event listeners, 
otherwise the DDL operations will be committed with errors.


- Sergio


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68444/#review207688
---


On Aug. 21, 2018, 5:45 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68444/
> ---
> 
> (Updated Aug. 21, 2018, 5:45 p.m.)
> 
> 
> Review request for sentry, Na Li and Sergio Pena.
> 
> 
> Bugs: SENTRY-2318
> https://issues.apache.org/jira/browse/SENTRY-2318
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> If the grant/revoke of owner privilege fails for any reason it should logged 
> be as an error in the hive logs otherwise this will go un-noticed.
> 
> 
> Diffs
> -
> 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java
>  c37f3706092f2239e45e1cef2f31cb8ab1c886f5 
>   
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/metastore/TestSentrySyncHMSNotificationsPostEventListener.java
>  98de8e36adfd790996aba8e61a164d85e80bc006 
> 
> 
> Diff: https://reviews.apache.org/r/68444/diff/1/
> 
> 
> Testing
> ---
> 
> Updated the tests to cover the change.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 67934: SENTRY-2233: Add e2e tests for testing HDFS sync for owner privileges.

[Na Li via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67934/#review207766
---




sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
Lines 893 (patched)


should this be verifyGroupPermOnAllSubDirs?


- Na Li


On Aug. 22, 2018, 6:33 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67934/
> ---
> 
> (Updated Aug. 22, 2018, 6:33 p.m.)
> 
> 
> Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2233
> https://issues.apache.org/jira/browse/SENTRY-2233
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Add tests to verify owner privileges are synchronized to HDFS ACL's where 
> owner can be a role/user.
> 
> 
> Diffs
> -
> 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java
>  e730dd583ac8521ffae4576c63226cabd35cabcc 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java
>  9535dee395162687de2a4b4354f75080a5562635 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java
>  0339c7bcfe9def5d06c0b70b24f2c33cdf56e76e 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java
>  f70b6abd3d95a2b2e5995648c112600108421652 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
>  c085a0cd1c364f7572797d65e5f054eac3c9ce8c 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivilegesWithGrantOption.java
>  c2ccb24d304cec9dc6f56642ee13fc9a06e9c19a 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java
>  c8fc019ec35164b704c1570553d6fc6d561ff525 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
>  f0cf9604893c9c1a3b291e3b7b535bc144d36467 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java
>  061900a4bd4d53532957e4fccddd5054c6022a0b 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationTogglingConf.java
>  7f1ec7b627db53f5eb7b02de01e5cfa22e1d0e20 
> 
> 
> Diff: https://reviews.apache.org/r/67934/diff/3/
> 
> 
> Testing
> ---
> 
> Added tests to verify HDFS ACL for owner privileges.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Sentry-jdk-1.8 - Build # 148 - Fixed

[Apache Jenkins Server]

The Apache Jenkins build system has built Sentry-jdk-1.8 (build #148)

Status: Fixed

Check console output at https://builds.apache.org/job/Sentry-jdk-1.8/148/ to 
view the results.

Re: Review Request 67934: SENTRY-2233: Add e2e tests for testing HDFS sync for owner privileges.

[kalyan kumar kalvagadda via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67934/
---

(Updated Aug. 22, 2018, 6:33 p.m.)


Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.


Changes
---

rebased the patch. Tests are not complete yet.


Bugs: SENTRY-2233
https://issues.apache.org/jira/browse/SENTRY-2233


Repository: sentry


Description
---

Add tests to verify owner privileges are synchronized to HDFS ACL's where owner 
can be a role/user.


Diffs (updated)
-

  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java
 e730dd583ac8521ffae4576c63226cabd35cabcc 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java
 9535dee395162687de2a4b4354f75080a5562635 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java
 0339c7bcfe9def5d06c0b70b24f2c33cdf56e76e 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java
 f70b6abd3d95a2b2e5995648c112600108421652 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
 c085a0cd1c364f7572797d65e5f054eac3c9ce8c 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivilegesWithGrantOption.java
 c2ccb24d304cec9dc6f56642ee13fc9a06e9c19a 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java
 c8fc019ec35164b704c1570553d6fc6d561ff525 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
 f0cf9604893c9c1a3b291e3b7b535bc144d36467 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java
 061900a4bd4d53532957e4fccddd5054c6022a0b 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationTogglingConf.java
 7f1ec7b627db53f5eb7b02de01e5cfa22e1d0e20 


Diff: https://reviews.apache.org/r/67934/diff/3/

Changes: https://reviews.apache.org/r/67934/diff/2-3/


Testing
---

Added tests to verify HDFS ACL for owner privileges.


Thanks,

kalyan kumar kalvagadda

Re: Review Request 61863: SENTRY-1896 - Optimize retrieving entities by other entity types

[Na Li via Review Board]

> On Aug. 22, 2018, 5:37 p.m., kalyan kumar kalvagadda wrote:
> > Arjun,
> > 
> > I see you added fetching groups in a lot of API's. Do we know if there wil 
> > be performence benifit in all the cases to to have fetch plan and avoid 
> > loose fetching?

I have worked with Arjun yesterday on the behavior of default fetch group. So 
far, it seems when there are more than 2 fields specifies 
"default-fetch-group="true"", only the first two fields are bulk-fetched 
automatically. The other fields are fetched on demand, and cause performance 
issue. We will work more to confirm this behavior. If it is true, then it is 
safer to specify fetching group to make sure those fields are fetched in bulk 
as it does not cause cause harm, but to guarantee good performance.


- Na


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61863/#review207758
---


On Aug. 21, 2018, 7:19 p.m., Arjun Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61863/
> ---
> 
> (Updated Aug. 21, 2018, 7:19 p.m.)
> 
> 
> Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Right now when we get privileges from sentry, we pass in a provider like set 
> of groups. Then we create a MSentryGroup object for each group and then get 
> roles using the .getRoles() method. This is bad since we only need the 
> roleNames for the group and not the entire Role object.  
> Instead running a SQL like query and just getting roleNames will drastically 
> improve performance
> 
> 
> Diffs
> -
> 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  0ef6a208f 
> 
> 
> Diff: https://reviews.apache.org/r/61863/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>

Re: Review Request 67934: SENTRY-2233: Add e2e tests for testing HDFS sync for owner privileges.

[Na Li via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67934/#review207759
---




sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
Line 431 (original), 456 (patched)


It seems your code is not update to date.

We don't have function verifyTablePrivilegeExistForUser, instead we have 
verifyTableOwnerPrivilegeExistForPrincipal now.


- Na Li


On Aug. 15, 2018, 6:16 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67934/
> ---
> 
> (Updated Aug. 15, 2018, 6:16 p.m.)
> 
> 
> Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2233
> https://issues.apache.org/jira/browse/SENTRY-2233
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Add tests to verify owner privileges are synchronized to HDFS ACL's where 
> owner can be a role/user.
> 
> 
> Diffs
> -
> 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessing.java
>  e730dd583ac8521ffae4576c63226cabd35cabcc 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutHdfsSync.java
>  9535dee395162687de2a4b4354f75080a5562635 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnCreate.java
>  0339c7bcfe9def5d06c0b70b24f2c33cdf56e76e 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestHmsNotificationProcessingWithOutSyncOnDrop.java
>  f70b6abd3d95a2b2e5995648c112600108421652 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
>  8a1021426d72eb5f282975963357a553d79d0a48 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java
>  c8fc019ec35164b704c1570553d6fc6d561ff525 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
>  9b4f4da0c89e00d002d95956521d014ad6c99ddc 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java
>  061900a4bd4d53532957e4fccddd5054c6022a0b 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationTogglingConf.java
>  7f1ec7b627db53f5eb7b02de01e5cfa22e1d0e20 
> 
> 
> Diff: https://reviews.apache.org/r/67934/diff/2/
> 
> 
> Testing
> ---
> 
> Added tests to verify HDFS ACL for owner privileges.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Sentry-jdk-1.8 - Build # 147 - Failure

[Apache Jenkins Server]

The Apache Jenkins build system has built Sentry-jdk-1.8 (build #147)

Status: Failure

Check console output at https://builds.apache.org/job/Sentry-jdk-1.8/147/ to 
view the results.

Re: Review Request 68452: SENTRY-2359: Object owner is unable to grant privileges: SentryAccessDeniedException

[kalyan kumar kalvagadda via Review Board]

> On Aug. 22, 2018, 3:58 p.m., Na Li wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
> > Line 3001 (original), 3007 (patched)
> > 
> >
> > why do you change exception type? SentryInvalidInputException is 
> > derived from SentryUserException

Becausse getMSentryPrivilegesByUserNameIfExists throws Exception.


- kalyan kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68452/#review207752
---


On Aug. 22, 2018, 10:40 a.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68452/
> ---
> 
> (Updated Aug. 22, 2018, 10:40 a.m.)
> 
> 
> Review request for sentry, Na Li and Sergio Pena.
> 
> 
> Bugs: SENTRY-2359
> https://issues.apache.org/jira/browse/SENTRY-2359
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Added code changes to look for owner privilege for roles and users while 
> authorizing a privilege grant request.
> 
> 
> Diffs
> -
> 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java
>  1decef2bafb98cdeb98f7d570eecdcc705f8249f 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  8b32e7b2f7b12cf2aa60eb955f72db85afbe41cd 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivilegesWithGrantOption.java
>  b3d98cb319916b2272c10ea0b39d91d4b118df3e 
> 
> 
> Diff: https://reviews.apache.org/r/68452/diff/3/
> 
> 
> Testing
> ---
> 
> Added new test to verify the same and also made sure that all the existing 
> tests passed.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 68456: SENTRY-2360: Update the pom file in 2.0 branch

[Na Li via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68456/#review207754
---


Ship it!




Ship It!

- Na Li


On Aug. 21, 2018, 9:33 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68456/
> ---
> 
> (Updated Aug. 21, 2018, 9:33 p.m.)
> 
> 
> Review request for sentry and Sergio Pena.
> 
> 
> Bugs: SENTRY-2360
> https://issues.apache.org/jira/browse/SENTRY-2360
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> updated the version from 2.0 to 2.0-2-SNAPSHOT in the pom files.
> 
> 
> Diffs
> -
> 
>   pom.xml 94b952fa7a4d59e58752d575b68a5260ef8cc2ab 
>   sentry-binding/pom.xml acffc5f55085a66db82b2dacc81e42b952a531ae 
>   sentry-binding/sentry-binding-hive-common/pom.xml 
> eb310da2d9273931b1d55a4a916c7749142ecbe5 
>   sentry-binding/sentry-binding-hive-conf/pom.xml 
> 232a3f28165b0fb14f80ccc2f7fe885d1799be71 
>   sentry-binding/sentry-binding-hive-follower/pom.xml 
> e5ecdfd3acaed632434ae392206ffe0f20d602e2 
>   sentry-binding/sentry-binding-hive-v2/pom.xml 
> 18dbe6484fb833198536c955c306c32194818183 
>   sentry-binding/sentry-binding-hive/pom.xml 
> 085a12e46460154e488d0f7d2583e4155498bed5 
>   sentry-binding/sentry-binding-kafka/pom.xml 
> fe8b3bbe1fb4cbb121c5ce19059b22dbffd7d722 
>   sentry-binding/sentry-binding-solr/pom.xml 
> 8a3fd1dcce06541695b1bda9b577dd04d1a2e5b0 
>   sentry-binding/sentry-binding-sqoop/pom.xml 
> d67aa1782b67d540531aba32a9f4ab350ecd832d 
>   sentry-core/pom.xml 6c877a70cc058d75711f2c3b5dbe9bd55b0fa721 
>   sentry-core/sentry-core-common/pom.xml 
> ee91c1a042cb5845e1ea27726afd22968fd32bf1 
>   sentry-core/sentry-core-model-db/pom.xml 
> 66df5d139037bb61df07bca025677e8233227088 
>   sentry-core/sentry-core-model-indexer/pom.xml 
> f85eb3fa91204e555284e07630277de13ce07674 
>   sentry-core/sentry-core-model-kafka/pom.xml 
> fc2daeb9e233d7df92661b430f5803ba1d8991a3 
>   sentry-core/sentry-core-model-solr/pom.xml 
> bd3784b54560223535275fad2b8766bf56ffcc3e 
>   sentry-core/sentry-core-model-sqoop/pom.xml 
> 8e58a1fbd30fdbb53fb41315fb2a8bb32edfc9c9 
>   sentry-dist/pom.xml ecd0d37e9781bc5e5092f8cff7ab8efa9b76a8c5 
>   sentry-hdfs/pom.xml d8b9efb248fc0c9cae8f73a61d35d8d690b81578 
>   sentry-hdfs/sentry-hdfs-common/pom.xml 
> fe8fcf0eb48985ebd6957e1b3d711e2b7a1ab5ee 
>   sentry-hdfs/sentry-hdfs-dist/pom.xml 
> 624fccc2759737e128014620e6a6c38636fcacd2 
>   sentry-hdfs/sentry-hdfs-namenode-plugin/pom.xml 
> f728b26e15583a789f7b6b27051cb57ae0c20933 
>   sentry-hdfs/sentry-hdfs-service/pom.xml 
> 158e837f92d81fc63e2438163a4b85eca351c926 
>   sentry-policy/pom.xml d56c836399fa147bbb048fe5dfb3e750c1b6acab 
>   sentry-policy/sentry-policy-common/pom.xml 
> 065cddeea6669453af8575eed9693866bd28b0ae 
>   sentry-policy/sentry-policy-engine/pom.xml 
> c97347790ddb70c5a75aa5d6efb972d7c830f117 
>   sentry-policy/sentry-policy-indexer/pom.xml 
> b25a0cc0d2cf8d1cf25880d1cff23cccf4ec78cf 
>   sentry-provider/pom.xml 6ce30f5b0fe3edd5d2eb33932e538a82519bebf9 
>   sentry-provider/sentry-provider-cache/pom.xml 
> dedd89444ddeea3782c2ab3eb4362ae8bebe508f 
>   sentry-provider/sentry-provider-common/pom.xml 
> 4536deab9dffee99cf4e420d13bc2ab10ce3d052 
>   sentry-provider/sentry-provider-db/pom.xml 
> 679868a689aa1bdf602a58505d53a57a9eacc953 
>   sentry-provider/sentry-provider-file/pom.xml 
> 586ab5f700c20e8445ee9c64474568674988dbb8 
>   sentry-solr/pom.xml 8060575d882926beabdc948a7e8b3ba8ebafeb81 
>   sentry-solr/solr-sentry-handlers/pom.xml 
> 7045c48a17d573eab779d6443a59b46cd16eacb8 
>   sentry-tests/pom.xml a82f2adb6b03a82a9198e0a7d36df92a9916d965 
>   sentry-tests/sentry-tests-hive-v2/pom.xml 
> ecb9dc75a4f5aa764026a7840ca05395feec1ba1 
>   sentry-tests/sentry-tests-hive/pom.xml 
> 64ab1e214e4aaac6c7d4f50d883ba7dfc71f2e2d 
>   sentry-tests/sentry-tests-kafka/pom.xml 
> 4b89a59162998a5fdbb2348adba90ec24ce752f3 
>   sentry-tests/sentry-tests-solr/pom.xml 
> 01f5c6c2992cdd03df3fac5aa7836f116b03469b 
>   sentry-tests/sentry-tests-sqoop/pom.xml 
> 2d425a42da38395366fbbd8a2762bdbfa01d32d8 
>   sentry-tools/pom.xml 64508fd35d716f3fb9b8ccb1e7bafccdd4a429e6 
> 
> 
> Diff: https://reviews.apache.org/r/68456/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 68452: SENTRY-2359: Object owner is unable to grant privileges: SentryAccessDeniedException

[Na Li via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68452/#review207753
---


Ship it!




Ship It!

- Na Li


On Aug. 22, 2018, 10:40 a.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68452/
> ---
> 
> (Updated Aug. 22, 2018, 10:40 a.m.)
> 
> 
> Review request for sentry, Na Li and Sergio Pena.
> 
> 
> Bugs: SENTRY-2359
> https://issues.apache.org/jira/browse/SENTRY-2359
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Added code changes to look for owner privilege for roles and users while 
> authorizing a privilege grant request.
> 
> 
> Diffs
> -
> 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java
>  1decef2bafb98cdeb98f7d570eecdcc705f8249f 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  8b32e7b2f7b12cf2aa60eb955f72db85afbe41cd 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivilegesWithGrantOption.java
>  b3d98cb319916b2272c10ea0b39d91d4b118df3e 
> 
> 
> Diff: https://reviews.apache.org/r/68452/diff/3/
> 
> 
> Testing
> ---
> 
> Added new test to verify the same and also made sure that all the existing 
> tests passed.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 68452: SENTRY-2359: Object owner is unable to grant privileges: SentryAccessDeniedException

[Na Li via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68452/#review207752
---




sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
Line 3001 (original), 3007 (patched)


why do you change exception type? SentryInvalidInputException is derived 
from SentryUserException


- Na Li


On Aug. 22, 2018, 10:40 a.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68452/
> ---
> 
> (Updated Aug. 22, 2018, 10:40 a.m.)
> 
> 
> Review request for sentry, Na Li and Sergio Pena.
> 
> 
> Bugs: SENTRY-2359
> https://issues.apache.org/jira/browse/SENTRY-2359
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Added code changes to look for owner privilege for roles and users while 
> authorizing a privilege grant request.
> 
> 
> Diffs
> -
> 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java
>  1decef2bafb98cdeb98f7d570eecdcc705f8249f 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  8b32e7b2f7b12cf2aa60eb955f72db85afbe41cd 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivilegesWithGrantOption.java
>  b3d98cb319916b2272c10ea0b39d91d4b118df3e 
> 
> 
> Diff: https://reviews.apache.org/r/68452/diff/3/
> 
> 
> Testing
> ---
> 
> Added new test to verify the same and also made sure that all the existing 
> tests passed.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 67949: SENTRY-2307: Avoid HMS event synchronization while sentry is fetching full snapshot.

[Na Li via Review Board]

> On Aug. 17, 2018, 5:24 p.m., Na Li wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializerState.java
> > Lines 28 (patched)
> > 
> >
> > It is enum, but only one state. Kind of weird.
> > 
> > Should it has other states, such as "INIT", "SUCCEED", "FAILED"
> > 
> > Or it is just a normal class, no need to be enum
> 
> kalyan kumar kalvagadda wrote:
> "INIT", "SUCCEED", "FAILED" reflect status not current state.
> Reason i did not add addtional states as we need not track any other 
> state at this point in time. When we may need to track more states in future 
> we can extend the enum to have more states. What do you say?

I am OK with this.


- Na


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67949/#review207514
---


On July 17, 2018, 10:53 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67949/
> ---
> 
> (Updated July 17, 2018, 10:53 p.m.)
> 
> 
> Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2307
> https://issues.apache.org/jira/browse/SENTRY-2307
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Sentry tries to synchronize the HMS operations to make sure that sentry 
> server process the notifications for create/drop/alter table and databases 
> before it receives permission grants/revokes on them. Blocking HMS threads to 
> make sentry processes appropriate notifications makes sense but doing the 
> same when full snapshot is taken doesn’t serve any purpose as sentry server 
> doesn’t update sentry permissions based on HMS full snapshot. We can document 
> that there sentry could have some stale permissions  when there are any DDL 
> operations performed at the time of snapshot creation.
> 
> 
> Diffs
> -
> 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
>  2efc8cf9c1380a063c54d6bf4ef83e9d0fa8ebc9 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializerState.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
>  12266cb25ea70753e07d27b53de777f347f68844 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryStateBank.java
>  2c05d49d7f1b7e43318dcfeba22f4f8f4fa3c724 
>   
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java
>  3475624e35cb011df01cc0fa633c01141a882337 
>   
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/service/thrift/TestSentryHMSClient.java
>  38668ca88f155e0fa2f3beb4db32b18e953e58b6 
> 
> 
> Diff: https://reviews.apache.org/r/67949/diff/1/
> 
> 
> Testing
> ---
> 
> Added tests to verify  the changes added.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 68456: SENTRY-2360: Update the pom file in 2.0 branch

[Sergio Pena via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68456/#review207738
---


Ship it!




Ship It!

- Sergio Pena


On Aug. 21, 2018, 9:33 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68456/
> ---
> 
> (Updated Aug. 21, 2018, 9:33 p.m.)
> 
> 
> Review request for sentry and Sergio Pena.
> 
> 
> Bugs: SENTRY-2360
> https://issues.apache.org/jira/browse/SENTRY-2360
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> updated the version from 2.0 to 2.0-2-SNAPSHOT in the pom files.
> 
> 
> Diffs
> -
> 
>   pom.xml 94b952fa7a4d59e58752d575b68a5260ef8cc2ab 
>   sentry-binding/pom.xml acffc5f55085a66db82b2dacc81e42b952a531ae 
>   sentry-binding/sentry-binding-hive-common/pom.xml 
> eb310da2d9273931b1d55a4a916c7749142ecbe5 
>   sentry-binding/sentry-binding-hive-conf/pom.xml 
> 232a3f28165b0fb14f80ccc2f7fe885d1799be71 
>   sentry-binding/sentry-binding-hive-follower/pom.xml 
> e5ecdfd3acaed632434ae392206ffe0f20d602e2 
>   sentry-binding/sentry-binding-hive-v2/pom.xml 
> 18dbe6484fb833198536c955c306c32194818183 
>   sentry-binding/sentry-binding-hive/pom.xml 
> 085a12e46460154e488d0f7d2583e4155498bed5 
>   sentry-binding/sentry-binding-kafka/pom.xml 
> fe8b3bbe1fb4cbb121c5ce19059b22dbffd7d722 
>   sentry-binding/sentry-binding-solr/pom.xml 
> 8a3fd1dcce06541695b1bda9b577dd04d1a2e5b0 
>   sentry-binding/sentry-binding-sqoop/pom.xml 
> d67aa1782b67d540531aba32a9f4ab350ecd832d 
>   sentry-core/pom.xml 6c877a70cc058d75711f2c3b5dbe9bd55b0fa721 
>   sentry-core/sentry-core-common/pom.xml 
> ee91c1a042cb5845e1ea27726afd22968fd32bf1 
>   sentry-core/sentry-core-model-db/pom.xml 
> 66df5d139037bb61df07bca025677e8233227088 
>   sentry-core/sentry-core-model-indexer/pom.xml 
> f85eb3fa91204e555284e07630277de13ce07674 
>   sentry-core/sentry-core-model-kafka/pom.xml 
> fc2daeb9e233d7df92661b430f5803ba1d8991a3 
>   sentry-core/sentry-core-model-solr/pom.xml 
> bd3784b54560223535275fad2b8766bf56ffcc3e 
>   sentry-core/sentry-core-model-sqoop/pom.xml 
> 8e58a1fbd30fdbb53fb41315fb2a8bb32edfc9c9 
>   sentry-dist/pom.xml ecd0d37e9781bc5e5092f8cff7ab8efa9b76a8c5 
>   sentry-hdfs/pom.xml d8b9efb248fc0c9cae8f73a61d35d8d690b81578 
>   sentry-hdfs/sentry-hdfs-common/pom.xml 
> fe8fcf0eb48985ebd6957e1b3d711e2b7a1ab5ee 
>   sentry-hdfs/sentry-hdfs-dist/pom.xml 
> 624fccc2759737e128014620e6a6c38636fcacd2 
>   sentry-hdfs/sentry-hdfs-namenode-plugin/pom.xml 
> f728b26e15583a789f7b6b27051cb57ae0c20933 
>   sentry-hdfs/sentry-hdfs-service/pom.xml 
> 158e837f92d81fc63e2438163a4b85eca351c926 
>   sentry-policy/pom.xml d56c836399fa147bbb048fe5dfb3e750c1b6acab 
>   sentry-policy/sentry-policy-common/pom.xml 
> 065cddeea6669453af8575eed9693866bd28b0ae 
>   sentry-policy/sentry-policy-engine/pom.xml 
> c97347790ddb70c5a75aa5d6efb972d7c830f117 
>   sentry-policy/sentry-policy-indexer/pom.xml 
> b25a0cc0d2cf8d1cf25880d1cff23cccf4ec78cf 
>   sentry-provider/pom.xml 6ce30f5b0fe3edd5d2eb33932e538a82519bebf9 
>   sentry-provider/sentry-provider-cache/pom.xml 
> dedd89444ddeea3782c2ab3eb4362ae8bebe508f 
>   sentry-provider/sentry-provider-common/pom.xml 
> 4536deab9dffee99cf4e420d13bc2ab10ce3d052 
>   sentry-provider/sentry-provider-db/pom.xml 
> 679868a689aa1bdf602a58505d53a57a9eacc953 
>   sentry-provider/sentry-provider-file/pom.xml 
> 586ab5f700c20e8445ee9c64474568674988dbb8 
>   sentry-solr/pom.xml 8060575d882926beabdc948a7e8b3ba8ebafeb81 
>   sentry-solr/solr-sentry-handlers/pom.xml 
> 7045c48a17d573eab779d6443a59b46cd16eacb8 
>   sentry-tests/pom.xml a82f2adb6b03a82a9198e0a7d36df92a9916d965 
>   sentry-tests/sentry-tests-hive-v2/pom.xml 
> ecb9dc75a4f5aa764026a7840ca05395feec1ba1 
>   sentry-tests/sentry-tests-hive/pom.xml 
> 64ab1e214e4aaac6c7d4f50d883ba7dfc71f2e2d 
>   sentry-tests/sentry-tests-kafka/pom.xml 
> 4b89a59162998a5fdbb2348adba90ec24ce752f3 
>   sentry-tests/sentry-tests-solr/pom.xml 
> 01f5c6c2992cdd03df3fac5aa7836f116b03469b 
>   sentry-tests/sentry-tests-sqoop/pom.xml 
> 2d425a42da38395366fbbd8a2762bdbfa01d32d8 
>   sentry-tools/pom.xml 64508fd35d716f3fb9b8ccb1e7bafccdd4a429e6 
> 
> 
> Diff: https://reviews.apache.org/r/68456/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 68452: SENTRY-2359: Object owner is unable to grant privileges: SentryAccessDeniedException

[kalyan kumar kalvagadda via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68452/
---

(Updated Aug. 22, 2018, 10:40 a.m.)


Review request for sentry, Na Li and Sergio Pena.


Changes
---

fixed issue with previous patch.


Bugs: SENTRY-2359
https://issues.apache.org/jira/browse/SENTRY-2359


Repository: sentry


Description
---

Added code changes to look for owner privilege for roles and users while 
authorizing a privilege grant request.


Diffs (updated)
-

  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java
 1decef2bafb98cdeb98f7d570eecdcc705f8249f 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
 8b32e7b2f7b12cf2aa60eb955f72db85afbe41cd 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivilegesWithGrantOption.java
 b3d98cb319916b2272c10ea0b39d91d4b118df3e 


Diff: https://reviews.apache.org/r/68452/diff/3/

Changes: https://reviews.apache.org/r/68452/diff/2-3/


Testing
---

Added new test to verify the same and also made sure that all the existing 
tests passed.


Thanks,

kalyan kumar kalvagadda

[ANNOUNCE] Apache Sentry 2.0.1 released

[Kalyan Kumar Kalvagadda]

The Apache Sentry team is happy to announce the release of version 2.0.1.
Apache Sentry is a system to enforce fine grained role based authorization
to data and metadata stored on a Hadoop cluster.

The release bits are available at:
http://sentry.apache.org/general/downloads.html

Sentry 2.0.1 Release Notes are available here:

*https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314720=12343306
*


We would like to thank all contributors who made the release possible.

Regards,
Sentry team

Re: Review Request 67949: SENTRY-2307: Avoid HMS event synchronization while sentry is fetching full snapshot.

[kalyan kumar kalvagadda via Review Board]

> On Aug. 17, 2018, 5:24 p.m., Na Li wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializerState.java
> > Lines 28 (patched)
> > 
> >
> > It is enum, but only one state. Kind of weird.
> > 
> > Should it has other states, such as "INIT", "SUCCEED", "FAILED"
> > 
> > Or it is just a normal class, no need to be enum

"INIT", "SUCCEED", "FAILED" reflect status not current state.
Reason i did not add addtional states as we need not track any other state at 
this point in time. When we may need to track more states in future we can 
extend the enum to have more states. What do you say?


- kalyan kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67949/#review207514
---


On July 17, 2018, 10:53 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67949/
> ---
> 
> (Updated July 17, 2018, 10:53 p.m.)
> 
> 
> Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena.
> 
> 
> Bugs: SENTRY-2307
> https://issues.apache.org/jira/browse/SENTRY-2307
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Sentry tries to synchronize the HMS operations to make sure that sentry 
> server process the notifications for create/drop/alter table and databases 
> before it receives permission grants/revokes on them. Blocking HMS threads to 
> make sentry processes appropriate notifications makes sense but doing the 
> same when full snapshot is taken doesn’t serve any purpose as sentry server 
> doesn’t update sentry permissions based on HMS full snapshot. We can document 
> that there sentry could have some stale permissions  when there are any DDL 
> operations performed at the time of snapshot creation.
> 
> 
> Diffs
> -
> 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
>  2efc8cf9c1380a063c54d6bf4ef83e9d0fa8ebc9 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializerState.java
>  PRE-CREATION 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
>  12266cb25ea70753e07d27b53de777f347f68844 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryStateBank.java
>  2c05d49d7f1b7e43318dcfeba22f4f8f4fa3c724 
>   
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java
>  3475624e35cb011df01cc0fa633c01141a882337 
>   
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/service/thrift/TestSentryHMSClient.java
>  38668ca88f155e0fa2f3beb4db32b18e953e58b6 
> 
> 
> Diff: https://reviews.apache.org/r/67949/diff/1/
> 
> 
> Testing
> ---
> 
> Added tests to verify  the changes added.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 68452: SENTRY-2359: Object owner is unable to grant privileges: SentryAccessDeniedException

[kalyan kumar kalvagadda via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68452/
---

(Updated Aug. 22, 2018, 7:15 a.m.)


Review request for sentry, Na Li and Sergio Pena.


Changes
---

addressed review comments.


Bugs: SENTRY-2359
https://issues.apache.org/jira/browse/SENTRY-2359


Repository: sentry


Description
---

Added code changes to look for owner privilege for roles and users while 
authorizing a privilege grant request.


Diffs (updated)
-

  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java
 1decef2bafb98cdeb98f7d570eecdcc705f8249f 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
 8b32e7b2f7b12cf2aa60eb955f72db85afbe41cd 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivilegesWithGrantOption.java
 b3d98cb319916b2272c10ea0b39d91d4b118df3e 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java
 8bf486e7d7d7a2e89278f1287115bf835513ef3f 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java
 b048989b42bde0318c6d0fa0e9353a2a59954407 


Diff: https://reviews.apache.org/r/68452/diff/2/

Changes: https://reviews.apache.org/r/68452/diff/1-2/


Testing
---

Added new test to verify the same and also made sure that all the existing 
tests passed.


Thanks,

kalyan kumar kalvagadda

Re: Review Request 68456: SENTRY-2360: Update the pom file in 2.0 branch

[kalyan kumar kalvagadda via Review Board]

> On Aug. 22, 2018, 3:53 a.m., Na Li wrote:
> > sentry-hdfs/sentry-hdfs-dist/pom.xml
> > Line 25 (original), 25 (patched)
> > 
> >
> > why to 2.0.2? We are releasing 2.0.1. Is this for future release?

This is prepating the branch for future release.


- kalyan kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68456/#review207727
---


On Aug. 21, 2018, 9:33 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68456/
> ---
> 
> (Updated Aug. 21, 2018, 9:33 p.m.)
> 
> 
> Review request for sentry and Sergio Pena.
> 
> 
> Bugs: SENTRY-2360
> https://issues.apache.org/jira/browse/SENTRY-2360
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> updated the version from 2.0 to 2.0-2-SNAPSHOT in the pom files.
> 
> 
> Diffs
> -
> 
>   pom.xml 94b952fa7a4d59e58752d575b68a5260ef8cc2ab 
>   sentry-binding/pom.xml acffc5f55085a66db82b2dacc81e42b952a531ae 
>   sentry-binding/sentry-binding-hive-common/pom.xml 
> eb310da2d9273931b1d55a4a916c7749142ecbe5 
>   sentry-binding/sentry-binding-hive-conf/pom.xml 
> 232a3f28165b0fb14f80ccc2f7fe885d1799be71 
>   sentry-binding/sentry-binding-hive-follower/pom.xml 
> e5ecdfd3acaed632434ae392206ffe0f20d602e2 
>   sentry-binding/sentry-binding-hive-v2/pom.xml 
> 18dbe6484fb833198536c955c306c32194818183 
>   sentry-binding/sentry-binding-hive/pom.xml 
> 085a12e46460154e488d0f7d2583e4155498bed5 
>   sentry-binding/sentry-binding-kafka/pom.xml 
> fe8b3bbe1fb4cbb121c5ce19059b22dbffd7d722 
>   sentry-binding/sentry-binding-solr/pom.xml 
> 8a3fd1dcce06541695b1bda9b577dd04d1a2e5b0 
>   sentry-binding/sentry-binding-sqoop/pom.xml 
> d67aa1782b67d540531aba32a9f4ab350ecd832d 
>   sentry-core/pom.xml 6c877a70cc058d75711f2c3b5dbe9bd55b0fa721 
>   sentry-core/sentry-core-common/pom.xml 
> ee91c1a042cb5845e1ea27726afd22968fd32bf1 
>   sentry-core/sentry-core-model-db/pom.xml 
> 66df5d139037bb61df07bca025677e8233227088 
>   sentry-core/sentry-core-model-indexer/pom.xml 
> f85eb3fa91204e555284e07630277de13ce07674 
>   sentry-core/sentry-core-model-kafka/pom.xml 
> fc2daeb9e233d7df92661b430f5803ba1d8991a3 
>   sentry-core/sentry-core-model-solr/pom.xml 
> bd3784b54560223535275fad2b8766bf56ffcc3e 
>   sentry-core/sentry-core-model-sqoop/pom.xml 
> 8e58a1fbd30fdbb53fb41315fb2a8bb32edfc9c9 
>   sentry-dist/pom.xml ecd0d37e9781bc5e5092f8cff7ab8efa9b76a8c5 
>   sentry-hdfs/pom.xml d8b9efb248fc0c9cae8f73a61d35d8d690b81578 
>   sentry-hdfs/sentry-hdfs-common/pom.xml 
> fe8fcf0eb48985ebd6957e1b3d711e2b7a1ab5ee 
>   sentry-hdfs/sentry-hdfs-dist/pom.xml 
> 624fccc2759737e128014620e6a6c38636fcacd2 
>   sentry-hdfs/sentry-hdfs-namenode-plugin/pom.xml 
> f728b26e15583a789f7b6b27051cb57ae0c20933 
>   sentry-hdfs/sentry-hdfs-service/pom.xml 
> 158e837f92d81fc63e2438163a4b85eca351c926 
>   sentry-policy/pom.xml d56c836399fa147bbb048fe5dfb3e750c1b6acab 
>   sentry-policy/sentry-policy-common/pom.xml 
> 065cddeea6669453af8575eed9693866bd28b0ae 
>   sentry-policy/sentry-policy-engine/pom.xml 
> c97347790ddb70c5a75aa5d6efb972d7c830f117 
>   sentry-policy/sentry-policy-indexer/pom.xml 
> b25a0cc0d2cf8d1cf25880d1cff23cccf4ec78cf 
>   sentry-provider/pom.xml 6ce30f5b0fe3edd5d2eb33932e538a82519bebf9 
>   sentry-provider/sentry-provider-cache/pom.xml 
> dedd89444ddeea3782c2ab3eb4362ae8bebe508f 
>   sentry-provider/sentry-provider-common/pom.xml 
> 4536deab9dffee99cf4e420d13bc2ab10ce3d052 
>   sentry-provider/sentry-provider-db/pom.xml 
> 679868a689aa1bdf602a58505d53a57a9eacc953 
>   sentry-provider/sentry-provider-file/pom.xml 
> 586ab5f700c20e8445ee9c64474568674988dbb8 
>   sentry-solr/pom.xml 8060575d882926beabdc948a7e8b3ba8ebafeb81 
>   sentry-solr/solr-sentry-handlers/pom.xml 
> 7045c48a17d573eab779d6443a59b46cd16eacb8 
>   sentry-tests/pom.xml a82f2adb6b03a82a9198e0a7d36df92a9916d965 
>   sentry-tests/sentry-tests-hive-v2/pom.xml 
> ecb9dc75a4f5aa764026a7840ca05395feec1ba1 
>   sentry-tests/sentry-tests-hive/pom.xml 
> 64ab1e214e4aaac6c7d4f50d883ba7dfc71f2e2d 
>   sentry-tests/sentry-tests-kafka/pom.xml 
> 4b89a59162998a5fdbb2348adba90ec24ce752f3 
>   sentry-tests/sentry-tests-solr/pom.xml 
> 01f5c6c2992cdd03df3fac5aa7836f116b03469b 
>   sentry-tests/sentry-tests-sqoop/pom.xml 
> 2d425a42da38395366fbbd8a2762bdbfa01d32d8 
>   sentry-tools/pom.xml 64508fd35d716f3fb9b8ccb1e7bafccdd4a429e6 
> 
> 
> Diff: https://reviews.apache.org/r/68456/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>