Re: Review Request 68721: SENTRY-2388: Preparing for 2.2.0-SNAPSHOT release

2018-09-14 Thread kalyan kumar kalvagadda via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68721/#review208641
---


Ship it!




Ship It!

- kalyan kumar kalvagadda


On Sept. 14, 2018, 7:14 p.m., Na Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68721/
> ---
> 
> (Updated Sept. 14, 2018, 7:14 p.m.)
> 
> 
> Review request for sentry, Curtis Sumner Sean Lee, kalyan kumar kalvagadda, 
> and Sergio Pena.
> 
> 
> Bugs: sentry-2388
> https://issues.apache.org/jira/browse/sentry-2388
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> change the version from "2.1.0-SNAPSHOT" to "2.2.0-SNAPSHOT"
> 
> 
> Diffs
> -
> 
>   pom.xml 984e15a 
>   sentry-binding/pom.xml fd5e28b 
>   sentry-binding/sentry-binding-hbase-indexer/pom.xml d50acfe 
>   sentry-binding/sentry-binding-hive-common/pom.xml e154cde 
>   sentry-binding/sentry-binding-hive-conf/pom.xml 3e7e70a 
>   sentry-binding/sentry-binding-hive-follower/pom.xml 5f8a5af 
>   sentry-binding/sentry-binding-hive/pom.xml 09d75f7 
>   sentry-binding/sentry-binding-kafka/pom.xml e4fdddf 
>   sentry-binding/sentry-binding-solr/pom.xml f086699 
>   sentry-binding/sentry-binding-sqoop/pom.xml 82cd4a6 
>   sentry-core/pom.xml 173d203 
>   sentry-core/sentry-core-common/pom.xml 75ce574 
>   sentry-core/sentry-core-model-db/pom.xml 30519aa 
>   sentry-core/sentry-core-model-indexer/pom.xml f65e49a 
>   sentry-core/sentry-core-model-kafka/pom.xml cfe9221 
>   sentry-core/sentry-core-model-solr/pom.xml 95ea02b 
>   sentry-core/sentry-core-model-sqoop/pom.xml 5629028 
>   sentry-dist/pom.xml b892536 
>   sentry-hdfs/pom.xml a015e11 
>   sentry-hdfs/sentry-hdfs-common/pom.xml 2bfb76d 
>   sentry-hdfs/sentry-hdfs-dist/pom.xml 1e04bf2 
>   sentry-hdfs/sentry-hdfs-namenode-plugin/pom.xml e1bd8c3 
>   sentry-hdfs/sentry-hdfs-service/pom.xml 888f61e 
>   sentry-policy/pom.xml 1124829 
>   sentry-policy/sentry-policy-common/pom.xml 902f3e6 
>   sentry-policy/sentry-policy-engine/pom.xml 5bdd10b 
>   sentry-provider/pom.xml b075f49 
>   sentry-provider/sentry-provider-cache/pom.xml e278878 
>   sentry-provider/sentry-provider-common/pom.xml f269873 
>   sentry-provider/sentry-provider-db/pom.xml ab586f7 
>   sentry-provider/sentry-provider-file/pom.xml 6623ffe 
>   sentry-service/pom.xml b63467b 
>   sentry-service/sentry-service-api/pom.xml be95976 
>   sentry-service/sentry-service-client/pom.xml a1ae8c8 
>   sentry-service/sentry-service-server/pom.xml 4919183 
>   sentry-solr/pom.xml df8c397 
>   sentry-solr/solr-sentry-handlers/pom.xml accd581 
>   sentry-spi/pom.xml f9dbc7f 
>   sentry-tests/pom.xml e17f2a8 
>   sentry-tests/sentry-tests-hive/pom.xml 388023c 
>   sentry-tests/sentry-tests-kafka/pom.xml 03bc574 
>   sentry-tests/sentry-tests-solr/pom.xml cc0969a 
>   sentry-tests/sentry-tests-sqoop/pom.xml 13f8eed 
>   sentry-thirdparty/pom.xml bfb5fa9 
>   sentry-thirdparty/sentry-shaded/pom.xml beb89b0 
>   sentry-tools/pom.xml 05cd75c 
> 
> 
> Diff: https://reviews.apache.org/r/68721/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Na Li
> 
>

Re: Review Request 68721: SENTRY-2388: Preparing for 2.2.0-SNAPSHOT release

2018-09-14 Thread kalyan kumar kalvagadda via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68721/#review208642
---


Ship it!




Ship It!

- kalyan kumar kalvagadda


On Sept. 14, 2018, 7:14 p.m., Na Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68721/
> ---
> 
> (Updated Sept. 14, 2018, 7:14 p.m.)
> 
> 
> Review request for sentry, Curtis Sumner Sean Lee, kalyan kumar kalvagadda, 
> and Sergio Pena.
> 
> 
> Bugs: sentry-2388
> https://issues.apache.org/jira/browse/sentry-2388
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> change the version from "2.1.0-SNAPSHOT" to "2.2.0-SNAPSHOT"
> 
> 
> Diffs
> -
> 
>   pom.xml 984e15a 
>   sentry-binding/pom.xml fd5e28b 
>   sentry-binding/sentry-binding-hbase-indexer/pom.xml d50acfe 
>   sentry-binding/sentry-binding-hive-common/pom.xml e154cde 
>   sentry-binding/sentry-binding-hive-conf/pom.xml 3e7e70a 
>   sentry-binding/sentry-binding-hive-follower/pom.xml 5f8a5af 
>   sentry-binding/sentry-binding-hive/pom.xml 09d75f7 
>   sentry-binding/sentry-binding-kafka/pom.xml e4fdddf 
>   sentry-binding/sentry-binding-solr/pom.xml f086699 
>   sentry-binding/sentry-binding-sqoop/pom.xml 82cd4a6 
>   sentry-core/pom.xml 173d203 
>   sentry-core/sentry-core-common/pom.xml 75ce574 
>   sentry-core/sentry-core-model-db/pom.xml 30519aa 
>   sentry-core/sentry-core-model-indexer/pom.xml f65e49a 
>   sentry-core/sentry-core-model-kafka/pom.xml cfe9221 
>   sentry-core/sentry-core-model-solr/pom.xml 95ea02b 
>   sentry-core/sentry-core-model-sqoop/pom.xml 5629028 
>   sentry-dist/pom.xml b892536 
>   sentry-hdfs/pom.xml a015e11 
>   sentry-hdfs/sentry-hdfs-common/pom.xml 2bfb76d 
>   sentry-hdfs/sentry-hdfs-dist/pom.xml 1e04bf2 
>   sentry-hdfs/sentry-hdfs-namenode-plugin/pom.xml e1bd8c3 
>   sentry-hdfs/sentry-hdfs-service/pom.xml 888f61e 
>   sentry-policy/pom.xml 1124829 
>   sentry-policy/sentry-policy-common/pom.xml 902f3e6 
>   sentry-policy/sentry-policy-engine/pom.xml 5bdd10b 
>   sentry-provider/pom.xml b075f49 
>   sentry-provider/sentry-provider-cache/pom.xml e278878 
>   sentry-provider/sentry-provider-common/pom.xml f269873 
>   sentry-provider/sentry-provider-db/pom.xml ab586f7 
>   sentry-provider/sentry-provider-file/pom.xml 6623ffe 
>   sentry-service/pom.xml b63467b 
>   sentry-service/sentry-service-api/pom.xml be95976 
>   sentry-service/sentry-service-client/pom.xml a1ae8c8 
>   sentry-service/sentry-service-server/pom.xml 4919183 
>   sentry-solr/pom.xml df8c397 
>   sentry-solr/solr-sentry-handlers/pom.xml accd581 
>   sentry-spi/pom.xml f9dbc7f 
>   sentry-tests/pom.xml e17f2a8 
>   sentry-tests/sentry-tests-hive/pom.xml 388023c 
>   sentry-tests/sentry-tests-kafka/pom.xml 03bc574 
>   sentry-tests/sentry-tests-solr/pom.xml cc0969a 
>   sentry-tests/sentry-tests-sqoop/pom.xml 13f8eed 
>   sentry-thirdparty/pom.xml bfb5fa9 
>   sentry-thirdparty/sentry-shaded/pom.xml beb89b0 
>   sentry-tools/pom.xml 05cd75c 
> 
> 
> Diff: https://reviews.apache.org/r/68721/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Na Li
> 
>

Re: Review Request 68721: SENTRY-2388: Preparing for 2.2.0-SNAPSHOT release

2018-09-14 Thread Na Li via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68721/
---

(Updated Sept. 14, 2018, 7:14 p.m.)


Review request for sentry, Curtis Sumner Sean Lee, kalyan kumar kalvagadda, and 
Sergio Pena.


Summary (updated)
-

SENTRY-2388: Preparing for 2.2.0-SNAPSHOT release


Bugs: sentry-2388
https://issues.apache.org/jira/browse/sentry-2388


Repository: sentry


Description
---

change the version from "2.1.0-SNAPSHOT" to "2.2.0-SNAPSHOT"


Diffs
-

  pom.xml 984e15a 
  sentry-binding/pom.xml fd5e28b 
  sentry-binding/sentry-binding-hbase-indexer/pom.xml d50acfe 
  sentry-binding/sentry-binding-hive-common/pom.xml e154cde 
  sentry-binding/sentry-binding-hive-conf/pom.xml 3e7e70a 
  sentry-binding/sentry-binding-hive-follower/pom.xml 5f8a5af 
  sentry-binding/sentry-binding-hive/pom.xml 09d75f7 
  sentry-binding/sentry-binding-kafka/pom.xml e4fdddf 
  sentry-binding/sentry-binding-solr/pom.xml f086699 
  sentry-binding/sentry-binding-sqoop/pom.xml 82cd4a6 
  sentry-core/pom.xml 173d203 
  sentry-core/sentry-core-common/pom.xml 75ce574 
  sentry-core/sentry-core-model-db/pom.xml 30519aa 
  sentry-core/sentry-core-model-indexer/pom.xml f65e49a 
  sentry-core/sentry-core-model-kafka/pom.xml cfe9221 
  sentry-core/sentry-core-model-solr/pom.xml 95ea02b 
  sentry-core/sentry-core-model-sqoop/pom.xml 5629028 
  sentry-dist/pom.xml b892536 
  sentry-hdfs/pom.xml a015e11 
  sentry-hdfs/sentry-hdfs-common/pom.xml 2bfb76d 
  sentry-hdfs/sentry-hdfs-dist/pom.xml 1e04bf2 
  sentry-hdfs/sentry-hdfs-namenode-plugin/pom.xml e1bd8c3 
  sentry-hdfs/sentry-hdfs-service/pom.xml 888f61e 
  sentry-policy/pom.xml 1124829 
  sentry-policy/sentry-policy-common/pom.xml 902f3e6 
  sentry-policy/sentry-policy-engine/pom.xml 5bdd10b 
  sentry-provider/pom.xml b075f49 
  sentry-provider/sentry-provider-cache/pom.xml e278878 
  sentry-provider/sentry-provider-common/pom.xml f269873 
  sentry-provider/sentry-provider-db/pom.xml ab586f7 
  sentry-provider/sentry-provider-file/pom.xml 6623ffe 
  sentry-service/pom.xml b63467b 
  sentry-service/sentry-service-api/pom.xml be95976 
  sentry-service/sentry-service-client/pom.xml a1ae8c8 
  sentry-service/sentry-service-server/pom.xml 4919183 
  sentry-solr/pom.xml df8c397 
  sentry-solr/solr-sentry-handlers/pom.xml accd581 
  sentry-spi/pom.xml f9dbc7f 
  sentry-tests/pom.xml e17f2a8 
  sentry-tests/sentry-tests-hive/pom.xml 388023c 
  sentry-tests/sentry-tests-kafka/pom.xml 03bc574 
  sentry-tests/sentry-tests-solr/pom.xml cc0969a 
  sentry-tests/sentry-tests-sqoop/pom.xml 13f8eed 
  sentry-thirdparty/pom.xml bfb5fa9 
  sentry-thirdparty/sentry-shaded/pom.xml beb89b0 
  sentry-tools/pom.xml 05cd75c 


Diff: https://reviews.apache.org/r/68721/diff/1/


Testing
---


Thanks,

Na Li

Re: Review Request 68721: SENTRY-2388: Update the pom file in master branch after release 2.1.0

2018-09-14 Thread Sergio Pena via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68721/#review208635
---


Ship it!




Looks good, can you just update the title to be 'Preparing for 2.2.0-SNAPSHOT 
release'

- Sergio Pena


On Sept. 14, 2018, 6:56 p.m., Na Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68721/
> ---
> 
> (Updated Sept. 14, 2018, 6:56 p.m.)
> 
> 
> Review request for sentry, Curtis Sumner Sean Lee, kalyan kumar kalvagadda, 
> and Sergio Pena.
> 
> 
> Bugs: sentry-2388
> https://issues.apache.org/jira/browse/sentry-2388
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> change the version from "2.1.0-SNAPSHOT" to "2.2.0-SNAPSHOT"
> 
> 
> Diffs
> -
> 
>   pom.xml 984e15a 
>   sentry-binding/pom.xml fd5e28b 
>   sentry-binding/sentry-binding-hbase-indexer/pom.xml d50acfe 
>   sentry-binding/sentry-binding-hive-common/pom.xml e154cde 
>   sentry-binding/sentry-binding-hive-conf/pom.xml 3e7e70a 
>   sentry-binding/sentry-binding-hive-follower/pom.xml 5f8a5af 
>   sentry-binding/sentry-binding-hive/pom.xml 09d75f7 
>   sentry-binding/sentry-binding-kafka/pom.xml e4fdddf 
>   sentry-binding/sentry-binding-solr/pom.xml f086699 
>   sentry-binding/sentry-binding-sqoop/pom.xml 82cd4a6 
>   sentry-core/pom.xml 173d203 
>   sentry-core/sentry-core-common/pom.xml 75ce574 
>   sentry-core/sentry-core-model-db/pom.xml 30519aa 
>   sentry-core/sentry-core-model-indexer/pom.xml f65e49a 
>   sentry-core/sentry-core-model-kafka/pom.xml cfe9221 
>   sentry-core/sentry-core-model-solr/pom.xml 95ea02b 
>   sentry-core/sentry-core-model-sqoop/pom.xml 5629028 
>   sentry-dist/pom.xml b892536 
>   sentry-hdfs/pom.xml a015e11 
>   sentry-hdfs/sentry-hdfs-common/pom.xml 2bfb76d 
>   sentry-hdfs/sentry-hdfs-dist/pom.xml 1e04bf2 
>   sentry-hdfs/sentry-hdfs-namenode-plugin/pom.xml e1bd8c3 
>   sentry-hdfs/sentry-hdfs-service/pom.xml 888f61e 
>   sentry-policy/pom.xml 1124829 
>   sentry-policy/sentry-policy-common/pom.xml 902f3e6 
>   sentry-policy/sentry-policy-engine/pom.xml 5bdd10b 
>   sentry-provider/pom.xml b075f49 
>   sentry-provider/sentry-provider-cache/pom.xml e278878 
>   sentry-provider/sentry-provider-common/pom.xml f269873 
>   sentry-provider/sentry-provider-db/pom.xml ab586f7 
>   sentry-provider/sentry-provider-file/pom.xml 6623ffe 
>   sentry-service/pom.xml b63467b 
>   sentry-service/sentry-service-api/pom.xml be95976 
>   sentry-service/sentry-service-client/pom.xml a1ae8c8 
>   sentry-service/sentry-service-server/pom.xml 4919183 
>   sentry-solr/pom.xml df8c397 
>   sentry-solr/solr-sentry-handlers/pom.xml accd581 
>   sentry-spi/pom.xml f9dbc7f 
>   sentry-tests/pom.xml e17f2a8 
>   sentry-tests/sentry-tests-hive/pom.xml 388023c 
>   sentry-tests/sentry-tests-kafka/pom.xml 03bc574 
>   sentry-tests/sentry-tests-solr/pom.xml cc0969a 
>   sentry-tests/sentry-tests-sqoop/pom.xml 13f8eed 
>   sentry-thirdparty/pom.xml bfb5fa9 
>   sentry-thirdparty/sentry-shaded/pom.xml beb89b0 
>   sentry-tools/pom.xml 05cd75c 
> 
> 
> Diff: https://reviews.apache.org/r/68721/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Na Li
> 
>

Review Request 68721: SENTRY-2388: Update the pom file in master branch after release 2.1.0

2018-09-14 Thread Na Li via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68721/
---

Review request for sentry, Curtis Sumner Sean Lee, kalyan kumar kalvagadda, and 
Sergio Pena.


Bugs: sentry-2388
https://issues.apache.org/jira/browse/sentry-2388


Repository: sentry


Description
---

change the version from "2.1.0-SNAPSHOT" to "2.2.0-SNAPSHOT"


Diffs
-

  pom.xml 984e15a 
  sentry-binding/pom.xml fd5e28b 
  sentry-binding/sentry-binding-hbase-indexer/pom.xml d50acfe 
  sentry-binding/sentry-binding-hive-common/pom.xml e154cde 
  sentry-binding/sentry-binding-hive-conf/pom.xml 3e7e70a 
  sentry-binding/sentry-binding-hive-follower/pom.xml 5f8a5af 
  sentry-binding/sentry-binding-hive/pom.xml 09d75f7 
  sentry-binding/sentry-binding-kafka/pom.xml e4fdddf 
  sentry-binding/sentry-binding-solr/pom.xml f086699 
  sentry-binding/sentry-binding-sqoop/pom.xml 82cd4a6 
  sentry-core/pom.xml 173d203 
  sentry-core/sentry-core-common/pom.xml 75ce574 
  sentry-core/sentry-core-model-db/pom.xml 30519aa 
  sentry-core/sentry-core-model-indexer/pom.xml f65e49a 
  sentry-core/sentry-core-model-kafka/pom.xml cfe9221 
  sentry-core/sentry-core-model-solr/pom.xml 95ea02b 
  sentry-core/sentry-core-model-sqoop/pom.xml 5629028 
  sentry-dist/pom.xml b892536 
  sentry-hdfs/pom.xml a015e11 
  sentry-hdfs/sentry-hdfs-common/pom.xml 2bfb76d 
  sentry-hdfs/sentry-hdfs-dist/pom.xml 1e04bf2 
  sentry-hdfs/sentry-hdfs-namenode-plugin/pom.xml e1bd8c3 
  sentry-hdfs/sentry-hdfs-service/pom.xml 888f61e 
  sentry-policy/pom.xml 1124829 
  sentry-policy/sentry-policy-common/pom.xml 902f3e6 
  sentry-policy/sentry-policy-engine/pom.xml 5bdd10b 
  sentry-provider/pom.xml b075f49 
  sentry-provider/sentry-provider-cache/pom.xml e278878 
  sentry-provider/sentry-provider-common/pom.xml f269873 
  sentry-provider/sentry-provider-db/pom.xml ab586f7 
  sentry-provider/sentry-provider-file/pom.xml 6623ffe 
  sentry-service/pom.xml b63467b 
  sentry-service/sentry-service-api/pom.xml be95976 
  sentry-service/sentry-service-client/pom.xml a1ae8c8 
  sentry-service/sentry-service-server/pom.xml 4919183 
  sentry-solr/pom.xml df8c397 
  sentry-solr/solr-sentry-handlers/pom.xml accd581 
  sentry-spi/pom.xml f9dbc7f 
  sentry-tests/pom.xml e17f2a8 
  sentry-tests/sentry-tests-hive/pom.xml 388023c 
  sentry-tests/sentry-tests-kafka/pom.xml 03bc574 
  sentry-tests/sentry-tests-solr/pom.xml cc0969a 
  sentry-tests/sentry-tests-sqoop/pom.xml 13f8eed 
  sentry-thirdparty/pom.xml bfb5fa9 
  sentry-thirdparty/sentry-shaded/pom.xml beb89b0 
  sentry-tools/pom.xml 05cd75c 


Diff: https://reviews.apache.org/r/68721/diff/1/


Testing
---


Thanks,

Na Li

Re: Work on Sentry 2.1.0 release

2018-09-14 Thread Sergio Pena 
Thanks Lina

On Fri, Sep 14, 2018 at 12:14 PM Na Li  wrote:

> Hi,
>
> Branch-2.1.0 is available at
> https://github.com/apache/sentry/commits/branch-2.1.0. You can commit
> changes to  https://github.com/apache/sentry now.
>
> Thanks,
>
> Lina
>
> On Thu, Sep 13, 2018 at 1:55 PM, Na Li  wrote:
>
> > Hi,
> >
> > I am  about to branch 2.1.0. Please hold off any commits until this is
> > finished. Another email will be sent out once branching is done.
> >
> > Thanks,
> >
> > Lina
> >
> > On Tue, Sep 4, 2018 at 1:55 PM, Na Li  wrote:
> >
> >> Hi,
> >>
> >> I created a tracking jira SENTRY-2377
> >>  for the Sentry
> >> release 2.1.0 and plan to branch on September 11, 2018.
> >>
> >> It will include all patches in Sentry master branch up to September 10,
> >> 2018.
> >>
> >> Is there jira you would like to see included that is not resolved yet?
> >>
> >> Thanks,
> >>
> >> Lina
> >>
> >
> >
>

New sentry release branch-2.1.0

2018-09-14 Thread Na Li 
HI,


I've just created new release branch for upcoming branch-2.1.0 release.
Please continue committing to master branch as usual.
I'll cherry-pick commits to branch-2.1.0 on per needed basis.


Thanks,


Lina

Re: Work on Sentry 2.1.0 release

2018-09-14 Thread Na Li 
Hi,

Branch-2.1.0 is available at
https://github.com/apache/sentry/commits/branch-2.1.0. You can commit
changes to  https://github.com/apache/sentry now.

Thanks,

Lina

On Thu, Sep 13, 2018 at 1:55 PM, Na Li  wrote:

> Hi,
>
> I am  about to branch 2.1.0. Please hold off any commits until this is
> finished. Another email will be sent out once branching is done.
>
> Thanks,
>
> Lina
>
> On Tue, Sep 4, 2018 at 1:55 PM, Na Li  wrote:
>
>> Hi,
>>
>> I created a tracking jira SENTRY-2377
>>  for the Sentry
>> release 2.1.0 and plan to branch on September 11, 2018.
>>
>> It will include all patches in Sentry master branch up to September 10,
>> 2018.
>>
>> Is there jira you would like to see included that is not resolved yet?
>>
>> Thanks,
>>
>> Lina
>>
>
>

Review Request 68716: SENTRY-2403: Incorrect naming in RollingFileWithoutDeleteAppender

2018-09-14 Thread Peter Somogyi via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68716/
---

Review request for sentry.


Bugs: SENTRY-2403
https://issues.apache.org/jira/browse/SENTRY-2403


Repository: sentry


Description
---

RollingFileWithoutDeleteAppender incorrectly append timestamp to logfiles 
without removing previous one.


Diffs
-

  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java
 fd133f34f 
  
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/log/appender/TestRollingFileWithoutDeleteAppender.java
 ca9062bca 


Diff: https://reviews.apache.org/r/68716/diff/1/


Testing
---

Modified TestRollingFileWithoutDeleteAppender to check the pattern correctly.


Thanks,

Peter Somogyi