Re: Review Request 68547: SENTRY-2370: Create a cache of PathUpdates to send to NN

2018-10-02 Thread Arjun Mishra via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68547/
---

(Updated Oct. 2, 2018, 9:57 p.m.)


Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.


Bugs: SENTRY-2370
https://issues.apache.org/jira/browse/SENTRY-2370


Repository: sentry


Description
---

When NN requests path updates from sentry and if it exceeds the time threshold, 
on consecutive attempts sentry will attempt to fetch the full update from 
scratch. Instead it should cache it and update the cache before sending it to NN


Diffs (updated)
-

  
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/ImageRetriever.java
 11b75411d 
  
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java
 08b16a4df 
  
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java
 3532ef33d 
  
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermImageRetriever.java
 443434127 
  
sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDBUpdateForwarder.java
 f86ce6f83 
  
sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestImageRetriever.java
 fb42b279a 


Diff: https://reviews.apache.org/r/68547/diff/9/

Changes: https://reviews.apache.org/r/68547/diff/8-9/


Testing
---


Thanks,

Arjun Mishra



Re: Review Request 68547: SENTRY-2370: Create a cache of PathUpdates to send to NN

2018-10-02 Thread Arjun Mishra via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68547/
---

(Updated Oct. 2, 2018, 9:47 p.m.)


Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena.


Changes
---

Post Sergio's feedback


Bugs: SENTRY-2370
https://issues.apache.org/jira/browse/SENTRY-2370


Repository: sentry


Description
---

When NN requests path updates from sentry and if it exceeds the time threshold, 
on consecutive attempts sentry will attempt to fetch the full update from 
scratch. Instead it should cache it and update the cache before sending it to NN


Diffs (updated)
-

  
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/ImageRetriever.java
 11b75411d 
  
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java
 08b16a4df 
  
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java
 3532ef33d 
  
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermImageRetriever.java
 443434127 
  
sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDBUpdateForwarder.java
 f86ce6f83 
  
sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestImageRetriever.java
 fb42b279a 


Diff: https://reviews.apache.org/r/68547/diff/8/

Changes: https://reviews.apache.org/r/68547/diff/7-8/


Testing
---


Thanks,

Arjun Mishra



Re: Review Request 68890: SENTRY-2300: Move Permission Update due to DDL to HMS Post Event Listener

2018-10-02 Thread Na Li via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68890/
---

(Updated Oct. 2, 2018, 9:26 p.m.)


Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio 
Pena.


Bugs: sentry-2300
https://issues.apache.org/jira/browse/sentry-2300


Repository: sentry


Description
---

Move the privilege updates from Notification event processing at 
NotificationProcessor to HMS post event processing at SentryPolicyStoreProcessor


Diffs (updated)
-

  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryHmsEvent.java
 e0f35e8 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentrySyncHMSNotificationsPostEventListener.java
 c37f370 
  
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/metastore/TestSentrySyncHMSNotificationsPostEventListener.java
 98de8e3 
  
sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegePrincipalType.java
 6eb8521 
  
sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryHmsEventNotification.java
 7cdf148 
  
sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java
 5fc299b 
  
sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java
 68d864c 
  
sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift
 3364648 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
 709434c 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java
 7b7d0e1 
  
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java
 059621a 
  
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollower.java
 0d62941 
  
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java
 a886836 
  
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestNotificationProcessor.java
 f227bb4 


Diff: https://reviews.apache.org/r/68890/diff/2/

Changes: https://reviews.apache.org/r/68890/diff/1-2/


Testing
---

Add new test cases in TestSentryPolicyStoreProcessor, and update tests in 
TestHMSFollower and TestNotificationProcessor. Tests in 
TestSentryPolicyStoreProcessor, TestHMSFollower and TestNotificationProcessor 
passed.


Thanks,

Na Li



Sentry-jdk-1.8 - Build # 169 - Fixed

2018-10-02 Thread Apache Jenkins Server
The Apache Jenkins build system has built Sentry-jdk-1.8 (build #169)

Status: Fixed

Check console output at https://builds.apache.org/job/Sentry-jdk-1.8/169/ to 
view the results.

Re: [ANNOUNCE] Apache Sentry 2.1.0 released

2018-10-02 Thread Sergio Pena
Wooo!, Thanks Lina

On Tue, Oct 2, 2018 at 11:01 AM Alexander Kolbasov
 wrote:

> Fantastic! Thank you Lina for doing the release!
>
> > On Oct 2, 2018, at 08:57, Na Li  wrote:
> >
> > The Apache Sentry team is happy to announce the release of version 2.1.0.
> > Apache Sentry is a system to enforce fine grained role based
> authorization
> > to data and metadata stored on a Hadoop cluster.
> >
> > The release bits are available at:
> > http://sentry.apache.org/general/downloads.html
> >
> > Sentry 2.0.1 Release Notes are available here:
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314720=12342213
> >
> >
> > We would like to thank all contributors who made the release possible.
> >
> > Regards,
> > Sentry team
>


Re: [ANNOUNCE] Apache Sentry 2.1.0 released

2018-10-02 Thread Alexander Kolbasov
Fantastic! Thank you Lina for doing the release!

> On Oct 2, 2018, at 08:57, Na Li  wrote:
> 
> The Apache Sentry team is happy to announce the release of version 2.1.0.
> Apache Sentry is a system to enforce fine grained role based authorization
> to data and metadata stored on a Hadoop cluster.
> 
> The release bits are available at:
> http://sentry.apache.org/general/downloads.html
> 
> Sentry 2.0.1 Release Notes are available here:
> 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314720=12342213
> 
> 
> We would like to thank all contributors who made the release possible.
> 
> Regards,
> Sentry team


[ANNOUNCE] Apache Sentry 2.1.0 released

2018-10-02 Thread Na Li
The Apache Sentry team is happy to announce the release of version 2.1.0.
Apache Sentry is a system to enforce fine grained role based authorization
to data and metadata stored on a Hadoop cluster.

The release bits are available at:
http://sentry.apache.org/general/downloads.html

Sentry 2.0.1 Release Notes are available here:

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314720=12342213


We would like to thank all contributors who made the release possible.

Regards,
Sentry team


Re: Review Request 68779: SENTRY-2409: ALTER TABLE SET OWNER does not allow to change the table if using only the table name

2018-10-02 Thread Sergio Pena via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68779/#review209149
---


Ship it!




Ship It!

- Sergio Pena


On Oct. 1, 2018, 9:23 p.m., Na Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68779/
> ---
> 
> (Updated Oct. 1, 2018, 9:23 p.m.)
> 
> 
> Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio 
> Pena.
> 
> 
> Bugs: sentry-2409
> https://issues.apache.org/jira/browse/sentry-2409
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> add code to get table name and DB name based on token children size
> 
> 
> Diffs
> -
> 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java
>  6731d1a 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java
>  385ca98 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java
>  55a79ee 
> 
> 
> Diff: https://reviews.apache.org/r/68779/diff/2/
> 
> 
> Testing
> ---
> 
> unit tests in TestOwnerPrivileges passed
> 
> 
> Thanks,
> 
> Na Li
> 
>