Re: Review Request 69260: SENTRY-2441: When MAuthzPathsMapping is deleted all associated MPaths should be deleted automatically.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69260/#review210356 --- Ship it! Ship It! - Arjun Mishra On Nov. 6, 2018, 6:08 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69260/ > --- > > (Updated Nov. 6, 2018, 6:08 p.m.) > > > Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2441 > https://issues.apache.org/jira/browse/SENTRY-2441 > > > Repository: sentry > > > Description > --- > > When MAuthzPathsMapping is deleted all associated MPaths should be deleted > automatically as MPaths are directly associated to MAuthzPathsMapping. > > > > Currently when entries in MAuthzPathsMapping are deleted the FK in MPaths is > set to NULL and the entries are left. These elements are slate are not not > used and will never be cleaned. > > > > > > Instead MPaths should be removed automatically associated MAuthzPathsMapping > entries are deleted. > > > Diffs > - > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 20ec0deab6b97065cfe99beea3d14a6c7268aac3 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 33c40613a05f7c7fde314af6aba6b269bf6ffaae > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 66db6ae9a436b9728fb3c2ebdd21167ef042f937 > > > Diff: https://reviews.apache.org/r/69260/diff/2/ > > > Testing > --- > > Made sure that all the existing tests pass. > > > Thanks, > > kalyan kumar kalvagadda > >
Re: Review Request 69260: SENTRY-2441: When MAuthzPathsMapping is deleted all associated MPaths should be deleted automatically.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69260/ --- (Updated Nov. 6, 2018, 6:08 p.m.) Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. Changes --- Added unit test case Bugs: SENTRY-2441 https://issues.apache.org/jira/browse/SENTRY-2441 Repository: sentry Description --- When MAuthzPathsMapping is deleted all associated MPaths should be deleted automatically as MPaths are directly associated to MAuthzPathsMapping. Currently when entries in MAuthzPathsMapping are deleted the FK in MPaths is set to NULL and the entries are left. These elements are slate are not not used and will never be cleaned. Instead MPaths should be removed automatically associated MAuthzPathsMapping entries are deleted. Diffs (updated) - sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 20ec0deab6b97065cfe99beea3d14a6c7268aac3 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 33c40613a05f7c7fde314af6aba6b269bf6ffaae sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 66db6ae9a436b9728fb3c2ebdd21167ef042f937 Diff: https://reviews.apache.org/r/69260/diff/2/ Changes: https://reviews.apache.org/r/69260/diff/1-2/ Testing --- Made sure that all the existing tests pass. Thanks, kalyan kumar kalvagadda
Re: Review Request 69260: SENTRY-2441: When MAuthzPathsMapping is deleted all associated MPaths should be deleted automatically.
> On Nov. 6, 2018, 5:11 p.m., Na Li wrote: > > Can you add code in unit test to verify the path is removed? For example, > > there is no MPath entries whose foreign key is null or the delected > > authorizable entry ID. +1 - Arjun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69260/#review210353 --- On Nov. 6, 2018, 4:59 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69260/ > --- > > (Updated Nov. 6, 2018, 4:59 p.m.) > > > Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2441 > https://issues.apache.org/jira/browse/SENTRY-2441 > > > Repository: sentry > > > Description > --- > > When MAuthzPathsMapping is deleted all associated MPaths should be deleted > automatically as MPaths are directly associated to MAuthzPathsMapping. > > > > Currently when entries in MAuthzPathsMapping are deleted the FK in MPaths is > set to NULL and the entries are left. These elements are slate are not not > used and will never be cleaned. > > > > > > Instead MPaths should be removed automatically associated MAuthzPathsMapping > entries are deleted. > > > Diffs > - > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 20ec0deab6b97065cfe99beea3d14a6c7268aac3 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 33c40613a05f7c7fde314af6aba6b269bf6ffaae > > > Diff: https://reviews.apache.org/r/69260/diff/1/ > > > Testing > --- > > Made sure that all the existing tests pass. > > > Thanks, > > kalyan kumar kalvagadda > >
Review Request 69260: SENTRY-2441: When MAuthzPathsMapping is deleted all associated MPaths should be deleted automatically.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69260/ --- Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. Bugs: SENTRY-2441 https://issues.apache.org/jira/browse/SENTRY-2441 Repository: sentry Description --- When MAuthzPathsMapping is deleted all associated MPaths should be deleted automatically as MPaths are directly associated to MAuthzPathsMapping. Currently when entries in MAuthzPathsMapping are deleted the FK in MPaths is set to NULL and the entries are left. These elements are slate are not not used and will never be cleaned. Instead MPaths should be removed automatically associated MAuthzPathsMapping entries are deleted. Diffs - sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 20ec0deab6b97065cfe99beea3d14a6c7268aac3 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 33c40613a05f7c7fde314af6aba6b269bf6ffaae Diff: https://reviews.apache.org/r/69260/diff/1/ Testing --- Made sure that all the existing tests pass. Thanks, kalyan kumar kalvagadda
