Review Request 69353: SENTRY-2454: Add new sentrys tore api to gather the privileges for a list of authorizables.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69353/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2454 https://issues.apache.org/jira/browse/SENTRY-2454 Repository: sentry Description --- New sentry API should be implemented to fetch the privileges granted to authorizables and it's children. authorizables include database, tables, columns and URI's. Diffs - sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java e2d6c85ac6b285e286c12f7eec669b841cf76e9d sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java e48eea377b842475f72b6fab4567a82c8fd93098 sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java ca8c41610d3dcd12b267579c3d3cbe5b7ba7b208 Diff: https://reviews.apache.org/r/69353/diff/1/ Testing --- Added new unit tests to test the API added. Thanks, kalyan kumar kalvagadda
Review Request 69352: SENTRY-2452: Change the thrift interface to send the list of authorizable to sentry server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69352/ --- Review request for sentry and Sergio Pena. Bugs: SENTRY-2452 https://issues.apache.org/jira/browse/SENTRY-2452 Repository: sentry Description --- TSentryExportMappingDataRequest and TSentryImportMappingDataRequest which are used to send export and import requests to sentry server should be changed to be able to send a list authorizables for which permission information has to be exported/imported. These requests should accommodate source and target cluster information as well. Diffs - sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SentryConstants.java d8c1061d36ed0b92116f0b2dd5ec820ccb166818 sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryExportMappingDataRequest.java 13e57e04dd779825e2986b1e527f4e556271a162 sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryImportMappingDataRequest.java 21f3bdf5e304fe2f49684c999d0aa0e0362320de sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryPrivilegesResponse.java cea868f0524c25bf63cfb7c532829354a280df28 sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/common/SentryServiceUtil.java 83393a98df5e10b324f74dc12f10c20bc5f02651 sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java 68d864cfbdf18057d87a65a04af8991292aadccf sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift 3364648dc88acbb8de1cc925fe8c512f34a4b064 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java b9e3bf2921a0696da639e1b1bee5d83cf2b9cee0 sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceImportExport.java cf1fdab382034c8950da2613ef9b0cf1af912e33 Diff: https://reviews.apache.org/r/69352/diff/1/ Testing --- Made sure that existiung tests pass. Thanks, kalyan kumar kalvagadda
Re: Review Request 69351: SENTRY-2458: Split web service from server service modules
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/ --- (Updated Nov. 15, 2018, 2:05 p.m.) Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena. Changes --- another header cleanup Bugs: SENTRY-2458 https://issues.apache.org/jira/browse/SENTRY-2458 Repository: sentry Description --- SENTRY-2458: Split web service from server service modules In order to additional modules to be added to Sentry there needs to be a separation of some of the features used by service-server into other modules. This will allow the web server to be pulled out from the base server and allow for additional modules to be able to add web services and functionality to the web interface without depending up the whole server module. It will use the SPI to dynamically include servlets and content from other modules. It creates a sentry-service-providers to allow for Server and sub modules SPI providers to be defined externally and not depended on directly. Diffs (updated) - pom.xml 46ca38e9a sentry-dist/pom.xml 62558d2e0 sentry-dist/src/main/assembly/bin.xml 986530c55 sentry-provider/sentry-provider-db/pom.xml df569474a sentry-service/pom.xml e653189eb sentry-service/sentry-service-providers/pom.xml PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProvider.java PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProviderFactory.java PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceSpi.java PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java PRE-CREATION sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION sentry-service/sentry-service-server/pom.xml 44540ad5d sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java 862548745 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java af81d6fce sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java 8da35f10f sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java PRE-CREATION sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java 5dc6cd6c4 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java 23121ecf5 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java PRE-CREATION sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java befe6c3ed sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java b3a4934df sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.SentryWebServiceProviderFactory PRE-CREATION sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css c31428b07 sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css a553c4f5e sentry-service/sentry-service-server/src/main/webapp/css/sentry.css sentry-service/sentry-service-server/src/main/webapp/sentry.png sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java 6e741e895 sentry-service/sentry-service-web/pom.xml PRE-CREATION sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/DefaultWebServicesProvider.java PRE-CREATION sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/SentryWebServer.java PRE-CREATION sentry-service/sentry-service-web/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.SentryWebServiceProviderFactory PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/index.html PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap-theme.min.css PRE-CREATION
Re: Review Request 69351: SENTRY-2458: Split web service from server service modules
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/ --- (Updated Nov. 15, 2018, 1:46 p.m.) Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na Li, Steve Moist, and Sergio Pena. Changes --- fixed extra headers and rat issue Bugs: SENTRY-2458 https://issues.apache.org/jira/browse/SENTRY-2458 Repository: sentry Description --- SENTRY-2458: Split web service from server service modules In order to additional modules to be added to Sentry there needs to be a separation of some of the features used by service-server into other modules. This will allow the web server to be pulled out from the base server and allow for additional modules to be able to add web services and functionality to the web interface without depending up the whole server module. It will use the SPI to dynamically include servlets and content from other modules. It creates a sentry-service-providers to allow for Server and sub modules SPI providers to be defined externally and not depended on directly. Diffs (updated) - pom.xml 46ca38e9a sentry-dist/pom.xml 62558d2e0 sentry-dist/src/main/assembly/bin.xml 986530c55 sentry-provider/sentry-provider-db/pom.xml df569474a sentry-service/pom.xml e653189eb sentry-service/sentry-service-providers/pom.xml PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProvider.java PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProviderFactory.java PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceSpi.java PRE-CREATION sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java PRE-CREATION sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi PRE-CREATION sentry-service/sentry-service-server/pom.xml 44540ad5d sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java 862548745 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java af81d6fce sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java 8da35f10f sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java PRE-CREATION sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java 5dc6cd6c4 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java 23121ecf5 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java PRE-CREATION sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java befe6c3ed sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java b3a4934df sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.SentryWebServiceProviderFactory PRE-CREATION sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css c31428b07 sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css a553c4f5e sentry-service/sentry-service-server/src/main/webapp/css/sentry.css sentry-service/sentry-service-server/src/main/webapp/sentry.png sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java 6e741e895 sentry-service/sentry-service-web/pom.xml PRE-CREATION sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/DefaultWebServicesProvider.java PRE-CREATION sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/SentryWebServer.java PRE-CREATION sentry-service/sentry-service-web/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.SentryWebServiceProviderFactory PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/index.html PRE-CREATION sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap-theme.min.css PRE-CREATION
Re: Review Request 69349: SENTRY-2457: Reuse connection objects on TestConcurrentClients#testConcurrentHS2Client
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69349/#review210584 --- Ship it! Ship It! - Arjun Mishra On Nov. 15, 2018, 4 p.m., Sergio Pena wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69349/ > --- > > (Updated Nov. 15, 2018, 4 p.m.) > > > Review request for sentry and Arjun Mishra. > > > Bugs: semtry-2457 > https://issues.apache.org/jira/browse/semtry-2457 > > > Repository: sentry > > > Description > --- > > Re-use the Connection object on the > TestConcurrentClient#testConcurrentHS2Client method. This increase the speed > of the test 10s. > > > Diffs > - > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestConcurrentClients.java > 2da6c6b8231ff2e59c302c1ecc857f852d7a28ee > > > Diff: https://reviews.apache.org/r/69349/diff/1/ > > > Testing > --- > > > Thanks, > > Sergio Pena > >
Review Request 69349: SENTRY-2457: Reuse connection objects on TestConcurrentClients#testConcurrentHS2Client
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69349/ --- Review request for sentry and Arjun Mishra. Bugs: semtry-2457 https://issues.apache.org/jira/browse/semtry-2457 Repository: sentry Description --- Re-use the Connection object on the TestConcurrentClient#testConcurrentHS2Client method. This increase the speed of the test 10s. Diffs - sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestConcurrentClients.java 2da6c6b8231ff2e59c302c1ecc857f852d7a28ee Diff: https://reviews.apache.org/r/69349/diff/1/ Testing --- Thanks, Sergio Pena
