Re: Review Request 69352: SENTRY-2452: Change the thrift interface to send the list of authorizable to sentry server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69352/ --- (Updated Dec. 5, 2018, 11:23 p.m.) Review request for sentry and Sergio Pena. Bugs: SENTRY-2452 https://issues.apache.org/jira/browse/SENTRY-2452 Repository: sentry Description --- TSentryExportMappingDataRequest and TSentryImportMappingDataRequest which are used to send export and import requests to sentry server should be changed to be able to send a list authorizables for which permission information has to be exported/imported. These requests should accommodate source and target cluster information as well. Diffs (updated) - sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SentryConstants.java d8c1061d36ed0b92116f0b2dd5ec820ccb166818 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegePrincipalType.java 6eb85217b9229438b9adbd1546a408dc507f1645 sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryExportMappingDataRequest.java 13e57e04dd779825e2986b1e527f4e556271a162 sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryImportMappingDataRequest.java 21f3bdf5e304fe2f49684c999d0aa0e0362320de sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryPrivilegesResponse.java cea868f0524c25bf63cfb7c532829354a280df28 sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/common/SentryServiceUtil.java 83393a98df5e10b324f74dc12f10c20bc5f02651 sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java 68d864cfbdf18057d87a65a04af8991292aadccf sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift 3364648dc88acbb8de1cc925fe8c512f34a4b064 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java b9e3bf2921a0696da639e1b1bee5d83cf2b9cee0 sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceImportExport.java cf1fdab382034c8950da2613ef9b0cf1af912e33 Diff: https://reviews.apache.org/r/69352/diff/3/ Changes: https://reviews.apache.org/r/69352/diff/2-3/ Testing --- Made sure that existiung tests pass. Thanks, kalyan kumar kalvagadda
Re: Review Request 69352: SENTRY-2452: Change the thrift interface to send the list of authorizable to sentry server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69352/ --- (Updated Dec. 5, 2018, 10:19 p.m.) Review request for sentry and Sergio Pena. Bugs: SENTRY-2452 https://issues.apache.org/jira/browse/SENTRY-2452 Repository: sentry Description --- TSentryExportMappingDataRequest and TSentryImportMappingDataRequest which are used to send export and import requests to sentry server should be changed to be able to send a list authorizables for which permission information has to be exported/imported. These requests should accommodate source and target cluster information as well. Diffs (updated) - sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SentryConstants.java d8c1061d36ed0b92116f0b2dd5ec820ccb166818 sentry-hdfs/sentry-hdfs-common/src/gen/thrift/gen-javabean/org/apache/sentry/hdfs/service/thrift/TPrivilegePrincipalType.java 6eb85217b9229438b9adbd1546a408dc507f1645 sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryExportMappingDataRequest.java 13e57e04dd779825e2986b1e527f4e556271a162 sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryImportMappingDataRequest.java 21f3bdf5e304fe2f49684c999d0aa0e0362320de sentry-service/sentry-service-api/src/gen/thrift/gen-javabean/org/apache/sentry/api/service/thrift/TSentryPrivilegesResponse.java cea868f0524c25bf63cfb7c532829354a280df28 sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/common/SentryServiceUtil.java 83393a98df5e10b324f74dc12f10c20bc5f02651 sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java 68d864cfbdf18057d87a65a04af8991292aadccf sentry-service/sentry-service-api/src/main/resources/sentry_policy_service.thrift 3364648dc88acbb8de1cc925fe8c512f34a4b064 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java b9e3bf2921a0696da639e1b1bee5d83cf2b9cee0 sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceImportExport.java cf1fdab382034c8950da2613ef9b0cf1af912e33 Diff: https://reviews.apache.org/r/69352/diff/2/ Changes: https://reviews.apache.org/r/69352/diff/1-2/ Testing --- Made sure that existiung tests pass. Thanks, kalyan kumar kalvagadda
Re: Review Request 69484: SENTRY-2460: Export sentry permission information to HDFS location
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69484/ --- (Updated Dec. 5, 2018, 10:18 p.m.) Review request for sentry and Sergio Pena. Bugs: SENTRY-2460 https://issues.apache.org/jira/browse/SENTRY-2460 Repository: sentry Description --- Sentry should be able to export permission information to a HDFS location. This can be done using hadoop-common library. Diffs (updated) - sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/SentryIniPolicyFileFormatter.java b8ec8a1abadd3b7f99160893c5a4adb2608ea927 sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/SentryPolicyFileFormatter.java 4f465b3671c1fdd6de7cd0773a29108af40311c8 sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java 5f1e3e916d71c51e19d3d37ba788f902ed6b7e27 sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryIniPolicyFileFormatter.java 7baeee17339d29576b841480e600a3cfaf14adf3 sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java 092060c450c6a906850630cb10454737157af5fe sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceImportExport.java cf1fdab382034c8950da2613ef9b0cf1af912e33 sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java df9299c5df26c891ceebbc59b79dd0f7cd3ceeb4 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java b048989b42bde0318c6d0fa0e9353a2a59954407 Diff: https://reviews.apache.org/r/69484/diff/2/ Changes: https://reviews.apache.org/r/69484/diff/1-2/ Testing --- Added new tests to verify the new behavior added. Thanks, kalyan kumar kalvagadda
