Re: Review Request 72706: SENTRY-2557: Queries are running too slow after when there are more than 4k roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72706/#review221345 --- Ship it! Ship It! - Na Li On July 23, 2020, 11:38 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72706/ > --- > > (Updated July 23, 2020, 11:38 p.m.) > > > Review request for sentry and Na Li. > > > Repository: sentry > > > Description > --- > > When there are more than 4k roles Hive queries are very slow below because of > the time it spends on the compile phase because of the delay in fetching the > permissions. > > > Diffs > - > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 980c8ad6 > > > Diff: https://reviews.apache.org/r/72706/diff/1/ > > > Testing > --- > > > Thanks, > > kalyan kumar kalvagadda > >
Review Request 72706: SENTRY-2557: Queries are running too slow after when there are more than 4k roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72706/ --- Review request for sentry and Na Li. Repository: sentry Description --- When there are more than 4k roles Hive queries are very slow below because of the time it spends on the compile phase because of the delay in fetching the permissions. Diffs - sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 980c8ad6 Diff: https://reviews.apache.org/r/72706/diff/1/ Testing --- Thanks, kalyan kumar kalvagadda
Review Request 72704: SENTRY-2422: HMS synchronization is causing multiple entries of the same ID in SENTRY_HMS_NOTIFICATION_ID
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72704/ --- Review request for sentry and kalyan kumar kalvagadda. Bugs: sentry-2422 https://issues.apache.org/jira/browse/sentry-2422 Repository: sentry Description --- before saving notification ID, check to make sure only save it if it is larger than the values of existing entries. We only track and use max(Notification ID). So no need to persist duplicated values. Diffs - sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 980c8ad sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java fd14963 Diff: https://reviews.apache.org/r/72704/diff/1/ Testing --- add new unit tests, and they pass Thanks, Na Li
