Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

2017-11-13 Thread Na Li via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63687/#review190856
---


Ship it!




Ship It!

- Na Li


On Nov. 13, 2017, 5:12 p.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63687/
> ---
> 
> (Updated Nov. 13, 2017, 5:12 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: sentry-2039
> https://issues.apache.org/jira/browse/sentry-2039
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Return the equalsIgnoreCase() to the KeyValue.equals() method (removed by 
> SENTRY-999)
> 
> 
> Diffs
> -
> 
>   
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java
>  4e944e5f2605459ac4166a784bb1d50362509221 
>   
> sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestKeyValue.java
>  ca44a245dc9abf003eaae13d0ebbfb1ef7eff29a 
>   
> sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilege.java
>  3f60b1901976d2236db0814fd63114c9598e8215 
> 
> 
> Diff: https://reviews.apache.org/r/63687/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

2017-11-09 Thread Na Li via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63687/#review190657
---




sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java
Line 35 (original), 37 (patched)


should you lower the case for value too? value is also case insensitive.


- Na Li


On Nov. 9, 2017, 11:44 p.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63687/
> ---
> 
> (Updated Nov. 9, 2017, 11:44 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: sentry-2039
> https://issues.apache.org/jira/browse/sentry-2039
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Return the equalsIgnoreCase() to the KeyValue.equals() method (removed by 
> SENTRY-999)
> 
> 
> Diffs
> -
> 
>   
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java
>  4e944e5f2605459ac4166a784bb1d50362509221 
>   
> sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestKeyValue.java
>  ca44a245dc9abf003eaae13d0ebbfb1ef7eff29a 
>   
> sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilege.java
>  3f60b1901976d2236db0814fd63114c9598e8215 
> 
> 
> Diff: https://reviews.apache.org/r/63687/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

2017-11-09 Thread Alexander Kolbasov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63687/#review190654
---


Fix it, then Ship it!




Ship It!


sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java
Lines 35 (patched)


Can you add Javadoc to the class explaining that by contract keys are 
always case-insensitive?


- Alexander Kolbasov


On Nov. 9, 2017, 11:44 p.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63687/
> ---
> 
> (Updated Nov. 9, 2017, 11:44 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: sentry-2039
> https://issues.apache.org/jira/browse/sentry-2039
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Return the equalsIgnoreCase() to the KeyValue.equals() method (removed by 
> SENTRY-999)
> 
> 
> Diffs
> -
> 
>   
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java
>  4e944e5f2605459ac4166a784bb1d50362509221 
>   
> sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestKeyValue.java
>  ca44a245dc9abf003eaae13d0ebbfb1ef7eff29a 
>   
> sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilege.java
>  3f60b1901976d2236db0814fd63114c9598e8215 
> 
> 
> Diff: https://reviews.apache.org/r/63687/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

2017-11-09 Thread Sergio Pena via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63687/
---

(Updated Nov. 9, 2017, 11:44 p.m.)


Review request for sentry.


Bugs: sentry-2039
https://issues.apache.org/jira/browse/sentry-2039


Repository: sentry


Description
---

Return the equalsIgnoreCase() to the KeyValue.equals() method (removed by 
SENTRY-999)


Diffs (updated)
-

  
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java
 4e944e5f2605459ac4166a784bb1d50362509221 
  
sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestKeyValue.java
 ca44a245dc9abf003eaae13d0ebbfb1ef7eff29a 
  
sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilege.java
 3f60b1901976d2236db0814fd63114c9598e8215 


Diff: https://reviews.apache.org/r/63687/diff/4/

Changes: https://reviews.apache.org/r/63687/diff/3-4/


Testing
---


Thanks,

Sergio Pena

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

2017-11-09 Thread Sergio Pena via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63687/
---

(Updated Nov. 9, 2017, 6:51 p.m.)


Review request for sentry.


Bugs: sentry-2039
https://issues.apache.org/jira/browse/sentry-2039


Repository: sentry


Description
---

Return the equalsIgnoreCase() to the KeyValue.equals() method (removed by 
SENTRY-999)


Diffs (updated)
-

  
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java
 4e944e5f2605459ac4166a784bb1d50362509221 
  
sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestKeyValue.java
 ca44a245dc9abf003eaae13d0ebbfb1ef7eff29a 
  
sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilege.java
 3f60b1901976d2236db0814fd63114c9598e8215 


Diff: https://reviews.apache.org/r/63687/diff/3/

Changes: https://reviews.apache.org/r/63687/diff/2-3/


Testing
---


Thanks,

Sergio Pena

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

2017-11-09 Thread Na Li via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63687/#review190627
---




sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestKeyValue.java
Lines 58 (patched)


Can you add test case to check value is also case insensitive?


- Na Li


On Nov. 9, 2017, 4:34 p.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63687/
> ---
> 
> (Updated Nov. 9, 2017, 4:34 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: sentry-2039
> https://issues.apache.org/jira/browse/sentry-2039
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Return the equalsIgnoreCase() to the KeyValue.equals() method (removed by 
> SENTRY-999)
> 
> 
> Diffs
> -
> 
>   
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java
>  4e944e5f2605459ac4166a784bb1d50362509221 
>   
> sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestKeyValue.java
>  ca44a245dc9abf003eaae13d0ebbfb1ef7eff29a 
>   
> sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilege.java
>  3f60b1901976d2236db0814fd63114c9598e8215 
> 
> 
> Diff: https://reviews.apache.org/r/63687/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

2017-11-09 Thread Sergio Pena via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63687/
---

(Updated Nov. 9, 2017, 4:34 p.m.)


Review request for sentry.


Changes
---

Added a javadoc to the equals() method that explaines equality is 
case-insensitive.


Bugs: sentry-2039
https://issues.apache.org/jira/browse/sentry-2039


Repository: sentry


Description
---

Return the equalsIgnoreCase() to the KeyValue.equals() method (removed by 
SENTRY-999)


Diffs (updated)
-

  
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java
 4e944e5f2605459ac4166a784bb1d50362509221 
  
sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestKeyValue.java
 ca44a245dc9abf003eaae13d0ebbfb1ef7eff29a 
  
sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilege.java
 3f60b1901976d2236db0814fd63114c9598e8215 


Diff: https://reviews.apache.org/r/63687/diff/2/

Changes: https://reviews.apache.org/r/63687/diff/1-2/


Testing
---


Thanks,

Sergio Pena

Re: Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

2017-11-08 Thread Alexander Kolbasov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63687/#review190512
---




sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java
Line 87 (original), 87 (patched)


Please add javaDoc explaining that this is case-insensitive comparison. 
Should both key and value be case-insensitive?

Would it make sense to instead convert key and value to the canonical case 
in constructor?


- Alexander Kolbasov


On Nov. 8, 2017, 11:43 p.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63687/
> ---
> 
> (Updated Nov. 8, 2017, 11:43 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: sentry-2039
> https://issues.apache.org/jira/browse/sentry-2039
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Return the equalsIgnoreCase() to the KeyValue.equals() method (removed by 
> SENTRY-999)
> 
> 
> Diffs
> -
> 
>   
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java
>  4e944e5f2605459ac4166a784bb1d50362509221 
>   
> sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestKeyValue.java
>  ca44a245dc9abf003eaae13d0ebbfb1ef7eff29a 
>   
> sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilege.java
>  3f60b1901976d2236db0814fd63114c9598e8215 
> 
> 
> Diff: https://reviews.apache.org/r/63687/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Review Request 63687: SENTRY-2039: KeyValue is case sensitive and it causes incompatibility issues with external comp

2017-11-08 Thread Sergio Pena via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63687/
---

Review request for sentry.


Bugs: sentry-2039
https://issues.apache.org/jira/browse/sentry-2039


Repository: sentry


Description
---

Return the equalsIgnoreCase() to the KeyValue.equals() method (removed by 
SENTRY-999)


Diffs
-

  
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java
 4e944e5f2605459ac4166a784bb1d50362509221 
  
sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestKeyValue.java
 ca44a245dc9abf003eaae13d0ebbfb1ef7eff29a 
  
sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilege.java
 3f60b1901976d2236db0814fd63114c9598e8215 


Diff: https://reviews.apache.org/r/63687/diff/1/


Testing
---


Thanks,

Sergio Pena